Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-17445 Don't force initialization of correlated joined table group

This commit is contained in:
Christian Beikov 2023-11-23 16:12:09 +01:00
parent 314c621f7b
commit e0875a127f
2 changed files with 17 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hibernate-core/src/main/java/org/hibernate/query/sqm/sql/BaseSqmToSqlAstConverter.java
View File

@ -3786,8 +3786,6 @@ public abstract class BaseSqmToSqlAstConverter<T extends Statement> extends Base
querySpec::applyPredicate, querySpec::applyPredicate,
this this
); );
// Force initialization of a possible lazy table group
tableGroup.getPrimaryTableReference();
querySpec.getFromClause().addRoot( tableGroup ); querySpec.getFromClause().addRoot( tableGroup );
} }
else { else {

18
hibernate-core/src/test/java/org/hibernate/orm/test/query/ImplicitJoinInSubqueryTest.java
View File

@ -18,7 +18,6 @@ import org.assertj.core.api.Assertions;
import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThat;
@JiraKey("HHH-16721")
@DomainModel(annotatedClasses = { @DomainModel(annotatedClasses = {
ImplicitJoinInSubqueryTest.A.class, ImplicitJoinInSubqueryTest.A.class,
ImplicitJoinInSubqueryTest.B.class, ImplicitJoinInSubqueryTest.B.class,
@ -28,6 +27,7 @@ import static org.assertj.core.api.Assertions.assertThat;
public class ImplicitJoinInSubqueryTest { public class ImplicitJoinInSubqueryTest {
@Test @Test
@JiraKey("HHH-16721")
public void testImplicitJoinInSubquery(SessionFactoryScope scope) { public void testImplicitJoinInSubquery(SessionFactoryScope scope) {
SQLStatementInspector statementInspector = scope.getCollectingStatementInspector(); SQLStatementInspector statementInspector = scope.getCollectingStatementInspector();
statementInspector.clear(); statementInspector.clear();
@ -41,6 +41,22 @@ public class ImplicitJoinInSubqueryTest {
); );
} }
@Test
@JiraKey("HHH-17445")
public void testImplicitJoinInSubquery2(SessionFactoryScope scope) {
SQLStatementInspector statementInspector = scope.getCollectingStatementInspector();
statementInspector.clear();
scope.inTransaction(
entityManager -> {
entityManager.createSelectionQuery(
"select a from A a where exists (select 1 from B b where a.b.c is null)"
).getResultList();
assertThat( statementInspector.getSqlQueries().get( 0 ) ).contains( "b1_0.c_id is null" );
assertThat( statementInspector.getSqlQueries().get( 0 ) ).doesNotContain( ".id=b1_0.c_id" );
}
);
}
@Entity(name = "A") @Entity(name = "A")
public static class A { public static class A {
@Id @Id