Hibernate/hibernate-orm
1
0
Fork 0
mirror of https://github.com/hibernate/hibernate-orm synced 2025-02-26 05:14:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

HHH-12594 Do not share AliasResolutionContextImpl between EntityLoadQueryDetails instances

Browse Source 
Sharing it results in some tables being aliased twice for the same query
space, but with different aliases, resulting in exceptions.

Ideally we should try to generate the aliases once, and then share the
AliasResolutionContextImpl between EntityLoadQueryDetails instances,
but I'm really not comfortable enough with this code to make that kind
of changes.
This commit is contained in:
Yoann Rodière 2018-06-25 15:17:25 +02:00
parent 80360b1317
commit e1bcfc12cf
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
hibernate-core/src/main/java/org/hibernate/loader/plan/exec/internal/EntityLoadQueryDetails.java
View File

@ -87,17 +87,14 @@ protected EntityLoadQueryDetails(
protected EntityLoadQueryDetails(
EntityLoadQueryDetails initialEntityLoadQueryDetails,
QueryBuildingParameters buildingParameters) {
super(
this(
initialEntityLoadQueryDetails.getLoadPlan(),
(AliasResolutionContextImpl) initialEntityLoadQueryDetails.getAliasResolutionContext(),
buildingParameters,
initialEntityLoadQueryDetails.getKeyColumnNames(),
initialEntityLoadQueryDetails.getRootReturn(),
new AliasResolutionContextImpl( initialEntityLoadQueryDetails.getSessionFactory() ),
(EntityReturn) initialEntityLoadQueryDetails.getRootReturn(),
buildingParameters,
initialEntityLoadQueryDetails.getSessionFactory()
);
this.entityReferenceAliases = initialEntityLoadQueryDetails.entityReferenceAliases;
this.readerCollector = initialEntityLoadQueryDetails.readerCollector;
generate();
}
private EntityReturn getRootEntityReturn() {