From e63449721a61640259793c7be1d50c709139deaa Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Yoann=20Rodi=C3=A8re?= <yoann@hibernate.org>
Date: Thu, 14 Mar 2019 16:03:42 +0100
Subject: [PATCH] HHH-13266 Skip some tests that apparently trigger bugs in
 HANA

---
 .../java/org/hibernate/test/type/LocalDateTest.java    |  3 +++
 .../java/org/hibernate/test/type/LocalTimeTest.java    | 10 ++++++++++
 .../java/org/hibernate/test/type/OffsetTimeTest.java   | 10 ++++++++++
 3 files changed, 23 insertions(+)

diff --git a/hibernate-core/src/test/java/org/hibernate/test/type/LocalDateTest.java b/hibernate-core/src/test/java/org/hibernate/test/type/LocalDateTest.java
index 417636b875..8cf5dabc4c 100644
--- a/hibernate-core/src/test/java/org/hibernate/test/type/LocalDateTest.java
+++ b/hibernate-core/src/test/java/org/hibernate/test/type/LocalDateTest.java
@@ -21,10 +21,12 @@ import javax.persistence.Column;
 import javax.persistence.Entity;
 import javax.persistence.Id;
 
+import org.hibernate.dialect.AbstractHANADialect;
 import org.hibernate.dialect.MariaDBDialect;
 import org.hibernate.dialect.MySQLDialect;
 import org.hibernate.type.descriptor.sql.TimestampTypeDescriptor;
 
+import org.hibernate.testing.SkipForDialect;
 import org.hibernate.testing.TestForIssue;
 import org.junit.runners.Parameterized;
 
@@ -32,6 +34,7 @@ import org.junit.runners.Parameterized;
  * Tests for storage of LocalDate properties.
  */
 @TestForIssue(jiraKey = "HHH-10371")
+@SkipForDialect(value = AbstractHANADialect.class, comment = "HANA systematically returns the wrong date when the JVM default timezone is not UTC")
 public class LocalDateTest extends AbstractJavaTimeTypeTest<LocalDate, LocalDateTest.EntityWithLocalDate> {
 
 	private static class ParametersBuilder extends AbstractParametersBuilder<ParametersBuilder> {
diff --git a/hibernate-core/src/test/java/org/hibernate/test/type/LocalTimeTest.java b/hibernate-core/src/test/java/org/hibernate/test/type/LocalTimeTest.java
index 64c3baa580..a7aa5628be 100644
--- a/hibernate-core/src/test/java/org/hibernate/test/type/LocalTimeTest.java
+++ b/hibernate-core/src/test/java/org/hibernate/test/type/LocalTimeTest.java
@@ -21,10 +21,13 @@ import javax.persistence.Column;
 import javax.persistence.Entity;
 import javax.persistence.Id;
 
+import org.hibernate.dialect.AbstractHANADialect;
 import org.hibernate.dialect.MariaDBDialect;
 import org.hibernate.dialect.MySQLDialect;
 import org.hibernate.type.descriptor.sql.TimestampTypeDescriptor;
 
+import org.hibernate.testing.SkipForDialect;
+import org.junit.Test;
 import org.junit.runners.Parameterized;
 
 /**
@@ -167,6 +170,13 @@ public class LocalTimeTest extends AbstractJavaTimeTypeTest<LocalTime, LocalTime
 		return resultSet.getTimestamp( columnIndex );
 	}
 
+	@Override
+	@Test
+	@SkipForDialect(value = AbstractHANADialect.class, comment = "HANA seems to return a java.sql.Timestamp instead of a java.sql.Time")
+	public void writeThenNativeRead() {
+		super.writeThenNativeRead();
+	}
+
 	@Entity(name = ENTITY_NAME)
 	static final class EntityWithLocalTime {
 		@Id
diff --git a/hibernate-core/src/test/java/org/hibernate/test/type/OffsetTimeTest.java b/hibernate-core/src/test/java/org/hibernate/test/type/OffsetTimeTest.java
index 448a74ea29..8a4203cbfc 100644
--- a/hibernate-core/src/test/java/org/hibernate/test/type/OffsetTimeTest.java
+++ b/hibernate-core/src/test/java/org/hibernate/test/type/OffsetTimeTest.java
@@ -23,11 +23,14 @@ import javax.persistence.Column;
 import javax.persistence.Entity;
 import javax.persistence.Id;
 
+import org.hibernate.dialect.AbstractHANADialect;
 import org.hibernate.dialect.MariaDBDialect;
 import org.hibernate.dialect.MySQLDialect;
 import org.hibernate.type.descriptor.sql.BigIntTypeDescriptor;
 import org.hibernate.type.descriptor.sql.TimestampTypeDescriptor;
 
+import org.hibernate.testing.SkipForDialect;
+import org.junit.Test;
 import org.junit.runners.Parameterized;
 
 /**
@@ -178,6 +181,13 @@ public class OffsetTimeTest extends AbstractJavaTimeTypeTest<OffsetTime, OffsetT
 		return resultSet.getTimestamp( columnIndex );
 	}
 
+	@Override
+	@Test
+	@SkipForDialect(value = AbstractHANADialect.class, comment = "HANA seems to return a java.sql.Timestamp instead of a java.sql.Time")
+	public void writeThenNativeRead() {
+		super.writeThenNativeRead();
+	}
+
 	@Entity(name = ENTITY_NAME)
 	static final class EntityWithOffsetTime {
 		@Id