HHH-16443 Convert SqlStatementLogger into a Service
This way is possible to get the logger without having to initialize the JdbcServices service. Without this change, in Hibernate Reactive, we have a cyclic dependency during the initialization of the services between JdbcEnvironment and JdbcServices.
This commit is contained in:
parent
07a9cee923
commit
e6c8fbc7af
|
@ -45,12 +45,7 @@ public class JdbcServicesImpl implements JdbcServices, ServiceRegistryAwareServi
|
||||||
this.jdbcEnvironment = serviceRegistry.getService( JdbcEnvironment.class );
|
this.jdbcEnvironment = serviceRegistry.getService( JdbcEnvironment.class );
|
||||||
assert jdbcEnvironment != null : "JdbcEnvironment was not found";
|
assert jdbcEnvironment != null : "JdbcEnvironment was not found";
|
||||||
|
|
||||||
final boolean showSQL = ConfigurationHelper.getBoolean( Environment.SHOW_SQL, configValues, false );
|
this.sqlStatementLogger = serviceRegistry.getService( SqlStatementLogger.class );
|
||||||
final boolean formatSQL = ConfigurationHelper.getBoolean( Environment.FORMAT_SQL, configValues, false );
|
|
||||||
final boolean highlightSQL = ConfigurationHelper.getBoolean( Environment.HIGHLIGHT_SQL, configValues, false );
|
|
||||||
final long logSlowQuery = ConfigurationHelper.getLong( Environment.LOG_SLOW_QUERY, configValues, 0 );
|
|
||||||
|
|
||||||
this.sqlStatementLogger = new SqlStatementLogger( showSQL, formatSQL, highlightSQL, logSlowQuery );
|
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
|
|
|
@ -0,0 +1,41 @@
|
||||||
|
/*
|
||||||
|
* Hibernate, Relational Persistence for Idiomatic Java
|
||||||
|
*
|
||||||
|
* License: GNU Lesser General Public License (LGPL), version 2.1 or later.
|
||||||
|
* See the lgpl.txt file in the root directory or <http://www.gnu.org/licenses/lgpl-2.1.html>.
|
||||||
|
*/
|
||||||
|
package org.hibernate.engine.jdbc.internal;
|
||||||
|
|
||||||
|
import java.util.Map;
|
||||||
|
|
||||||
|
import org.hibernate.boot.registry.StandardServiceInitiator;
|
||||||
|
import org.hibernate.cfg.Environment;
|
||||||
|
import org.hibernate.engine.jdbc.spi.SqlStatementLogger;
|
||||||
|
import org.hibernate.internal.util.config.ConfigurationHelper;
|
||||||
|
import org.hibernate.service.spi.ServiceRegistryImplementor;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* The {@link SqlStatementLogger} is accessible via {@link org.hibernate.engine.jdbc.spi.JdbcServices},
|
||||||
|
* but during service initialization, it might be needed before the {@code JdbcServices} service is initialized.
|
||||||
|
*
|
||||||
|
* For Hibernate Reactive
|
||||||
|
*/
|
||||||
|
public class SqlStatementLoggerInitiator implements StandardServiceInitiator<SqlStatementLogger> {
|
||||||
|
|
||||||
|
public static final SqlStatementLoggerInitiator INSTANCE = new SqlStatementLoggerInitiator();
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public SqlStatementLogger initiateService(Map<String, Object> configValues, ServiceRegistryImplementor registry) {
|
||||||
|
final boolean showSQL = ConfigurationHelper.getBoolean( Environment.SHOW_SQL, configValues, false );
|
||||||
|
final boolean formatSQL = ConfigurationHelper.getBoolean( Environment.FORMAT_SQL, configValues, false );
|
||||||
|
final boolean highlightSQL = ConfigurationHelper.getBoolean( Environment.HIGHLIGHT_SQL, configValues, false );
|
||||||
|
final long logSlowQuery = ConfigurationHelper.getLong( Environment.LOG_SLOW_QUERY, configValues, 0 );
|
||||||
|
|
||||||
|
return new SqlStatementLogger( showSQL, formatSQL, highlightSQL, logSlowQuery );
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public Class<SqlStatementLogger> getServiceInitiated() {
|
||||||
|
return SqlStatementLogger.class;
|
||||||
|
}
|
||||||
|
}
|
|
@ -10,6 +10,8 @@ import org.hibernate.engine.jdbc.internal.FormatStyle;
|
||||||
import org.hibernate.engine.jdbc.internal.Formatter;
|
import org.hibernate.engine.jdbc.internal.Formatter;
|
||||||
import org.hibernate.internal.CoreLogging;
|
import org.hibernate.internal.CoreLogging;
|
||||||
import org.hibernate.internal.build.AllowSysOut;
|
import org.hibernate.internal.build.AllowSysOut;
|
||||||
|
import org.hibernate.service.Service;
|
||||||
|
|
||||||
import org.jboss.logging.Logger;
|
import org.jboss.logging.Logger;
|
||||||
|
|
||||||
import java.sql.Statement;
|
import java.sql.Statement;
|
||||||
|
@ -21,7 +23,7 @@ import java.util.function.Supplier;
|
||||||
*
|
*
|
||||||
* @author Steve Ebersole
|
* @author Steve Ebersole
|
||||||
*/
|
*/
|
||||||
public class SqlStatementLogger {
|
public class SqlStatementLogger implements Service {
|
||||||
private static final Logger LOG = CoreLogging.logger( "org.hibernate.SQL" );
|
private static final Logger LOG = CoreLogging.logger( "org.hibernate.SQL" );
|
||||||
private static final Logger LOG_SLOW = CoreLogging.logger( "org.hibernate.SQL_SLOW" );
|
private static final Logger LOG_SLOW = CoreLogging.logger( "org.hibernate.SQL_SLOW" );
|
||||||
|
|
||||||
|
|
|
@ -25,6 +25,7 @@ import org.hibernate.engine.jdbc.dialect.internal.DialectFactoryInitiator;
|
||||||
import org.hibernate.engine.jdbc.dialect.internal.DialectResolverInitiator;
|
import org.hibernate.engine.jdbc.dialect.internal.DialectResolverInitiator;
|
||||||
import org.hibernate.engine.jdbc.env.internal.JdbcEnvironmentInitiator;
|
import org.hibernate.engine.jdbc.env.internal.JdbcEnvironmentInitiator;
|
||||||
import org.hibernate.engine.jdbc.internal.JdbcServicesInitiator;
|
import org.hibernate.engine.jdbc.internal.JdbcServicesInitiator;
|
||||||
|
import org.hibernate.engine.jdbc.internal.SqlStatementLoggerInitiator;
|
||||||
import org.hibernate.engine.jdbc.mutation.internal.MutationExecutorServiceInitiator;
|
import org.hibernate.engine.jdbc.mutation.internal.MutationExecutorServiceInitiator;
|
||||||
import org.hibernate.engine.jndi.internal.JndiServiceInitiator;
|
import org.hibernate.engine.jndi.internal.JndiServiceInitiator;
|
||||||
import org.hibernate.engine.transaction.jta.platform.internal.JtaPlatformInitiator;
|
import org.hibernate.engine.transaction.jta.platform.internal.JtaPlatformInitiator;
|
||||||
|
@ -119,6 +120,9 @@ public final class StandardServiceInitiators {
|
||||||
// BatchBuilder
|
// BatchBuilder
|
||||||
serviceInitiators.add( BatchBuilderInitiator.INSTANCE );
|
serviceInitiators.add( BatchBuilderInitiator.INSTANCE );
|
||||||
|
|
||||||
|
// SqlStatementLoggerInitiator
|
||||||
|
serviceInitiators.add( SqlStatementLoggerInitiator.INSTANCE );
|
||||||
|
|
||||||
// JdbcServices
|
// JdbcServices
|
||||||
serviceInitiators.add( JdbcServicesInitiator.INSTANCE );
|
serviceInitiators.add( JdbcServicesInitiator.INSTANCE );
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue