Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

removed unused code path from generateInsertString() 

as suggested in the TODO
This commit is contained in:
Gavin King 2021-09-06 15:07:03 +02:00 committed by Andrea Boriero
parent d1806c5e92
commit e929ac94ce
1 changed files with 5 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
hibernate-core/src/main/java/org/hibernate/persister/entity/AbstractEntityPersister.java
View File

@ -3011,12 +3011,8 @@ public abstract class AbstractEntityPersister
|| entityMetamodel.isVersionGenerated();
}
public String generateInsertString(boolean[] includeProperty, int j) {
return generateInsertString( false, includeProperty, j );
}
public String generateInsertString(boolean identityInsert, boolean[] includeProperty) {
return generateInsertString( identityInsert, includeProperty, 0 );
public String generateInsertString(boolean[] includeProperty) {
return generateInsertString( includeProperty, 0 );
}
private static final boolean[] SINGLE_TRUE = new boolean[] { true };
@ -3025,10 +3021,7 @@ public abstract class AbstractEntityPersister
/**
* Generate the SQL that inserts a row
*/
public String generateInsertString(boolean identityInsert, boolean[] includeProperty, int j) {
// todo : remove the identityInsert param and variations;
// identity-insert strings are now generated from generateIdentityInsertString()
public String generateInsertString(boolean[] includeProperty, int j) {
final Insert insert = createInsert().setTableName( getTableName( j ) );
@ -3071,12 +3064,7 @@ public abstract class AbstractEntityPersister
}
// add the primary key
if ( j == 0 && identityInsert ) {
insert.addIdentityColumn( getKeyColumns( 0 )[0] );
}
else {
insert.addColumns( getKeyColumns( j ) );
}
if ( getFactory().getSessionFactoryOptions().isCommentsEnabled() ) {
insert.setComment( "insert " + getEntityName() );
@ -3096,14 +3084,7 @@ public abstract class AbstractEntityPersister
}
}
String result = insert.toStatementString();
// append the SQL to return the generated identifier
if ( j == 0 && identityInsert && useInsertSelectIdentity() ) { //TODO: suck into Insert
result = getFactory().getJdbcServices().getDialect().getIdentityColumnSupport().appendIdentitySelectToInsert( result );
}
return result;
return insert.toStatementString();
}
/**