Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix Sybase ASE nightly failure of NationalizedTest

This commit is contained in:
Christian Beikov 2024-11-20 19:26:13 +01:00
parent de3408662c
commit ed5f1d82d1
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hibernate-core/src/test/java/org/hibernate/orm/test/mapping/basic/NationalizedTest.java
View File

@ -10,6 +10,8 @@ import jakarta.persistence.Id;
import org.hibernate.annotations.Nationalized;
import org.hibernate.orm.test.jpa.BaseEntityManagerFunctionalTestCase;
import org.hibernate.testing.orm.junit.DialectFeatureChecks;
import org.hibernate.testing.orm.junit.RequiresDialectFeature;
import org.junit.Test;
import static org.hibernate.testing.transaction.TransactionUtil.doInJPA;
@ -18,6 +20,7 @@ import static org.junit.Assert.assertEquals;
/**
* @author Vlad Mihalcea
*/
@RequiresDialectFeature(feature = DialectFeatureChecks.SupportsUnicodeNClob.class)
public class NationalizedTest extends BaseEntityManagerFunctionalTestCase {
@Override

10
hibernate-testing/src/main/java/org/hibernate/testing/orm/junit/DialectFeatureChecks.java
View File

@ -66,6 +66,7 @@ import org.hibernate.dialect.OracleDialect;
import org.hibernate.dialect.PostgreSQLDialect;
import org.hibernate.dialect.SQLServerDialect;
import org.hibernate.dialect.SpannerDialect;
import org.hibernate.dialect.SybaseASEDialect;
import org.hibernate.dialect.SybaseDialect;
import org.hibernate.dialect.SybaseDriverKind;
import org.hibernate.dialect.TiDBDialect;
@ -1023,6 +1024,15 @@ abstract public class DialectFeatureChecks {
}
}
public static class SupportsUnicodeNClob implements DialectFeatureCheck {
@Override
public boolean apply(Dialect dialect) {
return !(dialect instanceof SybaseASEDialect aseDialect)
// The jconn driver apparently doesn't support unicode characters
|| aseDialect.getDriverKind() == SybaseDriverKind.JTDS;
}
}
private static final HashMap<Dialect, SqmFunctionRegistry> FUNCTION_REGISTRIES = new HashMap<>();
public static boolean definesFunction(Dialect dialect, String functionName) {