Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't render distinct from predicate on SQL Server versions that don't support it

This commit is contained in:
Christian Beikov 2024-11-20 19:59:56 +01:00
parent c0804d366c
commit f12c6c3aed
2 changed files with 64 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/SQLServerLegacySqlAstTranslator.java
View File

@ -492,10 +492,28 @@ public class SQLServerLegacySqlAstTranslator<T extends JdbcOperation> extends Ab
&& lhsExpressionType.getSingleJdbcMapping().getJdbcType().getDdlTypeCode() == SqlTypes.SQLXML ) {
// In SQL Server, XMLTYPE is not "comparable", so we have to cast the two parts to varchar for this purpose
switch ( operator ) {
case EQUAL:
case NOT_DISTINCT_FROM:
case NOT_EQUAL:
case DISTINCT_FROM:
if ( !supportsDistinctFromPredicate() ) {
appendSql( "not " );
}
case NOT_DISTINCT_FROM: {
if ( !supportsDistinctFromPredicate() ) {
appendSql( "exists (select cast(" );
getClauseStack().push( Clause.SELECT );
visitSqlSelectExpression( lhs );
appendSql( " as nvarchar(max))" );
appendSql( getFromDualForSelectOnly() );
appendSql( " intersect select cast(" );
visitSqlSelectExpression( rhs );
appendSql( " as nvarchar(max))" );
appendSql( getFromDualForSelectOnly() );
getClauseStack().pop();
appendSql( CLOSE_PARENTHESIS );
return;
}
}
case EQUAL:
case NOT_EQUAL:
appendSql( "cast(" );
lhs.accept( this );
appendSql( " as nvarchar(max))" );
@ -509,7 +527,17 @@ public class SQLServerLegacySqlAstTranslator<T extends JdbcOperation> extends Ab
break;
}
}
renderComparisonEmulateIntersect( lhs, operator, rhs );
if ( supportsDistinctFromPredicate() ) {
renderComparisonStandard( lhs, operator, rhs );
}
else {
renderComparisonEmulateIntersect( lhs, operator, rhs );
}
}
@Override
protected boolean supportsDistinctFromPredicate() {
return getDialect().getVersion().isSameOrAfter( 16 );
}
@Override

36
hibernate-core/src/main/java/org/hibernate/dialect/SQLServerSqlAstTranslator.java
View File

@ -463,10 +463,28 @@ public class SQLServerSqlAstTranslator<T extends JdbcOperation> extends SqlAstTr
&& lhsExpressionType.getSingleJdbcMapping().getJdbcType().getDdlTypeCode() == SqlTypes.SQLXML ) {
// In SQL Server, XMLTYPE is not "comparable", so we have to cast the two parts to varchar for this purpose
switch ( operator ) {
case EQUAL:
case NOT_DISTINCT_FROM:
case NOT_EQUAL:
case DISTINCT_FROM:
if ( !supportsDistinctFromPredicate() ) {
appendSql( "not " );
}
case NOT_DISTINCT_FROM: {
if ( !supportsDistinctFromPredicate() ) {
appendSql( "exists (select cast(" );
getClauseStack().push( Clause.SELECT );
visitSqlSelectExpression( lhs );
appendSql( " as nvarchar(max))" );
appendSql( getFromDualForSelectOnly() );
appendSql( " intersect select cast(" );
visitSqlSelectExpression( rhs );
appendSql( " as nvarchar(max))" );
appendSql( getFromDualForSelectOnly() );
getClauseStack().pop();
appendSql( CLOSE_PARENTHESIS );
return;
}
}
case EQUAL:
case NOT_EQUAL:
appendSql( "cast(" );
lhs.accept( this );
appendSql( " as nvarchar(max))" );
@ -480,7 +498,17 @@ public class SQLServerSqlAstTranslator<T extends JdbcOperation> extends SqlAstTr
break;
}
}
renderComparisonEmulateIntersect( lhs, operator, rhs );
if ( supportsDistinctFromPredicate() ) {
renderComparisonStandard( lhs, operator, rhs );
}
else {
renderComparisonEmulateIntersect( lhs, operator, rhs );
}
}
@Override
protected boolean supportsDistinctFromPredicate() {
return getDialect().getVersion().isSameOrAfter( 16 );
}
@Override