diff --git a/hibernate-core/src/test/java/org/hibernate/test/inheritance/DenormalizedTablePhysicalIncludedTableConstraintTest.java b/hibernate-core/src/test/java/org/hibernate/test/inheritance/DenormalizedTablePhysicalIncludedTableConstraintTest.java index aaba275ab2..a4375db86a 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/inheritance/DenormalizedTablePhysicalIncludedTableConstraintTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/inheritance/DenormalizedTablePhysicalIncludedTableConstraintTest.java @@ -12,7 +12,9 @@ import javax.persistence.Table; import javax.persistence.UniqueConstraint; import org.hibernate.cfg.AvailableSettings; +import org.hibernate.dialect.H2Dialect; +import org.hibernate.testing.RequiresDialect; import org.hibernate.testing.TestForIssue; import org.hibernate.testing.junit4.BaseNonConfigCoreFunctionalTestCase; import org.junit.Test; @@ -22,6 +24,11 @@ import org.junit.Test; * @author Nathan Xu */ @TestForIssue( jiraKey = "HHH-14234" ) +@RequiresDialect( + value = H2Dialect.class, + comment = "This test relies on 'hibernate.hbm2ddl.halt_on_error', only tested on h2; " + + "other dialects might be broken due to irrelevant reason (e.g. not supporting 'if exists' while dropping tables)." +) public class DenormalizedTablePhysicalIncludedTableConstraintTest extends BaseNonConfigCoreFunctionalTestCase { @Override @@ -40,13 +47,12 @@ public class DenormalizedTablePhysicalIncludedTableConstraintTest extends BaseNo @Test public void testUniqueConstraintFromSupTableNotAppliedToSubTable() { // Unique constraint should be unique in db - // Without fixing, exception will be thrown when unique constraint in 'SUPTABLE' is applied to 'SUBTABLE' as well - // Both table names are uppercase to accommodate HANA dialect (see https://stackoverflow.com/questions/29974507/sap-hana-invalid-table-name) + // Without fixing, exception will be thrown when unique constraint in 'supTable' is applied to 'subTable' as well } @Entity(name = "SuperClass") @Inheritance(strategy = InheritanceType.TABLE_PER_CLASS) - @Table( name = "SUPTABLE", + @Table( name = "supTable", uniqueConstraints = { @UniqueConstraint( name = "UK", columnNames = {"colOne", "colTwo"}) @@ -66,7 +72,7 @@ public class DenormalizedTablePhysicalIncludedTableConstraintTest extends BaseNo } @Entity(name = "SubClass") - @Table( name = "SUBTABLE" ) + @Table( name = "subTable" ) static class SubClass extends SuperClass { @Column(name = "colThree")