HHH-5289 remove unnecessary security checks in property accessors

hibernate-core/src/main/java/org/hibernate/cfg/beanvalidation/BeanValidationIntegrator.java

@@ -69,9 +69,7 @@ public class BeanValidationIntegrator implements Integrator {
 			final Class activatorClass = BeanValidationIntegrator.class.getClassLoader().loadClass( ACTIVATOR_CLASS_NAME );
 			try {
 				final Method validateMethod = activatorClass.getMethod( VALIDATE_SUPPLIED_FACTORY_METHOD_NAME, Object.class );
-				if ( ! validateMethod.isAccessible() ) {
 				validateMethod.setAccessible( true );
-				}
 				try {
 					validateMethod.invoke( null, object );
 				}

hibernate-core/src/main/java/org/hibernate/internal/util/ReflectHelper.java

@@ -303,9 +303,7 @@ public final class ReflectHelper {
 
 		try {
 			Constructor<T> constructor = clazz.getDeclaredConstructor( NO_PARAM_SIGNATURE );
-			if ( !isPublic( clazz, constructor ) ) {
 			constructor.setAccessible( true );
-			}
 			return constructor;
 		}
 		catch ( NoSuchMethodException nme ) {
@@ -363,9 +361,7 @@ public final class ReflectHelper {
 					}
 				}
 				if ( found ) {
-					if ( !isPublic( clazz, constructor ) ) {
 					constructor.setAccessible( true );
-					}
 					return constructor;
 				}
 			}

hibernate-core/src/main/java/org/hibernate/property/BasicPropertyAccessor.java

@@ -260,7 +260,7 @@ public class BasicPropertyAccessor implements PropertyAccessor {
 		Method method = setterMethod(theClass, propertyName);
 
 		if (method!=null) {
-			if ( !ReflectHelper.isPublic(theClass, method) ) method.setAccessible(true);
+			method.setAccessible(true);
 			return new BasicSetter(theClass, method, propertyName);
 		}
 		else {
@@ -325,9 +325,7 @@ public class BasicPropertyAccessor implements PropertyAccessor {
 		Method method = getterMethod(theClass, propertyName);
 
 		if (method!=null) {
-			if ( !ReflectHelper.isPublic( theClass, method ) ) {
 			method.setAccessible(true);
-			}
 			return new BasicGetter(theClass, method, propertyName);
 		}
 		else {

hibernate-core/src/main/java/org/hibernate/property/DirectPropertyAccessor.java

@@ -157,7 +157,7 @@ public class DirectPropertyAccessor implements PropertyAccessor {
 		catch (NoSuchFieldException nsfe) {
 			field = getField( clazz, clazz.getSuperclass(), name );
 		}
-		if ( !ReflectHelper.isPublic(clazz, field) ) field.setAccessible(true);
+		field.setAccessible(true);
 		return field;
 	}
 
@@ -172,7 +172,7 @@ public class DirectPropertyAccessor implements PropertyAccessor {
 		catch (NoSuchFieldException nsfe) {
 			field = getField( root, clazz.getSuperclass(), name );
 		}
-		if ( !ReflectHelper.isPublic(clazz, field) ) field.setAccessible(true);
+		field.setAccessible(true);
 		return field;
 	}
 

hibernate-core/src/main/java/org/hibernate/proxy/pojo/javassist/JavassistLazyInitializer.java

@@ -192,9 +192,7 @@ public class JavassistLazyInitializer extends BasicLazyInitializer implements Me
 						returnValue = thisMethod.invoke( target, args );
 					}
 					else {
-						if ( !thisMethod.isAccessible() ) {
 						thisMethod.setAccessible( true );
-						}
 						returnValue = thisMethod.invoke( target, args );
 					}
 					

hibernate-core/src/main/java/org/hibernate/tuple/component/ComponentTuplizerFactory.java

@@ -135,16 +135,13 @@ public class ComponentTuplizerFactory implements Serializable {
 		Constructor<? extends ComponentTuplizer> constructor = null;
 		try {
 			constructor = clazz.getDeclaredConstructor( COMPONENT_TUP_CTOR_SIG );
-			if ( ! ReflectHelper.isPublic( constructor ) ) {
 			try {
-					// found a constructor, but it was not publicly accessible so try to request accessibility
 				constructor.setAccessible( true );
 			}
 			catch ( SecurityException e ) {
 				constructor = null;
 			}
 		}
-		}
 		catch ( NoSuchMethodException ignore ) {
 		}
 

hibernate-core/src/main/java/org/hibernate/tuple/entity/EntityTuplizerFactory.java

@@ -227,16 +227,13 @@ public class EntityTuplizerFactory implements Serializable {
 		Constructor<? extends EntityTuplizer> constructor = null;
 		try {
 			constructor = clazz.getDeclaredConstructor( constructorArgs );
-			if ( ! ReflectHelper.isPublic( constructor ) ) {
 			try {
-					// found a constructor, but it was not publicly accessible so try to request accessibility
 				constructor.setAccessible( true );
 			}
 			catch ( SecurityException e ) {
 				constructor = null;
 			}
 		}
-		}
 		catch ( NoSuchMethodException ignore ) {
 		}
 

hibernate-entitymanager/src/main/java/org/hibernate/jpa/event/internal/jpa/CallbackProcessorImpl.java

@@ -132,9 +132,7 @@ public class CallbackProcessorImpl implements CallbackProcessor {
 			if (argType != Object.class && argType != entityClass) {
 				continue;
 			}
-			if (!method.isAccessible()) {
 			method.setAccessible( true );
-			}
 
 			return new ListenerCallback( listenerInstance, method );
 		}
@@ -151,7 +149,7 @@ public class CallbackProcessorImpl implements CallbackProcessor {
 		for (Method method : callbackClass.getDeclaredMethods()) {
 			if (!method.getName().equals(methodName)) continue;
 			if (method.getParameterTypes().length != 0) continue;
-			if (!method.isAccessible()) method.setAccessible(true);
+			method.setAccessible(true);
 			return new EntityCallback(method);
 		}
 		return null;

hibernate-entitymanager/src/main/java/org/hibernate/jpa/event/internal/jpa/LegacyCallbackProcessor.java

@@ -104,7 +104,7 @@ public class LegacyCallbackProcessor implements CallbackProcessor {
 												.getName() + " - " + xMethod
 								);
 							}
-							if (!method.isAccessible()) method.setAccessible(true);
+							method.setAccessible(true);
 							log.debugf("Adding %s as %s callback for entity %s",
 									   methodName,
 									   annotation.getSimpleName(),

hibernate-entitymanager/src/main/java/org/hibernate/jpa/internal/metamodel/MetadataContext.java

@@ -428,10 +428,8 @@ class MetadataContext {
 					? metamodelClass.getField( name )
 					: metamodelClass.getDeclaredField( name );
 			try {
-				if ( ! field.isAccessible() ) {
 				// should be public anyway, but to be sure...
 				field.setAccessible( true );
-				}
 				field.set( null, attribute );
 			}
 			catch ( IllegalAccessException e ) {

hibernate-testing/src/main/java/org/hibernate/testing/junit4/TestClassMetadata.java

@@ -83,7 +83,6 @@ public class TestClassMetadata {
 	}
 
 	private void ensureAccessibility(Method method) {
-		if ( !method.isAccessible() ) {
 		try {
 			method.setAccessible( true );
 		}
@@ -91,7 +90,6 @@ public class TestClassMetadata {
 			// ignore for now
 		}
 	}
-	}
 
 	private void addAfterClassOnceCallback(Method method) {
 		if ( afterClassOnceMethods == null ) {
@@ -141,7 +139,6 @@ public class TestClassMetadata {
 					)
 			);
 		}
-		if ( !method.isAccessible() ) {
 		try {
 			method.setAccessible( true );
 		}
@@ -153,7 +150,6 @@ public class TestClassMetadata {
 			);
 		}
 	}
-	}
 
 	private static enum CallbackType {
 		BEFORE_CLASS_ONCE( BeforeClassOnce.class ),