Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-11458 - Optimize the SQL formatter call when iterating through multiple targets

This commit is contained in:
Timofey Gorshkov 2017-02-02 17:36:09 +03:00 committed by Vlad Mihalcea
parent efc041c9e6
commit f82dd465b1
3 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hibernate-core/src/main/java/org/hibernate/tool/schema/internal/AbstractSchemaMigrator.java
View File

@ -519,9 +519,10 @@ public abstract class AbstractSchemaMigrator implements SchemaMigrator {
ExecutionOptions options, ExecutionOptions options,
GenerationTarget... targets) { GenerationTarget... targets) {
if ( !StringHelper.isEmpty( sqlString ) ) { if ( !StringHelper.isEmpty( sqlString ) ) {
String sqlStringFormatted = formatter.format( sqlString );
for ( GenerationTarget target : targets ) { for ( GenerationTarget target : targets ) {
try { try {
target.accept( formatter.format( sqlString ) ); target.accept( sqlStringFormatted );
} }
catch (CommandAcceptanceException e) { catch (CommandAcceptanceException e) {
if ( !quiet ) { if ( !quiet ) {

3
hibernate-core/src/main/java/org/hibernate/tool/schema/internal/SchemaCreatorImpl.java
View File

@ -435,8 +435,9 @@ public class SchemaCreatorImpl implements SchemaCreator {
} }
try { try {
String sqlStringFormatted = formatter.format( sqlString );
for ( GenerationTarget target : targets ) { for ( GenerationTarget target : targets ) {
target.accept( formatter.format( sqlString ) ); target.accept( sqlStringFormatted );
} }
} }
catch (CommandAcceptanceException e) { catch (CommandAcceptanceException e) {

3
hibernate-core/src/main/java/org/hibernate/tool/schema/internal/SchemaDropperImpl.java
View File

@ -369,9 +369,10 @@ public class SchemaDropperImpl implements SchemaDropper {
return; return;
} }
String sqlStringFormatted = formatter.format( sqlString );
for ( GenerationTarget target : targets ) { for ( GenerationTarget target : targets ) {
try { try {
target.accept( formatter.format( sqlString ) ); target.accept( sqlStringFormatted );
} }
catch (CommandAcceptanceException e) { catch (CommandAcceptanceException e) {
options.getExceptionHandler().handleException( e ); options.getExceptionHandler().handleException( e );