Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-7631 - Improve performance of UpdateTimestampsCache

This commit is contained in:
Steve Ebersole 2012-09-21 07:02:16 -05:00
parent a8a3f9b112
commit f85e9247e9
1 changed files with 58 additions and 63 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

121
hibernate-core/src/main/java/org/hibernate/cache/spi/UpdateTimestampsCache.java vendored
View File

@ -26,7 +26,6 @@ package org.hibernate.cache.spi;
import java.io.Serializable; import java.io.Serializable;
import java.util.Properties; import java.util.Properties;
import java.util.Set; import java.util.Set;
import java.util.concurrent.locks.ReentrantReadWriteLock;
import org.jboss.logging.Logger; import org.jboss.logging.Logger;
@ -51,100 +50,96 @@ public class UpdateTimestampsCache {
public static final String REGION_NAME = UpdateTimestampsCache.class.getName(); public static final String REGION_NAME = UpdateTimestampsCache.class.getName();
private static final CoreMessageLogger LOG = Logger.getMessageLogger( CoreMessageLogger.class, UpdateTimestampsCache.class.getName() ); private static final CoreMessageLogger LOG = Logger.getMessageLogger( CoreMessageLogger.class, UpdateTimestampsCache.class.getName() );
private ReentrantReadWriteLock readWriteLock = new ReentrantReadWriteLock();
private final TimestampsRegion region;
private final SessionFactoryImplementor factory; private final SessionFactoryImplementor factory;
private final TimestampsRegion region;
public UpdateTimestampsCache(Settings settings, Properties props, final SessionFactoryImplementor factory) throws HibernateException { public UpdateTimestampsCache(Settings settings, Properties props, final SessionFactoryImplementor factory) throws HibernateException {
this.factory = factory; this.factory = factory;
String prefix = settings.getCacheRegionPrefix(); final String prefix = settings.getCacheRegionPrefix();
String regionName = prefix == null ? REGION_NAME : prefix + '.' + REGION_NAME; final String regionName = prefix == null ? REGION_NAME : prefix + '.' + REGION_NAME;
LOG.startingUpdateTimestampsCache( regionName ); LOG.startingUpdateTimestampsCache( regionName );
this.region = settings.getRegionFactory().buildTimestampsRegion( regionName, props ); this.region = settings.getRegionFactory().buildTimestampsRegion( regionName, props );
} }
@SuppressWarnings({"UnusedDeclaration"}) @SuppressWarnings({"UnusedDeclaration"})
public UpdateTimestampsCache(Settings settings, Properties props) public UpdateTimestampsCache(Settings settings, Properties props) throws HibernateException {
throws HibernateException { this( settings, props, null );
this(settings, props, null);
} }
@SuppressWarnings({"UnnecessaryBoxing"}) @SuppressWarnings({"UnnecessaryBoxing"})
public void preinvalidate(Serializable[] spaces) throws CacheException { public void preinvalidate(Serializable[] spaces) throws CacheException {
readWriteLock.writeLock().lock(); final boolean debug = LOG.isDebugEnabled();
final boolean stats = factory != null && factory.getStatistics().isStatisticsEnabled();
try { final Long ts = region.nextTimestamp() + region.getTimeout();
Long ts = region.nextTimestamp() + region.getTimeout();
for ( Serializable space : spaces ) { for ( Serializable space : spaces ) {
if ( debug ) {
LOG.debugf( "Pre-invalidating space [%s], timestamp: %s", space, ts ); LOG.debugf( "Pre-invalidating space [%s], timestamp: %s", space, ts );
//put() has nowait semantics, is this really appropriate?
//note that it needs to be async replication, never local or sync
region.put( space, ts );
if ( factory != null && factory.getStatistics().isStatisticsEnabled() ) {
factory.getStatisticsImplementor().updateTimestampsCachePut();
}
} }
} //put() has nowait semantics, is this really appropriate?
finally { //note that it needs to be async replication, never local or sync
readWriteLock.writeLock().unlock(); region.put( space, ts );
if ( stats ) {
factory.getStatisticsImplementor().updateTimestampsCachePut();
}
} }
} }
@SuppressWarnings({"UnnecessaryBoxing"}) @SuppressWarnings({"UnnecessaryBoxing"})
public void invalidate(Serializable[] spaces) throws CacheException { public void invalidate(Serializable[] spaces) throws CacheException {
readWriteLock.writeLock().lock(); final boolean debug = LOG.isDebugEnabled();
final boolean stats = factory != null && factory.getStatistics().isStatisticsEnabled();
try { final Long ts = region.nextTimestamp();
Long ts = region.nextTimestamp();
for (Serializable space : spaces) { for (Serializable space : spaces) {
if ( debug ) {
LOG.debugf( "Invalidating space [%s], timestamp: %s", space, ts ); LOG.debugf( "Invalidating space [%s], timestamp: %s", space, ts );
//put() has nowait semantics, is this really appropriate?
//note that it needs to be async replication, never local or sync
region.put( space, ts );
if ( factory != null && factory.getStatistics().isStatisticsEnabled() ) {
factory.getStatisticsImplementor().updateTimestampsCachePut();
}
} }
} //put() has nowait semantics, is this really appropriate?
finally { //note that it needs to be async replication, never local or sync
readWriteLock.writeLock().unlock(); region.put( space, ts );
if ( stats ) {
factory.getStatisticsImplementor().updateTimestampsCachePut();
}
} }
} }
@SuppressWarnings({"unchecked", "UnnecessaryUnboxing"}) @SuppressWarnings({"unchecked", "UnnecessaryUnboxing"})
public boolean isUpToDate(Set spaces, Long timestamp) throws HibernateException { public boolean isUpToDate(Set spaces, Long timestamp) throws HibernateException {
readWriteLock.readLock().lock(); final boolean debug = LOG.isDebugEnabled();
final boolean stats = factory != null && factory.getStatistics().isStatisticsEnabled();
try { for ( Serializable space : (Set<Serializable>) spaces ) {
for ( Serializable space : (Set<Serializable>) spaces ) { Long lastUpdate = (Long) region.get( space );
Long lastUpdate = (Long) region.get( space ); if ( lastUpdate == null ) {
if ( lastUpdate == null ) { if ( stats ) {
if ( factory != null && factory.getStatistics().isStatisticsEnabled() ) { factory.getStatisticsImplementor().updateTimestampsCacheMiss();
factory.getStatisticsImplementor().updateTimestampsCacheMiss();
}
//the last update timestamp was lost from the cache
//(or there were no updates since startup!)
//updateTimestamps.put( space, new Long( updateTimestamps.nextTimestamp() ) );
//result = false; // safer
} }
else { //the last update timestamp was lost from the cache
if ( LOG.isDebugEnabled() ) { //(or there were no updates since startup!)
LOG.debugf( //updateTimestamps.put( space, new Long( updateTimestamps.nextTimestamp() ) );
"[%s] last update timestamp: %s", //result = false; // safer
space, }
lastUpdate + ", result set timestamp: " + timestamp else {
); if ( debug ) {
} LOG.debugf(
if ( factory != null && factory.getStatistics().isStatisticsEnabled() ) { "[%s] last update timestamp: %s",
factory.getStatisticsImplementor().updateTimestampsCacheHit(); space,
} lastUpdate + ", result set timestamp: " + timestamp
if ( lastUpdate >= timestamp ) return false; );
}
if ( stats ) {
factory.getStatisticsImplementor().updateTimestampsCacheHit();
}
if ( lastUpdate >= timestamp ) {
return false;
} }
} }
return true;
}
finally {
readWriteLock.readLock().unlock();
} }
return true;
} }
public void clear() throws CacheException { public void clear() throws CacheException {