HHH-13496 Make inner classes 'static' when possible

hibernate-core/src/main/java/org/hibernate/boot/internal/InFlightMetadataCollectorImpl.java

@@ -1356,7 +1356,7 @@ public class InFlightMetadataCollectorImpl implements InFlightMetadataCollector
 		return xrefEntry == null ? null : xrefEntry.secondaryTableJoinMap;
 	}
 
-	private final class EntityTableXrefImpl implements EntityTableXref {
+	private static final class EntityTableXrefImpl implements EntityTableXref {
 		private final Identifier primaryTableLogicalName;
 		private final Table primaryTable;
 		private EntityTableXrefImpl superEntityTableXref;

hibernate-core/src/main/java/org/hibernate/boot/model/source/internal/hbm/ModelBinder.java

@@ -4149,7 +4149,7 @@ public class ModelBinder {
 		}
 	}
 
-	private class ManyToOneFkSecondPass extends FkSecondPass {
+	private static class ManyToOneFkSecondPass extends FkSecondPass {
 		private final MappingDocument mappingDocument;
 		private final ManyToOne manyToOneBinding;
 
@@ -4210,7 +4210,7 @@ public class ModelBinder {
 		}
 	}
 
-	private class NaturalIdUniqueKeyBinderImpl implements NaturalIdUniqueKeyBinder {
+	private static class NaturalIdUniqueKeyBinderImpl implements NaturalIdUniqueKeyBinder {
 		private final MappingDocument mappingDocument;
 		private final PersistentClass entityBinding;
 		private final List<Property> attributeBindings = new ArrayList<Property>();

hibernate-core/src/main/java/org/hibernate/bytecode/enhance/internal/bytebuddy/EnhancerImpl.java

@@ -541,7 +541,7 @@ public class EnhancerImpl implements Enhancer {
 		}
 	}
 
-	private class EnhancerClassFileLocator extends ClassFileLocator.ForClassLoader {
+	private static class EnhancerClassFileLocator extends ClassFileLocator.ForClassLoader {
 
 		// The name of the class to (possibly be) transformed.
 		private String className;

hibernate-core/src/main/java/org/hibernate/dialect/Teradata14Dialect.java

@@ -207,7 +207,7 @@ public class Teradata14Dialect extends TeradataDialect {
 	}
 
 
-	private class TeradataIndexExporter extends StandardIndexExporter implements Exporter<Index> {
+	private static class TeradataIndexExporter extends StandardIndexExporter implements Exporter<Index> {
 
 		public TeradataIndexExporter(Dialect dialect) {
 			super(dialect);

hibernate-core/src/main/java/org/hibernate/resource/beans/container/internal/JpaCompliantLifecycleStrategy.java

@@ -170,7 +170,7 @@ public class JpaCompliantLifecycleStrategy implements BeanLifecycleStrategy {
 	}
 
 
-	private class NamedBeanImpl<B> implements ContainedBeanImplementor<B> {
+	private static class NamedBeanImpl<B> implements ContainedBeanImplementor<B> {
 		private final Class<B> beanType;
 		private final String beanName;
 

hibernate-core/src/main/java/org/hibernate/resource/beans/internal/ManagedBeanRegistryImpl.java

@@ -120,7 +120,7 @@ public class ManagedBeanRegistryImpl implements ManagedBeanRegistry, BeanContain
 		registrations.clear();
 	}
 
-	private class ContainedBeanManagedBeanAdapter<B> implements ManagedBean<B> {
+	private static class ContainedBeanManagedBeanAdapter<B> implements ManagedBean<B> {
 		private final Class<B> beanClass;
 		private final ContainedBean<B> containedBean;
 

hibernate-core/src/main/java/org/hibernate/tool/schema/internal/SchemaDropperImpl.java

@@ -548,7 +548,7 @@ public class SchemaDropperImpl implements SchemaDropper {
 			}
 		}
 
-		private class JdbcContextDelayedDropImpl implements JdbcContext {
+		private static class JdbcContextDelayedDropImpl implements JdbcContext {
 			private final ServiceRegistry serviceRegistry;
 			private final JdbcServices jdbcServices;
 			private final JdbcConnectionAccess jdbcConnectionAccess;