Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

EJB-406 - Makes a test to fail if there are unfinished transactions, and closes it to not affect other tests 

git-svn-id: https://svn.jboss.org/repos/hibernate/core/trunk@15686 1b8cb986-b30d-0410-93ca-fae66ebed9b2
This commit is contained in:
Juraci Krohling 2008-12-12 13:10:10 +00:00
parent cc12ed8c53
commit fb2eb9e870
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
entitymanager/src/test/java/org/hibernate/ejb/test/TestCase.java
View File

@ -12,6 +12,8 @@ import javax.persistence.EntityManager;
import javax.persistence.EntityManagerFactory; import javax.persistence.EntityManagerFactory;
import javax.persistence.Persistence; import javax.persistence.Persistence;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.hibernate.cfg.Environment; import org.hibernate.cfg.Environment;
import org.hibernate.ejb.HibernatePersistence; import org.hibernate.ejb.HibernatePersistence;
@ -22,6 +24,7 @@ import org.hibernate.ejb.HibernatePersistence;
public abstract class TestCase extends junit.framework.TestCase { public abstract class TestCase extends junit.framework.TestCase {
protected EntityManagerFactory factory; protected EntityManagerFactory factory;
protected EntityManager em; protected EntityManager em;
private static Log log = LogFactory.getLog( TestCase.class );
public TestCase() { public TestCase() {
super(); super();
@ -44,10 +47,22 @@ public abstract class TestCase extends junit.framework.TestCase {
try { try {
em = getOrCreateEntityManager(); em = getOrCreateEntityManager();
super.runTest(); super.runTest();
if (em.getTransaction().isActive()) {
em.getTransaction().rollback();
fail("You left an open transaction! Fix your test case. For now, we are closing it for you.");
}
} catch (Throwable t) { } catch (Throwable t) {
if (em.getTransaction().isActive()) if (em.getTransaction().isActive())
em.getTransaction().rollback(); em.getTransaction().rollback();
throw t; throw t;
} finally {
if (em.isOpen()) {
// as we open an EM before the test runs, it will still be open if the test uses a custom EM.
// or, the person may have forgotten to close. So, do not raise a "fail", but log the fact.
em.close();
log.warn("The EntityManager is not closed. Closing it.");
}
} }
} }