Hibernate/hibernate-orm
1
0
Fork 0
mirror of https://github.com/hibernate/hibernate-orm synced 2025-03-02 15:59:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

HHH-13976 Some javadoc clarifications and code style adjustments

Browse Source
This commit is contained in:
Sanne Grinovero 2020-04-30 14:31:00 +01:00
parent dd6ebda110
commit fcc5c150c0
4 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hibernate-core/src/main/java/org/hibernate/engine/jdbc/internal/JdbcCoordinatorImpl.java
View File

@ -444,10 +444,8 @@ public void afterTransactionBegin() {
@Override @Override
public void beforeTransactionCompletion() { public void beforeTransactionCompletion() {
owner.beforeTransactionCompletion(); this.owner.beforeTransactionCompletion();
if ( getConnectionReleaseMode() == ConnectionReleaseMode.BEFORE_TRANSACTION_COMPLETION ) { this.logicalConnection.beforeTransactionCompletion();
this.logicalConnection.beforeTransactionCompletion();
}
} }
@Override @Override

1
hibernate-core/src/main/java/org/hibernate/resource/jdbc/internal/LogicalConnectionManagedImpl.java
View File

@ -152,7 +152,6 @@ public void afterStatement() {
@Override @Override
public void beforeTransactionCompletion() { public void beforeTransactionCompletion() {
super.beforeTransactionCompletion(); super.beforeTransactionCompletion();
if ( connectionHandlingMode.getReleaseMode() == ConnectionReleaseMode.BEFORE_TRANSACTION_COMPLETION ) { if ( connectionHandlingMode.getReleaseMode() == ConnectionReleaseMode.BEFORE_TRANSACTION_COMPLETION ) {
log.debug( "Initiating JDBC connection release from beforeTransactionCompletion" ); log.debug( "Initiating JDBC connection release from beforeTransactionCompletion" );
releaseConnection(); releaseConnection();

5
hibernate-core/src/main/java/org/hibernate/resource/jdbc/spi/LogicalConnectionImplementor.java
View File

@ -36,8 +36,9 @@ public interface LogicalConnectionImplementor extends LogicalConnection {
void afterStatement(); void afterStatement();
/** /**
* Notification indicating a transaction is about to completed to trigger * Notification indicating a transaction is about to be completed, so to trigger
* {@link org.hibernate.ConnectionReleaseMode#BEFORE_TRANSACTION_COMPLETION} releasing if needed * releasing of the connection if needed ({@link org.hibernate.ConnectionReleaseMode#BEFORE_TRANSACTION_COMPLETION}
* is enabled)
*/ */
void beforeTransactionCompletion(); void beforeTransactionCompletion();

2
hibernate-core/src/test/java/org/hibernate/test/connections/BeforeCompletionReleaseTest.java
View File

@ -43,7 +43,7 @@ public class BeforeCompletionReleaseTest extends BaseEntityManagerFunctionalTest
@Override @Override
protected Map getConfig() { protected Map getConfig() {
Map config = super.getConfig(); Map config = super.getConfig();
TestingJtaBootstrap.prepare( config ); TestingJtaBootstrap.prepare( config );
config.put( AvailableSettings.CONNECTION_PROVIDER, new ConnectionProviderDecorator() ); config.put( AvailableSettings.CONNECTION_PROVIDER, new ConnectionProviderDecorator() );
config.put( AvailableSettings.CONNECTION_HANDLING, PhysicalConnectionHandlingMode.DELAYED_ACQUISITION_AND_RELEASE_BEFORE_TRANSACTION_COMPLETION ); config.put( AvailableSettings.CONNECTION_HANDLING, PhysicalConnectionHandlingMode.DELAYED_ACQUISITION_AND_RELEASE_BEFORE_TRANSACTION_COMPLETION );