Yanming Zhou
b870214ce9
Polishing `EntityVersionMappingImpl`
...
1. remove unused field `BasicAttributeMapping attributeMapping`
2. remove unused constructor parameter `MappingModelCreationProcess creationProcess`
2024-09-05 09:58:41 +02:00
Gavin King
7c30bbed2b
very minor code cleanups
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-04 22:22:58 +02:00
Gavin King
eacbd78956
split out SessionFactorySettings and kill off MappingMetamodelImpl.close()
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-04 09:27:46 +02:00
Gavin King
4781c09d0d
migrate toward the new PersistenceUnitTransactionType from JPA 3.2
...
clean up the test base classes etc.
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-04 09:27:46 +02:00
Gavin King
437b59a57d
continue in attempt to clean up EMFBuilderImpl
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-03 19:05:12 +02:00
Gavin King
1f48e8c41d
get rid of hangovers from HEM merge
...
make a rough start on cleaning up EntityManagerFactoryBuilderImpl
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-03 02:57:37 +02:00
Gavin King
049610b90d
split out SessionFactoryRegistryMessageLogger
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 19:22:41 +02:00
Gavin King
f6ff6fa0f7
code cleanup in Visitors
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King
763401a5c8
clean up the internal DefaultVisitor hierarchy
...
by removing two obsolete abstract superclasses
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King
9c75adcffc
cleanups in event listeners
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King
ec3be767e4
HHH-18553 handle case where managed entity was already removed
...
just short-circuit and abort the remove()
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King
edf813083e
HHH-18553 add a log message
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King
342afd28d4
improve/modernize some error messages
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King
f7adc587b2
HHH-18553 add the test
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King
578023e538
HHH-18553 change thrown exception type
...
and cleanups in DefaultDeleteEventListener
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Andrea Boriero
7e4df3f805
HHH-18543 Skip GenericCompositeUserTypeTest for JVM OpenJ9
2024-09-02 10:00:18 +02:00
Gavin King
052eb0b78c
cleanups to EventListenerGroup(Impl)
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 00:46:51 +02:00
Gavin King
48fc2ee66d
cleanups to EntityEntryContext javadoc
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 00:46:51 +02:00
Gavin King
302dd29be1
move check for remove(detached) to SessionImpl for consistency/simplicity
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 00:46:51 +02:00
Gavin King
f7db3f0005
misc cleanups
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 00:46:51 +02:00
Gavin King
09fa8ef76a
HHH-18553 flush/evict when there is a managed instance while deleting the detached instance
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 00:46:51 +02:00
Gavin King
5c89079f2e
consistently pass along session-level lock options
...
previously, these were respected by a random subset of session methods
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King
335f7bea9c
avoid use of deprecated methods
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King
f95182e736
more consistent error message between JPA and plain Hibernate
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King
d7aa5f7a78
clean up ExceptionConverterImpl
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King
dd16ed61f0
fix and clean up AbstractJPATest
...
clean up LockTest a little
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King
f805bcec63
cleanups, especially to useless uses of JBoss logging
...
don't use loggers to generate exception messages
our convention for exception messages is NOT that they begin with HHH-XXXX
it's completely useless to have, like, five of them which do
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King
83cdeb81b6
HHH-18169 big cleanup of lock/refresh in SessionImpl and collaborators
...
this was a big mess with no consistency between different overloads of
the same-named method of Session, not to mention different methods
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King
f45e3db4b0
HHH-18552 clean up inappropriate usages of TransientObjectException
...
and minor cleanups in StatefulPersistenceContext
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-31 17:46:11 +02:00
Gavin King
7422c18a94
HHH-18169 disallow refresh/lock for detached instance
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-31 17:46:11 +02:00
Gavin King
1d12dc0499
HHH-18547, HHH-17114 add default implementations to UserType
...
and deprecate the wrong-signature nullSafeGet() method
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-31 10:45:48 +02:00
Gavin King
519ffb7c78
some cleanup around SessionFactoryImplementor
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-31 00:22:00 +02:00
Gavin King
67bd785add
more misc cleanups
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-31 00:22:00 +02:00
Gavin King
ab12b436a2
push down some methods from SessionImplementor to EventSource
...
just as recommended by the @Deprecated tags added in H6
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-31 00:22:00 +02:00
Gavin King
681bd09b9d
squash warnings in bean LifecycleStrategy stuff
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-30 21:42:15 +02:00
Gavin King
7b8c403df7
clean up ResultSetReturnImpl
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-30 21:42:15 +02:00
Gavin King
252bae18a1
clean up ConnectionProviderInitiator
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-30 21:42:15 +02:00
Gavin King
a59f2ac6c8
some cleanup to DatasourceConnectionProviderImpl and multi-tenant version
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-30 20:01:58 +02:00
Gavin King
47c99d5a31
HHH-18538 fix startup logging for DatasourceConnectionProviderImpl and multi-tenant version
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-30 20:01:58 +02:00
Gavin King
8aa37a9d85
fix the typing in ReplicationMode
...
and improve readability in DefaultReplicateEventListener
even though they are deprecated
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-30 16:44:22 +02:00
Gavin King
e351a00c19
fix a typo in previous commit
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-30 15:46:27 +02:00
Gavin King
72e42817e3
rationalize diverse ways to split strings
...
+ a couple of other code cleanups
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-30 13:40:34 +02:00
Gavin King
6787da71af
HHH-18548 remove org.hibernate.annotations.QueryHints
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-30 11:14:08 +02:00
Kyrylo Merzlikin
ad6f326090
HHH-18516 - Ignore @AttributeOverride for map key when checking type of map value
2024-08-30 09:41:49 +02:00
Tommy Svendsen
d39ba13ee4
HHH-18518 Using StringHelper to split versionString instead of regex parsing
2024-08-30 09:32:39 +02:00
Tommy Svendsen
9ac9637daa
HHH-18518 change implementation to capture MySQL custom versions better
2024-08-30 09:32:39 +02:00
Marco Belladelli
00680b37fd
HHH-18541 Migrate hibernate-envers from hcann to hibernate-models
2024-08-29 13:40:54 -05:00
Gavin King
f1d7d86c2d
add since to some @Deprecated operations and delete a couple
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 19:56:30 +02:00
Gavin King
b53728f727
clean up QueryBinder a bit
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 19:56:30 +02:00
Yanming Zhou
b1fcfdc54e
HHH-18538 Improve database connection info from configured DataSource
2024-08-29 18:00:33 +02:00
Anilabha Baral
3159c80146
HHH-17310: Bug with names with digits in CamelCaseToUnderscoresNamingStrategy
2024-08-29 15:35:58 +02:00
Gavin King
850d266c52
HHH-18544 add disabled tests
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 15:30:39 +02:00
Gavin King
dee06bfcb8
HHH-18539 remove the obsolete test for HHH-13891
...
we now just throw an exception when the setter is final
(there was some special case for load() which made no sense)
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 15:30:39 +02:00
Gavin King
64622858ab
add some @Serial annotations as recommended by IntelliJ
...
improve a @Deprecated annotation
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 15:30:39 +02:00
Gavin King
11b11c02eb
HHH-18540 remove an overload of lock() that's completely useless
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 15:30:39 +02:00
Gavin King
d38971f75b
HHH-18539 update tests after removal of load()
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 15:30:39 +02:00
Gavin King
6fe0553fb9
HHH-18540 remove Session.LockRequest
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 15:30:39 +02:00
Gavin King
bbbaf511ec
HHH-18539 remove Session.load()
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 15:30:39 +02:00
Yanming Zhou
e407c53c86
Remove duplicated space before `when matched`
...
Running `org.hibernate.orm.test.stateless.UpsertTest`:
Before -> `merge into "UpsertTest$Record" as t using (select cast(? as bigint) id, cast(? as varchar) message) as s on (t.id=s.id) when not matched then insert (id, message) values (s.id, s.message) when matched then update set message=s.message`
After -> `merge into "UpsertTest$Record" as t using (select cast(? as bigint) id, cast(? as varchar) message) as s on (t.id=s.id) when not matched then insert (id, message) values (s.id, s.message) when matched then update set message=s.message`
2024-08-29 10:55:30 +02:00
Yanming Zhou
4cef240c5c
HHH-6951 IdentifiableType.getIdType() should respect @IdClass
...
Before this commit, `IdentifiableType.getIdType()` returns unexpected `null` if multiple @Id present.
2024-08-29 10:02:39 +02:00
Gavin King
b9f15e888e
remove makeCopy() method, since it was annotated @Remove
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 01:38:43 +02:00
Gavin King
9e745b4e79
remove more obsolete things annotated @Remove
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 01:38:43 +02:00
Gavin King
8eb4d8da0d
HHH-18341 fix the issue simply by removing obsolete code
...
also take the opportunity to "do" a todo
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 00:17:12 +02:00
nathan.xu
3e8f75079a
HHH-18385 Remove java.sql.Statement logging in SqlStatementLogger
2024-08-28 22:04:28 +02:00
marko-bekhta
7c594d1412
HHH-18488 Remove table-information-group attribute group in hbm mapping
...
- just use a list of attributes instead of the group.
2024-08-28 10:36:21 -05:00
marko-bekhta
28988a9a5c
HHH-18488 Bump the jboss logging dependency
2024-08-28 10:36:21 -05:00
Vladimír Kuruc
43745c9372
HHH-18531 Fix for Informix timestamp literal error
2024-08-28 17:15:17 +02:00
Marco Belladelli
b8b8f011dc
HHH-18524 Fix binding of meta-annotated id generators for id-class
2024-08-28 16:21:06 +02:00
Marco Belladelli
6d0c9599e6
HHH-18524 Add test for issue
2024-08-28 16:21:06 +02:00
Gavin King
a87e08b2e2
HHH-18487 align behavior of UnsavedValueFactory with semantics of persist()
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-28 14:28:04 +02:00
Gavin King
318e4e6c5d
remove unused method marked for removal
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-28 14:28:04 +02:00
Vladimír Kuruc
5975d02e39
Tests with current_timestamp requires Dialect UsesStandardCurrentTimestampFunction feature
2024-08-27 07:10:43 -05:00
Gavin King
d90807f9e4
HHH-17117 allow @TenantId to form part of composite key
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-26 21:47:29 +02:00
Steve Ebersole
77a34e6312
HHH-18519 - Add vararg method to HibernatePersistenceConfiguration for supplying mappings
2024-08-26 14:31:23 -05:00
Marco Belladelli
4b06bf63cd
HHH-18337 Account for physical naming strategy when querying db sequence
...
Introduced new signature for `Configurable#configure` which accepts a `GeneratorCreationContext`.
2024-08-26 13:47:24 +02:00
Marco Belladelli
7402e1a153
HHH-18337 Add test for issue
2024-08-26 13:47:24 +02:00
Gavin King
d306aadb9d
HHH-18517 allow composition of CriteriaDefinitions
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-25 22:18:32 +02:00
Gavin King
4fd9a4f0df
HHH-18158 additional test
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-23 22:39:48 +02:00
Gavin King
1f9add32c2
HHH-18512 cleanup code surrounding custom PostgreSQL and Oracle types
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-23 18:21:54 +02:00
Gavin King
54d80f6d1c
HHH-18512 @EnumeratedValue and Oracle named enum types
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-23 18:21:54 +02:00
Gavin King
64a98417e2
HHH-18512 @EnumeratedValue and PostgreSQL named enum types
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-23 18:21:54 +02:00
Gavin King
5dcbdf64f1
code cleanups to SequenceStyleGenerator and TableGenerator ( #8816 )
...
* code cleanups to SequenceStyleGenerator and TableGenerator
Signed-off-by: Gavin King <gavin@hibernate.org>
* code cleanups to TableStructure and SequenceStructure
Signed-off-by: Gavin King <gavin@hibernate.org>
* more very minor cleanups around enhanced generators
Signed-off-by: Gavin King <gavin@hibernate.org>
* more very minor cleanups around enhanced generators
Signed-off-by: Gavin King <gavin@hibernate.org>
* more very minor cleanups around enhanced generators
Signed-off-by: Gavin King <gavin@hibernate.org>
---------
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-22 19:22:59 +02:00
Christian Beikov
5d45d19005
HHH-18506 Reduce itable stubs during dirty checking
2024-08-21 18:54:28 +02:00
Christian Beikov
94b444b4d8
HHH-18506 Improve flush performance by reducing itable stubs
2024-08-21 18:54:28 +02:00
Gavin King
d4740a9bc8
some very minor cleanups
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-21 13:21:22 +02:00
Gavin King
afca93158e
minor code cleanups in AbstractEntityPersister
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-16 05:54:17 -06:00
Christian Beikov
a956fda688
HHH-17646 Optimize away real table group rendering if possible
2024-08-16 13:35:45 +02:00
Christian Beikov
5fd74adcbf
HHH-18493 Resolving already initialized collection elements leads to assertion error
2024-08-16 13:29:59 +02:00
Steve Ebersole
6708cd5cf5
rebase fixups : main -> 7.0
2024-08-15 13:52:33 -05:00
Gavin King
1718e884cc
remove unused Logger
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-15 13:52:33 -05:00
Steve Ebersole
f2afee75d8
HHH-2003 - Collections which are fetched AND restricted should not be written to second-level cache
2024-08-15 13:52:33 -05:00
Steve Ebersole
5f5551c950
HHH-17448 - Add newly standard column annotation attributes to Hibernate column annotations
2024-08-15 13:52:33 -05:00
Steve Ebersole
13362867dd
rebase main -> 7.0
2024-08-15 13:52:32 -05:00
Jan Schatteman
cbe89511d2
HHH-17888 - Remove support for MariaDB versions older than 10.5
...
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2024-08-15 13:52:32 -05:00
Steve Ebersole
2273365e06
HHH-17448 - Add newly standard column annotation attributes to Hibernate column annotations
2024-08-15 13:52:32 -05:00
Steve Ebersole
c1124d46aa
Revert 01ceadf51c (diff-3aa97a10c4448cdca7e99efdfdfc751068382426129b9cdfc0f6bcb9c3ae2993)
...
That constructor form is used by Reactive.
2024-08-15 13:52:32 -05:00
Andrea Boriero
0b964a3f19
HHH-17448 Add newly standard column annotation attributes to Hibernate column annotations
2024-08-15 13:52:32 -05:00
Andrea Boriero
ec556f0fa5
HHH-18444 Remove deprecate Session#refresh methods
2024-08-15 13:52:32 -05:00
Steve Ebersole
c9cc54d156
fix ups
2024-08-15 13:52:32 -05:00
Andrea Boriero
37644a42a8
HHH-18452 Remove deprecated org.hibernate.Interceptor methods
2024-08-15 13:52:32 -05:00