Commit Graph

5641 Commits

Author SHA1 Message Date
Yoann Rodière 0dd322d4be
HHH-14371 Open java.base/java.security and java/base/java.lang to the unnamed module in tests
Weld needs this, in CDI tests.

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-01-07 17:21:05 +01:00
Yoann Rodière f2a866e0af
HHH-14371 Open java.base/java.nio.charset to the unnamed module in tests
NamingHelper test needs access to Charset.defaultCharset.

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-01-07 17:21:05 +01:00
Yoann Rodière 6845edd74e
HHH-14371 Correctly set JVM args in the JVM running tests
Turns out getJvmArgs() returns a copy, so modifying that copy won't
change the JVM args.

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-01-07 17:21:05 +01:00
Yoann Rodière 08079035c7
HHH-14315 Force JVM options when using toolchains
Apparently Gradle won't just use the same options as in its own JVM.

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-01-07 17:15:35 +01:00
Yoann Rodière fb2a5cf94b
HHH-14315 Add optional support for toolchains to the Gradle build
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-01-07 17:15:35 +01:00
Yoann Rodière ddb474f7c3
HHH-14323 Enable extended bytecode enhancement in NaturalIdInUninitializedAssociationTest
This test accesses a field of an entity directly and expects it to be
automatically initialized; this cannot work without extended bytecode
enhancement.

This used to work with Java 8 bytecode, but only by chance. It seems
that Java 8 bytecode relies on "synthetic", static access methods
inserted by the compiler to access the fields of entities in this test:
any access to the field is done through this access method instead of
through a direct field access. Since we apply bytecode enhancement to
all methods of entities, this means that access to fields triggers
initialization, without any bytecode enhancement in the caller class.

I believe this is specific to nested classes, but couldn't find a
source. For reference, the bytecode of access methods looks like this:

  static int access$002(org.hibernate.test.bytecode.enhancement.lazy.NaturalIdInUninitializedAssociationTest$AnEntity, int);
    Code:
       0: aload_0
       1: iload_1
       2: dup_x1
       3: putfield      #3                  // Field id:I
       6: ireturn

  static org.hibernate.test.bytecode.enhancement.lazy.NaturalIdInUninitializedAssociationTest$EntityImmutableNaturalId access$102(org.hibernate.test.bytecode.enhancement.lazy.NaturalIdInUninitializedAssociationTest$AnEntity, org.hibernate.test.bytecode.enhancement.lazy.NaturalIdInUninitializedAssociationTest$EntityImmutableNaturalId);
    Code:
       0: aload_0
       1: aload_1
       2: dup_x1
       3: putfield      #2                  // Field entityImmutableNaturalId:Lorg/hibernate/test/bytecode/enhancement/lazy/NaturalIdInUninitializedAssociationTest$EntityImmutableNaturalId;
       6: areturn

With Java 11, however, access to fields of entities is done directly,
even for nested classes. So the access methods no longer exist, and we
don't get automatic initialization upon field access. We need extended
bytecode enhancement, like we would in any other case of field access
(in particular accessing fields of non-nested classes).
2021-01-07 17:15:34 +01:00
Sanne Grinovero 21ec1a19d1 HHH-14385 Allow specifying a target JVM version for compatibility of generated proxies via ByteBuddy 2020-12-22 18:01:12 +00:00
Christian Beikov 89f0000b62 HHH-14380 - Only reorder destination from elements from the same from clause 2020-12-20 10:53:34 +01:00
Jan-Willem Gmelig Meyling c1baa23734 HHH-14380 Test case from https://github.com/Blazebit/blaze-persistence/pull/1237 for subquery in on-clause 2020-12-20 10:53:28 +01:00
jiangHZ 5a57bc9798 HHH-13913 An SQL Dialect for PostgreSQL 10 and later. Adds support for Partition table. 2020-12-16 14:40:35 +01:00
Yanming Zhou 04c97c2293 HHH-14356 Avoid NPE when booting with xml_mapping_enabled=false
Introduced by HHH-14334
when use Envers with hibernate.xml_mapping_enabled=false
see 34151a9660 (r44735539)
2020-12-14 16:39:01 +00:00
Christian Beikov 9e59f02e0f HHH-14360 Test a fix for NPE due to non-existing previous state in bytecode enhanced dirty attribute resolving 2020-12-11 15:16:30 +00:00
Andrea Boriero f8f88f4e3f HHH-14363 MutableTypeEnhancementTestCase failing when run on Oracle DB 2020-12-08 16:12:46 +01:00
Andrea Boriero 70f3a9260b HHH-14242 Fix issue for Dialects supporting row value constructor Syntax but not in the SET clause 2020-11-30 20:46:45 +00:00
Andrea Boriero 54ea3c15bf HHH-14251 Fix issue for Dialects not supporting row value constructor Syntax 2020-11-30 20:46:40 +00:00
Andrea Boriero ec7a278358 HHH-14251 Invalid SQL for @Embedded UPDATE 2020-11-30 20:46:36 +00:00
Andrea Boriero cb04aa1e5d HHH-14251 Add test for issue 2020-11-30 20:46:31 +00:00
Michael Edgar 12b284cfcf HHH-14346 Check declaredPluralAttributes for null before access 2020-11-30 20:38:27 +00:00
nicklas.wallgren c215601025 HHH-14350 MariaDB103Dialect requires the lock wait timeout to be expressed in seconds 2020-11-30 20:37:26 +00:00
Christian Beikov 8728cc32a1 HHH-14343 Fix quoting of column names when globally quoted identifiers is active 2020-11-30 18:35:50 +00:00
info@kawoolutions.com a917fc1798 HHH-14343 Test case for issue 2020-11-30 18:35:42 +00:00
Christian Beikov 41f44ad2a1 Restore collectionsInDefaultFetchGroupEnabled usage in LazyAttributesMetadata 2020-11-30 17:24:05 +00:00
Christian Beikov 7dd49e425e HHH-14348 Special handling in bytecode enhancement for lazy PersistentCollection fields 2020-11-30 17:23:58 +00:00
Yanming Zhou 34151a9660 HHH-14334 Make dom4j jaxb-api optional as possible
dependency dom4j and jaxb-api is optional if xml mapping disabled
continuation of HHH-13204
2020-11-20 16:41:50 +00:00
Christian Beikov de0f141b4f HHH-14335 Remember the resolved type in SimpleValue#getType instead of resolving multiple times 2020-11-20 10:03:56 +00:00
Sanne Grinovero 33123d267f HHH-14333 Pessimistic Lock causes FOR UPDATE on outer join statements 2020-11-17 18:51:32 +00:00
Sanne Grinovero 84e37c15eb HHH-14332 Make it easier for Quarkus SPI to avoid loading XML related resources 2020-11-17 18:01:31 +00:00
Sanne Grinovero da8706e5eb HHH-14329 Amend existing DirtyTrackingTest 2020-11-17 16:20:55 +00:00
Christian Beikov 2669848ca4 HHH-14329 consider mutable types always as potentially dirty when using DirtinessTracker 2020-11-17 16:20:48 +00:00
Christian Beikov 5ea0d92c37 HHH-14329 test case showing that DirtinessTracker usage for enhanced entities doesn't respect mutable types 2020-11-17 16:20:43 +00:00
Steve Ebersole c444d5f9e5 HHH-14325 - Add Query hint for specifying "query spaces" for native queries 2020-11-16 17:10:43 +00:00
Steve Ebersole 49ae7bdff0 HHH-14325 - Add Query hint for specifying "query spaces" for native queries 2020-11-16 17:10:30 +00:00
Sanne Grinovero fe2230f813 HHH-14276 Amend style and formatting 2020-11-16 12:21:37 +00:00
Christian Beikov a8fdb4d2d5 HHH-14276 Avoid quoting column name for looking up references during composite identifier second pass 2020-11-16 12:21:31 +00:00
info@kawoolutions.com 44ca255b50 HHH-14276 test case for strange AnnotationException: MapsId in IdClass context 2020-11-16 12:21:25 +00:00
Christian Beikov 9997eb1b1a HHH-14322 Fix HBM many-to-one property ref support 2020-11-16 10:12:52 +00:00
Andrea Boriero 9081a1119e HHH-14257 Add test for issue 2020-11-16 09:27:31 +00:00
Andrea Boriero 21c048bc22 HHH-14257 An Entity A with a map collection having as index an Embeddable with a an association to the Entity A fails with a NPE 2020-11-16 09:27:24 +00:00
Andrea Boriero 36ebf7d383 HHH-14225 CVE-2020-25638 Potential for SQL injection on use_sql_comments logging enabled 2020-11-13 13:30:03 +00:00
Steve Ebersole 61dcb7dcd4 HHH-14312 - entity graph is ignored for 'padded' and 'dynamic' batch style entity loader
- Adjusted multi-loading to use LoadPlans (and apply entity-graphs) as well.
- All of the loaders/builder in `org.hibernate.loader.entity` are now no longer used, superseded by `org.hibernate.loader.entity.plan`.  Removed no longer needed code.
- Adjusted multi-load tests that relied on the actual generated SQL *String* - they now explicitly count the number of parameters and use that for assertions
2020-11-11 16:57:25 +00:00
Steve Ebersole 48527437ef HHH-14312 - entity graph is ignored for 'padded' and 'dynamic' batch style entity loader
- completed fix for HHH-11970
2020-11-11 15:30:36 +00:00
Steve Ebersole 603a393b4e HHH-14312 - entity graph is ignored for 'padded' and 'dynamic' batch style entity loader 2020-11-11 15:30:30 +00:00
Nathan Xu fc04e0a320 HHH-14312 fix issue entity graph is ignored for 'padded' batch style entity loader 2020-11-11 15:30:25 +00:00
Andrea Boriero df2bbd75dc HHH-13310 getParameterValue() not working for collections 2020-11-10 19:03:16 +00:00
Andrea Boriero 21b65718ff HHH-13310 Add test for issue 2020-11-10 19:03:07 +00:00
Guillaume Smet 358fc58dc1 HHH-14316 Avoid accessing state in DriverManagerConnectionProviderImpl if null 2020-11-09 15:15:57 +00:00
Christian Beikov f4633d83af HHH-14279 Fix join ordering issue that happens for entity key joins when using a WITH/ON clause 2020-11-03 11:58:28 +01:00
Laurent Almeras aae54bc4a8 HHH-14279 Testcase showing key join order is messed up 2020-11-03 11:58:21 +01:00
Sanne Grinovero 7b8092f6a6 Make new EntityLoader buildling methods in AbstractEntityPersister protected for Hibernate Reactive 2020-11-01 22:38:55 +00:00
Sanne Grinovero 7f4373f7b9 HHH-14305 Memory optimisations for ReaderCollector implementations 2020-11-01 22:00:51 +00:00