Commit Graph

6143 Commits

Author SHA1 Message Date
Davide D'Alto 88a712bab7 HHH-14024 Fix NativeSQLQueryPlanEqualsTest compilation error 2020-05-18 12:53:12 +01:00
gavinking 92b559abda HHH-14024 add QueryPlanCreator functional interface
simplifies customization of HQLQueryPlan instantiation
2020-05-18 06:47:34 -05:00
Davide D'Alto 4a7f9ec0d6 HHH-14026 Change scope to protected for SessionImple#verifyImmutableEntityUpdate 2020-05-18 06:47:34 -05:00
Davide D'Alto 9fd9c0533d HHH-14025 Add method to return the query statements for update queries 2020-05-18 06:47:34 -05:00
Davide D'Alto 42acc81067 HHH-14028 Change scope of various private methods to protected
So that Hibernate Reactive can reuse them.
2020-05-18 06:47:34 -05:00
Davide D'Alto 0633559f9f HHH-14024 Allow the creation of a different QueryPlanCache 2020-05-18 06:47:34 -05:00
Davide D'Alto d914c8aabc HHH-14027 Allow the creation of a different QueryLoader 2020-05-18 06:47:34 -05:00
Davide D'Alto 5968044118 HHH-14024 Allow the creation of a different QueryPlan 2020-05-18 06:47:34 -05:00
Andrea Boriero ee740d82fd Fix compilation error after merging master 2020-05-14 10:14:43 +01:00
Andrea Boriero 257e479e92 Merge remote-tracking branch 'upstream/master' into wip/6.0_merge_39 2020-05-14 10:00:59 +01:00
Sanne Grinovero e23dad19ca HHH-14019 Adding some comments to the new SPI 2020-05-13 22:29:41 +01:00
gavinking 137c524a14 HHH-14019 Allow customizing the Database target in the Schema Management tool
Add an API allowing Hibernate Reactive to plug in to schema export:
we've decided that HR should not use JDBC for schema export
2020-05-13 22:25:25 +01:00
Sanne Grinovero cb4909a5e1 HHH-14004 Attempt to load from 2LC when initializing an Enhanced Proxy 2020-05-13 21:33:01 +01:00
Sanne Grinovero 947dda618e HHH-14004 Test for Cacheable Enhanced Proxies 2020-05-13 21:33:01 +01:00
Steve Ebersole ab71b369b6 Removed no-longer relevant code comment 2020-05-12 21:16:33 -05:00
Nathan Xu fa6acf4e50 fix an obvious bug in SqmSelectClause 2020-05-12 21:16:33 -05:00
Andrea Boriero 0e1713a3a0 HHH-13936 Add additional test 2020-05-12 10:55:39 +01:00
Jonathan Bregler fa4ead1baa HHH-13996: Update documentation for HANA Cloud 2020-05-11 22:39:04 +01:00
Yoann Rodière 1a28fd419e HHH-14006 Test extended bytecode enhancement for mapped superclasses and entity superclasses 2020-05-11 22:15:14 +01:00
Yoann Rodière 5c5b347614 HHH-14006 Take inherited fields into account in extended bytecode enhancement 2020-05-11 22:15:14 +01:00
Sanne Grinovero bc12eee661 Revert "HHH-13950 Update to Bean Validation 3 preview: Hibernate Validator 7.0.0.Alpha1"
This reverts commit b9a24f458c.
2020-05-11 18:00:20 +01:00
Sanne Grinovero 6dd7d09ba0 Revert "HHH-13950 Apply the mass replace script to switch to Jakarta Validation API"
This reverts commit 60abc8aa76.
2020-05-11 18:00:07 +01:00
michiel.hendriks 585ca8e2bf HHH-13936 Call pulseTransactionCoordinator before checking for transaction in flush() 2020-05-11 16:01:43 +01:00
Nathan Xu 5c11778032 replace 'AtomicInteger' with 'MutableInteger' in single thread scenario 2020-05-10 17:48:06 -04:00
Andrea Boriero 72bf70f013 Fix issue with Column size detection causing errors during schema generation 2020-05-07 14:32:34 +01:00
Andrea Boriero 4e6011d093 Fix EntityInitializer double registration 2020-05-07 13:34:27 +01:00
Andrea Boriero 35a4c42347 Fix merge compilation errors 2020-05-05 10:58:42 +01:00
Andrea Boriero 5d572cc876 Merge remote-tracking branch 'upstream/master' into wip/6.0_merge_37 2020-05-05 09:21:34 +01:00
Steve Ebersole e38a4de536 Verified and fixed BasicValue resolutions based on type-defs and UserTypes 2020-05-01 11:29:44 -05:00
Sanne Grinovero 2c12ca401d HHH-13995 Remove dead code from StandardBasicTypes 2020-04-30 19:20:23 +01:00
Sanne Grinovero 922ec04422 HHH-13994 Bootstrap analysis: avoid initializing unused JtaPlatform classes 2020-04-30 19:20:23 +01:00
Sanne Grinovero 49405effce HHH-13993 Bootstrap analysis: avoid initializing many Dialect classes 2020-04-30 19:20:22 +01:00
Steve Ebersole 41093ae66c * Added JpaCompliance for @OrderBy handling
* Added `NonTransientException` checked during MappingModelCreationProcess "post init callback" handling to indicate non-recoverable errors
* Redesigned `MappingModelCreationProcess#executePostInitCallbacks` to account for `NonTransientException`
2020-04-30 09:13:37 -05:00
Sanne Grinovero 41cd5ab359 HHH-13976 Some javadoc clarifications and code style adjustments 2020-04-30 14:43:33 +01:00
barreiro 4d0bd0f080 HHH-13976 Introduce BEFORE_TRANSACTION_COMPLETION release mode 2020-04-30 14:43:27 +01:00
Steve Ebersole 0bfef60c25 tests for `@AssociationOverride` 2020-04-29 14:50:43 -05:00
Steve Ebersole 4755e19964 * Verified / implemented query-result cache support - improved fetch test checks 2020-04-29 13:19:45 -05:00
Steve Ebersole 1f1f5f118b * Verified named "result mapping" support - e.g. JPA's `@SqlResultMapping`; gets stored correctly, but can't test it getting applied correctly until after native-query support is implemented
* Verified / implemented query-result cache support
2020-04-29 13:12:45 -05:00
Andrea Boriero 250160d923 HHH-13986 Fix test failure on MariaDB 2020-04-29 11:12:35 +01:00
Andrea Boriero ac4af03ea3 Fix checkstyle error 2020-04-29 08:11:22 +01:00
Andrea Boriero 859ffb608a HHH-13986 SequenceHiLoGeneratorNoIncrementTest is not testing the right Optimiser 2020-04-28 17:48:28 +01:00
Steve Ebersole 75bfc096ef Verified `@NamedQuery` support 2020-04-28 11:23:24 -05:00
Steve Ebersole 933788789d * enable additional HBM tests
* fixed minor bug
* re-organized tests related to mapping assertions
2020-04-28 10:50:09 -05:00
Steve Ebersole 1aab2219ce * enable additional HBM tests
* fixed minor bug
* re-organized tests related to mapping assertions
2020-04-28 10:48:21 -05:00
Steve Ebersole 96f4a350e0 * HBM mappings
* dynamic models
* initial non-aggregated cid support
2020-04-27 15:21:09 -05:00
Nathan Xu 9ef62f1fb8 implement @where and @whereJoinTable 2020-04-24 13:23:37 -05:00
Nathan Xu f919358e0c make use of Collections.addAll() for better performance 2020-04-24 13:22:53 -05:00
Andrea Boriero 72f8c079e9 Revert "HHH-13950 Update to Bean Validation 3 preview: Hibernate Validator 7.0.0.Alpha1"
This reverts commit b9a24f458c.
2020-04-24 13:56:53 +01:00
Andrea Boriero 3bc33221f0 Revert "HHH-13950 Apply the mass replace script to switch to Jakarta Validation API"
This reverts commit 60abc8aa76.
2020-04-24 13:26:37 +01:00
gavinking 01d3485970 Add rollup() and cube() for group by clause
This syntax is supported on at least DB2, Oracle, SQL Server, and
Postgres. It's not supported on MySQL.
2020-04-22 15:09:05 -05:00
Steve Ebersole 08bf2bb906 HHH-13890 : Add support for custom EventType and listeners - EventEngine 2020-04-22 13:26:22 -05:00
Andrea Boriero 9ec19e3c65 Merge remote-tracking branch 'upstream/master' into wip/6.0_merge_36 2020-04-22 15:15:10 +01:00
Steve Ebersole 5d9c25c318 `@JavaTypeRegistration` and `@SqlTypeRegistration` support 2020-04-21 18:58:47 -05:00
Nathan Xu 686a519680 implement @Filter for HQL/Criteria 2020-04-21 17:08:19 -05:00
Steve Ebersole 709e7d49b7 minor fix-up 2020-04-21 16:50:04 -05:00
Steve Ebersole afff2d0cfe minor fix-up 2020-04-21 16:46:05 -05:00
Andrea Boriero 8d026b05d2 Fix extra query executed for Embedded fk when embeddable has a lazy ToOne association 2020-04-21 16:46:05 -05:00
Andrea Boriero 99778fd9a1 Composite Foreign Key for EmbeddedId removed unnecessary join for Embeddable with ManyToOne 2020-04-21 16:46:05 -05:00
Andrea Boriero e5a2b582fe Removed ForeignKeyDescriptor direction attribute 2020-04-21 16:46:05 -05:00
Andrea Boriero 7f4c25095e Implement Composite Foreign Key for EmbeddedId 2020-04-21 16:44:03 -05:00
Gail Badner 903bb292e7 HHH-13916 : Add a unique Session "token" 2020-04-21 16:26:40 -05:00
Nathan Xu 7bca059f94 replace '\n' with platform specific char in both SqmTreePrinter and SqlTreePrinter 2020-04-21 16:24:52 -05:00
Nathan Xu 23719ff481 implement readonly loader feature 2020-04-21 16:23:39 -05:00
Steve Ebersole ced4f5e602 Various changes around how basic values are handled in terms of mapping consumption for annotations and how value conversions happen
* Split BasicType "resolution" into 2 - one used for reading (mapping model) versus one used from writing (legacy persister model)
* @SqlTypeCode, @SqlType, @SqlTypeRegistration
* @JavaType, @JavaTypeRegistration
* @Mutability
* jdbc_mappings.adoc section for DomainModel chapter

[*] At the moment, neither @SqlTypeRegistration nor @JavaTypeRegistration support has been implemented
[*] Still need to make sure @Mutability is propogated properly in all the cases
[*] jdbc_mappings.adoc still needs a lot of attention
2020-04-21 16:09:46 -05:00
Panagiotis Sotiropoulos 55e54795c3 HHH-13960 Add SAXReader sec features to match the defaults 2020-04-21 10:49:59 +01:00
Nathan Xu 52a101291d fix a RE sloppiness in IndexQueryHintHandler 2020-04-20 13:29:59 -05:00
gavinking 5e53f2130e Also fix spelling error in method name
Caught by @NathanQingyangXu
2020-04-20 13:11:43 -05:00
gavinking d3d92f9a95 Use lambda syntax to instantiate SQLExceptionConversionDelegates
Especially remove the amazingly verbose CacheSQLExceptionConversionDelegate
2020-04-20 13:11:42 -05:00
gavinking 5fc35980fd Clean up ViolatedConstraintNameExtract-o-rs
- Fix the spelling error in the name of this hierarchy
- Use delegation to an anonymous function instead of overriding in
  TemplateViolatedConstraintNameExtractor
2020-04-20 13:06:00 -05:00
Andrea Boriero 56873732b7 Fix errors after merge 2020-04-20 14:10:07 +01:00
Andrea Boriero 88d65adafb Merge remote-tracking branch 'upstream/master' into wip/6.0_merge_35 2020-04-20 13:44:39 +01:00
Andrea Boriero 0a5ae91c08 fix errors after merge 2020-04-20 12:37:33 +01:00
Andrea Boriero a0b4566264 Merge remote-tracking branch 'upstream/master' into wip/6.0_merge_34 2020-04-20 12:17:22 +01:00
Sanne Grinovero 60abc8aa76 HHH-13950 Apply the mass replace script to switch to Jakarta Validation API
For reference, this is the script being applied:
find . -type f -name '*\..java' -o -name '*.\.adoc' -o -name '*.\.gradle' | xargs sed -i 's/javax\.validation/jakarta\.validation/g'
2020-04-20 12:16:36 +01:00
Sanne Grinovero b9a24f458c HHH-13950 Update to Bean Validation 3 preview: Hibernate Validator 7.0.0.Alpha1
We apply the update int two steps:
 - some hand-rolled changes, such as switching the dependency to the new Hibernate Validator preview build
 - running a replace-all scripts

This individual commit represents the first set of changes.
When porting this change to a different branch, this one should be cherry picked while the second change
is better ported by running the same script once again.
2020-04-20 12:14:24 +01:00
Andrea Boriero 32e4a16623 Fix merge issues 2020-04-17 15:03:19 +01:00
Andrea Boriero 7ced01d303 Merge remote-tracking branch 'upstream/master' into wip/6.0_merge_32 2020-04-17 14:39:36 +01:00
Sanne Grinovero 3f2a4947a7 HHH-13952 Remove dependency to Arquillian as its no longer used 2020-04-17 14:27:19 +01:00
Sanne Grinovero 1aa2e858ba HHH-13952 Remove all WildFly based integration tests 2020-04-17 14:27:19 +01:00
Sanne Grinovero 2b279c6a83 HHH-13952 Remove our ability to build the Wildfly feature pack and run integration tests on WildFly 2020-04-17 14:27:19 +01:00
Jonathan Bregler 95c9526dda HHH-13917: Add support for HANA Cloud 2020-04-17 13:30:38 +01:00
Andrea Boriero 9547c9ca09 Merge remote-tracking branch 'upstream/master' into wip/6.0_merge_31 2020-04-17 07:53:00 +01:00
Gail Badner 4741fa4f33 HHH-11903 : @OneToOne Derived ID is null when returned by query when bidirectional 2020-04-16 14:29:58 -07:00
Steve Ebersole 2ddf58907e HHH-13948 - EnhancedSetterImpl should define writeReplace 2020-04-16 14:48:07 +01:00
Gail Badner 2a4c10a663 HHH-13890 Add support for custom event types and listeners 2020-04-16 14:12:44 +01:00
Andrea Boriero 132a4121b5 Fix issues after merging master 2020-04-16 11:46:19 +01:00
Andrea Boriero 2ccf7fab9e Merge remote-tracking branch 'upstream/master' into wip/6.0_merge_30 2020-04-16 11:03:49 +01:00
Andrea Boriero 299826b9b7 HHH-13937 Get rid of junit5 compile-time dependencies 2020-04-14 14:23:29 +01:00
Yoann Rodière 1060baf74b HHH-13682 Enable extended bytecode enhancement in NaturalIdInUninitializedAssociationTest
This test accesses a field of an entity directly and expects it to be
automatically initialized; this cannot work without extended bytecode
enhancement.

This used to work with Java 8 bytecode, but only by chance. It seems
that Java 8 bytecode relies on "synthetic", static access methods
inserted by the compiler to access the fields of entities in this test:
any access to the field is done through this access method instead of
through a direct field access. Since we apply bytecode enhancement to
all methods of entities, this means that access to fields triggers
initialization, without any bytecode enhancement in the caller class.

I believe this is specific to nested classes, but couldn't find a
source. For reference, the bytecode of access methods looks like this:

  static int access$002(org.hibernate.test.bytecode.enhancement.lazy.NaturalIdInUninitializedAssociationTest$AnEntity, int);
    Code:
       0: aload_0
       1: iload_1
       2: dup_x1
       3: putfield      #3                  // Field id:I
       6: ireturn

  static org.hibernate.test.bytecode.enhancement.lazy.NaturalIdInUninitializedAssociationTest$EntityImmutableNaturalId access$102(org.hibernate.test.bytecode.enhancement.lazy.NaturalIdInUninitializedAssociationTest$AnEntity, org.hibernate.test.bytecode.enhancement.lazy.NaturalIdInUninitializedAssociationTest$EntityImmutableNaturalId);
    Code:
       0: aload_0
       1: aload_1
       2: dup_x1
       3: putfield      #2                  // Field entityImmutableNaturalId:Lorg/hibernate/test/bytecode/enhancement/lazy/NaturalIdInUninitializedAssociationTest$EntityImmutableNaturalId;
       6: areturn

With Java 11, however, access to fields of entities is done directly,
even for nested classes. So the access methods no longer exist, and we
don't get automatic initialization upon field access. We need extended
bytecode enhancement, like we would in any other case of field access
(in particular accessing fields of non-nested classes).
2020-04-14 13:36:43 +01:00
Nathan Xu 34d5a2ae7a implement @Filter for loader 2020-04-14 10:54:05 +01:00
Nathan Xu 7e571cc75c fix some obvious logging bugs 2020-04-14 10:35:51 +01:00
Nathan Xu a91383a226 revert back v5 implementation of fetch entity graph 2020-04-14 10:22:55 +01:00
Nathan Xu 11c5a1019f renaming and some legacy code fixing 2020-04-14 10:22:55 +01:00
Andrea Boriero 5d1aea1897 Fix merge checkstyle and compilation errors 2020-04-09 11:07:00 +01:00
Andrea Boriero 5c86c4a805 Merge remote-tracking branch 'upstream/master' into wip/6.0_merge_29 2020-04-09 07:37:11 +01:00
Andrea Boriero b897a36f2f Fix issue with generated pom missing project description 2020-04-06 18:21:11 +01:00
Sanne Grinovero 6ea9844874 HHH-13935 Allow subclasses of StandardServiceRegistryBuilder to initialize a custom list of StandardServiceInitiator(s) 2020-04-06 16:10:44 +01:00
Yoann Rodière bee15c498f HHH-13925 Fix malformed @author tags in javadoc
You're not supposed to use unescaped "<" or ">".

This wasn't detected by checkstyle in Gradle 5, but it is now, and that
fails the build.
2020-04-06 16:04:55 +02:00
Yoann Rodière aebf9d192f HHH-13925 Fix invalid javadoc syntax
This wasn't detected by checkstyle in Gradle 5, but it is now, and that
fails the build.
2020-04-06 16:04:55 +02:00
Sanne Grinovero e1aa8714c0 HHH-13930 Minor formatting improvements and comments 2020-04-05 23:07:39 +01:00
Stuart Douglas 0955394c82 HHH-13930 Allow for creation of unloaded proxies in ByteBuddyProxyHelper 2020-04-05 23:07:22 +01:00
Sanne Grinovero a975d0de19 HHH-13929 Add test coverage using PersistenceUtilHelper within exising test for Enhanced Proxies 2020-04-05 22:26:34 +01:00
Sanne Grinovero 2ac0d2ee91 HHH-13929 Improve the PersistenceUtilHelper to allow dealing with Enhanced Proxies 2020-04-05 22:26:31 +01:00
Steve Ebersole 40d0c8580e Merge remote-tracking branch 'upstream/master' into wip/6.0
- up to the point of upgrading Gradle version for wrapper to 5.6.3
2020-04-01 11:32:00 -05:00
Yoann Rodière 2f32169249 HHH-13689 Replace uses of the deprecated osgi plugin with the biz.aQute.bnd plugin
https://docs.gradle.org/5.0-milestone-1/release-notes.html#deprecated-osgi-plugin
2020-04-01 10:54:56 -05:00
Yoann Rodière cee0fce043 HHH-13685 Replace uses of deprecated classifier property in Jar tasks with archiveClassifier 2020-04-01 09:53:13 -05:00
Andrea Boriero 2f98e4bfe8 Fix ToOne @Fetch(FetchMode.SELECT) 2020-04-01 14:44:25 +01:00
Nathan Xu 5f83662226 HHH-13889 fix the issue that inline string literal in Criteria is not escaped 2020-04-01 13:29:55 +01:00
Andrea Boriero 8971843626 Fix compilation errors after merge 2020-04-01 11:01:37 +01:00
Andrea Boriero 2c127bdbe3 Merge remote-tracking branch 'upstream/master' into wip/6.0_merge_27 2020-04-01 10:40:03 +01:00
Steve Ebersole 00beab3ba9 Support for SQL script (import.sql) handling as part of schema tooling 2020-03-31 13:50:04 -05:00
Gail Badner e1d2aecef7 HHH-13910 : MySQL57Dialect selected by automatic dialect resolution when using MySQL 8.0 database 2020-03-26 21:02:44 -07:00
Gail Badner caded6cd40 HHH-13910 : Added and corrected tests 2020-03-26 20:59:55 -07:00
Gail Badner a54d657d98 HHH-13891 : ProxyFactory should not be built if any ID or property getter/setter methods are final 2020-03-25 18:36:05 -07:00
Gail Badner 3427bc8414 HHH-13891 : Added test 2020-03-25 18:36:05 -07:00
Steve Ebersole eae3a4a0a6 fix issue with Criteria queries not defining selections explicitly. should use the (single) root as the selection. 2020-03-23 08:28:56 -05:00
Andrea Boriero ade760d71a Fix compilation errors after merge 2020-03-20 11:07:21 +00:00
Andrea Boriero 3476e82122 Merge remote-tracking branch 'upstream/master' into wip/6.0_merge_26 2020-03-20 08:01:20 +00:00
Nathan Xu 7e2987ac79 HHH-13877 - Make @SortNatural by default 2020-03-19 14:41:05 -05:00
Nathan Xu cf46163958 Fix a subtle double-checked locking issue 2020-03-19 14:02:50 -05:00
Nathan Xu df0aa1eb2e Fix a subtle double-checked locking issue 2020-03-19 14:02:50 -05:00
romainmoreau b5443deab3 Drop constraints using CASCADE
Co-Authored-By: William Cekan <wcekan@oath.com>
2020-03-19 13:58:26 -05:00
Romain Moreau b35ccc8e37 HHH-13711: drop constraints enabled for H2 2020-03-19 13:58:26 -05:00
Nathan Xu 620dcc62c0 HHH-13756 renaming and internal implementation tweaking 2020-03-19 13:27:09 -05:00
Nathan Xu 12c272a9cd make use of JUnit5's ParameterizedTest to avoid some testing code duplication 2020-03-19 13:27:09 -05:00
Nathan Xu a9c2ea3a46 add 'Criteria' testing 2020-03-19 13:27:09 -05:00
Nathan Xu e2ddd800ac finish both 'loader' and 'HQL' testing 2020-03-19 13:27:09 -05:00
Nathan Xu a3dce5f00a HHH-13756 simplify EntityGraphNavigator's navigate() to never return null value 2020-03-19 13:27:09 -05:00
Nathan Xu d4746da853 HHH-13756 fix some bug in EmbeddableFetchImpl 2020-03-19 13:27:09 -05:00
Nathan Xu 979e146f55 HHH-13756 enrich hql testing class 2020-03-19 13:27:09 -05:00
Nathan Xu 3b9c1cd777 HHH-13756 add a hql testing skeleton 2020-03-19 13:27:09 -05:00
Nathan Xu 94b8d8a128 HHH-13756 rename 'NavigateResult' class name to 'Navigation' 2020-03-19 13:27:09 -05:00
Nathan Xu 335c1ecd75 HHH-13756 implement entity graph in v6 2020-03-19 13:27:09 -05:00
Nathan Xu 62e9a674ad fix bug that newly created 'tableGroupJoin' is not added to its 'joinedGroup' 2020-03-19 13:17:02 -05:00
Nathan Xu 70b6de476c implement ResourceRegistryStandardImpl#convert to get rid of 'todo' 2020-03-19 13:12:47 -05:00
Nathan Xu adc87b7908 various cosmetic code improvements 2020-03-19 13:12:12 -05:00
Steve Ebersole b3254a2fa6 SQM 'insert select', 'insert values', and 'update' queries 2020-03-19 13:01:49 -05:00
gavinking 02cd346d3f add additional HQL bulk tests
- failing test for secondary table update
- failing test for embeddable update
- passing test for secondary table delete
2020-03-19 13:01:49 -05:00
gavinking e90207e651 remove unused class 2020-03-19 13:01:49 -05:00
gavinking c787dae475 Minor cleanups to SqlAstTranslators
- rename SqlAstInsertSelectTranslator to SqlAstInsertTranslator
- use simplified for loops
2020-03-19 13:01:49 -05:00
gavinking 0381da76b9 Test for insert values 2020-03-19 13:01:49 -05:00
gavinking 95ff568b3d Add support for HQL 'insert ... values ...' 2020-03-19 13:01:49 -05:00
gavinking 10f333943d tests for HQL insert/update 2020-03-19 13:01:48 -05:00
gavinking 5f2745a503 HQL 'insert ... select' and 'update'
- fill in the implementation of HQL insert ... select
- clean up grammar for HQL insert/delete/update
- fix syntax for 'set' clause of HQL update
- fix translation of set value expression in HQL update
- tentative fix for attribute resolution with repeated entities
2020-03-19 13:01:48 -05:00
gavinking 375076df35 Remove unnecessary parens in grammar 2020-03-19 13:01:48 -05:00
Yoann Rodière 3f95c2eadb HHH-7318 Test auto-discovery of result types in native queries 2020-03-19 08:55:42 -05:00
Yoann Rodière 62a14972bc HHH-7318 Fix native queries incorrectly converting BIGINT results to BigInteger
Also fix existing tests with wrong expectations:

* TupleNativeQueryTest: there is no reason to expect a BigInteger in
results, since the ID of entity Users if of type Long.
* MultiLineImportFileTest: there is no reason to expect "COUNT(*)" to
return a BigInteger, since the SQL type of COUNT(*) is bigint, which
corresponds to Long in Java.
2020-03-19 08:55:42 -05:00
Sanne Grinovero 486addab0c HHH-13897 ResultSetProcessingContextImpl: no need to clear collections before discarding the reference to them 2020-03-19 11:51:59 +00:00
Andrea Boriero 6462218587 Implemented SelectEagerCollectionInitializer 2020-03-18 14:09:54 +00:00
Andrea Boriero 2fa3889e5a Add one more test for empty collections 2020-03-18 14:09:54 +00:00
Andrea Boriero 6eb729003a Fix initialization of empty collections 2020-03-18 14:09:54 +00:00
Nathan Xu db50e046e2 revert back changes in 'org.hibernate.test.cascade' 2020-03-18 08:17:41 -05:00
Nathan Xu 30bfe89246 verify 'column quoting' 2020-03-16 07:52:15 -05:00
Andrea Boriero 5999d80701 Fix wrong tableExpression and columnExpression value assignment for ColumnConsumer#accept method 2020-03-13 14:17:12 +00:00
Gail Badner 8c6f8025e3 HHH-13619 - Support for JPA's `size` function as a select expression
- Fix to work on Oracle by removing "as" between table name and alias
2020-03-12 14:42:11 -07:00
Andrea Boriero d88d4a8d7b Re-enabled hibernate-orm-modules 2020-03-12 14:43:16 +00:00
Nathan Xu 7ee45f68ee wrap up verification for both @SortedSet and @SortedMap 2020-03-09 13:48:46 -05:00
Andrea Boriero cce8f823e7 Fix issue with empty array collection 2020-03-09 18:45:31 +00:00
Andrea Boriero 1dbda278f9 Add test 2020-03-09 18:45:31 +00:00
Andrea Boriero 956da855cd EntityFetchDelayedInitializer check if a Proxy already exists before creating a new one 2020-03-09 18:45:31 +00:00
Andrea Boriero a96096bc28 Move more tests to o.h.orm.test 2020-03-09 18:45:31 +00:00
Andrea Boriero 28f4d62f6a Fix checkstyle errors 2020-03-09 18:45:31 +00:00
Andrea Boriero 37292c5876 Fix issue with circular fetch detection 2020-03-09 18:45:31 +00:00
Andrea Boriero 52b126d4cf Fix issue with SimpleForeignKeyDescriptor DomainResult creation 2020-03-09 18:45:31 +00:00
Andrea Boriero 681c3fa9cf Fix issue with collection initializer for test OneToManyAutoReferenceTest#testSelectParentFetchChildren 2020-03-09 18:45:31 +00:00
Andrea Boriero 2e285f891d Fix issue with SimpleForeignKeyDescriptor#generateJoinPredicate() using wrong columns 2020-03-09 18:45:31 +00:00
Andrea Boriero 1fea05742c Fix initialization of empty collections 2020-03-09 18:45:31 +00:00
Andrea Boriero 3a9c578a14 Add test 2020-03-09 18:45:31 +00:00
Andrea Boriero 94f23dd2d5 EntityInitializer and DelayedCollectoinAssembler see if we have an existing entry in the PC for the EntityKey 2020-03-09 18:45:31 +00:00
Andrea Boriero e61f610e32 EntityFetchDelayedInitializer check if the entity instance has been already loaded 2020-03-09 18:45:31 +00:00
Andrea Boriero 587a2b0e35 Fix NPE when a fetched association is null 2020-03-09 18:45:31 +00:00
Andrea Boriero 90cd4e5c8f fix issue with circularity detection 2020-03-09 18:45:31 +00:00
Andrea Boriero 1df4824d5f Move more tests to o.h.orm.test 2020-03-09 18:45:31 +00:00
gavinking 2dd745110d Add SqlSelection.getExpressionType() and remove some typecasts 2020-03-09 13:40:37 -05:00
gavinking a1a85e2517 Fixes for subqueries in HQL select clause
Allow subqueries to occur in the select list, and allow their aliases to occur
in the order by clause.
2020-03-09 13:40:37 -05:00
gavinking 76000201eb Support HQL 'any'/'some', 'every'/'all', and 'exists' subquery operators
- 'exists' and 'not exists' are predicates
- 'any'/'some' are expression used on RHS of comparison operators, but
  note that they also collide with the HQL aggregate functions of the
  same name
2020-03-09 13:40:37 -05:00
Andrea Boriero e0ffa498b1 Add one more test 2020-03-09 18:23:44 +00:00
Andrea Boriero b5080b555f Fix issue initializing an Entity with an array collection 2020-03-09 18:23:44 +00:00
Andrea Boriero a7ecba4f5b Remove @FailureExpected from ArrayTests 2020-03-09 18:23:44 +00:00
Koen Aers 23f2cc584b Verify array support: add 'EntityOfArrays' case to the GambitDomainModel and the PluralAttributeMappingTests
Signed-off-by: Koen Aers <koen.aers@gmail.com>
2020-03-09 18:23:44 +00:00
Koen Aers 86fa0d5fed Verify array support: Make PluralAttributeBuilder also recognize array types
Signed-off-by: Koen Aers <koen.aers@gmail.com>
2020-03-09 18:23:44 +00:00
Koen Aers 9d9a240917 Verify array support: Add a basic test fixture
Signed-off-by: Koen Aers <koen.aers@gmail.com>
2020-03-09 18:23:44 +00:00
Nathan Xu 38effc6191 fix HashMap constructor with expected size usage error 2020-03-09 12:47:29 -05:00
Steve Ebersole 26ab3c5362 HHH-13619 - Support for JPA's `size` function as a select expression
- PR revisions
2020-03-05 09:58:35 -06:00
Steve Ebersole 336c3b9e30 HHH-13619 - Support for JPA's `size` function as a select expression
- code cleanup
2020-03-04 12:37:37 -06:00
Steve Ebersole 692f19c83f HHH-13619 - Support for JPA's `size` function as a select expression
- initial support
2020-03-04 12:37:37 -06:00
Gail Badner 24cedfa6ec HHH-13619 : test cases 2020-03-04 12:36:24 -06:00
Andrea Boriero abe1e656f7 Merge remote-tracking branch 'upstream/master' into wip/6.0 2020-03-03 16:59:30 +00:00
Andrea Boriero 5bf772c59d HHH-13322 Fix test 2020-03-02 11:48:54 +00:00
Nathan Xu 188c05cc33 HHH-13322 Fix Oracle dialect's 'getQuerySequencesString()' issue by limiting to current schema 2020-03-02 10:31:18 +00:00
Nathan Xu c9190e45f8 Remove unused imports 2020-03-02 09:51:44 +00:00
Nathan Xu d8d8d6e112 Fix some obvious log or exception message issues 2020-02-28 08:12:45 +00:00
Nathan Xu 09c33446ff modernize legacy code via JDK7's diamond operator 2020-02-26 10:06:14 +00:00
Sanne Grinovero b856d534cb HHH-13876 Remove unused code from StandardStack 2020-02-26 09:59:23 +00:00
Sanne Grinovero e65ef1354c HHH-13876 Delete the immutable SingletonStack implementation as its no longer used 2020-02-26 09:44:17 +00:00
Sanne Grinovero 90c669108b HHH-13876 Remove method Stack#getPrevious as its unused and contains a bug 2020-02-26 09:42:06 +00:00
Davide D'Alto 4e58006f10 HHH-13878 Make some private methods in Loader protected
This way we can reduce the amount of copy and paste in Hibernate Rx.
2020-02-26 09:35:44 +00:00
Davide D'Alto fe52328ab6 HHH-13878 Remove final from SessionImpl#internalLoad
In Hibernate RX we need to override this method.
2020-02-26 09:35:44 +00:00
Nathan Xu 06a26fe5c6 enrich existing tesing case by SQL inspect 2020-02-26 09:21:39 +00:00
Nathan Xu 5e5bef71e6 verify bidirectional collection circular reference detection 2020-02-26 09:21:39 +00:00
Nathan Xu bb8ceaea1d Fix an obvious bug in AbstractLimitHandler 2020-02-26 09:19:22 +00:00
Vlad Mihalcea c76675f11a Changes according to PR review. Requires rebase! 2020-02-25 11:46:13 -06:00
Vlad Mihalcea c7aaf31cbe HHH-13879 - Slow query log should use System#nanoTime not System#currentTimeMillis 2020-02-25 11:46:13 -06:00
Gail Badner a7261ad053 HHH-13875 : Optional one-to-one does not always join the associated entity table when querying 2020-02-24 12:28:22 -08:00
Gail Badner b060b21851 HHH-13875 : Added test cases 2020-02-24 12:28:22 -08:00
gavinking 3545de74ea fix logic for interpreting HQL literal enum values
Note that this feature still doesn't work because we still
can't get a MappingModelExpressable from an SqmEnumLiteral.
2020-02-22 15:19:31 +01:00
The Geeky Asian b914b02dca HHH-13874 - Removing the @author added.
The newly added @author in the previous commit or deprecation messages has been removed in this commit.
2020-02-21 06:11:37 -06:00
The Geeky Asian e98e89d806 HHH-13874 - Messages added for the deprecated methods. 2020-02-21 06:11:37 -06:00
The Geeky Asian c4bd5937e3 HHH-13874 - Deprecating methods that will be removed soon
Two methods that are dropped in v6.0 are now marked as deprecated in this commit.

As discussed in the removal PR https://github.com/hibernate/hibernate-orm/pull/3229
2020-02-21 06:11:37 -06:00
Nathan Xu e9df1cb626 HHH-13853 fix minor issue 2020-02-21 12:04:12 +00:00
Vlad Mihalcea d9a335c429 HHH-13872 - Make the Java Stream close the underlying ScrollableResultsIterator upon calling a terminal operation 2020-02-21 06:03:42 -06:00
The Geeky Asian e808041477 HHH-13856 - Long-awaited TODOs done as an improvement
1. TODO: Remove duplicate method from ConstraintConstaint.java currently has two duplicate methods. 1. getColumnIterator()2. columnIterator()

Both the methods return the same value i.e. column.iterator().

One of them needs to be removed in order to reduce and clean the duplication. 

2. TODO: Change method name for getXmlFiles in BaseCoreFunctionalTestCaseCurrently, in BaseCoreFunctionalTestCase a method named getXmlFiles()has a TODO placed that suggests the method name to be changed to getOrmXmlFiles().

Since the method has a protected scope, there is a possibility it is being used by other clients. Hence, changing the method name in minor versions might break the code for clients.
2020-02-20 10:54:50 -06:00
w1ida 28b8cebf9d HHH-13873 IdTableHelper can skip opening a connection when there's no statements to execute 2020-02-20 15:15:59 +00:00
Nathan Xu 86a8106696 correct an obvious coding bug 2020-02-20 07:06:43 -06:00
gavinking b1d7bad4ef Move a couple of log messages to ConnectionPoolingLogger
For consistency.
2020-02-20 12:08:07 +01:00
gavinking 78423a8d55 Move Dialect logging to DialectFactoryImpl
As suggested by @Sanne.
2020-02-20 12:06:45 +01:00
Steve Ebersole 285b7d8696 @Version support
- improved design where EntityVersionMapping simply has a (delayed) reference to the version attribute and provides easier access to often used information
2020-02-19 13:56:26 -06:00
Christian Beikov 28b5f493b9 Determine type of self rendering function lazily during type access 2020-02-19 12:13:19 -06:00
Steve Ebersole ab6d1953d6 initial work on @Version support
- by side effect fixed batch collection loading
2020-02-19 12:10:16 -06:00
gavinking 1503f09a41 Log usage of deprecated Dialect classes using DeprecationLogger
We want people to stop using the ones annotated @Deprecated.
2020-02-19 08:57:04 -06:00
Nathan Xu 60ead26c4b Disallow FQN as entity name in Jpa compliance mode 2020-02-19 08:54:36 -06:00
gavinking c97fb45a02 Remove FrontBaseDialect
I can't find evidence that anyone uses this on StackOverflow, and the Dialect
is not of high quality.
2020-02-19 08:48:40 -06:00
gavinking 7267b418c5 Rename SAPDBDialect to MaxDBDialect
(Leaving a stub SAPDBDialect class for backward compatibility.)
2020-02-19 08:35:34 -06:00
Steve Ebersole e43c5a3166 https://github.com/asciidoctor/asciidoclet/pull/91
- work in progress as the PR did not fix the problems
2020-02-19 08:30:57 -06:00
gavinking 5d830ceebf Attempt to reconstruct the fallbackSqmMutationStrategies
This method threw lots of NotImplementedFor6Exceptions, so I've tried
to figure out what the right implementations are, going by what was
there in the other branches. However, I'm not at all sure that I got
everything here right.
2020-02-19 07:07:00 -06:00
Fabio Massimo Ercoli ccc3c58367 HH-13720 Test mapping model support for plural attributes - sorted map 2020-02-19 06:52:38 -06:00
Steve Ebersole 1042f23bee HHH-13103 - Allow Hibernate Types to get access to the current configuration properties using constructor injection 2020-02-18 15:22:05 -06:00
Vlad Mihalcea c346171b23 HHH-13103 - Allow Hibernate Types to get access to the current configuration properties 2020-02-18 15:22:05 -06:00
Vlad Mihalcea 9084ce497e HHH-13853 - Pass the merged Integration settings and Persistence Unit properties to buildBootstrapServiceRegistry 2020-02-18 11:42:51 -06:00
Andrea Boriero 8defa9619e Remove NavigablePath#hashCode field 2020-02-18 16:33:03 +00:00
Andrea Boriero c355ecee08 Fix issue with FromClauseIndex#findFetchedJoinByPath for hql 'from entity1 e1 join fetch e1.entity2 e2 join fetch e2.entity3' not resolving entity3 fetch join during EntityResultImpl creation 2020-02-17 18:07:00 +00:00
Andrea Boriero d77adbfc13 Add FailureExpcted to EmbeddedTest for @Parent annotation 2020-02-17 18:07:00 +00:00
Andrea Boriero 9d7c4f98e3 Fix compilation error after rebase 2020-02-17 18:07:00 +00:00
Andrea Boriero 529726f59a Remove unused import 2020-02-17 18:07:00 +00:00
Andrea Boriero 6cfbed73ba Fix issue with hql and where clause with Embeddable is null 2020-02-17 18:07:00 +00:00
Andrea Boriero efb07506f2 Fix test 2020-02-17 18:07:00 +00:00
Andrea Boriero 7d13abf528 Add test 2020-02-17 18:07:00 +00:00
Andrea Boriero 484589c5b4 Fix BiDirectionalFetchImpl CircularFetchAssembler#assemble for collection initialization 2020-02-17 18:07:00 +00:00
Andrea Boriero 7de3be2492 Fix NPE in SingularAssociationAttributeMapping#resolveCircularFetch(...) method 2020-02-17 18:07:00 +00:00
Andrea Boriero 9633345dbb Fix issue determining fetchablePath and fetchParent for PluralAttributes in LoaderSelectBuilder#createFetchableConsumer() method 2020-02-17 18:07:00 +00:00
Andrea Boriero d34353e2a3 Revert "EntityCollectionPart#generateFetch() add TableGroupJoin to EntityCollectionPartTableGroup"
This reverts commit f5351addb8155bd85fbd38f5b989ef0a260bcf3f.
2020-02-17 18:07:00 +00:00
Andrea Boriero 8c377e9208 Fix issue with @ElementColletion of Embeddables 2020-02-17 18:07:00 +00:00
Andrea Boriero a4330599c2 Fix SingularAssociationAttributeMapping identifyingColumnsTableExpression and inverseIdentifyingColumnsTableExpression values 2020-02-17 18:07:00 +00:00
Andrea Boriero f3b2a1537b Implemented SingularAssociationAttributeMapping circular fetch detection for ToOne with JoinTable 2020-02-17 18:07:00 +00:00
Andrea Boriero 2afd4c8123 Avoid EntityFetchJoinedImpl visiting the EntityIdentifierMapping 2020-02-17 18:07:00 +00:00
Andrea Boriero bd28b54482 EntityCollectionPart#generateFetch() add TableGroupJoin to EntityCollectionPartTableGroup 2020-02-17 18:07:00 +00:00
Andrea Boriero 8c16e7cfe9 Fix issue with AbstractEntityPersister and the creation of the RootTableGroup 2020-02-17 18:07:00 +00:00
Andrea Boriero 16d81eb4bf Refactoring 2020-02-17 18:07:00 +00:00
Steve Ebersole 3222b52ab2 continued work on circular fetch detection. still need to work through the cases involving embeddables "in between" 2020-02-17 18:07:00 +00:00
Steve Ebersole 00b5a700eb continued work on circular fetch detection. still need to work through the cases involving embeddables "in between" 2020-02-17 18:07:00 +00:00