Commit Graph

4867 Commits

Author SHA1 Message Date
Gail Badner 329a1663ec HHH-13307 : Added test
(cherry picked from commit 1241d35a50)
2019-11-06 22:06:00 -08:00
Gail Badner 81f42693dd HHH-13634 : Fix test case queries to order results
(cherry picked from commit 93a07453f0)
2019-11-06 21:51:53 -08:00
Gail Badner 04eba997e2 HHH-13634 : PersistenceContext can get cleared before load completes using StatelessSessionImpl
(cherry picked from commit 42de569a37)
2019-11-06 21:51:53 -08:00
Gail Badner dd92c0f9a8 HHH-13634 : Test cases
(cherry picked from commit eccb786ba4)
2019-11-06 21:51:53 -08:00
Gail Badner f56a5847ec HHH-13633 : Fix test case queries to order results
(cherry picked from commit 81d5f5eb21)
2019-11-06 21:51:53 -08:00
Gail Badner 52ceafaa87 HHH-13633 : Bugs join-fetching a collection when scrolling with a stateless session using enhancement as proxy
Make corrections.
2019-11-06 21:51:53 -08:00
Gail Badner 7121001fd4 HHH-13633 : Add tests including for no HibernateProxy factory 2019-11-06 21:51:53 -08:00
Gail Badner cf0f6a6410 HHH-13640 : Correct DefaultLoadEventListener#proxyOrLoad to work properly enhancement but no HibernateProxy factory 2019-11-06 21:51:53 -08:00
Gail Badner ea5de89f56 HHH-13640 : Add test using custom EntityTuplizer with no HibernateProxy factory using Session 2019-11-06 21:51:53 -08:00
Gail Badner cd0054cec1 HHH-13633 : Bugs join-fetching a collection when scrolling with a stateless session using enhancement as proxy
Minor changes suggested by Andrea.
2019-11-06 21:51:53 -08:00
Gail Badner 9cb4d2f411 HHH-13633 : Bugs join-fetching a collection when scrolling with a stateless session using enhancement as proxy 2019-11-06 21:51:53 -08:00
Gail Badner daae4c9090 HHH-13633 : Added more tests based on renamed original (w/ and w/o bytecode enhancement) 2019-11-06 21:51:53 -08:00
Andrea Boriero 471e64ede0 HHH-13633 : Add test for issue 2019-11-06 21:51:53 -08:00
Gail Badner d3d7705fa6 HHH-13640 : Remove SharedSessionContractImplementor#internalLoad(String, Serializable, boolean, boolean, Boolean unwrapProxy)
(cherry picked from commit e10e84159a)
2019-11-06 21:51:53 -08:00
Gail Badner 7249e4f736 HHH-13640 : Added/modified tests
(cherry picked from commit c21ecb511c)
2019-11-06 21:51:53 -08:00
Gail Badner 45604c53cd HHH-13653 : More test cases
(cherry picked from commit c712b83955)
2019-11-06 21:51:53 -08:00
Andrea Boriero 20beec97c1 HHH-13653 Uninitialized entity does not get initialized when a setter is called with enhancement-as-proxy enabled
(cherry picked from commit 3c1f4356dd)
2019-11-06 21:51:53 -08:00
Gail Badner b788b62e08 HHH-13653 : Test case
(cherry picked from commit 00f45951da)
2019-11-06 21:51:53 -08:00
Gail Badner ff6f2e5bf8 HHH-13640 : Minor improvement
(cherry picked from commit d6376834a7)
2019-11-06 21:51:53 -08:00
Andrea Boriero a3ec300866 HHH-13640 - Fix initialization of existing proxy association leaf subclass
(cherry picked from commit cec4228d70)
2019-11-06 21:51:53 -08:00
Andrea Boriero 8b855d631b HHH-13640 - Add PrepareStatement executed check to LazyToOnesProxyWithoutSubclassesTest
(cherry picked from commit 2bc7fed96e)
2019-11-06 21:51:53 -08:00
Gail Badner 295702a7ae HHH-13640 : Added failing test where a proxy is found in PersistenceContext, but it does not have a subclass
(cherry picked from commit 616f549f8c)
2019-11-06 21:51:53 -08:00
Steve Ebersole ce24b3c389 HHH-13640 - Uninitialized HibernateProxy mapped as NO_PROXY gets initialized when reloaded with enhancement-as-proxy enabled
(cherry picked from commit ee304305e8)
2019-11-06 21:51:53 -08:00
Gail Badner fdb5ba7d4e HHH-13640 : Test case (marked FailureExpected)
(cherry picked from commit 283802c491)
2019-11-06 21:51:53 -08:00
Gail Badner 6c4643f265 HHH-13586 : ClassCastException when using a single region name for both entity and query results
(cherry picked from commit 2076c68ddf)
2019-10-01 14:13:30 -07:00
Gail Badner 1f48df3ee5 HHH-13586 : test case
(cherry picked from commit 1cb81c0304)
2019-10-01 14:13:30 -07:00
Sanne Grinovero c523c527ea HHH-13645 Include a comment in the implementation about the design choice to not optimise for null values 2019-09-30 11:02:17 +01:00
Gail Badner 7b104e5ded HHH-13645 : StatsNamedContainer#getOrCompute throws NullPointerException when computed value is null 2019-09-30 11:02:13 +01:00
Gail Badner a7d9d75e94 HHH-13645 : test cases 2019-09-30 11:02:08 +01:00
Yoann Rodière c527ac15a5 HHH-13581 Disable tests involving MariaDB ConnectorJ's buggy ResultSet#getTime(int, Calendar) method
(cherry picked from commit debc5d37f8)
2019-09-11 21:24:13 -05:00
Yoann Rodière a3c894e455 HHH-13580 Ignore LocalTimeTest and OffsetTimeTest's 'nativeWriteThenRead' test for MySQL
The returned time is right (otherwise #writeThenRead would fail), it's
just that a different day is returned, but it won't affect the LocalTime
representation manipulated by the user.

(cherry picked from commit 74d35b2d59)
2019-09-11 21:14:54 -05:00
Yoann Rodière aef0405b5f HHH-13580 Use safer ZoneId => TimeZone conversion in AbstractJavaTimeTypeTest
We were testing GMT instead of UTC-8 without even knowing it...

(cherry picked from commit 8fce51c765)
2019-09-11 21:14:54 -05:00
Yoann Rodière 58674a7ba7 HHH-13580 Fix a copy/paste error in OffsetTimeTest
(cherry picked from commit f9f6793232)
2019-09-11 21:14:54 -05:00
Yoann Rodière b7c7bccc0b HHH-13582 Ignore LocalDateTest for MySQL
MySQL ConnectorJ 8.x returns the wrong date
when the JVM default timezone is different from the server timezone:
https://bugs.mysql.com/bug.php?id=91112

(cherry picked from commit a580227569)
2019-09-11 21:14:54 -05:00
Yoann Rodière 52bdda7d40 HHH-13582 Upgrade MySQL Connector/J to 8.0.17
ConnectorJ 8 is the version used in WildFly integration tests.
ConnectorJ 5 is apparently no longer tested.

Note this solves most timezone-related issues we've been having.

(cherry picked from commit be7cc76556)
2019-09-11 21:14:54 -05:00
Steve Ebersole 5274f15ef5 HHH-13607 - Exception thrown while flushing uninitialized enhanced proxy with immutable natural ID
(cherry picked from commit 7ceaf3aaa4)
2019-09-11 15:40:31 -05:00
Gail Badner c3286a2b56 HHH-13607 : Added tests
(cherry picked from commit 650b1dec6a)
2019-09-11 15:40:31 -05:00
Vlad Mihalcea 59ad417498 HHH-12968 - Flush is not flushing inserts for inherited tables before a select within a transaction
Extract IdentityGenerator batch support validation logic

(cherry picked from commit f21c8c2927)
2019-09-11 13:57:48 -05:00
Javad Alimohammadi fd186a1dd5 HHH-12968 - Flush is not flushing inserts for inherited tables before a select within a transaction
(cherry picked from commit 9dfdb2b471)
2019-09-11 13:57:48 -05:00
Andrea Boriero af3231820a HHH-13611 : Restore EntityMetamodel constructor to take SessionFactoryImplementor argument instead of PersisterCreationContext 2019-09-11 13:54:04 -05:00
Gail Badner 996e60f685 HHH-13611 : Restore EntityMetamodel constructor to take SessionFactoryImplementor argument instead of PersisterCreationContext 2019-09-11 13:54:04 -05:00
Yoann Rodière 8aa47b4e61 HHH-13592 Populate AutoFlushEvent#isFlushRequired with the correct value
(cherry picked from commit 5fc6012449)
2019-09-11 13:25:21 -05:00
Yoann Rodière 6c2be5224e HHH-13592 Test AutoFlushEvent#isFlushRequired 2019-09-11 13:25:21 -05:00
Yoann Rodière 69fa165664 HHH-13043 Upgrade to JAXB 2.3.1
... which has a correctly formatted POM, and doesn't wreak havoc in
projects depending on us and using Maven + JDK11.
2019-09-11 10:26:35 +02:00
Yoann Rodière f34fd25518 HHH-13022 Allow to fall back to the OSGi-provided TCCL during bootstrap
We previously erased that class loader, which is not a great idea, in
particular when we use libraries such as JAXB which rely on the TCCL, to
some extent.

Without this patch, we cannot make the OSGi integration work correctly
with Java 9 and above, because the JAXB APIs won't find the JAXB
runtime.
2019-09-11 10:26:35 +02:00
Yoann Rodière acc7934173 HHH-12990 Remove unnecessary dependencies to JSR-250 when generating JAXB classes
It seems these dependencies were not necessary at all, even before the
previous patches.
2019-09-11 10:26:35 +02:00
Yoann Rodière a69de05e44 HHH-12946 Enable JAXB dependencies regardless of the JDK being used when building Hibernate ORM
Previously we would only add the dependency when building with JDK9+,
and we built all releases using JDK8.
This means the dependencies were useless, because they would never be
mentioned in the actual POMs published to users.
2019-09-11 10:26:35 +02:00
Yoann Rodière e6cd7d8495 HHH-12946 Remove unnecessary dependencies when building with JDK9+
We don't need to depend on JAXB's compiler (XJC) in our modules,
we just need the dependency in specific tasks during the build.
In particular we don't want users to transitively depend on XJC.

Also, we don't need an explicit dependency to JAXB in every module,
having one in hibernate-core is enough.
2019-09-11 10:26:35 +02:00
Yoann Rodière f9609f93b2 HHH-12946 Add explicit dependencies to JAXB APIs where relevant 2019-09-11 10:26:35 +02:00
Yoann Rodière 90c059aaa4 HHH-12946 Use constants for JAXB dependencies instead of inline strings
We may have to update these dependencies, let's make it easy.
2019-09-11 10:26:35 +02:00
Gail Badner b966f6c921 HHH-13590 : test cases
(cherry picked from commit 11409ed633)
2019-09-03 14:21:18 -07:00
Gail Badner 631a2645a8 HHH-13590 : TransientObjectException merging a non-proxy association to a proxy
(cherry picked from commit 148b4b2ed0)
2019-09-03 13:25:23 -07:00
Gail Badner 345ac0ce75 HHH-13569 : Shorten table name that's too long for Oracle
(cherry picked from commit 7c57047f4a)
2019-08-15 01:32:06 -07:00
Andrea Boriero 60cb3762ba HHH-13577 LockTest.testContendedPessimisticLock and StatementIsClosedAfterALockExceptionTest.testStatementIsClosed tests fail on Sybase
HHH-13577 : Re-enable LockTest for SybaseASE15Dialect
(cherry picked from commit 210aff098c)
2019-08-14 18:58:07 -07:00
Andrea Boriero e60defd402 HHH-13574 SybaseASE does not support PARTITION BY
(cherry picked from commit cfd7db36c6)
2019-08-14 18:11:52 -07:00
Andrea Boriero 677b73d8e1 HHH-13460 - FetchGraphTest is failing on MariaDB
(cherry picked from commit 1aa6ce9b12)
2019-08-14 13:46:42 -07:00
Andrea Boriero c211c61d86 HHH-13455 - Enabling Enhancement as a Proxy causes IllegalStateException when using Javassist
(cherry picked from commit beac486533)
2019-08-14 11:09:48 -07:00
Gail Badner 1ff9d19d8e HHH-13573 : Test failure due to Sybase not supporting cascade delete on foreign key definitions
(cherry picked from commit fed93b0ae9)
2019-08-14 00:27:18 -07:00
Gail Badner ada9f901e9 HHH-13570 : Test failures due to Sybase not supporting UPDATE statement with WITH(NOWAIT)
(cherry picked from commit ce03ef96b9)
2019-08-13 23:38:53 -07:00
Gail Badner eb85932c42 HHH-13571 : Test failures due to cross joined table out of scope of a subsequent JOIN on Sybase
(cherry picked from commit 9988d677b9)
2019-08-13 23:18:45 -07:00
Gail Badner 9b1c21444c HHH-13569 : org.hibernate.test.annotations.embedded.EmbeddedTest failures on Sybase
(cherry picked from commit 937d4a3503)
2019-08-13 18:04:21 -07:00
Andrea Boriero 68e89ba0dd HHH-13554 QueryAndSQLTest.testNativeQueryWithFormulaAttributeWithoutAlias() fails on MariaDB
(cherry picked from commit 1a5b401d09)
2019-08-13 14:39:12 -07:00
Andrea Boriero a95bbddd57 HHH-13556 Tests doing dynamic fetch scrolling a collection fail on DB2
(cherry picked from commit 2aee5a930d)
2019-08-13 14:26:17 -07:00
Andrea Boriero c7e86e9237 HHH-13459 - Unit test lock up when they run on PostgreSQL
(cherry picked from commit cb343567e6)
2019-08-13 14:26:07 -07:00
Gail Badner c451219cff HHH-13558 : InstantTest, LocalDateTimeTest, OffsetDateTimeTest, ZonedDateTimeTest failing on Sybase for year 1600
(cherry picked from commit 3583074619)
2019-08-12 21:32:37 -07:00
Gail Badner e9dc757c54 HHH-13557 : LocalTimeTest#writeThenNativeRead and OffsetTimeTest#writeThenNativeRead tests are failing on SQL Server
(cherry picked from commit 1b06b76e17)
2019-08-12 19:41:11 -07:00
Gail Badner 86385bdce3 HHH-13559 : Skip failing tests on Sybase
(cherry picked from commit fdca4b2854)
2019-08-09 18:53:20 -07:00
Gail Badner 9eab3a80d1 HH-13550 : Fix Oracle failure for test added by HHH-13424
(cherry picked from commit cb51b1e838)
2019-08-09 17:29:37 -07:00
Gail Badner f17ea81cff HHH-13555 : FetchGraphTest, MergeProxyTest and ProxyDeletionTest fail due to ConstraintViolationException
(cherry picked from commit dbb94d8066)
2019-08-09 14:57:29 -07:00
Gail Badner 19fdd0665a HHH-13554 : QueryAndSQLTest.testNativeQueryWithFormulaAttributeWithoutAlias() fails on Oracle, MSSQL, Sybase, DB2
(cherry picked from commit 2a154cb583)
2019-08-09 13:58:53 -07:00
Gail Badner cc164e4dec HHH-13550 : Fix Oracle failure for test added by HHH-13424
(cherry picked from commit 6510c34e93)
2019-08-08 22:40:28 -07:00
Sanne Grinovero 2f1774beb8 HHH-13512 Remove some dead code 2019-08-07 14:43:50 -07:00
Sanne Grinovero ccae2388ed HHH-13512 Optimise StringHelper#isQuoted(String, Dialect) 2019-08-07 14:43:50 -07:00
Sanne Grinovero c9f41dc9b7 HHH-13512 Avoid allocating an array in org.hibernate.internal.util.StringHelper#unquote(String[], Dialect) if there are no changes to be applied 2019-08-07 14:43:50 -07:00
Sanne Grinovero 86cd6360b2 HHH-13544 Restore logged warning on jdbc code mapping issue in NationalizedTypeMappings 2019-08-07 14:43:50 -07:00
Sanne Grinovero b37d6938fa HHH-13495 Deprecate singleton access to NationalizedTypeMappings 2019-08-07 14:43:50 -07:00
Sanne Grinovero ab832caf0d HHH-13495 Do not use BoundedConcurrentHashMap for NationalizedTypeMappings 2019-08-07 14:43:50 -07:00
Sanne Grinovero 3088a2cfd0 HHH-13494 Deprecate singleton access in favour of static helpers 2019-08-07 14:43:50 -07:00
Sanne Grinovero cd3b76960e HHH-13494 LobTypeMappings should not use a Bounded ConcurrentHashmap 2019-08-07 14:43:50 -07:00
Sanne Grinovero cf4eeef40b HHH-13531 Some more opportunities to reuse the constants pool in AliasConstantsHelperMore opportunities to reuse the int_ constant pools 2019-08-07 14:43:50 -07:00
Sanne Grinovero 8c515f0cf6 HHH-13534 AbstractLoadPlanBasedLoader never needs a List of AfterLoadAction 2019-08-07 14:43:50 -07:00
Sanne Grinovero 5d097a627a HHH-13527 Minimize captured state in lambdas used for Statistics 2019-08-07 09:02:39 +01:00
Sanne Grinovero 3ea09791eb HHH-13527 Fix contention in StatisticsImpl#getDomainDataRegionStatistics() 2019-08-07 09:02:39 +01:00
Sanne Grinovero eb1ab2cd9b HHH-13527 Optimise DefaultLoadEventListener#getFromSharedCache hot path 2019-08-07 09:02:39 +01:00
Sanne Grinovero 3dbf0166fe HHH-13525 Make test SessionDelegatorBaseImplTest more resilient to previously existing alias definition
(cherry picked from commit d6abbe5124)
2019-08-02 15:48:25 -07:00
Andrea Boriero 81d7be0ad3 HHH-13514 - Calling the wrong method inside SessionDelegatorBaseImpl#createStoredProcedureQuery
(cherry picked from commit 65fa9cb1e7)
2019-08-02 15:48:25 -07:00
Andrea Boriero 497f17e251 HHH-13514 - Add test for issue
(cherry picked from commit 7eaf4904d8)
2019-08-02 15:48:25 -07:00
Yoann Rodière 791b64f63f HHH-13379 Test storage of java.time type representing an instant near the end of DST
(cherry picked from commit 0387090bba)
2019-08-02 15:44:24 -07:00
Yoann Rodière 4f02f4e5ee HHH-13379 Do not change the instant when storing a java.time type representing an instant at DST end in the default JVM timezone
Note problems can still occur in the JDBC driver if the JDBC timezone is
not forced to GMT/UTC.

(cherry picked from commit 89d304a00e)
2019-08-02 15:44:24 -07:00
Yoann Rodière f4fd801c3e HHH-13379 Enhance date/time tests to allow testing certain values only when forcing the JDBC timezone
(cherry picked from commit de8e965cc8)
2019-08-02 15:44:24 -07:00
Scott Marlow 330b5da305 HHH-13505 : NullPointerException thrown by StatisticsImpl#getCacheRegionStatistics 2019-08-02 15:41:20 -07:00
Gail Badner f7498b2340 HHH-13466 : ClassCastException when changing a Collection association to a Set if @PreUpdate listener exists
(cherry picked from commit 7d54b59743)
2019-08-02 15:38:53 -07:00
Gail Badner 1d316e6452 HHH-13466 : Test cases
(cherry picked from commit 80828eba43)
2019-08-02 15:38:53 -07:00
Sanne Grinovero 98ee32415d HHH-13521 Avoid excessive validation of enabled filters 2019-08-01 11:20:54 +01:00
Andrea Boriero ef242b283a HHH-13528 Remove call to resourceRegistry.release(ResultSet resultSet, Statement statement) from AbstractLoadPlanBasedLoader#executeLoad() 2019-08-01 11:20:54 +01:00
Sanne Grinovero 8d6fa83e59 HHH-13529 Specifically optimise Dialect retrieval from DefaultEntityAliases 2019-08-01 11:20:54 +01:00
Sanne Grinovero 460ff8c125 HHH-13529 Dot not access hot JdbcServices over ServiceRegistry 2019-08-01 11:20:54 +01:00
Sanne Grinovero 6147c6120a HHH-13528 Invoke afterStatements only at the end of releasing all statements for a batch 2019-08-01 11:20:54 +01:00
Sanne Grinovero 65ab8a0ec6 HHH-13526 Avoid repeated lookups for the same component 2019-08-01 11:20:54 +01:00
Sanne Grinovero 5699258aa2 HHH-13526 Optimise HashMap lookup operations on ResourceRegistryStandardImpl xref 2019-08-01 11:20:54 +01:00