Commit Graph

5458 Commits

Author SHA1 Message Date
Davide D'Alto 0251473c87 HHH-13759 Additional test cases 2019-12-13 14:56:51 +00:00
Andrea Boriero 0dea8319d4 HHH-13759 - Support for private Embedded in MappedSuperclass 2019-12-13 14:56:51 +00:00
Davide D'Alto c4dc9b0d25 HHH-13704 Make javassist a compile time dependency again
This commit revert some of the changes so that we can release it in a micro
  without breaking application using Javassist.

  In the next minor it should be reverted.
2019-12-13 11:29:40 +00:00
Davide D'Alto b8ffe851a7 HHH-13704 Format imports in EnhancerFileNotFoundTest 2019-12-12 13:50:01 +00:00
Davide D'Alto c3ccc65275 HHH-13704 Test Javassist is not on the classpath 2019-12-12 13:50:01 +00:00
Davide D'Alto 76d2672122 HHH-13704 Make Javassist an optional dependency
* Change the gradle scope to `provide`
  * Add the dependency to the OSGi test bundle

HHH-13704 Add Javassist to the dependencies for the OSGi test
2019-12-12 10:33:32 +00:00
Davide D'Alto 39071a4d39 HHH-13704 Move EnhancerFileNotFoundTest
Tests requiring Javassist are now in a dedicated folder.
2019-12-12 10:33:32 +00:00
Davide D'Alto 2e5892236b HHH-13704 Remove Javassist from ClassFileArchiveEntryHandler
Use Jandex instead.
2019-12-12 10:33:32 +00:00
Davide D'Alto bac88eda53 HHH-13704 Typo: tupizer -> tuplizer 2019-12-12 10:33:32 +00:00
Nathan Xu 3a69b74894 HHH-13456 refactor ForeignGenerator to allow for the possibility of StatelessSession 2019-12-11 17:37:31 -06:00
Nathan Xu 8ce1404754 HHH-13644 fix the NPE by override ProcedureCallImpl's 'getResultStream()' method. 2019-12-11 17:23:22 -06:00
Jan-Willem Gmelig Meyling a6b924ffe7 HHH-9301 Fix test under PostgreSQL 2019-12-05 14:00:01 +00:00
Andrea Boriero 963a516ea8 Revert "HHH-13752 - Test and fix deletion of entities with many-to-many assocations using non-primary keys for join table"
This reverts commit 58dd469e4c.
2019-12-05 12:34:27 +00:00
Andrea Boriero e924d55fdf Revert "HHH-13752 - Deletion of entities with many-to-many assocations using non-primary keys for join table"
This reverts commit 11455f3467.
2019-12-05 12:34:10 +00:00
Gail Badner 99868fb5f9 HHH-13355 : StaleStateException for updates to optional secondary table using saveOrUpdate 2019-12-05 12:05:24 +00:00
Gail Badner 69dad5fda5 HHH-13355 : test case 2019-12-05 12:05:24 +00:00
Gail Badner 6ce7831f77 HHH-13365 : Entities in joined subclass table are not inserted with batch size > 0 using sequence-identity ID generator 2019-12-05 11:36:04 +00:00
Gail Badner 7d11649d99 HHH-13365 : Added test case 2019-12-05 11:36:04 +00:00
Andrea Boriero 11455f3467 HHH-13752 - Deletion of entities with many-to-many assocations using non-primary keys for join table 2019-12-05 10:18:23 +00:00
Christian Beikov 58dd469e4c HHH-13752 - Test and fix deletion of entities with many-to-many assocations using non-primary keys for join table 2019-12-05 10:05:16 +00:00
Andrea Boriero a133aff97f HHH-13608 Fix failing tests 2019-12-05 09:25:32 +00:00
Jason Jijón 7daf67172a HHH-13758 - Limit Handler for SQL server doesn't work with CTE queries with strings literals 2019-12-04 19:38:56 +00:00
Sanne Grinovero 42752ec89d HHH-8901 Missing data cleanup in the new test 2019-12-04 17:44:02 +00:00
Sanne Grinovero 386d77129e HHH-13761 Debug logging of JPA compliance settings didn't log the value of the settings 2019-12-04 16:56:23 +00:00
Sanne Grinovero b9b15245b7 HHH-8901 Some very minor string handling optimisations 2019-12-04 16:37:34 +00:00
Nathan Xu ab9ae43185 HHH-8901 replace "in ()" SQL with "in (null)" in QueryParameterBindingsImpl 2019-12-04 16:05:10 +00:00
Davide D'Alto 4e449dfafa HHH-13764 Test behaviour doesn't change when @Embedded is on the getter 2019-12-03 20:40:53 +00:00
Davide D'Alto 4fb813f39c HHH-13764 Include getter annotations when required for the enhancements 2019-12-03 20:09:09 +00:00
Davide D'Alto 98101bfc52 HHH-13759 Add AssertJ for testing Hibernate Core 2019-12-03 12:13:56 +00:00
Vlad Mihalcea f08abf3628 HHH-13608 Oracle8iDialect should use CASE_INSENSITIVE pattern matching when checking the statement type 2019-11-25 15:41:33 +00:00
Jan-Willem Gmelig Meyling 21e79125e6 HHH-9301 - Support select variable refs in group by for DBMS dialects that support it
While not strictly compliant with the SQL specification, the MySQL, PostgreSQL and H2 support the use of select aliases in the GROUP BY clause. An obvious benefit is that produced SQL queries will be easier to read, because complex select expressions from aggregrate queries will have to be included in the group by clause as well. These can now simply reference the aliases of the respective columns for the tuple element. However, there is also a functional difference. For function invocations that have parameterized arguments, the query optimizer can't guarantee the that the function result between the selection projection and grouping process are equal. This results in an error because a value is projected which is not grouped by. An example where this for example becomes relevant, is when parameterizing TimeScaleDB's [`time_bucket_gapfill()`](https://docs.timescale.com/latest/api#time_bucket_gapfill-examples) function.

For example, using `time_bucket_gapfill()` one might want to produce a criteria query that produces the following SQL:

```sql
SELECT
    time_bucket_gapfill(?, time, ?, ?) AS ts,
    avg(tg) as tg
FROM iaqmeasurement
GROUP BY ts
ORDER BY ts;
```

When the alias is not used as grouping value, the query will yield an error:

```sql
SELECT
    time_bucket_gapfill(?, time, ?, ?) AS ts,
    avg(tg) as tg
FROM iaqmeasurement
GROUP BY time_bucket_gapfill(?, time, ?, ?)
ORDER BY ts;
```

Of course the parameter values can just be stored in a CTE as well, but I think we should consider support for variable refs in group by for DBMS dialects that support it. This pull request implements the feature equivalently to how its currently done for order by clauses, and only enables the feature for known supported dialects (H2, PostgreSQL and MySQL - based on [https://stackoverflow.com/a/3841804/2104280](https://stackoverflow.com/a/3841804/2104280)).

Jira: https://hibernate.atlassian.net/browse/HHH-9301

Co-authored-by: Sayra Ranjha <S.S.Ranjha@student.tudelft.nl>
2019-11-25 14:57:17 +00:00
Jan-Willem Gmelig Meyling bde7ca974b HHH-12895 - Extra LEFT JOIN generated with @ManyToOne and @JoinTable when projecting
on main entity id
2019-11-25 14:27:57 +00:00
Jan-Willem Gmelig Meyling 473566c50d HHH-13742 - Added additional tests 2019-11-25 12:15:21 +00:00
Jan-Willem Gmelig Meyling 325239353e HHH-13742 - Preliminary fix for HHH-13742 2019-11-21 16:28:49 +01:00
Jan-Willem Gmelig Meyling 8089d8c575 HHH-13742 - Missing from clause with joined inheritance property in association subquery 2019-11-21 15:30:41 +01:00
Andreas Knees be23e167af HHH-13722 Introducing a test case 2019-11-18 14:59:56 +00:00
Sanne Grinovero 7331a58d5e HHH-13722 ArrayStoreException in Constraint.generateName 2019-11-18 14:55:37 +00:00
Gail Badner 76308e8a3e HHH-13737 : Correct log message and fix checkstyle failure 2019-11-14 18:22:01 -08:00
Gail Badner 7d8549d8aa HHH-13737 : Add debug logging 2019-11-14 18:22:01 -08:00
Gail Badner c02011ef40 HHH-13737 : Add test case for HHH-13433 2019-11-14 18:22:01 -08:00
Andrea Boriero 841368175f HHH-13614 Allow the IntegratorProvider to be supplied via its FQN in the JPA persistence.xml 2019-11-14 13:35:09 +00:00
Vlad Mihalcea 52f9a36a6d HHH-13614 Allow the IntegratorProvider to be supplied via its FQN in the JPA persistence.xml 2019-11-14 13:35:09 +00:00
Andrea Boriero f5fb84cfe2 HHH-13705 Enhancement as Proxy with inline dirty checking - flush of an @ManyToOne with an Embedded value having not null properties causes PropertyValueException 2019-11-14 11:31:11 +00:00
Andrea Boriero 842a155615 HHH-13705 Add test for issue
HHH-13705 Add test for issue
2019-11-14 11:31:11 +00:00
Christian Beikov 47c8a89390 HHH-13712 - Test and fix for missing superclass table joins when joining superclass associations 2019-11-14 11:29:01 +00:00
Andrea Boriero 9ddab37748 HHH-13727 H2 database with DATABASE_TO_UPPER=false throws org.h2.jdbc.JdbcSQLSyntaxErrorException: Table sequences not found 2019-11-13 13:57:48 +00:00
Christian Beikov 0c0248d448 Include the WITH clause AST in the FromElement so that column references can be analyzed 2019-11-12 17:47:48 +00:00
Jan-Willem Gmelig Meyling 05e6a41e5f HHH-13670 - Reproducer Missing from clause in query with joined inheritance, regression in 5.4.5 2019-11-12 17:47:48 +00:00
Sanne Grinovero 164e1fc7cc HHH-13687 TenantSchemaResolver not called in integration test after upgrade from 2019-11-12 17:40:59 +00:00
Sanne Grinovero 66515a2e4e HHH-13723 Hint sizing of ArrayList in ResultSetProcessingContextImpl 2019-11-11 10:59:14 +00:00
Scott Marlow a682a7d19c HHH-13433 EntityManager.find() should only check for roll-back-only condition if there is an active JTA transaction, otherwise ORM should throw throw convert( e, lockOptions ) 2019-11-07 20:33:25 -08:00
Gail Badner 0c1df5fc0d HHH-13698 : Hibernate does not recognize MySQL 8 error code 3572 as PessimisticLockException 2019-11-01 10:58:46 -07:00
Gail Badner a7f017c3dc HHH-13307 : On release of batch it still contained JDBC statements using JTA 2019-11-01 10:58:13 -07:00
Gail Badner 1241d35a50 HHH-13307 : Added test 2019-11-01 10:58:13 -07:00
Sanne Grinovero cec7329214 HHH-13700 Configuration property CONNECTION_PROVIDER_DISABLES_AUTOCOMMIT should not be passed to the JDBC connection properties 2019-10-31 23:43:38 +00:00
Sanne Grinovero 2bcb1b0a6d HHH-13654 Reorganize fields and add some comments about this work 2019-10-30 12:27:59 +00:00
Sanne Grinovero f89bf35106 HHH-13654 Make AbstractFlushingEventListener#entitiesByKey also lazily initialized 2019-10-30 12:27:59 +00:00
Sanne Grinovero 6034ece731 HHH-13654 Refactor references to StatefulPersistenceContext#batchFetchQueue 2019-10-30 12:27:55 +00:00
Sanne Grinovero 500819e169 HHH-13654 Defer initialization of StatefulPersistenceContext#entitySnapshotsByKey 2019-10-30 12:27:53 +00:00
Sanne Grinovero f4bf11331b HHH-13654 Defer initialization of StatefulPersistenceContext#collectionsByKey 2019-10-30 12:27:48 +00:00
barreiro 1dd787eaa1 HHH-13446 - Validate mapped-by values got from annotations in bytecode enhancers 2019-10-26 17:53:56 +01:00
Sanne Grinovero b4a8052a15 HHH-13695 DDL export forgets to close a Statement 2019-10-25 16:47:52 +01:00
Sanne Grinovero e5539cc36c HHH-13651 Adding a regression test for the issue 2019-10-24 11:25:17 +01:00
Yosef Yona a5c8a812f5 HHH-13651 Applying hibernate codestyle to PersistentBag 2019-10-24 09:27:23 +01:00
Yosef Yona 2808a75d5c HHH-13651 NPE on flushing when ElementCollection field contains null element 2019-10-24 09:26:51 +01:00
Andrea Boriero 96e7abf80b HHH-13672 The temporary PersistenceContext of a StatelessSession is not cleared after a refresh operation 2019-10-21 12:08:58 +01:00
Andrea Boriero 43402ea51c HHH-13672 Add test for issue 2019-10-21 12:08:58 +01:00
Yoann Rodière cacef1f466 HHH-13680 Upgrade to Byte-buddy 1.10.2 2019-10-21 12:59:29 +02:00
Andrea Boriero f39d96f9fa HHH-13673 Cryptic error when providing import.sql file without a terminal char at the end of each line 2019-10-21 10:17:03 +01:00
Andrea Boriero 8f68a3573e HHH-13673 Add test for issue 2019-10-21 10:17:03 +01:00
Christoph Dreis 3b1e7afb20 HHH-13675 : Optimize PersistentBag.groupByEqualityHash() 2019-10-18 13:28:00 +01:00
Andrea Boriero 1c840f9dd1 HHH-12858 HHH-13432 fix Oracle failing tests 2019-10-18 13:15:48 +01:00
Gail Badner 93a07453f0 HHH-13634 : Fix test case queries to order results 2019-10-17 12:04:19 -07:00
Gail Badner 42de569a37 HHH-13634 : PersistenceContext can get cleared before load completes using StatelessSessionImpl 2019-10-17 09:46:58 -07:00
Gail Badner eccb786ba4 HHH-13634 : Test cases 2019-10-17 09:46:58 -07:00
Yoann Rodière 6cdb0256d4 HHH-13666 Test custom BeforeTransactionCompletionProcess/AfterTransactionCompletionProcess 2019-10-17 15:54:16 +02:00
Yoann Rodière 5c8169ba7c HHH-13666 Re-use the wrapped exception's message upon beforeTransactionCompletion/afterTransactionCompletion failure
For convenience.
2019-10-17 15:54:16 +02:00
Yoann Rodière f9c149ab0d HHH-13666 Throw a HibernateException with a more appropriate message upon beforeTransactionCompletion/afterTransactionCompletion failure 2019-10-17 15:54:16 +02:00
Yoann Rodière 250f569339 HHH-13666 Clarify that existing BeforeCompletion/AfterCompletion tests are about JTA only 2019-10-17 15:54:16 +02:00
Yoann Rodière 8655d683e6 HHH-13666 Remove some dead code in tests related to transactions 2019-10-17 15:54:16 +02:00
Gail Badner 81d5f5eb21 HHH-13633 : Fix test case queries to order results 2019-10-16 13:53:53 -07:00
Gail Badner 388b62f049 HHH-13633 : Bugs join-fetching a collection when scrolling with a stateless session using enhancement as proxy
Make corrections.

(cherry picked from commit 40a7cee13d)
2019-10-16 11:27:35 -07:00
Gail Badner ce19b83e4e HHH-13633 : Add tests including for no HibernateProxy factory
(cherry picked from commit 5aa421d697)
2019-10-16 11:27:35 -07:00
Gail Badner 20d6b53631 HHH-13633 : Bugs join-fetching a collection when scrolling with a stateless session using enhancement as proxy
Minor changes suggested by Andrea.

(cherry picked from commit cce634f03b)
2019-10-16 11:27:35 -07:00
Gail Badner f1fa438bbe HHH-13633 : Bugs join-fetching a collection when scrolling with a stateless session using enhancement as proxy
(cherry picked from commit b589251166)
2019-10-16 11:27:35 -07:00
Gail Badner e2a403e19d HHH-13633 : Added more tests based on renamed original (w/ and w/o bytecode enhancement)
(cherry picked from commit 9ad427a33e)
2019-10-16 11:27:35 -07:00
Andrea Boriero 38ff41c896 HHH-13633 : Add test for issue
(cherry picked from commit 1d8f93ca64)
2019-10-16 11:27:35 -07:00
Gail Badner fb8d5b42c9 HHH-13640 : Correct DefaultLoadEventListener#proxyOrLoad to work properly enhancement but no HibernateProxy factory 2019-10-15 10:47:33 -07:00
Gail Badner 66afff296a HHH-13640 : Add test using custom EntityTuplizer with no HibernateProxy factory using Session 2019-10-15 10:47:33 -07:00
Andrea Boriero c392d03bf1 HHH-13665 selecting an Entity annotated with @Immutalbe but not with @Cachable causes a NPE when use_reference_entries is enabled 2019-10-15 11:02:04 +01:00
Andrea Boriero 8d9eb04d16 HHH-13665 Add test for issue 2019-10-15 11:02:04 +01:00
Gail Badner e10e84159a HHH-13640 : Remove SharedSessionContractImplementor#internalLoad(String, Serializable, boolean, boolean, Boolean unwrapProxy) 2019-10-14 11:40:00 -07:00
Gail Badner c21ecb511c HHH-13640 : Added/modified tests 2019-10-14 11:39:59 -07:00
Francisco A. Lozano 8f96d7e1e9 HHH-4235 MapBinder.createFormulatedValue() does not honor DB schema name when creating query 2019-10-14 10:29:58 +01:00
Andrea Boriero 2985c1db98 HHH-4235 Add test for issue 2019-10-14 10:27:11 +01:00
Sanne Grinovero 14b6330a32 HHH-13663 Have the test actually use ThreadLocalSessionContext 2019-10-11 10:59:29 +01:00
Sanne Grinovero 1d64a386cd HHH-13663 adjust formatting style 2019-10-11 10:44:39 +01:00
mimmoz81 26edb2863f HHH-13663 Method setHibernateFlushMode not callable without an active transaction on threadbound Sessions 2019-10-11 10:41:53 +01:00
Sanne Grinovero 9d6463eab6 HHH-13662 Avoid initializing XmlMappingBinderAccess when no XML mappings are defined 2019-10-10 10:27:52 +01:00
Sanne Grinovero 404bc196f7 HHH-13660 Removing dead parameter: forceFetchLazyAttributes 2019-10-09 11:57:56 +01:00
Sanne Grinovero 9dd6b8439b HHH-13660 Reduce allocation costs of IdentityMaps used by ResultSetProcessingContextImpl 2019-10-09 11:57:53 +01:00
Gail Badner d6376834a7 HHH-13640 : Minor improvement 2019-10-07 12:22:51 +01:00
Andrea Boriero cec4228d70 HHH-13640 - Fix initialization of existing proxy association leaf subclass 2019-10-07 12:22:51 +01:00
Gail Badner c712b83955 HHH-13653 : More test cases 2019-10-07 07:58:45 +01:00
Andrea Boriero 3c1f4356dd HHH-13653 Uninitialized entity does not get initialized when a setter is called with enhancement-as-proxy enabled 2019-10-07 07:58:45 +01:00
Steve Ebersole ab508d2afa HHH-12858 - integration overrides during JPA bootstrap ought to override all logically related settings
HHH-13432 - Have EntityManagerFactory expose persistence.xml `jta-data-source` element as a `javax.persistence.nonJtaDataSource` property
2019-10-05 23:03:09 -05:00
Steve Ebersole fd72e4f75f HHH-12858 - integration overrides during JPA bootstrap ought to override all logically related settings
HHH-13432 - Have EntityManagerFactory expose persistence.xml `jta-data-source` element as a `javax.persistence.nonJtaDataSource` property
2019-10-05 22:45:29 -05:00
Gail Badner 00f45951da HHH-13653 : Test case 2019-10-03 23:54:23 -07:00
Steve Ebersole b350599442 HHH-12858 - integration overrides during JPA bootstrap ought to override all logically related settings
- e.g. a datasource passed in the integration overrides map ought to effectively override JDBC-connection settings in `persistence.xml` (and vice-versa)

HHH-13432 - Have EntityManagerFactory expose persistence.xml `jta-data-source` element as a `javax.persistence.nonJtaDataSource` property
2019-10-03 16:03:43 +01:00
Andrea Boriero 2bc7fed96e HHH-13640 - Add PrepareStatement executed check to LazyToOnesProxyWithoutSubclassesTest 2019-10-02 16:19:54 +01:00
Gail Badner 616f549f8c HHH-13640 : Added failing test where a proxy is found in PersistenceContext, but it does not have a subclass 2019-10-01 17:32:45 -07:00
Steve Ebersole ee304305e8 HHH-13640 - Uninitialized HibernateProxy mapped as NO_PROXY gets initialized when reloaded with enhancement-as-proxy enabled 2019-10-01 09:25:09 -05:00
Steve Ebersole d46d3d66a2 HHH-13432 - EntityManagerFactory no longer exposes "javax.persistence.nonJtaDataSource" 2019-10-01 09:25:09 -05:00
Vlad Mihalcea 9a627c30fe HHH-13493 - For a native query, the SessionImpl class does not call applyQuerySettingsAndHints 2019-09-30 11:02:22 +01:00
Sanne Grinovero a92cd6c9b9 HHH-13645 Include a comment in the implementation about the design choice to not optimise for null values 2019-09-30 10:40:45 +01:00
Gail Badner 00d25c1824 HHH-13645 : StatsNamedContainer#getOrCompute throws NullPointerException when computed value is null 2019-09-30 10:30:05 +01:00
Gail Badner 3f7d03bfec HHH-13645 : test cases 2019-09-30 10:30:05 +01:00
Kim Hansen 7355fc5131 Fix error in error message 2019-09-27 12:33:27 +01:00
Andrea Boriero e04348079f HHH-13597 Building DatabaseInformation fails on H2 without DATABASE_TO_UPPER 2019-09-27 11:57:36 +01:00
Vootele Rotov 0e9ef8c7c9 HHH-13597 Add test for issue 2019-09-27 11:57:36 +01:00
Steve Ebersole 57fba402b4 HHH-12858 - Persistence.createEntityManagerFactory(Map) should allow overwriting jta-data-source of persistence.xml 2019-09-25 15:12:25 -05:00
Gail Badner 283802c491 HHH-13640 : Test case (marked FailureExpected) 2019-09-24 15:03:29 -07:00
Sanne Grinovero 1bdbc0e764 HHH-13625 After upgrading to 5.4.5, it's no longer possible to bootstrap Hibernate if the org.hibernate.cfg LOG is set to DEBUG 2019-09-17 19:43:08 +01:00
Andrea Boriero f5877052ff HHH-13621 Exception if spaces after value of javax.persistence.schema-generation.scripts.action in hibernate.properties 2019-09-16 10:12:13 +01:00
Andrea Boriero 26c2e0bf2b HHH-13621 Add test for issue 2019-09-16 10:12:13 +01:00
Yoann Rodière debc5d37f8 HHH-13581 Disable tests involving MariaDB ConnectorJ's buggy ResultSet#getTime(int, Calendar) method 2019-09-11 21:20:35 -05:00
Yoann Rodière 74d35b2d59 HHH-13580 Ignore LocalTimeTest and OffsetTimeTest's 'nativeWriteThenRead' test for MySQL
The returned time is right (otherwise #writeThenRead would fail), it's
just that a different day is returned, but it won't affect the LocalTime
representation manipulated by the user.
2019-09-11 19:38:15 -05:00
Yoann Rodière 8fce51c765 HHH-13580 Use safer ZoneId => TimeZone conversion in AbstractJavaTimeTypeTest
We were testing GMT instead of UTC-8 without even knowing it...
2019-09-11 19:38:15 -05:00
Yoann Rodière f9f6793232 HHH-13580 Fix a copy/paste error in OffsetTimeTest 2019-09-11 19:38:15 -05:00
Yoann Rodière a580227569 HHH-13582 Ignore LocalDateTest for MySQL
MySQL ConnectorJ 8.x returns the wrong date
when the JVM default timezone is different from the server timezone:
https://bugs.mysql.com/bug.php?id=91112
2019-09-11 19:38:15 -05:00
Yoann Rodière be7cc76556 HHH-13582 Upgrade MySQL Connector/J to 8.0.17
ConnectorJ 8 is the version used in WildFly integration tests.
ConnectorJ 5 is apparently no longer tested.

Note this solves most timezone-related issues we've been having.
2019-09-11 19:38:15 -05:00
Andrea Boriero ea8694ad38 HHH-13611 : Restore EntityMetamodel constructor to take SessionFactoryImplementor argument instead of PersisterCreationContext 2019-09-09 11:00:31 +01:00
Gail Badner b26ec4e625 HHH-13611 : Restore EntityMetamodel constructor to take SessionFactoryImplementor argument instead of PersisterCreationContext 2019-09-09 09:52:07 +01:00
Gail Badner 2076c68ddf HHH-13586 : ClassCastException when using a single region name for both entity and query results 2019-09-05 12:49:00 -07:00
Gail Badner 1cb81c0304 HHH-13586 : test case 2019-09-05 12:49:00 -07:00
Steve Ebersole 7ceaf3aaa4 HHH-13607 - Exception thrown while flushing uninitialized enhanced proxy with immutable natural ID 2019-09-04 20:46:22 -07:00
Gail Badner 650b1dec6a HHH-13607 : Added tests 2019-09-04 20:46:22 -07:00
Gail Badner 148b4b2ed0 HHH-13590 : TransientObjectException merging a non-proxy association to a proxy 2019-09-03 13:03:01 -07:00
Gail Badner 11409ed633 HHH-13590 : test cases 2019-09-03 13:03:01 -07:00
Sanne Grinovero 40b30fa099 HHH-13600 Avoid capturing lambdas in ParameterTranslationsImpl 2019-08-28 11:56:37 +01:00
Sanne Grinovero c8a36cd961 HHH-13600 Extracting some more constants from loops 2019-08-28 11:56:35 +01:00
Sanne Grinovero 9f71bd890d HHH-13600 Unguarded log statement in CollectionCacheInvalidator 2019-08-28 11:56:33 +01:00
Sanne Grinovero 86e498f4f7 HHH-13600 Avoid capturing lambdas in AbstractDomainDataRegion construction 2019-08-28 11:56:31 +01:00
Sanne Grinovero 3d715c0ae8 HHH-13600 Extract Alias allocation from loop in AbstractCollectionPersister 2019-08-28 11:56:28 +01:00
Sanne Grinovero bcbfea7724 HHH-13599 Avoid ArrayList allocation in JtaTransactionCoordinatorImp in common scenario 2019-08-27 18:25:36 +01:00
Sanne Grinovero 44c6f0fa3f HHH-13595 Remove the invocations to the no-op methods of ConnectionObserver 2019-08-23 15:41:12 +01:00
Sanne Grinovero db92f7aa00 HHH-13595 Small tuning of JdbcObserverImpl 2019-08-23 15:41:12 +01:00
Sanne Grinovero c94117cedc HHH-13595 Deprecate ConnectionObserver 2019-08-23 15:36:54 +01:00
Yoann Rodière 5fc6012449 HHH-13592 Populate AutoFlushEvent#isFlushRequired with the correct value 2019-08-22 12:07:24 -07:00
Yoann Rodière 618a502dac HHH-13592 Test AutoFlushEvent#isFlushRequired 2019-08-22 12:07:24 -07:00
Sanne Grinovero 9bfffd85d7 HHH-13565 Ensure all events from EventListenerGroup can be fired without allocations 2019-08-22 13:51:36 +01:00
Sanne Grinovero 646a8756a9 HHH-13565 Making SessionFactoryImpl#LockOptions lazily initialized as well 2019-08-22 13:51:36 +01:00
Sanne Grinovero 2de048fde5 HHH-13565 Prepare the most commonly needed SessionBuilder instances in advance 2019-08-22 13:51:36 +01:00
Sanne Grinovero cc39f54717 HHH-13565 Micro cleanup of Trace level checks 2019-08-22 13:51:36 +01:00
Sanne Grinovero 91299aeb7f HHH-13565 Remove some dead code from SessionImpl 2019-08-22 13:51:36 +01:00
Sanne Grinovero b8f3fc3616 HHH-13565 Convert iteration of event listeners to be allocation free 2019-08-22 13:51:36 +01:00
Sanne Grinovero 269d5f8358 HHH-13565 Review allocations for default SessionEventListener instances 2019-08-22 13:51:36 +01:00
Sanne Grinovero 4b2f056a63 HHH-13565 Avoid allocating ArrayList of ConnectionObserver instances on each Session 2019-08-22 13:51:36 +01:00
Sanne Grinovero 4ef8030f51 HHH-13565 Move field SessionImpl#discardOnClose to FastSessionServices as well 2019-08-22 13:51:36 +01:00
Sanne Grinovero e23e6a73e6 HHH-13565 Extract Session properties to avoid eager initialization of Map<String,Object> properties 2019-08-22 13:51:36 +01:00
Sanne Grinovero 457e9b61fa HHH-13565 Formatting improvements 2019-08-22 13:51:36 +01:00
Sanne Grinovero bc5b3c028f HHH-13565 Remove some related dead code 2019-08-22 13:51:36 +01:00
Sanne Grinovero be9fe27592 HHH-13565 Promote to FastSessionServices: isJtaTransactionAccessible 2019-08-22 13:51:36 +01:00
Sanne Grinovero 8931ef0962 HHH-13565 Promote JDBCServices as hot service to be retrieved from FastSessionService as well 2019-08-22 13:51:32 +01:00
Sanne Grinovero 185ef2edb7 HHH-13565 Extract some hot ServiceRegistry services as well 2019-08-22 09:26:16 +01:00
Sanne Grinovero 72ce71ef10 HHH-13565 Dialect is another constant 2019-08-22 09:26:16 +01:00
Sanne Grinovero 8a3c1ee504 HHH-13565 Promote field useStreamForLobBinding as cross-Session constant 2019-08-22 09:26:16 +01:00
Sanne Grinovero a39acebde8 HHH-13565 Move field AbstractSharedSessionContract#disallowOutOfTransactionUpdateOperations to constants in FastSessionServices 2019-08-22 09:26:16 +01:00
Sanne Grinovero 5eaa1498df HHH-13565 Session opening efficiency: introduce FastSessionServices and design for shared services among sessions 2019-08-22 09:26:16 +01:00
Sanne Grinovero 408275ddec HHH-13594 ResourceRegistryStandardImpl#release could avoid allocating a capturing lambda 2019-08-20 19:12:21 +01:00
Sanne Grinovero 4661efa468 HHH-13591 Fixing formatting of previous patch 2019-08-20 08:44:51 +01:00
Carsten Hammer 19ac013eeb HHH-13591 Replaces simple uses of array iteration with a corresponding for-each loop 2019-08-20 08:44:39 +01:00
Ladislav Kulhanek e0f4047429 HHH-12993 Omit joining of superclass table when querying subclass only 2019-08-19 10:11:29 -05:00
Sanne Grinovero da847f4b57 HHH-13587 Avoid using deprecated PersistenceContext#getCollectionEntries in tests 2019-08-19 14:18:28 +01:00
Sanne Grinovero 7531ed793a HHH-13587 Make StatefulPersistenceContext#entitiesByUniqueKey lazily initialized as well 2019-08-19 14:18:28 +01:00
Sanne Grinovero 05b888e0c0 HHH-13587 Make StatefulPersistenceContext#arrayHolders lazily initialized as well 2019-08-19 14:18:28 +01:00
Sanne Grinovero dbbc24c2e1 HHH-13587 Make StatefulPersistenceContext#nonlazyCollections a lazily initialized field 2019-08-19 14:18:28 +01:00
Sanne Grinovero 690a8d5520 HHH-13587 Make StatefulPersistenceContext#collectionEntries also lazily initialized 2019-08-19 14:18:28 +01:00
Sanne Grinovero 3b30c60ce3 HHH-13587 Introduce SPI method PersistenceContext#getCollectionEntriesSize() 2019-08-19 14:18:28 +01:00
Sanne Grinovero 0d10174c23 HHH-13587 Make StatefulPersistenceContext#parentsByChild a lazily initialized IdentityHashMap 2019-08-19 14:18:28 +01:00
Sanne Grinovero 1101727a4f HHH-13587 StatefulPersistenceContext#unownedCollections was almost fully lazy already 2019-08-19 14:18:28 +01:00
Sanne Grinovero a11359524b HHH-13587 Lazily initialize ConcurrentReferenceHashMap proxiesByKey in StatefulPersistenceContext 2019-08-19 14:18:28 +01:00
Sanne Grinovero 0538b97d6a HHH-13587 Allocate StatefulPersistenceContext#naturalIdXrefDelegate lazily 2019-08-19 14:18:28 +01:00
Sanne Grinovero aae670b9b3 HHH-13587 Allocate StatefulPersistenceContext#nullAssociations lazily 2019-08-19 14:18:28 +01:00
Sanne Grinovero 5bbf417c52 HHH-13587 Allocate StatefulPersistenceContext#nullifiableEntityKeys lazily 2019-08-19 14:18:28 +01:00
Sanne Grinovero eb675e1c7f HHH-13587 Review formatting and logging style of StatefulPersistenceContext 2019-08-19 14:18:28 +01:00
Sanne Grinovero d065888140 HHH-13589 Avoid HashMap.values() when forEach is an easy replacement 2019-08-19 10:35:39 +01:00
Sanne Grinovero f49c97c0aa HHH-13589 ActionQueue review: code formatting 2019-08-19 10:35:39 +01:00
Sergey Ponomarev 0a3f62abbf HHH-13588 Add missed functions to MySQL Dialect: weight_string, to_base64, from_base64, regexp_replace, regexp_instr, regexp_substr 2019-08-19 09:54:22 +01:00
Sanne Grinovero 0a1213be1a HHH-13585 Duplicate resource release in PessimisticReadSelectLockingStrategy 2019-08-16 15:11:12 +01:00
Sanne Grinovero 0b64cef2b3 HHH-13579 Optimise ResourceRegistryStandardImpl to avoid heavy allocation of iterators 2019-08-16 12:31:19 +01:00
Sanne Grinovero 927f4c2ffc HHH-13584 Reduce ServiceRegistry lookups in LocalConnectionAccess in SessionFactory 2019-08-16 12:16:18 +01:00
Gail Badner 7c57047f4a HHH-13569 : Shorten table name that's too long for Oracle 2019-08-15 01:28:23 -07:00
Andrea Boriero 210aff098c HHH-13577 LockTest.testContendedPessimisticLock and StatementIsClosedAfterALockExceptionTest.testStatementIsClosed tests fail on Sybase
HHH-13577 : Re-enable LockTest for SybaseASE15Dialect
2019-08-14 18:43:09 -07:00
Andrea Boriero cfd7db36c6 HHH-13574 SybaseASE does not support PARTITION BY 2019-08-14 18:11:02 -07:00
Sanne Grinovero 6b489474f5 HHH-13576 Similar debugf and tracef issues found via grepping 2019-08-14 11:40:39 +01:00
Sanne Grinovero e110ab0030 HHH-13576 A couple more Logger mistakes in SessionImpl 2019-08-14 11:16:58 +01:00
Sanne Grinovero 7746227115 HHH-13576 Invoking tracef() or debugf() w/o an array of parameters actually allocates an empty Object[] 2019-08-14 11:16:58 +01:00
Legohuman 35037dac7b HHH-13259 Fix StackOverflowError in StringHelper
Before fix method org.hibernate.internal.util.StringHelper#replace
matched placeholders illegally in case when ordinal parameters list was
expanded. Ex. placeholder ?1 was matched with ?11, ?12, ?13 etc. For
queries with 2 or more IN clauses with different collections there were
a situation when ?1 from the first clause matched with already expanded
placeholders from the second collection. Each match led to recursive
call of replace method. If collection in second clause was very long
then StackOverflowError occurred.

Fix adds check of partial placeholder match for wholeWords mode which
is used in expanding list parameters. Partial matches are skipped
during replace.
2019-08-14 10:11:26 +01:00
Gail Badner fed93b0ae9 HHH-13573 : Test failure due to Sybase not supporting cascade delete on foreign key definitions 2019-08-14 00:25:49 -07:00
Gail Badner ce03ef96b9 HHH-13570 : Test failures due to Sybase not supporting UPDATE statement with WITH(NOWAIT) 2019-08-13 23:37:47 -07:00
Gail Badner 9988d677b9 HHH-13571 : Test failures due to cross joined table out of scope of a subsequent JOIN on Sybase 2019-08-13 23:16:45 -07:00
Gail Badner 937d4a3503 HHH-13569 : org.hibernate.test.annotations.embedded.EmbeddedTest failures on Sybase 2019-08-13 18:02:32 -07:00
Andrea Boriero 1a5b401d09 HHH-13554 QueryAndSQLTest.testNativeQueryWithFormulaAttributeWithoutAlias() fails on MariaDB 2019-08-13 14:37:49 -07:00
Andrea Boriero 2aee5a930d HHH-13556 Tests doing dynamic fetch scrolling a collection fail on DB2 2019-08-13 14:17:41 -07:00
Yoann Rodière f2f788c03d HHH-13551 Test the retrieval of a service when an "incompatible" classloader is provided 2019-08-13 19:08:39 +01:00
Yoann Rodière 5174fc28dc HHH-13551 Ignore ServiceConfigurationError thrown when accessing services of individual (non-aggregated) class loaders 2019-08-13 19:08:39 +01:00
Yoann Rodière 31fb14e0d9 HHH-13551 Restucture ClassPathAndModulePathAggregatedServiceLoader
This does not change the behavior of the class at all: it simply
restructures the code to allow for the changes in the next commits.
2019-08-13 19:08:39 +01:00
Gail Badner 3583074619 HHH-13558 : InstantTest, LocalDateTimeTest, OffsetDateTimeTest, ZonedDateTimeTest failing on Sybase for year 1600 2019-08-12 21:30:20 -07:00
Gail Badner 1b06b76e17 HHH-13557 : LocalTimeTest#writeThenNativeRead and OffsetTimeTest#writeThenNativeRead tests are failing on SQL Server 2019-08-12 19:39:53 -07:00
Sanne Grinovero 3e17be9832 HHH-13562 List of TransactionObserver for JdbcResourceLocalTransactionCoordinatorImpl should be lazily initialized 2019-08-12 18:50:19 +01:00
Sanne Grinovero 25ca80b1c5 HHH-13563 ResultSetReturnImpl is looking up JdbcServices on each construction 2019-08-12 18:50:19 +01:00
Sanne Grinovero d4e1b7ffbc HHH-13561 Do not retrieve the same ActionQueue multiple times 2019-08-12 16:54:58 +01:00
Gail Badner fdca4b2854 HHH-13559 : Skip failing tests on Sybase 2019-08-09 18:52:16 -07:00
Gail Badner cb51b1e838 HH-13550 : Fix Oracle failure for test added by HHH-13424 2019-08-09 17:28:42 -07:00
Gail Badner 2a018ffcb4 Revert "HHH-13557 : LocalTimeTest#writeThenNativeRead and OffsetTimeTest#writeThenNativeRead tests are failing on SQL Server"
This reverts commit c703bbede1.
2019-08-09 17:13:44 -07:00
Gail Badner c703bbede1 HHH-13557 : LocalTimeTest#writeThenNativeRead and OffsetTimeTest#writeThenNativeRead tests are failing on SQL Server 2019-08-09 17:09:00 -07:00
Gail Badner dbb94d8066 HHH-13555 : FetchGraphTest, MergeProxyTest and ProxyDeletionTest fail due to ConstraintViolationException 2019-08-09 14:56:18 -07:00
Gail Badner 2a154cb583 HHH-13554 : QueryAndSQLTest.testNativeQueryWithFormulaAttributeWithoutAlias() fails on Oracle, MSSQL, Sybase, DB2 2019-08-09 13:55:14 -07:00
Jonathan Bregler 6841012f78 HHH-13553 Fix test failures on SAP HANA
- Skip org.hibernate.test.annotations.query.QueryAndSQLTest.testNativeQueryWithFormulaAttributeWithoutAlias
- Update HANA JDBC driver to fix org.hibernate.test.type.LocalDateTimeTest
2019-08-09 17:58:17 +01:00
Sanne Grinovero 1d4d018dfa HHH-13552 Avoid retrieving the same Persister twice 2019-08-09 17:38:47 +01:00
Sanne Grinovero 80f8f0845c HHH-13552 Store the Collection Persister in a field of CollectionType 2019-08-09 17:38:36 +01:00
Gail Badner 6510c34e93 HHH-13550 : Fix Oracle failure for test added by HHH-13424 2019-08-08 22:34:09 -07:00
Sanne Grinovero 9b3c9e6f0f HHH-13548 Since SessionOwner is deprecated several fields in SessionImpl can be removed 2019-08-08 15:27:19 +01:00
Sanne Grinovero 0028c850b9 HHH-13549 StringHelper: use char rather than string when possible 2019-08-08 15:19:04 +01:00
Sanne Grinovero 85d4ffda14 HHH-13549 Simplify StringHelper#isQuoted 2019-08-08 15:19:04 +01:00
Sanne Grinovero de8d6d095f HHH-13549 StringHelper: Prefer generics over casting 2019-08-08 15:19:04 +01:00
Sanne Grinovero 0bf9bb1423 HHH-13549 Fix a couple typos 2019-08-08 15:19:04 +01:00
Sanne Grinovero a1498331aa HHH-13549 Remove dead code from StringHelper 2019-08-08 15:19:04 +01:00
Sanne Grinovero 7dd520d7e4 HHH-13512 Amend: Optimise StringHelper#isQuoted(String, Dialect) 2019-08-07 21:57:21 +01:00
Sanne Grinovero 87907e1edd HHH-13546 Fetch configuration details at initialization of StatisticsImpl 2019-08-07 11:56:33 +01:00
Sanne Grinovero 8460cd8796 HHH-13546 Make the sessionFactory field in StatisticsImpl required 2019-08-07 11:56:30 +01:00
Sanne Grinovero 41cab3bfce HHH-13527 Minimize captured state in lambdas used for Statistics 2019-08-07 09:10:22 +01:00
Sanne Grinovero b07e4b1ba3 HHH-13527 Fix contention in StatisticsImpl#getDomainDataRegionStatistics() 2019-08-07 09:10:22 +01:00
Sanne Grinovero 7cb828f4e7 HHH-13544 Restore logged warning on jdbc code mapping issue in NationalizedTypeMappings 2019-08-06 16:18:21 +01:00
Sanne Grinovero 8c228244de HHH-13541 ExceptionConverter instance in AbstractSharedSessionContract should be lazily initialized 2019-08-05 15:15:41 +01:00
Batbileg Dorj d9e16fe8ca HHH-13249 Introduce an option to Log slow queries instead of all queries 2019-08-05 10:51:09 +01:00
Sanne Grinovero 618d186cb2 HHH-13534 AbstractLoadPlanBasedLoader never needs a List of AfterLoadAction 2019-08-02 15:38:17 +01:00
Sanne Grinovero 343deb982f HHH-13531 Some more opportunities to reuse the constants pool in AliasConstantsHelperMore opportunities to reuse the int_ constant pools 2019-08-02 11:43:59 +01:00
Sanne Grinovero 33532c8998 HHH-13512 Remove some dead code 2019-08-01 15:51:42 +01:00
Sanne Grinovero ca444fc487 HHH-13512 Optimise StringHelper#isQuoted(String, Dialect) 2019-08-01 15:51:42 +01:00
Sanne Grinovero 7f6bf82fed HHH-13512 Avoid allocating an array in org.hibernate.internal.util.StringHelper#unquote(String[], Dialect) if there are no changes to be applied 2019-08-01 15:49:37 +01:00
Sanne Grinovero c35bce15f9 HHH-13521 Avoid excessive validation of enabled filters 2019-07-31 19:36:06 +01:00
Andrea Boriero ae176223b2 HHH-13528 Remove call to resourceRegistry.release(ResultSet resultSet, Statement statement) from AbstractLoadPlanBasedLoader#executeLoad() 2019-07-31 19:03:16 +01:00
Sanne Grinovero edb8093319 HHH-13529 Specifically optimise Dialect retrieval from DefaultEntityAliases 2019-07-31 18:54:08 +01:00
Sanne Grinovero 6e373f2e17 HHH-13529 Dot not access hot JdbcServices over ServiceRegistry 2019-07-31 18:54:08 +01:00
Sanne Grinovero 2c304a5e18 HHH-13528 Invoke afterStatements only at the end of releasing all statements for a batch 2019-07-31 12:19:23 +01:00
Sanne Grinovero 51c94121cb HHH-13526 Avoid repeated lookups for the same component 2019-07-31 12:19:23 +01:00
Sanne Grinovero 68b1b650e9 HHH-13526 Optimise HashMap lookup operations on ResourceRegistryStandardImpl xref 2019-07-31 12:19:23 +01:00
Gail Badner 7d54b59743 HHH-13466 : ClassCastException when changing a Collection association to a Set if @PreUpdate listener exists 2019-07-30 11:53:07 -07:00