Commit Graph

5569 Commits

Author SHA1 Message Date
Sanne Grinovero 6745dff121 HHH-14289 Detection of JDBC support for RefCursors was returning false even for Oracle JDBC drivers supporting it 2020-10-26 18:22:36 +00:00
Sanne Grinovero 3c36bbaf7a HHH-10715 Deleting more dead code 2020-10-25 21:45:09 +00:00
Sanne Grinovero f394194032 HHH-10715 Remove unused logger instance 2020-10-25 21:45:09 +00:00
Sanne Grinovero 20ae8d1ee0 HHH-10715 More static and final keywords missing 2020-10-25 21:45:09 +00:00
Sanne Grinovero 3d50f1895b HHH-10715 Missing null check after File.listFiles 2020-10-25 21:45:09 +00:00
Sanne Grinovero c44f1f96bf HHH-10715 Unreleased statement in IdTableHelper 2020-10-25 21:45:09 +00:00
Sanne Grinovero 8dda0616f5 HHH-10715 A couple of missing final keywords 2020-10-25 21:45:09 +00:00
Sanne Grinovero 9a4b8e098f HHH-10715 Dead code eliminated 2020-10-25 21:45:09 +00:00
Sanne Grinovero e1d217e10d HHH-10715 Dead code elimination 2020-10-25 21:45:08 +00:00
Sanne Grinovero 2358692797 HHH-10715 Make IdentifierProperty immutable 2020-10-25 21:45:08 +00:00
Sanne Grinovero 55eba6320b HHH-14282 StandardRefCursorSupport can rely on having JDK8 as baseline today 2020-10-25 21:45:08 +00:00
Sanne Grinovero c2eb653f36 HHH-14278 No longer use the AssertionFailure and StringHelper implementations from HCANN 2020-10-22 20:11:19 +01:00
Andrea Boriero 83578c116b HHH-14245 ClassCastException for Criteria Collection size selection 2020-10-22 13:56:00 +01:00
Andrea Boriero 398d5978b0 HHH-14245 Add test for issue 2020-10-22 13:55:42 +01:00
Scott Marlow bf1ea31cc4 HHH-14196 Add parsing of persistence.xml/orm.xml documents in the EE 9 namespace
Signed-off-by: Scott Marlow <smarlow@redhat.com>
2020-10-21 11:29:24 +01:00
Réda Housni Alaoui 54dae7394d HHH-13980 NullPointerException on AbstractEntityGraphVisitationStrategy.startingCollectionIndex 2020-10-20 13:16:13 +01:00
Sanne Grinovero 4e216f7ca7 HHH-14269 Confusing method names unableToObjectConnectionMetadata and unableToObjectConnectionToQueryMetadata 2020-10-20 13:11:48 +01:00
Daniel Wu 4f32f6e1de HHH-14268 Include stacktrace at WARN level in case of an error occurs when getting the connection metadata 2020-10-20 12:25:01 +01:00
Nathan Xu 06715dd9b6 HHH-14248 Other minor improvements to ActionQueue 2020-10-08 08:22:06 +01:00
Nathan Xu 79ccd9f225 HHH-14248 Refactor latestBatches from InsertActionSorter's field to temporary variable in its sort method 2020-10-08 08:22:00 +01:00
Andrea Boriero c01718f735 HHH-14249 MultiLineImport fails when script contains blank spaces or tabs at the end of the last sql statement 2020-10-07 08:55:23 +01:00
Andrea Boriero 79e6ffe483 HHH-14249 Add test for issue 2020-10-07 08:55:16 +01:00
Nathan Xu 74218d84c4 HHH-14227 fix testing failure on Oracle 2020-10-06 08:57:06 +01:00
Nathan Xu 64f8314ea1 HHH-14227 Add some more tests to cover order of batched insert executions 2020-10-05 13:42:30 +01:00
Nathan Xu c3d704c35b HHH-14227 Some additional typos and message improvements 2020-10-05 13:42:25 +01:00
Nathan Xu b7ae588768 HHH-14227 Insert statements are not ordered with entities that use inheritance and reference a subclass 2020-10-05 13:42:21 +01:00
Nathan Xu 18bbc9fd5e HHH-14231 Fix ClassCastException in ScrollableResultsImpl for primitive array value 2020-09-30 18:16:35 +01:00
Dmitry Gusev e752b8d191 HHH-14242 Micro optimisations of ActionQueue: redundant branch evaluation 2020-09-30 17:34:27 +01:00
Sanne Grinovero d959098ec7 HHH-14217 Minor optimisations in the highlighting formatter implementation 2020-09-30 17:01:07 +01:00
Sanne Grinovero 758de18531 HHH-14217 Code style 2020-09-30 17:01:02 +01:00
Gavin King 6f9b650bcb HHH-14217 Add syntax highlighting to the logged SQL
Using ANSI escape codes

Must be explicitly enabled using hibernate.highlight_sql
2020-09-30 17:00:57 +01:00
Gavin King c4ee4b1033 HHH-14203 DB2 requires the restrict keyword to drop the schema
The 'restrict' keyword is required on DB2.
2020-09-30 16:04:48 +01:00
Gavin King 94b819e70c HHH-14238 Option to include collection fields in the default fetch group
There is no good reason to lazily-instantiate a collection
wrapper, since that operation never requires access to the
database.

See discussion here:

   https://github.com/hibernate/hibernate-reactive/issues/374
2020-09-30 15:36:54 +01:00
Andrea Boriero 6eaa3f4415 HHH-14220 Fix failure with Oracle 2020-09-29 12:29:26 +01:00
Yanming Zhou 41e94dfab1 HHH-14205 Replace StringBuffer with StringBuilder
Avoid unnecessary synchronization
2020-09-29 11:35:59 +01:00
Nathan Xu f39089bf4e HHH-14197 Criteria API doubly-nested subquery generates invalid SQL - missing subquery root 2020-09-29 11:35:59 +01:00
Moritz Becker 69e485e5bd HHH-13201 - do not set empty text on collection join parent without queryable collection 2020-09-29 11:35:59 +01:00
Jan-Willem Gmelig Meyling a8a177886e HHH-14198 - Expose CompositeUserTypes through JPA Metamodel
Composite User Types work like regular Composite Types (like Embeddable) in HQL. However, because they cannot be represented in the JPA metamodel, libraries like [GraphQL for JPA](https://github.com/jcrygier/graphql-jpa) or [Blaze-Persistence](https://persistence.blazebit.com/) cannot fully utilize them. In order to make the composite property names available to these libraries, it would be nice to optionally expose these attributes as embedded attributes. This pull request aims to make that change and makes it configurable through a custom setting.

Composite User Types are a common solution for mapping composite interfaces. A common example is for example `Money` from the Java Money API (JSR-354), for which composite user types are implemented in [Jadira](http://jadira.sourceforge.net/usertype-userguide.html).

I know Composite User Types are currently not consiered in Hibernate 6.x. See also [this](https://hibernate.zulipchat.com/#narrow/stream/132094-hibernate-orm-dev/topic/CompositeUserType) Zulip thread. I am not sure if Hibernate 6.x will even have multi column types, which I presume would be a requirement to even introduce Composite User types back at some point. Usually Embeddables are a much easier, suitable mechanism for composite user types. But Embeddables are not always a viable alternative, because Embeddables require the type to be subclassed (as an interface cannot be mapped, and the type may not solely comprise fields that can be mapped to a simple basic type). To deal with this exact problem, `MonetaryAmounts` are still mapped as composite user type. There also have been suggestions to the JPA Spec to consider `AttributeConverters` for Embeddables for pracitcally the same purpose (which I think is going to be a mess of an implementation). See: https://github.com/eclipse-ee4j/jpa-api/issues/105

Anyways, regardless of whether this gets integrated in 5.x, I don't expect it to be integrated in 6.x unless we also reintroduce Composite User Types. I am willing to contribute Composite User Types for 6.x if people see benefit in it and think it can be done in the first place.
2020-09-29 11:35:59 +01:00
Jan-Willem Gmelig Meyling 69ddb4f782 HHH-14223 - Consider formulaTemplates in ID mapping for formula dereference 2020-09-29 11:35:59 +01:00
kubo 4c364a159a HHH-14223 - nullpointer exception on @JoinFormula with implicit join 2020-09-29 11:35:59 +01:00
Nathan Xu 14a72bcf8a HHH-13058 fix issue left join root cannot be replaced by correlated parent in subquery 2020-09-29 11:35:59 +01:00
Nathan Xu d0e22ddb20 HHH-14206 Auto-apply converter not applied to primitives 2020-09-29 11:35:59 +01:00
Christian Beikov 42cb22cae4 HHH-14212 Rename trigger entity to avoid keyword collision on Oracle 2020-09-29 11:35:59 +01:00
Nathan Xu a77f10cdab HHH-14212 fix Fetch Graph by simply returning false in TwoPhaseLoad#getOverridingEager() when Fetch Graph is being enforced 2020-09-29 11:35:59 +01:00
Nathan Xu ce70858df3 HHH-14212 revert back HHH-8776 (retaining testing case) 2020-09-29 11:35:59 +01:00
Nathan Xu c0a7b66273 HHH-14212 revert back HHH-14097 (retaining testing case) 2020-09-29 11:35:59 +01:00
Nathan Xu d1f9469cac HHH-14212 revert back HHH-14124 (retaining testing case) 2020-09-29 11:35:59 +01:00
Nathan Xu cadc3bf9dc HHH-14213 fix query numeric literal (integer representation) parsing exception message 2020-09-29 11:35:59 +01:00
Nathan Xu dd74a613cc HHH-14218 fix some typos in code comments 2020-09-29 11:35:59 +01:00
Christian Beikov 0db25441b0 HHH-14201 Fix test issues of NaturalIdDereferenceTest 2020-09-29 11:35:59 +01:00