Commit Graph

19350 Commits

Author SHA1 Message Date
Gavin King ec3be767e4 HHH-18553 handle case where managed entity was already removed
just short-circuit and abort the remove()

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King edf813083e HHH-18553 add a log message
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King 342afd28d4 improve/modernize some error messages
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King f7adc587b2 HHH-18553 add the test
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King 578023e538 HHH-18553 change thrown exception type
and cleanups in DefaultDeleteEventListener

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Andrea Boriero 7e4df3f805 HHH-18543 Skip GenericCompositeUserTypeTest for JVM OpenJ9 2024-09-02 10:00:18 +02:00
Gavin King 052eb0b78c cleanups to EventListenerGroup(Impl)
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 00:46:51 +02:00
Gavin King 48fc2ee66d cleanups to EntityEntryContext javadoc
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 00:46:51 +02:00
Gavin King 302dd29be1 move check for remove(detached) to SessionImpl for consistency/simplicity
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 00:46:51 +02:00
Gavin King f7db3f0005 misc cleanups
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 00:46:51 +02:00
Gavin King 09fa8ef76a HHH-18553 flush/evict when there is a managed instance while deleting the detached instance
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 00:46:51 +02:00
Gavin King 5c89079f2e consistently pass along session-level lock options
previously, these were respected by a random subset of session methods

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King 335f7bea9c avoid use of deprecated methods
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King f95182e736 more consistent error message between JPA and plain Hibernate
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King d7aa5f7a78 clean up ExceptionConverterImpl
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King dd16ed61f0 fix and clean up AbstractJPATest
clean up LockTest a little

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King f805bcec63 cleanups, especially to useless uses of JBoss logging
don't use loggers to generate exception messages

our convention for exception messages is NOT that they begin with HHH-XXXX

it's completely useless to have, like, five of them which do

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King 83cdeb81b6 HHH-18169 big cleanup of lock/refresh in SessionImpl and collaborators
this was a big mess with no consistency between different overloads of
the same-named method of Session, not to mention different methods

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King f45e3db4b0 HHH-18552 clean up inappropriate usages of TransientObjectException
and minor cleanups in StatefulPersistenceContext

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-31 17:46:11 +02:00
Gavin King 7422c18a94 HHH-18169 disallow refresh/lock for detached instance
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-31 17:46:11 +02:00
Gavin King 1d12dc0499 HHH-18547, HHH-17114 add default implementations to UserType
and deprecate the wrong-signature nullSafeGet() method

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-31 10:45:48 +02:00
Gavin King 519ffb7c78 some cleanup around SessionFactoryImplementor
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-31 00:22:00 +02:00
Gavin King 67bd785add more misc cleanups
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-31 00:22:00 +02:00
Gavin King ab12b436a2 push down some methods from SessionImplementor to EventSource
just as recommended by the @Deprecated tags added in H6

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-31 00:22:00 +02:00
Gavin King 681bd09b9d squash warnings in bean LifecycleStrategy stuff
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-30 21:42:15 +02:00
Gavin King 7b8c403df7 clean up ResultSetReturnImpl
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-30 21:42:15 +02:00
Gavin King 252bae18a1 clean up ConnectionProviderInitiator
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-30 21:42:15 +02:00
Gavin King a59f2ac6c8 some cleanup to DatasourceConnectionProviderImpl and multi-tenant version
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-30 20:01:58 +02:00
Gavin King 47c99d5a31 HHH-18538 fix startup logging for DatasourceConnectionProviderImpl and multi-tenant version
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-30 20:01:58 +02:00
Gavin King 8aa37a9d85 fix the typing in ReplicationMode
and improve readability in DefaultReplicateEventListener

even though they are deprecated

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-30 16:44:22 +02:00
Gavin King e351a00c19 fix a typo in previous commit
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-30 15:46:27 +02:00
Gavin King 72e42817e3 rationalize diverse ways to split strings
+ a couple of other code cleanups

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-30 13:40:34 +02:00
Gavin King 6787da71af HHH-18548 remove org.hibernate.annotations.QueryHints
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-30 11:14:08 +02:00
Kyrylo Merzlikin ad6f326090 HHH-18516 - Ignore @AttributeOverride for map key when checking type of map value 2024-08-30 09:41:49 +02:00
Tommy Svendsen d39ba13ee4 HHH-18518 Using StringHelper to split versionString instead of regex parsing 2024-08-30 09:32:39 +02:00
Tommy Svendsen 9ac9637daa HHH-18518 change implementation to capture MySQL custom versions better 2024-08-30 09:32:39 +02:00
Marco Belladelli e039bbc085 HHH-18541 Remove no longer needed hcann library definition 2024-08-29 13:40:54 -05:00
Marco Belladelli 00680b37fd HHH-18541 Migrate hibernate-envers from hcann to hibernate-models 2024-08-29 13:40:54 -05:00
Gavin King f1d7d86c2d add since to some @Deprecated operations and delete a couple
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 19:56:30 +02:00
Gavin King b53728f727 clean up QueryBinder a bit
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 19:56:30 +02:00
Yanming Zhou b1fcfdc54e HHH-18538 Improve database connection info from configured DataSource 2024-08-29 18:00:33 +02:00
Anilabha Baral 3159c80146 HHH-17310: Bug with names with digits in CamelCaseToUnderscoresNamingStrategy 2024-08-29 15:35:58 +02:00
Gavin King 850d266c52 HHH-18544 add disabled tests
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 15:30:39 +02:00
Gavin King dee06bfcb8 HHH-18539 remove the obsolete test for HHH-13891
we now just throw an exception when the setter is final
(there was some special case for load() which made no sense)

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 15:30:39 +02:00
Gavin King 64622858ab add some @Serial annotations as recommended by IntelliJ
improve a @Deprecated annotation

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 15:30:39 +02:00
Gavin King 11b11c02eb HHH-18540 remove an overload of lock() that's completely useless
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 15:30:39 +02:00
Gavin King d38971f75b HHH-18539 update tests after removal of load()
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 15:30:39 +02:00
Gavin King 6fe0553fb9 HHH-18540 remove Session.LockRequest
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 15:30:39 +02:00
Gavin King bbbaf511ec HHH-18539 remove Session.load()
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 15:30:39 +02:00
Yanming Zhou e407c53c86 Remove duplicated space before `when matched`
Running `org.hibernate.orm.test.stateless.UpsertTest`:

Before -> `merge into "UpsertTest$Record" as t using (select cast(? as bigint) id, cast(? as varchar) message) as s on (t.id=s.id) when not matched then insert (id, message) values (s.id, s.message)  when matched then update set message=s.message`
After  -> `merge into "UpsertTest$Record" as t using (select cast(? as bigint) id, cast(? as varchar) message) as s on (t.id=s.id) when not matched then insert (id, message) values (s.id, s.message) when matched then update set message=s.message`
2024-08-29 10:55:30 +02:00