Gavin King
d1fdb24fb8
minor cleanups to InFlightMetadataCollectorImpl
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-06 20:26:05 +02:00
Gavin King
a20fb5663d
major rework of Template + battery of new tests
...
I discovered that the over-complex support for ANSI trim() was
completely broken, unsurprisingly, given the complexity of the
implementation, and the absence of tests.
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-06 20:26:05 +02:00
Gavin King
a7c3e9a4e9
document explicitly that filter restrictions are written in SQL
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-06 20:26:05 +02:00
Gavin King
35f96d6e90
HHH-18570 reallow use of 'date' and 'time' as regular column names in parsed SQL
...
attempt to simplify the logic here
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-06 20:26:05 +02:00
Yanming Zhou
cb0268a618
Remove redundant methods `isBatchLoadable()`
...
The method implementation is identical to default method
2024-09-06 16:28:26 +02:00
Noel Trout
8a88ad7f59
HHH-18571 Fix bug and correctly report effective batching
2024-09-05 14:53:02 +02:00
Noel Trout
ff1d5fdb90
HHH-18571 Added test case demonstrating issue
2024-09-05 14:53:02 +02:00
Marco Belladelli
65d4613d72
Fix contributing remark about jira keys in commit messages
2024-09-05 11:41:55 +02:00
Gavin King
52a9de7cac
more @SuppressWarnings cleanups
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-05 10:46:52 +02:00
Gavin King
5748376edc
improve an error message
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-05 10:46:52 +02:00
Gavin King
56e0893b3a
some misc code cleanups
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-05 10:46:52 +02:00
Gavin King
0dd2defc89
@SuppressWarnings({"UnusedDeclaration"}) -> @SuppressWarnings("unused")
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-05 10:46:52 +02:00
Alex
9cf4bd8251
HHH-18560: added unittest
2024-09-05 10:36:36 +02:00
Alex
944ff41a65
HHH-18560: fix for invalid queries executed on DB2i AS/400 machine
2024-09-05 10:36:36 +02:00
Yanming Zhou
b870214ce9
Polishing `EntityVersionMappingImpl`
...
1. remove unused field `BasicAttributeMapping attributeMapping`
2. remove unused constructor parameter `MappingModelCreationProcess creationProcess`
2024-09-05 09:58:41 +02:00
Gavin King
7c30bbed2b
very minor code cleanups
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-04 22:22:58 +02:00
Vladimír Kuruc
dfe6a09f31
HHH-18561 Fix for Informix primary key constraint syntax error
2024-09-04 13:58:30 +02:00
Gavin King
eacbd78956
split out SessionFactorySettings and kill off MappingMetamodelImpl.close()
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-04 09:27:46 +02:00
Gavin King
4781c09d0d
migrate toward the new PersistenceUnitTransactionType from JPA 3.2
...
clean up the test base classes etc.
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-04 09:27:46 +02:00
Gavin King
437b59a57d
continue in attempt to clean up EMFBuilderImpl
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-03 19:05:12 +02:00
Vladimír Kuruc
226e85957b
HHH-18558 Fix for Informix UUID type support
2024-09-03 16:42:03 +02:00
Gavin King
1f48e8c41d
get rid of hangovers from HEM merge
...
make a rough start on cleaning up EntityManagerFactoryBuilderImpl
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-03 02:57:37 +02:00
Gavin King
049610b90d
split out SessionFactoryRegistryMessageLogger
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 19:22:41 +02:00
Gavin King
f6ff6fa0f7
code cleanup in Visitors
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King
763401a5c8
clean up the internal DefaultVisitor hierarchy
...
by removing two obsolete abstract superclasses
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King
9c75adcffc
cleanups in event listeners
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King
ec3be767e4
HHH-18553 handle case where managed entity was already removed
...
just short-circuit and abort the remove()
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King
edf813083e
HHH-18553 add a log message
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King
342afd28d4
improve/modernize some error messages
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King
f7adc587b2
HHH-18553 add the test
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King
578023e538
HHH-18553 change thrown exception type
...
and cleanups in DefaultDeleteEventListener
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Andrea Boriero
7e4df3f805
HHH-18543 Skip GenericCompositeUserTypeTest for JVM OpenJ9
2024-09-02 10:00:18 +02:00
Gavin King
052eb0b78c
cleanups to EventListenerGroup(Impl)
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 00:46:51 +02:00
Gavin King
48fc2ee66d
cleanups to EntityEntryContext javadoc
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 00:46:51 +02:00
Gavin King
302dd29be1
move check for remove(detached) to SessionImpl for consistency/simplicity
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 00:46:51 +02:00
Gavin King
f7db3f0005
misc cleanups
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 00:46:51 +02:00
Gavin King
09fa8ef76a
HHH-18553 flush/evict when there is a managed instance while deleting the detached instance
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 00:46:51 +02:00
Gavin King
5c89079f2e
consistently pass along session-level lock options
...
previously, these were respected by a random subset of session methods
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King
335f7bea9c
avoid use of deprecated methods
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King
f95182e736
more consistent error message between JPA and plain Hibernate
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King
d7aa5f7a78
clean up ExceptionConverterImpl
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King
dd16ed61f0
fix and clean up AbstractJPATest
...
clean up LockTest a little
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King
f805bcec63
cleanups, especially to useless uses of JBoss logging
...
don't use loggers to generate exception messages
our convention for exception messages is NOT that they begin with HHH-XXXX
it's completely useless to have, like, five of them which do
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King
83cdeb81b6
HHH-18169 big cleanup of lock/refresh in SessionImpl and collaborators
...
this was a big mess with no consistency between different overloads of
the same-named method of Session, not to mention different methods
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King
f45e3db4b0
HHH-18552 clean up inappropriate usages of TransientObjectException
...
and minor cleanups in StatefulPersistenceContext
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-31 17:46:11 +02:00
Gavin King
7422c18a94
HHH-18169 disallow refresh/lock for detached instance
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-31 17:46:11 +02:00
Gavin King
1d12dc0499
HHH-18547, HHH-17114 add default implementations to UserType
...
and deprecate the wrong-signature nullSafeGet() method
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-31 10:45:48 +02:00
Gavin King
519ffb7c78
some cleanup around SessionFactoryImplementor
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-31 00:22:00 +02:00
Gavin King
67bd785add
more misc cleanups
...
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-31 00:22:00 +02:00
Gavin King
ab12b436a2
push down some methods from SessionImplementor to EventSource
...
just as recommended by the @Deprecated tags added in H6
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-31 00:22:00 +02:00