Commit Graph

4677 Commits

Author SHA1 Message Date
Guillaume Smet 6a3ed33627 HHH-12857 Reuse the TypePool created in EnhancerImpl 2018-08-01 23:41:28 +02:00
Guillaume Smet dff202ded9 HHH-12857 Rewrite getDeclaredMethod() calls in static initializers
We rewrite them to run them as privileged blocks.
2018-08-01 23:41:06 +02:00
Guillaume Smet d95b36ffb6 HHH-12857 Avoid using a static ByteBuddy object
In the end, it does not change anything as the BytecodeProvider is still
static but it helps as a general cleanup for the following commits.
2018-08-01 18:01:20 +02:00
Guillaume Smet 349bd2649c HHH-12835 In the end, remove the assertion
It's not really compatible with batch loading, padding and a couple of
other corner cases.

And I don't think it has a lot of value by itself.
2018-08-01 16:07:49 +02:00
Andrea Boriero 725da274fd HHH-12849 - QuotedIdentifierTest fails with ORA-04043 on Oracle12c 2018-08-01 13:42:10 +02:00
Guillaume Smet bee200a84c HHH-12835 Fix an incorrect assertion in BatchFetchQueueHelper 2018-08-01 11:44:19 +02:00
Guillaume Smet d85831f543 HHH-12848 Restore the original Oracle LimitHandler
Oracle does not support using the SQL 2008 standard limit handler with
FOR UPDATE clauses. Thus we need to get back to the old limit handler.
2018-08-01 11:44:19 +02:00
Guillaume Smet e84aae23f0 HHH-10603 Avoid doing distinct and comparisons on byte arrays
They are stored as blobs starting with Oracle12cDialect and distinct and
comparisons on blobs are not supported.

Some tests were adapted, some are now skipped with Oracle12cDialect.
2018-08-01 11:43:32 +02:00
Guillaume Smet f43f668fb8 HHH-12730 Remove the deprecated methods previouly added
We don't need them as everything is now dealt with the transformer.
2018-08-01 11:32:02 +02:00
Guillaume Smet 0ada118635 HHH-12730 Add missing @Overrides 2018-08-01 11:32:02 +02:00
Guillaume Smet 6d7f7878e1 HHH-12730 Add deprecated constructors taking a SessionImplementor 2018-08-01 11:32:02 +02:00
Gail Badner 19388972dc HHH-12730 : User types built using 5.1 are not binary compatible with 5.3 2018-08-01 11:32:02 +02:00
Guillaume Smet d30e461fa1 HHH-12868 Fix NPE when loading entity with CacheConcurrencyStrategy.NONE 2018-07-31 14:52:15 +02:00
Sanne Grinovero d67278a6d2 HHH-12872 Reduce memory consumption of XSD schema validations 2018-07-31 12:48:10 +02:00
Andrea Boriero 7da105be0a HHH-12861 SchemaUpdate doesn't work with Sybase 2018-07-31 10:43:54 +01:00
Yoann Rodière dc42deafcb HHH-12492 Qualify references to columns from the target table in subqueries in DELETE/UPDATE queries
Don't try to duplicate the logic from
org.hibernate.hql.internal.ast.tree.FromElementType#toColumns(java.lang.String, java.lang.String, boolean, boolean)
in other classes, it's complex enough and already seems to handle all
the cases we might encounter.

In this specific case, we want the table name to be used to qualify
column names, because the target table doesn't have any alias (it's not
supported by every version of every RDBMS), and not qualifying columns
at all may lead to a confusing statement, in particular if tables
referenced in the subquery contain columns with the same name.
Since we use aliases for every other table in the query, referencing the
table should not lead to any conflict.
2018-07-27 15:02:55 +02:00
Yoann Rodière 48f59e891f HHH-12492 Test HQL Delete query with a subquery referencing the parent query's aliases 2018-07-27 15:02:48 +02:00
Martin Simka 036ea775da HHH-12863 SchemaUpdateTest should be skipped with Sybase 2018-07-27 14:55:49 +02:00
Jan-Willem Gmelig Meyling ea77c1fb4b HHH-12775 - Avoid join on natural id property access 2018-07-23 21:37:49 +02:00
Alvaro Esteban Pedraza b94b126141 HHH-12763 - Log which JtaPlatform implementation is used at startup on info level 2018-07-23 18:13:28 +02:00
Sanne Grinovero 5164d8b5b3 HHH-12841 DriverManagerConnectionProviderImpl: implement lazy Thread starting and fix visibility guarantees 2018-07-23 18:11:38 +02:00
Martin Simka 8be7aaf1be HHH-12851 ConverterTest fails with SQL Server depending on collation 2018-07-23 18:08:24 +02:00
Chris Cranford 333c190c82 HHH-12846 - Merge cascade of collection fails when orphan removal enabled with flush mode commit. 2018-07-23 11:00:55 -04:00
Martin Simka 89844c50de HHH-12844 Fix HbmWithIdentityTest with Oracle 2018-07-20 14:03:05 +02:00
Martin Simka c03cb7c2c8 HHH-12843 Fix CreateDeleteTest and FlushIdGenTest with Oracle 2018-07-20 13:22:23 +02:00
Sanne Grinovero 628b23faaa HHH-12840 Simplify implementation of LocalObjectUuidHelper 2018-07-20 10:33:21 +01:00
Martin Simka d08cc00628 HHH-12839 Fix EntityProxySerializationTest with Oracle 2018-07-20 11:29:11 +02:00
Guillaume Smet 5d350f19b4 HHH-7404 HHH-6776 Add tests to prevent regressions
The issues have apparently already been fixed but let's add the tests
present in the issue to prevent regressions.
2018-07-20 11:27:32 +02:00
Guillaume Smet cae8c12bbc HHH-12666 Only run the tests with H2
We don't need to run them with all our dialects: we just need to check
the mechanism works correctly.

At least TransactionExceptionHandlingTest fails with MariaDB so better
be safe.
2018-07-20 11:26:25 +02:00
Guillaume Smet 9fde3e08f0 HHH-12832 Make SchemaUpdateHaltOnErrorTest use the CustomRunner
Otherwise @SkipForDialect doesn't work.
2018-07-20 10:37:06 +02:00
Martin Simka 188760250a HHH-12838 Fix AndNationalizedTests with DB2
This is consecutive to the changes made in HHH-12753.
2018-07-20 10:25:46 +02:00
Gail Badner 44ecb96e2d HHH-12666 : Add test 2018-07-20 10:08:54 +02:00
Gail Badner a790096965 HHH-12666 : Add documentation 2018-07-20 10:08:34 +02:00
Gail Badner 9bb9e4bc38 HHH-12666 : Added more tests 2018-07-20 10:08:24 +02:00
Yoann Rodière 88fb16e5c9 HHH-12666 Test the current behavior of exception conversion on persist/save/merge/flush/etc.
Original tests by Gail Badner:
09aa6fbce2
2018-07-20 10:05:53 +02:00
Gail Badner 8ef0ca9a13 HHH-12666 : Add an option for restoring 5.1 native exception handling 2018-07-19 23:48:23 -07:00
Martin Simka 9286f9147b HHH-12833 Fix UniqueConstraintDropTest with DB2 2018-07-19 16:05:35 +02:00
Chris Cranford ad5f96c613 HHH-12753 - Remove an override that was not relevant to this jira. 2018-07-19 10:01:16 -04:00
Chris Cranford 005d5b7c74 HHH-12753 - Fix Nationalized CLOB test failures on DB2.
Force column read/write to use non-nationalized driver methods since the driver does
not implement the nationalized equivalents.
2018-07-19 09:54:13 -04:00
nikowitt c17a83cc0d HHH-12830 Improve error message when a method is called in a non active
transaction
2018-07-19 15:22:31 +02:00
Guillaume Smet cc600abf38 HHH-12832 Skip SchemaUpdateHaltOnErrorTest and al. with DB2
DB2 has no issue with reserved keywords in the CREATE TABLE clause so
let's skip these tests.

There is very little value to test them for every dialect anyway.
2018-07-19 15:04:27 +02:00
Guillaume Smet 2d318b76b2 HHH-12822 Skip "case when" tests requiring casts for DB2 2018-07-19 15:04:27 +02:00
Guillaume Smet de4c356189 HHH-12827 Define a numeric type as decimal for DB2
DB2 converts the numeric type to decimal and returns Types.DECIMAL for a
numeric. We change the type name used so that we have a match when
comparing the type names as last resort.
2018-07-19 15:04:27 +02:00
Guillaume Smet 19d31ea94d HHH-12815 Remove the zeroDateTimeBehavior option
It's useless for this test and it causes compatibility issues.
2018-07-19 13:26:52 +02:00
Guillaume Smet 51c67310f7 HHH-12791 Cache the Component type to avoid generating one proxy per call
While Javassist only generates one proxy as the name is stable,
ByteBuddy uses random names and thus generates a new proxy for every
call, leading to the generation of 18 different proxies for the other
test of the test class.

We can't do better than using a volatile/synchronized pattern as the
Component is not fully initialized in the constructor.

Maybe we could take the risk of admitting that the getType() method is
called at least once before we pass the element to a multi-threaded
environment but that's a bet I don't want to take alone.
2018-07-19 10:01:22 +02:00
Chris Cranford 3fe7d6e13e HHH-12826 - Persist cascade of collection fails when orphan removal enabled with flush mode commit. 2018-07-18 18:08:55 -04:00
Chris Cranford 15a59a1a19 HHH-12542 - Add necessary privileged action blocks for SecurityManager used on WildFly. 2018-07-18 17:18:51 +02:00
Martin Simka 8df12b7d0a HHH-12825 CriteriaHQLAlignmentTest.testCountReturnValues fails on databases that don't support tuple distinct counts because it expects wrong exception 2018-07-18 16:02:52 +02:00
Martin Simka 3f468facd0 HHH-12824 ASTParserLoadingTest.testComponentNullnessChecks fails with DB2 because it uses legacy-style query parameter 2018-07-18 15:59:39 +02:00
Martin Simka 393129fd1d HHH-12823 CompositeIdTest.testDistinctCountOfEntityWithCompositeId fails on databases that don't support tuple distinct counts because it expects wrong exception
The SQLGrammarException is now wrapped in a PersistenceException, we
should take that into account.
2018-07-18 14:38:07 +02:00
Guillaume Smet 92f4758889 HHH-12718 Add a comment about the true meaning of interceptorHandledDirtyCheck 2018-07-17 11:56:50 +02:00
Yoann Rodière 7134e8b968 HHH-12718 Avoid double negations in DefaultFlushEntityEventListener#dirtyCheck 2018-07-17 11:56:26 +02:00
Yoann Rodière 74aa03881a HHH-12718 Compute dirtiness using whatever method is appropriate after a flush event interception
We used to have a simpler version of the dirtyCheck() method after an
interception, but that's not enough.
2018-07-17 11:52:33 +02:00
Yoann Rodière a9f743069b HHH-12718 Test that dirtiness strategies are invoked a second time after a flush interceptor changes the entity state
Bytecode enhancement is harder to test, so I didn't add a test for that,
but since bytecode enhancement dirty checking is called exactly at the
same place, if one works, the other should, too.
2018-07-17 11:52:33 +02:00
Ulrich Bestfleisch c3c322d91b HHH-12718 - Entity changes in @PreUpdate callback are not persisted when lazy loading is active for more than one field 2018-07-17 11:52:03 +02:00
Yoann Rodière 523b29af04 HHH-12795 Remove duplicate code from SessionImpl
SessionImpl.initQueryFromNamedDefinition calls its super implementation
AbstractSharedSessionContract.initQueryFromNamedDefinition, which
already does a lot of the work performed in
SessionImpl.initQueryFromNamedDefinition.
The only difference is that SessionImpl uses hints to set values on the
query, whereas AbstractSharedSessionContract uses direct calls to
setters. But that should produce the same result, since setHint() just
delegates to the setters.

Only one thing was done in SessionImpl but not in
AbstractSharedSessionContract: lock mode handling.
I left it in SessionImpl since moving it to the superclass would also
affect other subclasses such as StatelessSession or OGM sessions, and I
certainly don't want to change any behavior without further
investigation.
2018-07-17 11:06:59 +02:00
Yoann Rodière a0e6d86052 HHH-12795 Test the flushMode attribute of @NamedQuery and @NamedNativeQuery 2018-07-17 11:06:59 +02:00
Yoann Rodière a9fdc1239a HHH-12795 Use the exact flush mode specified in @NamedQuery/@NamedNativeQuery when instantiating named queries
... instead of using an approximation in terms of JPA flush mode.
2018-07-17 11:06:59 +02:00
Guillaume Smet fa02d1c65f HHH-12811 Add @Target annotations to @CreationTimestamp and @UpdateTimestamp 2018-07-17 10:59:06 +02:00
Guillaume Smet 208e789bb1 HHH-12786 Improve the basic proxy interceptor
Apart from cosmetic changes, we were testing in the equals() method that the
instance == the proxied object which will always be true.

We should use the argument of the equals() method instead to do the
comparison.

And we can do the comparison on the instance, instead of requiring
passing the proxiedObject into the interceptor.
2018-07-16 17:34:48 +02:00
Guillaume Smet f722db367e HHH-12786 Only define the default constructor
We don't need the others, better not create them in the proxy.
2018-07-16 17:34:48 +02:00
Guillaume Smet ed53fd5346 HHH-12786 Allow to call methods when the interceptor is not set yet
Typically, if the constructor calls instrumented methods, the
interceptor is not defined yet and we get a NPE.
2018-07-16 17:34:48 +02:00
Guillaume Smet 3759f776ab HHH-12786 Properly indent the Bytebuddy DSL
It helps to understand what exactly these calls do.
2018-07-16 17:34:48 +02:00
Guillaume Smet f274db28f6 HHH-12804 Don't mock Map in CollectionBinderTest
Apparently, Mockito + ByteBuddy are unable to mock Map on JDK 11.

It might be solved in the future but there's no point in doing it so
let's avoid it.
2018-07-14 11:45:56 +02:00
Guillaume Smet 99b4f3c24a HHH-12801 Adjust the assertion to the new message generated by JDK 11 2018-07-14 11:43:16 +02:00
Guillaume Smet 5ec70ec22e HHH-12800 Use a class loading strategy suitable for the JDK used
The previously chosen strategy used misc.Unsafe which is not possible
anymore with JDK 11.
2018-07-14 11:43:16 +02:00
Gail Badner 9202a5a11d HHH-12802 : Fix test case to recover from exception properly 2018-07-13 15:51:39 -07:00
Gail Badner 926ad5a133 HHH-12802 : Hibernate does not thrown an exception when more than entity is loaded with the same ID 2018-07-13 14:45:11 -07:00
Gail Badner 2ef777e3fe HHH-12802 : test case 2018-07-13 14:43:53 -07:00
Vlad Mihalcea cf3622f64c HHH-12771 - Caused by: java.lang.UnsupportedOperationException: Cache provider [org.hibernate.cache.ehcache.internal.EhcacheRegionFactory@3271ec2a] does not support `transactional` access 2018-07-13 09:40:48 +03:00
Vlad Mihalcea 414a0dd75d HHH-12787 - SessionJdbcBatchTest hangs with DB2 2018-07-12 13:39:10 +03:00
Fabio Massimo Ercoli 3d1d1d2d98 HHH-12793 Upgrade Karaf, pax-exam and reenable the OSGi tests 2018-07-12 12:11:53 +02:00
Vlad Mihalcea 97b77bcde3 HHH-12768 - TimeAndTimestampTest fails with SQL Server and MYSQL 2018-07-11 18:17:15 +03:00
Yoann Rodière 479975dcb3 HHH-12695 Restore the getType method in ParameterRegistration
It was removed in 5.3.0.Beta1, but this breaks backward compatibility
with 5.1.
2018-07-11 09:56:43 +02:00
Yoann Rodière e9b8a80a99 HHH-12695 Rename org.hibernate.query.QueryParameter#getType to getHibernateType
Because it conflicts with the Class-returning getType method we want to
re-introduce in ParameterRegistration to restore backward compatibility.
2018-07-11 09:56:43 +02:00
Yoann Rodière 99c0c320bb HHH-12695 Add missing @Overrides in subclasses of javax.persistence.Parameter
Because we are in 2018 and Java 5 is now 14 years old.
2018-07-11 09:56:43 +02:00
Yoann Rodière 66d123be75 HHH-12695 Explicitly mark contracts as @Incubating, since a comment in QueryParameter implies they are in fact incubating
I did not mark ParameterRegistration as incubating, because it's a
pre-existing interface that we can't reasonably consider as incubating.

It's a bit odd to have a non-incubating contract (ParameterRegistration)
extend an incubating one (ProcedureParameter), though...
2018-07-11 09:56:43 +02:00
Guillaume Smet d32997a32d HHH-12784 Fix a regression in Javassist support 2018-07-11 09:52:31 +02:00
Gail Badner 579ee65fd3 HHH-12740 : Subselect fetching doesn't work when multiLoad was used 2018-07-10 18:37:21 -07:00
Robert Rettig 831bff13be HHH-8805 - [SchemaUpdate] javax.persistence.ForeignKey doesn't respect ConstraintMode.NO_CONSTRAINT 2018-07-10 13:09:07 +03:00
Yoann Rodière d4477ff5f8 HHH-7686 Add missing @Overrides in MapProxy 2018-07-09 16:27:31 +02:00
Yoann Rodière f3e62ea795 HHH-7686 Allow lazy loading outside of a transaction after dynamic map proxy deserialization if the proper settings were enabled
In theory, trying to deserialize MapLazyInitializer instances that were
serialized before this patch should still work, although using such
instances (i.e. trying to access any method on the proxy) would still
fail, just like it used to before this patch.
2018-07-09 16:27:31 +02:00
Yoann Rodière 1522efc0ad HHH-7686 Test dynamic map proxy serialization 2018-07-09 16:27:31 +02:00
Yoann Rodière 677f3dffba HHH-7686 Clarify and test initialization code in the writeReplace() method in proxies
If we copy the behavior of "traditional" (non-map) proxies to the
"dynamic-map" proxies, we'd better know what this behavior is and be
sure it works correctly.
2018-07-09 16:27:31 +02:00
Yoann Rodière 415f964a67 HHH-12720 Deprecate a useless constructor in AbstractSerializableProxy
A no-arg constructor is only necessary for superclasses of serializable
classes that are not themselves serializable. Here the class is
serializable, so the constructor is useless.
2018-07-09 16:27:31 +02:00
Yoann Rodière 41943fb920 HHH-12720 Allow lazy loading outside of a transaction after proxy deserialization if the proper settings were enabled 2018-07-09 16:27:31 +02:00
Yoann Rodière 4699c73243 HHH-12720 Test proxy serialization with hibernate.enable_lazy_load_no_trans = true 2018-07-09 16:27:31 +02:00
Guillaume Smet dcf1f66b8a HHH-12778 Register the cause when an exception occurs creating a proxy 2018-07-09 15:07:56 +02:00
Guillaume Smet daef4b7f08 Revert "HHH-12670 - Allows native SQL queries that take a given resultClass to map the result set to the required type"
This reverts commit 9fac6747ef.
2018-07-09 13:27:55 +02:00
Gail Badner 9b0c3ba600 HHH-12746 : Remove assertion that hashCodes are not equal from test 2018-07-04 15:55:30 -07:00
Gail Badner b4762fd52c Revert "HHH-12746 : CacheKeyImplementation objects with different entityOrRoleName and same id/tenantId have the same hashCode"
This reverts commit 220f41dc3b.
2018-07-04 15:52:11 -07:00
Gail Badner 8081aaec93 HHH-12729 : Correct Javadoc comments 2018-07-04 15:47:51 -07:00
Gail Badner c143e888d2 HHH-12729 : Binary and behavioral incompatibilities of org.hibernate.Query.getFirstResult(), setFirstResult(), getMaxResults(), setMaxResults() 2018-07-04 15:47:51 -07:00
Vlad Mihalcea 8fff54d6ee HHH-12769 - Rework LockTest#testContendedPessimisticLock so that it can work on Oracle without throwing exceptions 2018-07-04 21:00:11 +03:00
Vlad Mihalcea 6b3e4e6f56 HHH-12767 - Fix tests failing on Oracle 2018-07-04 17:49:42 +03:00
Guillaume Smet 88bfe7e66c HHH-12531 Make the legacy names public so that Infinispan can reuse them 2018-07-04 16:15:41 +02:00
Yoann Rodière 21eac287e9 HHH-12531 Default to using legacy region names when default query caches do not exist in the EhCache and JCache integrations 2018-07-04 10:03:23 +02:00
Yoann Rodière 63cc63b386 HHH-12531 Use short, simple names for the query result and update timestamps caching regions 2018-07-04 10:03:23 +02:00
Yoann Rodière 2649e1372c HHH-12649 Move the created cache warning to org.hibernate.cache.spi.SecondLevelCacheLogger 2018-07-04 09:44:50 +02:00
Guillaume Smet e7145cfe72 HHH-12727 Reduce the accesses to the statement -> result sets map 2018-07-04 09:37:44 +02:00
Guillaume Smet 4c22b52f80 HHH-12699 Resolve once and for all the method mapping in ResultSet proxy 2018-07-04 09:37:44 +02:00
Guillaume Smet 377b3d1fbe HHH-12699 Fix a typo 2018-07-04 09:37:44 +02:00
Yoann Rodière a19fc84320 HHH-12594 Properly share AliasResolutionContextImpl between EntityLoadQueryDetails instances
In particular, avoid contributing the aliases twice for the same
context: this would just trigger exceptions.
2018-07-04 09:22:09 +02:00
Sanne Grinovero 665110452e HHH-12692 Fixing style 2018-07-03 23:41:48 +01:00
Walter White 5f0024feae HHH-12692 SessionImpl#toString - add system identity hashcode
show the instance id in addition to whether the session is open or closed (when trace is not enabled).
2018-07-03 23:38:06 +01:00
Walter White a0633b84fe HHH-12692 SessionImpl#toString - remove overly verbose output
Is toString used, if so, when do we need to see the actionQueue or persistenceContext?
TRACE?
2018-07-03 23:37:50 +01:00
Andrea Boriero a9538ef710 HHH-12247 Verify JPA bootstrap errors are propagated 2018-07-03 19:52:37 +01:00
Sanne Grinovero 2253fad19d HHH-12247 Propagate bootstrapping exceptions rather than logging them at DEBUG level 2018-07-03 19:52:37 +01:00
Martin Simka d79d6267d0 [HHH-12765] don't use SQL Server reserved keyword in test 2018-07-03 19:28:39 +01:00
Yoann Rodière 212d8c01e5 HHH-11495 Update the javadoc of Metamodel#getImplementors to reflect the actual implementation
In particular, the actual implementations may not return all persisted
subtypes if the given type is persisted and "explicit polymorphism" is
enabled. So this really is more about HQL queries than about a class
hierarchy.
2018-07-03 19:00:13 +02:00
Yoann Rodière 600164869b HHH-11495 Add a missing @Override 2018-07-03 19:00:13 +02:00
Guillaume Smet 6c5e71fc40 HHH-11495 Only cache values if the class is mapped somehow 2018-07-03 19:00:13 +02:00
Guillaume Smet 7067b191b7 HHH-11495 Change the logic to be more efficient
We are optimistic about our chances to find the elements in the cache,
thus avoiding calling computeIfAbsent() if not necessary.

We only store in the cache the elements for which we have a proper
class, thus avoiding filling the cache with random values.
2018-07-03 19:00:13 +02:00
Guillaume Smet e17491a198 HHH-11495 Return a defensive copy of the array 2018-07-03 19:00:13 +02:00
Carlos Aristu 9684afda76 HHH-11495 Reduce criteria overhead by adding an implementors cache 2018-07-03 19:00:12 +02:00
Sanne Grinovero a67c6b9cd4 HHH-12760 Remove no longer needed EqualsHelper and cleanup some equality checks 2018-07-03 10:43:49 +01:00
Sanne Grinovero a3d39bbf96 HHH-12758 Arquillian JVM configuration for integration tests is ignoring system properties 2018-07-02 19:59:45 +01:00
Vlad Mihalcea 6f336b850c HHH-12749 - Avoid setting the isolation level to the same value in C3P0ConnectionProvider 2018-07-02 13:36:23 +03:00
Gail Badner 220f41dc3b HHH-12746 : CacheKeyImplementation objects with different entityOrRoleName and same id/tenantId have the same hashCode 2018-07-02 09:46:11 +02:00
Gail Badner f166b044a6 HHH-12746 : test case 2018-07-02 09:46:11 +02:00
Guillaume Smet 6b0ef0a5c4 HHH-12685 Fix a few warnings 2018-06-29 11:51:54 +02:00
Guillaume Smet 989ff9509f HHH-12685 Move the test where it should have been
Add an additional test for getParameters()
2018-06-29 11:51:54 +02:00
Andrea Boriero 673e4f7d01 HHH-12685 - Add tests 2018-06-29 11:51:54 +02:00
Andrea Boriero d64a9a9000 HHH-12685 - Fix CriteriaQueryTypeQueryAdapter parameters type validation issues 2018-06-29 11:51:54 +02:00
cristhiank d4a46fa93e HHH-12685 Add test case
Signed-off-by: cristhiank <calovi86@gmail.com>
2018-06-29 11:51:54 +02:00
Guillaume Smet 27409b27a3 HHH-12685 Convert the parameters to JPQL ones before calling isBound() 2018-06-29 11:51:54 +02:00
Vlad Mihalcea 07738c4d89 HHH-12738 - Session/EntityManager is closed in ForeignGenerator (JTA setup) 2018-06-29 11:09:00 +03:00
Gail Badner 3dcf69c687 HHH-12637 : Improvement to fix for HHH-12592
HHH-12637 : Rename/add new tests; remove sequences from IDs
2018-06-27 11:41:37 -07:00
Sanne Grinovero 06174d8433 HHH-12743 Cleanup some deprecated code from ProviderChecker 2018-06-27 13:42:12 +01:00
Sanne Grinovero 57ba794a62 HHH-12744 Remove no longer necessary jboss-deployment-structure.xml from integration tests 2018-06-27 13:42:12 +01:00
Guillaume Smet 09aa12496f HHH-12741 Add a comment to explain why we add the new keywords here 2018-06-27 13:28:47 +02:00
Yanming Zhou 0a4a609a42 HHH-12741 Register new reserved words added in MySQL 8.0
https://dev.mysql.com/doc/refman/8.0/en/keywords.html#keywords-new-8-0-A
2018-06-27 13:26:41 +02:00
Vlad Mihalcea b3e0d363bd HHH-12738 - Session/EntityManager is closed in ForeignGenerator (JTA setup)
Add test case proving the issue does not replicate for either RESOURCE_LOCAL or JTA transactions
2018-06-27 11:45:02 +03:00
Guillaume Smet 163cab99e2 HHH-12630 Keep the original starting exception and use it as a cause 2018-06-26 18:09:26 +02:00
Sanne Grinovero d0087948ef HHH-12640 Do not fully deprecate the WildFlyStandAloneJtaPlatform so to allow an explicit user choice 2018-06-26 15:44:17 +01:00
Scott Marlow 1a89a167b4 HHH-12640 deprecate WildFlyStandAloneJtaPlatform but still allow apps to reference it until we remove it in the future 2018-06-26 15:33:28 +01:00
Vlad Mihalcea 9fac6747ef HHH-12670 - Allows native SQL queries that take a given resultClass to map the result set to the required type 2018-06-26 15:13:25 +03:00
Florian Lopes 83e4384c3e HHH-12734 Add original exception when selected strategy could not be loaded 2018-06-26 13:28:41 +02:00
Vlad Mihalcea ed34a25769 HHH-12684 - Hibernate fails when mapping one-to-many collections by non-primary key
Fix indentation issue due to multi-line formatting
2018-06-26 13:49:42 +03:00
Vlad Mihalcea e6ea4828db HHH-12124 - The JPA Metamodel does not allow to retrieve the actual EmbeddableType since all instances are registered by the associated Java type 2018-06-26 13:16:25 +03:00
Vlad Mihalcea 84439af053 HHH-12684 - Hibernate fails when mapping one-to-many collections by non-primary key
Fix indentation issues
2018-06-26 13:14:16 +03:00
Guillaume Smet afbec8856c HHH-12724 Add javax.activation as a dependency
It is required by JAXB now that JDK 9 does not provide it anymore.
2018-06-26 12:01:06 +02:00
Peter Holvenstot 9728694386 HHH-12684 - Hibernate fails when mapping one-to-many collections by non-primary key 2018-06-26 12:38:09 +03:00
Vlad Mihalcea 9b106cf59c HHH-12688 - Duplicated Error Information Displayed in the Log
Restrict test case to H2 only
2018-06-26 12:37:28 +03:00
Vlad Mihalcea bcb71fcdd6 HHH-12688 - Duplicated Error Information Displayed in the Log 2018-06-26 11:12:29 +03:00
Vlad Mihalcea 62b2af760e HHH-12476 - NativeQuery with EntityGraphs cause a ClassCastException to be thrown 2018-06-26 10:20:28 +03:00
Yoann Rodière e5dc635a52 HHH-12594 Un-ignore BatchFetchBootstrapTest 2018-06-25 15:22:27 +02:00
Yoann Rodière e1bcfc12cf HHH-12594 Do not share AliasResolutionContextImpl between EntityLoadQueryDetails instances
Sharing it results in some tables being aliased twice for the same query
space, but with different aliases, resulting in exceptions.

Ideally we should try to generate the aliases once, and then share the
AliasResolutionContextImpl between EntityLoadQueryDetails instances,
but I'm really not comfortable enough with this code to make that kind
of changes.
2018-06-25 15:22:27 +02:00
Yoann Rodière 80360b1317 HHH-12594 Trim down BatchFetchBootstrapTest to the simplest possible configuration
So that we can investigate without unnecessary complexity getting in the
way.
2018-06-25 14:15:35 +02:00
Andrea Boriero 337646de13 HHH-12723 - Revert the changes applied by HHH-12585 to the DefaultFlushEntityEventListener#invokeInterceptor() method
This reverts commit 9b00aaf9a5.
2018-06-25 10:16:05 +01:00
Vlad Mihalcea a30635f14a HHH-12704 - MSSQL executing StoredProcedure on different DB using dot notation throws error
Make base class abstract
2018-06-22 14:30:48 +03:00
Vlad Mihalcea ffa5eb0e1d HHH-12704 - MSSQL executing StoredProcedure on different DB using dot notation throws error
Add test case proving the issue is caused by the SQL Server JDBC Driver
2018-06-22 14:27:52 +03:00
Vlad Mihalcea 8bbd22967e HHH-12710 - BaseCoreFunctionalTestCase opens an InputStream for mapping files but never closes it 2018-06-20 17:47:47 +03:00
Vlad Mihalcea ebca36a768 HHH-12654 - Throw MappingException if both @Inheritance and @AttributeOverride are used 2018-06-20 17:03:04 +03:00
Vlad Mihalcea d4861fed9f HHH-12700 - Missing property in sample code in documentation of bulk-id strategies 2018-06-18 16:55:36 +03:00
Sanne Grinovero fb473e6a60 Whitespace fixes required by checkstyle 2018-06-18 13:43:01 +01:00
Jan-Willem Gmelig Meyling 2211e61b04 HHH-12671 - Fix persisting generated properties on identity insert 2018-06-18 11:08:22 +03:00
Gail Badner 607e51617e HHH-12687 : ManyToOne associations in embeddable collection elements and composite IDs are always eagerly loaded 2018-06-15 15:12:50 -07:00
Gail Badner 35b908167e HHH-12651 : org.hibernate.Session.*Query(Ljava/lang/String) methods return different types in 5.1 and 5.3 2018-06-14 16:10:24 -07:00
Vlad Mihalcea 30fec4be79 HHH-12662 - JPQL queries fail when using the Java attribute type which has an associated AttributeConverter (only the DB column type works) 2018-06-14 09:29:18 +03:00
Vlad Mihalcea bff9e2e450 Fix test failing on MariaDB 2018-06-14 08:23:11 +03:00
Philippe Marschall 5089a818e2 HHH-12686 Replace EmptyIterator with emptyIterator 2018-06-13 14:20:19 +02:00
Philippe Marschall 4c52764c41 HHH-12604 Replace EqualsHelper.equals with Objects.equals 2018-06-13 14:20:19 +02:00
Jonathan Bregler c1eaf011ad HHH-12661 - Hibernate types (e.g. NumericBooleanType, YesNoType and any implementations of UserType) cannot bind value in StoredProcedureQuery
Fix tests for HANA, Oracle
2018-06-12 19:55:25 +03:00
cristhiank 22973c355a HHH-9403 - AssertionFailure: Fail to process type argument in a generic declaration 2018-06-11 08:04:05 +03:00
Vlad Mihalcea 566a23736d HHH-12561 - bulk_id_strategy does not work with globally_quoted_identifiers 2018-06-08 11:48:51 +03:00
Roland Kurucz b6a16a3678 HHH-12661 - Hibernate types (e.g. NumericBooleanType, YesNoType and any implementations of UserType) cannot bind value in StoredProcedureQuery 2018-06-08 11:26:38 +03:00
Chris Cranford 9ad030aee6 HHH-12668 - Fix JPA 2.2 xsds so they properly validate. 2018-06-07 13:44:06 -04:00
Chris Cranford 736c913f14 HHH-12396 - Fix problem with EnumType resolution on GlassFish platforms. 2018-06-04 13:05:33 -04:00
Guenther Demetz 7a4b38c6b7 HHH-12657 - Fix ClassCastException for cached natural-id entity with subclasses 2018-06-01 13:12:23 -04:00
Vlad Mihalcea b98c02c503 HHH-12609 - Cannot override constaints when using @AttributeOverride annotation
Add test cases to prove the issue does not replicate for @MappedSuperclass
2018-05-31 11:35:32 +03:00
Gail Badner dfecae09c5 HHH-11979 : Invalid SQL when force increment version of inherited entity 2018-05-30 18:22:27 -07:00
Gail Badner cc9b3eb183 HHH-11979 : test case 2018-05-30 18:21:14 -07:00
Guillaume Smet 6a04d7836c HHH-12633 Fix model definition in the test to be PostgreSQL compatible 2018-05-28 12:13:48 +02:00
Guillaume Smet de5bf278f6 HHH-12633 Fix dirty tracking when previous state is unfetched 2018-05-28 11:07:29 +02:00
Scott Marlow 0c52195a7d Revert "HHH-12620 Update JBossStandAloneJtaPlatform to use org.wildfly.transaction.client.* TM/UT"
This reverts commit c886111a79.
2018-05-27 10:10:33 -04:00
Scott Marlow 558cbdd97d HHH-12640 Update to JBossStandAloneJtaPlatform should be backward compatible attempting old names as well 2018-05-27 10:10:00 -04:00
Philippe Marschall 83c6b56fc8 HHH-12606 Container contents are never accessed
https://hibernate.atlassian.net/browse/HHH-12606
2018-05-25 22:21:52 +01:00
Philippe Marschall 3489f75e1d HHH-12605 Boxed variables never null
https://hibernate.atlassian.net/browse/HHH-12605
2018-05-25 22:05:09 +01:00
Gail Badner 01caa5f2b4 HHH-12592 - Fix merging detached enhanced entities with orphan-removal collections. 2018-05-25 17:32:38 +01:00
Gail Badner 6aa8301499 HHH-12592 : Add more tests 2018-05-25 17:32:38 +01:00
Gail Badner e1b08967d9 Revert "HHH-12592 - Fix merging detached enhanced entities with orphan-removal collections."
This reverts commit 4f119105f8.
2018-05-25 17:32:38 +01:00
Gail Badner c3c0cd550f HHH-12592 : add assertions to ensure that the detached and merged collection are not the same, which currently fails 2018-05-25 17:32:38 +01:00
Andrea Boriero 80bf92e32a HHH-12620 fix test dependencies 2018-05-25 11:56:00 -04:00
smarlow b34f615200 HHH-12620 some test dependencies 2018-05-25 11:56:00 -04:00
smarlow c886111a79 HHH-12620 Update JBossStandAloneJtaPlatform to use org.wildfly.transaction.client.* TM/UT 2018-05-25 11:56:00 -04:00
Guillaume Smet 38552103cc HHH-12634 Make EntityPrinter more permissive regarding the parameters passed 2018-05-25 09:47:28 -04:00
Guillaume Smet 9d4d0ae63b HHH-12584 In fact, we can provide a ReflectionOptimizer, just without the fast class instantiator
The fast class instantiator don't make sense for an abstract class or an
interface. I checked the code and we can indeed instantiate a
ReflectionOptimizer without a fast class instantiator.
2018-05-25 09:22:40 -04:00
Guillaume Smet 9a3aa99e83 HHH-12631 Fix invalid tracev calls in DefaultResolveNaturalIdEventListener 2018-05-25 13:13:59 +02:00
nikowitt b96af61566 HHH-12629 Make some methods protected in DefaultLoadListener
And some nice dead code removal.
2018-05-25 11:47:33 +01:00
Guillaume Smet 7c1a737c2a HHH-12627 Fix a debug level message 2018-05-25 10:31:21 +01:00
Gail Badner eee04e2e9a HHH-12599 : Add Javadoc indicating that region names do not include a prefix 2018-05-25 02:16:21 -07:00
Andrea Boriero 83283218dc HHH-12540 - Fix test 2018-05-25 01:04:04 +01:00
Chris Cranford 4f119105f8 HHH-12592 - Fix merging detached enhanced entities with orphan-removal collections. 2018-05-24 19:36:04 -04:00
Chris Cranford e7b338a109 HHH-12592 - Added test case. 2018-05-24 19:36:04 -04:00
Sanne Grinovero d5244de697 HHH-12626 Avoid high CPU contention by not allocating Session UUIDs eagerly 2018-05-24 21:14:59 +01:00
Guillaume Smet dc29e45af3 HHH-12621 Copy the query spaces when initializing a new NativeQueryImpl
This could ultimately lead to ConcurrentModificationException.
2018-05-24 19:42:29 +02:00
Steve Ebersole 9081aaf23b HHH-12622 - ignore markRollbackOnly on inactive transactions 2018-05-24 12:20:50 -05:00
Guillaume Smet 6be4001022 HHH-12579 Rename a variable for consistency with FieldReaderAppender 2018-05-24 17:06:55 +02:00
Guillaume Smet c0652a5359 HHH-12579 Use the field description with type variables resolved to cast the return value of the $$_hibernate_read_<property>() method 2018-05-24 17:06:55 +02:00