Commit Graph

10264 Commits

Author SHA1 Message Date
Gavin fb28443081 raft of minor code cleanups 2023-05-20 12:48:19 +02:00
Gavin 4247f7b155 allow instantiation via non-public constructor in HQL 2023-05-20 12:09:17 +02:00
Gavin f673441ab3 HHH-16647 allow unqualified use of query result type in HQL instantiation 2023-05-20 12:09:17 +02:00
Gavin addd88000c improve error reporting in DynamicInstantiation stuff 2023-05-20 12:09:17 +02:00
Gavin f38de6217b HHH-16601 log second-level cache RegionFactory initiation 2023-05-20 09:27:35 +02:00
Gavin 689414e347 improve some error messages
also, tell StringType know how to convert ints and longs
2023-05-19 15:53:25 +02:00
Gavin 47d8a63f16 HHH-16638 allow @DialectOverride for @SQLInsert and friends 2023-05-19 12:36:25 +02:00
Andrea Boriero 62c05eadb9 HHH-16570 Batch fetch with FetchMode JOIN might lead to multiplication in OneToMany items 2023-05-19 11:41:40 +02:00
Andrea Boriero 87fc258109 HHH-16570 Add test for issue 2023-05-19 11:41:40 +02:00
Jarkko Hyöty 6c8bb03c93 HHH-16433 Fix forced follow on locking with order by 2023-05-19 11:31:49 +02:00
Gavin eafe6fd79b HHH-16637 add methods to SessionFactory for handling lifecycle of StatelessSession
also clean up the related code
2023-05-19 09:44:47 +02:00
Steve Ebersole 2ce3eef67a HHH-16626 - JPA hint for Session (EntityManager) level tenant-id 2023-05-18 15:05:54 -05:00
Sanne Grinovero 71a335dbe6 HHH-16630 Refactor code to avoid frequent lookup of Service MutationExecutorService 2023-05-18 14:38:11 +02:00
Sanne Grinovero 1c8e6fe462 HHH-16631 Avoid unnecessary INFO logging at bootstrap 2023-05-18 14:38:11 +02:00
Sanne Grinovero 46d66ec141 HHH-16625 Introduce a compilation unit among tests to serve as reminder about Quarkus requirements 2023-05-18 14:38:11 +02:00
Sanne Grinovero 67488980e0 HHH-16625 Introduce a compilation unit among tests to serve as reminder about Quarkus requirements 2023-05-18 12:17:55 +02:00
Sanne Grinovero a8ce9f615c HHH-16625 Expose enough state from MetadataImpl to allow cloning it 2023-05-18 12:17:55 +02:00
Gavin c5d7030741 fix misleading parameter name 2023-05-18 11:26:59 +02:00
Andrea Boriero 97ab6f6879 HHH-16569 Batch fetch leads to some collections to be wrongly initialized with empty due to wrong generated SQL 2023-05-18 09:41:18 +02:00
Andrea Boriero f4617621c6 HHH-16569 Add test for issue 2023-05-18 09:41:18 +02:00
Andrea Boriero aa93bac008 HHH-16573 NPE with embeddable element collection with updateable = false 2023-05-18 09:36:19 +02:00
Yoann Rodière b6721961dd HHH-16573 Reproduce NPE with embeddable element collection with updateable = false 2023-05-18 09:36:19 +02:00
Marco Belladelli a8fe62ebb3 HHH-16472 Allow null discriminators for treated left/full joins 2023-05-17 18:04:40 +02:00
Marco Belladelli 04684da054 HHH-16472 Add test for issue 2023-05-17 18:04:40 +02:00
Christian Beikov bee160e9f2 HHH-16541 Don't report supportsSkipLocked() for Sybase 2023-05-17 16:22:31 +02:00
Gavin 8fcd3a1f54 get rid of a stack trace
because some amazing geniuses on stackoverflow who know
much more than me about Hibernate are obsessing over this
DEBUG-level log message
2023-05-17 13:00:30 +02:00
Gavin a2f1ee3364 squash two warnings 2023-05-17 12:59:33 +02:00
Christian Beikov 7823b48a3a HHH-16541 Fix Sybase test issues and HSQLDB hanging 2023-05-17 11:41:18 +02:00
Christian Beikov 031098a248 HHH-16541 Don't consider uninitialized LazyTableGroup for follow-on locking emulation. Fix lock mode upgrade for follow-on locking 2023-05-16 12:58:25 -05:00
Christian Beikov 93d0121b9a HHH-16541 - (Jakarta EE 10 Platform TCK) jpa/core/lock/query/Client.java#getResultListTest1 test regression 2023-05-16 12:58:25 -05:00
Steve Ebersole 8f94719152 HHH-16538 - Remove BeanValidationIntegrator#BV_CHECK_CLASS 2023-05-16 12:36:32 -05:00
Gavin d43e89cc4a HHH-16604 partial fix to 'ENUM member of collection'
fix for the case of a fully-qualified name, i.e. org.package.Enum.ENUM
2023-05-15 16:54:47 +02:00
Marco Belladelli f310338198 HHH-16576 Fix column aliases when rendering query part with table reference aliasing emulation 2023-05-15 16:06:04 +02:00
Zhihong Yu 8e21d0eb54 HHH-16542 - Correct typo in javadoc 2023-05-15 15:56:08 +02:00
Gavin 7f361157e4 HHH-16603, HHH-9763 fix some tests:
- test that @Cache on a subclass throws instead of WARNs
- remove @FailureExpected because HHH-9763 is now fixed
- correct test with wrong expectation for SharedCacheMode.UNSPECIFIED
- fix test that did not realize ImmmutableMutabilityPlan requires Serializable
2023-05-15 15:11:12 +02:00
Gavin f709763dab HHH-16603, HHH-9763 fix some issues with interpreting @Cache/@Cacheable annotations
1. throw instead of logging a WARN if @Cache is on a subclass.
   I just lost 1/2 an hour of my life due to this being a WARN.
   Logging WARNs is a terrible way to report user error!

2. Fix interpretation of SharedCacheMode.UNSPECIFIED
2023-05-15 15:11:12 +02:00
Christian Beikov eb6e848de3 HHH-15726 Fix treat disjunction handling and improve pushdown 2023-05-15 10:07:08 +02:00
Marco Belladelli 4e9a643346 Fix several tests failing on Oracle 11 and some others on older dbs 2023-05-15 09:27:35 +02:00
Gavin 88fea9a2cf improve code snippets in @Formula annotation jdoc 2023-05-14 12:37:24 +02:00
Gavin 10ea3bfd0a clean up a couple of imports 2023-05-14 11:21:10 +02:00
Gavin ac83f3e62f improve the aesthetics of some quite ugly log messages 2023-05-14 05:10:17 +02:00
Gavin a9d27e0fb2 fix incorrect javadoc of FlushMode 2023-05-13 21:23:01 +02:00
Gavin c648aee954 false is the default for getBoolean() 2023-05-13 21:23:01 +02:00
Gavin 7ff2c86c6e fix incorrect warning
the warning was printed even when it should not be (my fault)
2023-05-13 21:23:01 +02:00
Gavin cc3a17a972 fix two jdoc typos 2023-05-13 21:23:01 +02:00
Gavin 5fd441df70 improve discussion of foreign key mappings 2023-05-13 21:08:47 +02:00
Gavin bab2ae1782 mark parameter as deprecated since it is always null
leaving the parameter there seems to have been a mistake,
since it was _was_ removed from nullSafeSet()
2023-05-11 21:32:55 +02:00
Gavin c9a161ebee allow mappedBy to refer to a non-association property
(get rid of a totally unnecessary error)
2023-05-11 21:32:55 +02:00
Marco Belladelli 2eed461b9e HHH-16555 Correct source alias for embedded virtual table group joins on implicitly treated paths 2023-05-11 17:12:50 +02:00
Marco Belladelli 23a03fcb58 HHH-16555 Consider implicit treats when creating SqmJoinable's navigable path 2023-05-11 17:12:50 +02:00
Marco Belladelli 3bc4cac14f HHH-16555 Add test for issue 2023-05-11 17:12:50 +02:00
Marco Belladelli 725c292227 HHH-16491 Special handling for generic component properties 2023-05-11 15:51:09 +02:00
Marco Belladelli 5c2657d27c HHH-16491 Add test for issue 2023-05-11 15:51:09 +02:00
Marco Belladelli a7e3c8c7e9 HHH-16505 Avoid using the FK for left joins with condition 2023-05-11 15:10:14 +02:00
Marco Belladelli 6a659a7f32 HHH-16505 Add test for issue 2023-05-11 15:10:14 +02:00
Marco Belladelli dcbbd28926 HHH-16517 Don't clear map to allow prepared statement group reuse 2023-05-11 15:08:53 +02:00
Marco Belladelli 51b04ab011 HHH-16517 Add test for issue 2023-05-11 15:08:53 +02:00
Gavin d4ed740e38 ExceptionConverterImpl was swallowing some root cause exceptions 2023-05-11 14:16:18 +02:00
Steve Ebersole 90227d94bd HHH-16542 - Bad get/is handling with bytecode enhancement 2023-05-10 12:21:50 -05:00
Jan Schatteman 4f403a1815 HHH-16579 - Make the parseVersion() method in CockroachDialect.java public for Reactive 2023-05-10 19:01:25 +02:00
Davide D'Alto 21b7510c40 HHH-16579 Add constructor to CockroachDialect
Hibernate Reactive needs a constructor that parses the version
and doesn't run a query on the database.
2023-05-10 19:01:25 +02:00
Felix 1bb1ef93ee HHH-16580 - Some typos in org.hibernate.query.sqm 2023-05-10 18:22:11 +02:00
Gavin 36099deb2e make @Array apply to "implicit" columns 2023-05-10 15:51:34 +02:00
Jan Schatteman 1d1053ef08 HHH-16549 - Fix potential NPE in LoadQueryInfluencers
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-05-10 14:56:22 +02:00
Cedomir Igaly d933ad8594 HHH-16498 - Removing (when needed) trailing chars after stripping arguments 2023-05-10 10:05:05 +02:00
Cedomir Igaly 43f0ed4855 HHH-16498 - Test case showing the problem 2023-05-10 10:05:05 +02:00
Gavin 2d345fc04b add two new tests 2023-05-09 22:23:31 +02:00
Gavin 3da745e62b improve exception message 2023-05-09 22:23:31 +02:00
Gavin 6a72952057 add a missing @Override annotations 2023-05-09 22:23:31 +02:00
Jan Schatteman 2e97374660 HHH-16567 - Remove support for CockroachDB versions older than 22.1
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-05-09 20:40:05 +02:00
Christian Beikov 467399437c HHH-16423 Improve optional object handling for entity refreshing 2023-05-09 17:48:41 +02:00
Christian Beikov 8786ee8d03 HHH-16423 Switch to row cardinality state enum in LoaderSelectBuilder 2023-05-09 17:48:41 +02:00
Marco Belladelli be773182a9 HHH-16453 Small changes for bag fetchables in LoaderSelectBuilder 2023-05-09 17:48:41 +02:00
Marco Belladelli ab3986a533 HHH-16496 Add test for issue 2023-05-09 17:48:41 +02:00
Andrea Boriero 036784b257 HHH-16453 Loading an Entity with two eager collections, produces duplicates when one of the collection is a a bag 2023-05-09 17:48:41 +02:00
Andrea Boriero a16e505972 HHH-16423 Add tests for issue 2023-05-09 17:48:41 +02:00
Andrea Boriero d777389ee0 HHH-16447 Add test for issue 2023-05-09 17:48:41 +02:00
Andrea Boriero 8480eca26f HHH-16423 LazyInitializationException when calling em.refresh() on entity with lazy and eager children 2023-05-09 17:48:41 +02:00
Andrea Boriero 4c1fe081ba HHH-16423 Add test for issue 2023-05-09 17:48:41 +02:00
Cedomir Igaly 43b54be622 HHH-16551 - Re-designed test case similar to org.hibernate.orm.test.annotations.beanvalidation.DDLTest 2023-05-09 15:52:48 +02:00
Cedomir Igaly f469c769f6 HHH-16551 - Removed declared discriminator column length check 2023-05-09 15:52:48 +02:00
Cedomir Igaly bb49a26af9 HHH-16551 - If discriminator column type is CHAR, set length to 1 2023-05-09 15:52:48 +02:00
Cedomir Igaly eb630fb8e8 HHH-16551 - Test case demonstrating the bug 2023-05-09 15:52:48 +02:00
Jan Schatteman e12cfdb0b9 HHH-16515 - Add the org.hibernate.bytecode.spi package to nullness checking
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-05-08 20:23:21 +02:00
Jan Schatteman 924e3883d7 HHH-16515 - Add @nullable annotations to org.hibernate.action.spi
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-05-08 20:23:21 +02:00
Marco Belladelli 0d9ef5444a HHH-16425 Handle path sources in function return type resolvers 2023-05-08 15:47:36 +02:00
Marco Belladelli c5c237e70e HHH-16425 Add test for issue 2023-05-08 15:47:36 +02:00
Yoann Rodière e8008007de HHH-16546 Reduce verbosity of logs in a few edge cases 2023-05-08 15:46:11 +02:00
Andrea Boriero 726a3929ba HHH-16298 Failure merging a referenced entity 2023-05-08 15:43:08 +02:00
Davide D'Alto 4db54a931d HHH-16298 Add test for issue 2023-05-08 15:43:08 +02:00
Andrea Boriero f3cf7eb87d HHH-16469 Hibernate repeatedly issues identical SELECT queries to load an optional one-to-one association 2023-05-08 15:41:29 +02:00
Andrea Boriero 291626eb04 HHH-16469 Add test for issue 2023-05-08 15:41:29 +02:00
Maximilian Zellhofer 3a3882155f HHH-15393: fix for what looks like a copy & paste error
In the changes added to BasicCollectionPersister during HHH-15393, it looks as if generateUpdateRowOperation has maybe been copy-pasted from generateInsertRowOperation (which is perfectly fine), but when the custom sql update row operation is generated, the mutation details for the insert case rather than the ones for the update case are fetched. In case that this assumption is correct, there are some more in buildCustomSqlUpdateRowOperation, where getDeleteDetails() is used instead of getUpdateDetails().
2023-05-08 13:33:30 +02:00
Gavin 69f14f7a8b clean up two more enums 2023-05-07 20:18:07 +02:00
Gavin d5b6f769a4 HHH-16564 introduce BottomType 2023-05-07 11:29:28 +02:00
Gavin 8c1f9c4aad fix javadoc examples for @Array and @Struct 2023-05-07 11:29:28 +02:00
Gavin 5f49441fcc fix the tests for Oracle nested tables / arrays
I messed up
2023-05-07 02:17:28 +02:00
Gavin c922a10df2 HHH-16564 allow null in 'select new' argument list 2023-05-07 00:25:40 +02:00
Sanne Grinovero 7eacbfab3c HHH-16545 PersistenceUtil.MetadataCache needs to be threadsafe 2023-05-05 16:49:47 +03:00
Gavin 60d449e8da improve reporting of errors in named queries 2023-05-05 15:45:04 +03:00
Vincent Jansen e6fc35fa56 HHH-16556 Correct MS SQL 2016 deprecation version
Use version 13 as suggestion in the deprecation warning instead of 11 which is version MS SQL 2012
2023-05-05 13:03:56 +03:00
Gavin f2f19fecbf HHH-16125 add tests for Postgres enums and Oracle nested tables 2023-05-04 02:18:19 +03:00
Gavin 84a3233267 minor 2023-05-04 02:18:19 +03:00
Gavin d29fdbb8d5 remove unused import 2023-05-03 17:57:25 +03:00
Marco Belladelli c08af7469c HHH-16483 Delay copying of cte statement definitions to handle recursion 2023-05-03 16:46:20 +02:00
Marco Belladelli 5578109fe7 HHH-16483 Add test for issue 2023-05-03 16:46:20 +02:00
Gavin 8bd99231a5 clean up obsolete javadoc which confused a user 2023-05-03 16:34:20 +03:00
Gavin 7c22a537d1 HHH-16544 add support for Oracle nested tables
... and clean up of some stuff about array type initialization
2023-05-03 16:31:36 +03:00
Gavin 18ddbe15d6 cleanup Action enum 2023-05-02 18:05:41 +03:00
Gavin 2538c96cad cleanup two enums 2023-05-02 18:05:41 +03:00
Gavin a56942ce3b HHH-16535 introduce @Array annotation 2023-05-02 14:40:00 +03:00
Christian Beikov 53c7ef470a HHH-16533 Fix issues with jConnect driver related to temporal literals. Also improve truncation and casting SQL 2023-05-02 11:16:04 +02:00
Gavin 473984f1eb HHH-16125 introduce JdbcTypeConstructor instead of using JdbcTypes as their own factories
previously, there was a global instance of ArrayJdbcType registered by the Dialects, in
an inconsistent state, that acted as a factory for correctly-initialized instances
2023-05-02 10:47:28 +03:00
Gavin 16915cec63 HHH-16125 some small cleanups 2023-05-01 19:45:24 +02:00
Gavin aebd601845 HHH-16125 fix tests after adding Oracle array support 2023-05-01 17:37:19 +02:00
Gavin 07268d6568 HHH-16125 Oracle array support using varray types 2023-05-01 17:37:19 +02:00
Gavin 783e0772e6 fix rendering of in (...) lists
they are not function calls
2023-05-01 17:24:15 +03:00
Gavin 20b157000c HHH-16125 final cleanup of legacy enum converters stuff 2023-04-29 15:42:56 +02:00
Gavin 15d20113e7 HHH-16125 make tests work with postgres enums 2023-04-29 15:42:56 +02:00
Gavin c91cfdf2f1 HHH-16125 delete/fix a bunch of assertions that constrain implementation details
these are bad tests; they don't test observable behavior
2023-04-29 15:42:56 +02:00
Gavin 7514f8ad00 HHH-16125 introduce SqlTypes.NAMED_ENUM to make pg enums non-default
and clean up the impl of enums
2023-04-29 15:42:56 +02:00
Gavin bfb0fc6aba HHH-16125 fix the encoding of enum arrays to varbinary 2023-04-29 15:42:56 +02:00
Gavin 9c6c3eba81 HHH-16125 fix enums in embeddable types on postgres
fixes allowing correct serialization/deserialization of enums
includes workaround for StructJdbcType sending us a BigDecimal (need better solution)
2023-04-29 15:42:56 +02:00
Gavin db4a1bb6ef HHH-16125 remove DDL generation stuff from converters
it never belonged there!
2023-04-29 15:42:56 +02:00
Gavin d075093ebf HHH-16125 clean up legacy EnumType 2023-04-29 15:42:56 +02:00
Gavin febf39cc55 HHH-16125 complete redesign of how enum mappings work
- introduce SqlTypes.ENUM
- no more converters!
- finish of Potgres enum support
- disable BIND for enums in Criteria on PostgreSQL
  (PostgreSQL doesn't do the needed type conversion to the enum type)
2023-04-29 15:42:56 +02:00
Gavin d348ae2d8c workaround issue on postgres
this is probably a pre-existing hole in the logic,
not related really related to my work
2023-04-29 15:42:56 +02:00
Gavin fb9c007bdd HHH-16125 attempt to support PostgreSQL enum types 2023-04-29 15:42:56 +02:00
Gavin 1d7be9512a cleanups to InFlightMetadataCollector[Impl]
incl attempt to fix PK to FK copying
2023-04-29 15:42:56 +02:00
Gavin eefa1d9365 improve an error message 2023-04-29 11:29:39 +02:00
Gavin cebef1618d clean up of VarcharJdbcType 2023-04-29 09:05:23 +02:00
Gavin aa9bb26498 fix some javadoc 2023-04-29 09:05:23 +02:00
Gavin c36fdc4d06 fix bug in SQL formatting on MySQL 2023-04-29 08:50:11 +02:00
Jan Schatteman 784bc3463e Remove the unused o.h.stat.internal.CategorizedStatistics
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-04-28 21:08:54 +02:00
Jan Schatteman 4a8c51f14f HHH-16515 - Add o.h.pretty to nullness checking
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-04-28 14:10:32 +02:00
Karel Maesen 559fbe77ce HHH-15160 - Add SPATIAL FunctionParameterType
This enables us to validate spatial arguments in functions.
2023-04-28 13:50:36 +02:00
Marco Belladelli 0854cd9408
Fix test failing on H2 version < 2 2023-04-28 11:19:26 +02:00
Marco Belladelli f7eb58341e Fix in-array predicate rendering for cockroachdb 2023-04-28 11:11:26 +02:00
Christian Beikov 203f28e14c HHH-16528 Revert SybaseDialect NameQualifierSupport to CATALOG only and fix ansinull option for jconnect 2023-04-28 10:30:43 +02:00
Christian Beikov aad0c55f9b HHH-15833 Disable named parameters for jConnect JDBC driver 2023-04-28 10:30:43 +02:00
Marco Belladelli e60d2c878b HHH-16397 Allow fk optimization for correlated paths in subqueries 2023-04-28 10:26:00 +02:00
Marco Belladelli 3fe9ac9e32 HHH-16397 Add test for issue 2023-04-28 10:26:00 +02:00
Marco Belladelli c86c2b8300 HHH-16392 Add column qualifier support to Dialect 2023-04-28 10:22:26 +02:00
Marco Belladelli a9080f5f7d HHH-16392 Fix where clause in collection cleanup subqueries 2023-04-28 10:22:26 +02:00
Marco Belladelli c16cedf327 HHH-16392 Add test for issue 2023-04-28 10:22:26 +02:00
Jan Schatteman 5e4ca03260 Correction to remove the main method from H2Dialect
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-04-28 00:06:55 +02:00
Steve Ebersole c6389efb1b Add a Dialect report
Also added
* H2Dialect#getMinimumSupportedVersion
* DerbyDialect#getMinimumSupportedVersion
2023-04-27 11:28:35 -05:00
Christian Beikov 3ae07666ab HHH-16304 Default unquotedCaseStrategy to MIXED with Sybase 2023-04-27 09:54:17 +02:00
Christian Beikov 8ce01de60c Fix build issues with JDK17+ 2023-04-27 09:52:33 +02:00
Sven Strickroth f8379eefe1 HHH-16507 Use subsystem logger instead of hard-coded "SQL dialect"
Signed-off-by: Sven Strickroth <email@cs-ware.de>
2023-04-26 22:15:17 -05:00