Commit Graph

358 Commits

Author SHA1 Message Date
Gavin King bbf4619fcd remove deprecated Sort annotation 2021-03-25 18:54:41 +01:00
Andrea Boriero c3df793dbe HHH-14509 : Git master -> main branch renaming 2021-03-22 12:38:00 +01:00
Andrea Boriero 96d103215c Merge remote-tracking branch 'upstream/main' into wip/6.0 2021-03-22 12:26:31 +01:00
Steve Ebersole 725faa258f HHH-14509 : Git master -> main branch renaming 2021-03-19 10:59:03 -05:00
Andrea Boriero 6250942e7f Merge remote-tracking branch 'upstream/master' into wip/6.0 2021-03-05 11:18:14 +01:00
Vlad Mihalcea 17c5fab50e HHH-12338 - Incorrect metamodel for basic collections 2021-03-04 13:22:37 +01:00
Christian Beikov 6643e9f4bc Use java.lang.reflect.Type instead of java.lang.Class for JavaTypeDescriptor#getJavaType to support parameterized types 2021-02-23 12:22:54 +01:00
Andrea Boriero 6d124a7c6d Merge remote-tracking branch 'upstream/master' into wip/6.0 2021-01-14 11:34:06 +01:00
Jan Schatteman 9965551056 Remove left-over references to @ServiceRegistry.Setting (follow-up on commit 'Fix compilation errors' - 9770b49)
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2020-12-19 18:58:18 +01:00
Yoann Rodière 1acb6fea52 HHH-14371 Add --add-opens options required for Gradle plugin tests
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2020-12-14 14:02:18 +00:00
Christian Beikov d9446e7c77 Fix a few test issues, implement tuple emulation, group by support and support configuring criteria value handling mode 2020-12-08 11:27:27 +01:00
Andrea Boriero 1927d1aa33 Merge branch 'master' into wip/6.0 2020-11-17 12:40:43 +01:00
Steve Ebersole d4233ce6a8 fixed issue with project-template module wrt version 2020-11-11 08:26:34 -06:00
Yoann Rodière 9616e24c80 HHH-14315 Add optional support for toolchains to the Gradle build
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2020-11-10 11:02:08 +00:00
Steve Ebersole 29848c49db ORM + Gradle
HHH-14285 - project template
HHH-14286 - Gradle plugin
2020-10-28 16:09:42 -05:00
Andrea Boriero 9cf4edfbee Merge remote-tracking branch 'upstream/master' into wip/6.0 2020-10-26 08:14:01 +00:00
Sanne Grinovero 55cb66780d HHH-10715 Make static constant collections immutable in metamodel-generator 2020-10-25 21:33:11 +00:00
Sanne Grinovero 1de234ea93 HHH-10715 Unclear excepion handling 2020-10-25 21:33:06 +00:00
Sanne Grinovero b8ddc70ff1 HHH-10715 Dodgy comparison with Boolean instance 2020-10-25 21:33:04 +00:00
Andrea Boriero 8b938610cf Merge remote-tracking branch 'upstream/master' into wip/6.0_merge 2020-09-08 08:19:13 +01:00
Sanne Grinovero ea24abd757 HHH-9422 Metamodel Generator should close streams opened to persistence.xml and referenced mapping files 2020-09-02 12:22:25 +01:00
Andrea Boriero 4550c70d15 Merge remote-tracking branch 'upstream/master' into wip/6.0_merge_47 2020-07-20 10:50:17 +01:00
Yoann Rodière 12127b2272 HHH-14111 Ensure Groovy compilation tasks target the same JDK version as the rest of the project 2020-07-20 10:25:15 +02:00
Andrea Boriero 5c86c4a805 Merge remote-tracking branch 'upstream/master' into wip/6.0_merge_29 2020-04-09 07:37:11 +01:00
Andrea Boriero b897a36f2f Fix issue with generated pom missing project description 2020-04-06 18:21:11 +01:00
Yoann Rodière 9bb76a5cca HHH-13925 Upgrade hibernate-gradle-plugin to Gradle 6 2020-04-06 16:04:55 +02:00
Yoann Rodière aebf9d192f HHH-13925 Fix invalid javadoc syntax
This wasn't detected by checkstyle in Gradle 5, but it is now, and that
fails the build.
2020-04-06 16:04:55 +02:00
Steve Ebersole 40d0c8580e Merge remote-tracking branch 'upstream/master' into wip/6.0
- up to the point of upgrading Gradle version for wrapper to 5.6.3
2020-04-01 11:32:00 -05:00
Yoann Rodière 6921b02891 HHH-13685 Upgrade to Gradle 5.6.3 2020-04-01 09:53:13 -05:00
Andrea Boriero abe1e656f7 Merge remote-tracking branch 'upstream/master' into wip/6.0 2020-03-03 16:59:30 +00:00
Nathan Xu d8d8d6e112 Fix some obvious log or exception message issues 2020-02-28 08:12:45 +00:00
Christoph Dreis 1364929fe0 HHH-13870 - Add explaining comment 2020-02-19 12:20:42 -06:00
Christoph Dreis 5ea5bd12b0 HHH-13870 - Extract task action in Gradle plugin to fix up-to-date checks
Lambdas are not allowed and cause the compile task to be always out of date
2020-02-19 12:20:42 -06:00
Sam De Block a60a10f009 HHH-13390
Upgrade JPA MetaModel Generator (jpamodelgen) to support Gradle Incremental Compile
2020-01-29 20:23:11 +01:00
Chris Cranford 0e329bef5a HHH-12030 - Fix ClassCastException when Embeddable collection uses generic types 2019-11-14 13:56:56 +00:00
Steve Ebersole 57fba402b4 HHH-12858 - Persistence.createEntityManagerFactory(Map) should allow overwriting jta-data-source of persistence.xml 2019-09-25 15:12:25 -05:00
Steve Ebersole 4ff3c0b6e4 HHH-13130 - Provide Gradle-based bytecode enhancement as a task separate from the compileJava task 2019-09-25 12:28:28 -05:00
Steve Ebersole 5c9cf4d0d8 HHH-13130 - Provide Gradle-based bytecode enhancement as a task separate from the compileJava task 2019-09-18 12:05:39 -05:00
Sanne Grinovero 71fe4229b4 HHH-13133 Review logging usage in the MavenEnhancePlugin 2019-08-05 11:44:24 +01:00
skis ac7d7f4d6f HHH-13133 Changed the log level from info to debug to reduce the amount of logging under non-debug mode 2019-08-05 11:17:11 +01:00
Sebastian Nohn 7e71843a50 HHH-13463 - updated plexus-utils to 3.0.24 to avoid being vulnerable to CVE-2017-1000487 2019-06-27 20:06:02 +01:00
Sebastian Nohn c10832a740 HHH-13463 - updated plexus-utils to 3.0.24 to avoid being vulnerable to CVE-2017-1000487 2019-06-27 20:06:02 +01:00
Sergey Morgunov b9edc8d323 HHH-13145 - Generated metamodel class can't be compiled. 2018-12-17 13:54:55 +01:00
Guillaume Smet 190dedc8fc HHH-13128 Add missing jaxb-runtime dependency to metamodel generator
It's necessary for JDK 11 and we missed it when we added the
jaxb-runtime dependency to hibernate-core.
2018-11-29 11:20:44 +01:00
Guillaume Smet 5cdf56774d HHH-13097 Add a missing @Override 2018-11-13 23:52:55 +00:00
Henning Rohlfs aa441ddb12 HHH-13071 Use SourceSetOutput.getClassesDirs to prevent deprecation warnings during build when using the gradle plugin 2018-11-02 17:01:13 +01:00
Yoann Rodière 653b123276 HHH-12990 Remove unnecessary dependencies to JSR-250 when generating JAXB classes
It seems these dependencies were not necessary at all, even before the
previous patches.
2018-10-17 11:50:45 +02:00
Yoann Rodière e436b316da HHH-12990 Auto-detect the fqcn of the Generated annotation in jpamodelgen
It's "javax.annotation.Generated" in Java 8 and below, but
"javax.annotation.processing.Generated" in Java 9 and above.
2018-10-17 11:50:45 +02:00
Yoann Rodière 5fd97472b9 HHH-12946 Enable JAXB dependencies regardless of the JDK being used when building Hibernate ORM
Previously we would only add the dependency when building with JDK9+,
and we built all releases using JDK8.
This means the dependencies were useless, because they would never be
mentioned in the actual POMs published to users.
2018-10-17 11:43:03 +02:00
Yoann Rodière 2daa3811c6 HHH-12946 Remove unnecessary dependencies when building with JDK9+
We don't need to depend on JAXB's compiler (XJC) in our modules,
we just need the dependency in specific tasks during the build.
In particular we don't want users to transitively depend on XJC.

Also, we don't need an explicit dependency to JAXB in every module,
having one in hibernate-core is enough.
2018-10-17 11:43:03 +02:00
Yoann Rodière 51ab9f744d HHH-12946 Add explicit dependencies to JAXB APIs where relevant 2018-10-17 11:43:03 +02:00
Yoann Rodière 530ab1569e HHH-12946 Use constants for JAXB dependencies instead of inline strings
We may have to update these dependencies, let's make it easy.
2018-10-17 11:43:03 +02:00
Chris Cranford 0d79bc06cf HHH-12612 - Added embeddable TYPE_USE test case coverage. 2018-05-24 17:01:36 -04:00
Chris Cranford 5674eae3ae HHH-12612 - Use getQualifiedName rather than toString. 2018-05-24 17:01:36 -04:00
Chris Cranford 45a3b39c40 HHH-12612 - Fix JDK9 compatibility with TYPE_USE on collection fields. 2018-05-23 19:10:58 -04:00
Chris Cranford 895b0bb75d HHH-12011 HHH 12612 - Remove unnecessary output from test case. 2018-05-23 19:08:50 -04:00
Chris Cranford df6d44f646 HHH-12581 - Revert original fix for HHH-12338 to address regression. 2018-05-23 13:57:44 -04:00
Chris Cranford 3b05e92f40 HHH-12581 - Added test case. 2018-05-23 13:57:35 -04:00
Chris Cranford f8ffbd03ff HHH-12011 - Fix JDK9 compatibility with TYPE_USE on array primitive-based fields. 2018-05-13 15:33:37 -04:00
Chris Cranford 2ad6bf6724 HHH-12011 - Use TypeVisitor rather than string parsing for array types. 2018-05-11 12:51:37 -04:00
Chris Cranford 67096ce547 HHH-12011 - Fix metamodel generation with TYPE_USE targeted annotations. 2018-05-11 12:48:20 -04:00
Chris Cranford 7162bf26ec HHH-12011 - Added test case. 2018-05-11 12:48:20 -04:00
helloztt 7bcfa0d90d HHH-12338 - Incorrect metamodel for basic collections 2018-03-29 17:22:49 +03:00
Réda Housni Alaoui 884569f9cc HHH-12378 JDK 9 support: Remove javax.annotation.Generated usage 2018-03-13 23:17:40 +00:00
Andrea Boriero 9d335961b8 HHH-12246 - Gradle build fails with Java 9 2018-01-24 14:51:36 +00:00
Guillaume Smet 203575865c HHH-12245 Don't use the toString() of primitive type to detect the type
Better use getKind().
2018-01-24 08:56:49 +00:00
Steve Ebersole 6e25c30812 HHH-12190 - General tidying of Gradle scripts 2018-01-16 14:34:43 -06:00
Steve Ebersole d806eff912 HHH-12190 - General tidying of Gradle scripts 2018-01-16 14:34:43 -06:00
barreiro ec211b9699 HHH-12095 - do not fork execution of hibernate-maven-plugin as it causes compilation to run twice 2017-12-30 09:43:02 -06:00
Sanne Grinovero 5c43ad571f Fix checkstyle violations 2017-12-19 10:02:43 +00:00
Réda Housni Alaoui 4efac1369a HHH-10294 EntityGraph improvement: For each jpa attribute, generate also a String constant holding the attribute field name 2017-12-18 06:49:56 -06:00
Vlad Mihalcea 3ab1974d66 HHH-11871 - Skip Metamodel attribute generation for non-Java Bean property methods
Fix indentation issue
2017-11-06 17:02:35 +02:00
Vlad Mihalcea 164178330a HHH-12073 - Change BaseUnitTestCase Logger to protected 2017-11-01 19:04:07 +02:00
Bogdan Stirbat f20fe860c9 HHH-11871 - Skip Metamodel attribute generation for non-Java Bean property methods 2017-11-01 15:44:40 +02:00
Archie L. Cobbs c3f61c73dd HHH-12068 - Fix generated @SuppressWarnings to work for all compilers 2017-10-30 11:28:58 +02:00
Andrea Boriero ca368f85a6 HHH-11507 - Upgrade to Gradle 4.2 2017-09-21 15:07:29 +01:00
barreiro 50ee618f1e HHH-10930 - Add explicit dependency on JTA to the maven enhacer plugin 2017-01-31 13:15:19 +02:00
barreiro ffe62ac68b HHH-11242 - Basic test case for the maven plugin 2017-01-18 18:55:23 -06:00
Andrea Boriero 9976edc853 HHH-11183 - Mixed line endings in schema creation script 2016-12-14 17:56:18 +02:00
Rafael Winterhalter 159bc99a36 HHH-11321: fixes resolution of class names via build plugins 2016-12-14 08:55:01 +02:00
Craig Andrews 67f7be9a80 HHH-11288 - Execution project artifacts are always empty, so dependencies are never included
Get artifacts from project, not executionProject
2016-12-12 16:42:32 +02:00
Craig Andrews b0f6f77d74 HHH-11287 Include requiresDependencyResolution in the Maven plugin descriptor 2016-12-08 11:04:36 +02:00
Craig Andrews 5f8db1066d HHH-11282 - Support m2e/Eclipse integration in hibernate-enhance-maven-plugin 2016-12-07 20:36:18 -06:00
Rafael Winterhalter ba3359fe62 HHH-11152: Added BytecodeProvider based on Byte Buddy 2016-11-16 13:18:46 -06:00
johara dbfeb0bb5c HHH-11149 : Update plugin parameters for maven enhancer plugin 2016-10-04 12:52:50 -07:00
Bradley Hess 1be0a347c4 HHH-11004: Proper handling of array ElementCollection values in jpamodelgen 2016-08-09 13:15:32 +03:00
barreiro cdc69a475b HHH-10801 - Bytecode enhancement of @MappedSuperclass 2016-06-30 00:29:29 +02:00
Steve Ebersole 015be3df6e HHH-10864 - Allow ORM to be built with Java 9 2016-06-17 13:40:44 -05:00
Vlad Mihalcea 438e9643f9 HHH-10781 - Remove all slf4j dependencies 2016-05-31 16:06:57 +03:00
Gail Badner 5c1f4238c6 HHH-10579 : Add missing Manifest data 2016-03-02 18:07:16 -08:00
barreiro 1590ad145b HHH-10359 - Have consistent configuration of bytecode enhancement 2015-12-16 15:55:31 -06:00
barreiro 6828f5ee9b HHH-10354 - Rename 'field access' to 'extended enhancement' 2015-12-16 13:56:56 -06:00
barreiro 85c1fd7e9e HHH-10145 - [maven plugin] Transitive dependencies as well 2015-11-06 12:17:41 -06:00
barreiro 0ab716cca6 HHH-10146 - [gradle plugin] Create loading classloader after classes have been compiled 2015-11-06 12:17:41 -06:00
barreiro 22a4bdd502 HHH-10145 - [maven plugin] Include dependencies in loader classloader 2015-11-06 12:17:41 -06:00
Andrea Boriero c5b1cf94f3 HHH-10108 - Substituted checkstyle NewlineAtEndOfFile rule with rules used in OGM and fixed classes having more than a newline at the end of file 2015-09-22 18:11:43 +01:00
barreiro c2c69ca62c HHH-10077 - Fix SourceSet generation on gradle plugin 2015-09-03 08:50:04 -05:00
Kamil Szymanski 5f5e5f82c4 HHH-9593 Remove superfluous references to enclosing class
Conflicts:
	hibernate-core/src/main/java/org/hibernate/boot/registry/classloading/internal/ClassLoaderServiceImpl.java
	hibernate-core/src/main/java/org/hibernate/internal/SQLQueryImpl.java
	hibernate-core/src/main/java/org/hibernate/service/internal/JaxbProcessor.java
2015-08-26 15:55:45 -04:00
barreiro 6ac234eb01 HHH-9938 - field access parameter on gradle plugin 2015-07-29 09:26:26 -05:00
barreiro 088b15f451 HHH-9938 - field access parameter on maven enhacement plugin 2015-07-29 09:26:26 -05:00
barreiro d50258f424 HHH-9902 - fix gradle plugin 2015-07-08 04:44:38 +01:00
barreiro 6ef981edf8 HHH-9582 - maven enahcer plugin - fix local classloader 2015-07-08 02:46:04 +01:00
barreiro 3e72b84b0c HHH-9584 - maven enahcer plugin - add parameter to control behavior in case of error 2015-07-08 02:45:36 +01:00
Janario Oliveira 99c643febc Changed to keep generated classes in Context 2015-07-06 14:05:40 -05:00
barreiro ebb2ca19cd HHH-9813 - Improve Hibernate Enhance Maven Plugin 2015-05-27 12:03:22 -05:00
Steve Ebersole 1812bb2ef3 HHH-9809 - Improve Hibernate Gradle plugin 2015-05-21 00:24:56 -05:00
Steve Ebersole bd256e4783 HHH-9803 - Checkstyle fix ups - headers 2015-05-18 23:25:14 -05:00
Steve Ebersole 611f8a0e1c HHH-9803 - Checkstyle fix ups 2015-05-18 13:35:27 -05:00
Steve Ebersole 7308e14fed HHH-9803 - Checkstyle fix ups 2015-05-15 18:07:07 -05:00
barreiro 165f037bad HHH-8489 - bytecode enhancement: bi-directional associtation management
Closes #933
2015-05-07 13:10:58 -05:00
Gunnar Morling 7da8083388 HHH-9773 Adding missing package declarations 2015-05-07 11:50:20 -05:00
Steve Ebersole b790840b1e release 5.0.0.Beta2 2015-04-29 23:30:20 -05:00
Steve Ebersole f6980f3324 release 5.0.0.Beta2 2015-04-29 23:21:38 -05:00
10urshin 1361925bc7 HHH-9722
Changed all toLowerCase() and toUpperCase() to toLowerCase(Locale.ROOT),
toUpperCase(Locale.ROOT).
2015-04-17 15:53:24 -04:00
Steve Ebersole 650267077d HHH-9717 - Build script improvements - applied new standalone XJC and AnimalSniffer plugins 2015-04-10 11:58:22 -05:00
Steve Ebersole da06b22dee HHH-9717 - Build script improvements - applied new standalone XJC and AnimalSniffer plugins 2015-04-09 21:42:42 -05:00
barreiro 81d30aa037 HHH-9679 - Fix hibernate-enhance-maven-plugin buid script 2015-03-26 13:03:16 -05:00
Sanne Grinovero fd95ccb398 Include a new .gitignore file for tooling/hibernate-gradle-plugin as it's generated by Eclipse 2015-03-10 12:47:55 -04:00
Brett Meyer 7f17e50c72 HHH-9528 close InputStreams in jpamodelgen JpaDescriptorParser 2015-01-21 15:55:25 -05:00
Steve Ebersole 66ce8b7fb5 HHH-9466 - Drop metamodel package from source 2014-10-30 07:43:55 -05:00
Brett Meyer 4ef7cd9696 HHH-8777 corrected configurations used in pom plugin 2014-02-04 12:32:21 -05:00
Brett Meyer 518bda7a43 HHH-8777 dynamically generate descriptor dependencies
Conflicts:
	.gitignore
	hibernate-enhance-maven-plugin/src/main/resources/META-INF/maven/plugin.xml
	hibernate-enhance-maven-plugin/src/main/resources/META-INF/maven/plugin.xml.original
	tooling/hibernate-enhance-maven-plugin/src/main/resources/META-INF/maven/plugin.xml
2014-02-04 10:37:48 -05:00
Jeremy Whiting be4f2e186d HHH-8777 Completed implementation of Maven Enhance Plugin fixing issue
with
missing descriptor files. Mojo will automatically hook into build
lifecycle compile phase.

Conflicts:
	hibernate-enhance-maven-plugin/src/main/java/org/hibernate/bytecode/enhance/plugins/MavenEnhancePlugin.java
	settings.gradle
	tooling/hibernate-maven-plugin/hibernate-maven-plugin.gradle
2014-02-04 10:29:50 -05:00
Steve Ebersole 49ff975f7d HHH-8733 - General build cleanup 2013-12-02 22:11:00 -06:00
Steve Ebersole 055a750a53 HHH-8733 - General build cleanup 2013-12-02 20:57:57 -06:00
Steve Ebersole 7b69aaacb3 HHH-8741 - More checkstyle cleanups 2013-11-24 15:16:12 -06:00
Steve Ebersole cd590470c0 HHH-8741 - More checkstyle cleanups 2013-11-24 09:44:55 -06:00
Steve Ebersole 8ec17e68e7 HHH-8741 - More checkstyle cleanups 2013-11-23 00:06:06 -06:00
Steve Ebersole f9aa122b5e HHH-8733 - General build cleanup 2013-11-22 19:46:05 -06:00
Steve Ebersole 9e58a6de69 HHH-8694 - Move hibernate-maven-plugin and hibernate-gradle-plugin under tooling sub directory 2013-11-13 18:23:48 -06:00
Hardy Ferentschik faca8f5dd4 HHH-8483 Deleting obsolte settings.gralde in metamodel-generator project and making sure artifact is correctly named in root level settings file 2013-11-12 16:07:00 +01:00
Hardy Ferentschik 5618ea53e3 METAGEN-104 Making sure that determination of bean properties takes method name and return type into consideration 2013-11-11 20:08:17 +08:00
Hardy Ferentschik b98c45f904 METAGEN-104 Improving the way the test source directory is discovered 2013-11-11 20:08:17 +08:00
Hardy Ferentschik 052012776e HHH-8483 Deleting readme 2013-11-11 20:08:17 +08:00
Hardy Ferentschik 9cd2851373 HHH-8483 Changing the license header to LGPL 2013-11-11 20:08:17 +08:00
Hardy Ferentschik ff235d8c55 HHH-8433 Making sure javadocs and release tasks work 2013-11-11 20:08:17 +08:00
Hardy Ferentschik f25ea58750 HHH-8483 Moving metamodelgen documentation into documentation module 2013-11-11 20:08:17 +08:00
Hardy Ferentschik 7c8984469b HHH-8483 Getting metamodel-generator:build working 2013-11-11 20:08:16 +08:00
Hardy Ferentschik dfe7fab422 HHH-8483 Removing Gradle wrapper files, license.txt and changelog, since they are obsolete in the case of metamodel-generator being a sub-project of ORM 2013-11-11 20:08:16 +08:00
Hardy Ferentschik cc6f423373 METAGEN-103 Adding package-info files and trying to get the file ending right for the Shops 2013-11-11 20:08:16 +08:00
Hardy Ferentschik a12b9d7fd5 METAGEN-103 Fixing existing checkstyle violations 2013-11-11 20:08:16 +08:00
Hardy Ferentschik 5fbcad2e88 METAGEN-102 Upgrading Hibernate and JPA version 2013-11-11 20:08:16 +08:00
Hardy Ferentschik bf5b146191 METAGEN-98 Switching to JUnit, adding a custom test runner and the annotations @WithClasses, @WithMappingFiles, WithProcessorOptions and @IgnoreCompilationErrors 2013-11-11 20:08:16 +08:00
Hardy Ferentschik b51b230c57 METAGEN-101 Removing obsolete resources 2013-11-11 20:08:16 +08:00
Hardy Ferentschik 4ba59c529f METAGEN-101 Adding release tasks and removing pom.xml 2013-11-11 20:08:16 +08:00
Hardy Ferentschik fdbfbd03ec METAGEN-101 Adding checkstyle plugin and making some style fixes (not 100% Hibernate ORM compatible yet) 2013-11-11 20:08:15 +08:00
Hardy Ferentschik 0c6b601006 METAGEN-100 Exclude generated JAXB classes from JavaDocs 2013-11-11 20:08:15 +08:00
Hardy Ferentschik f68234727b METAGEN-101 Switching to Gradle
- Basic build config
- Adding Maven publish configuration
- Adding javadocs configuration
2013-11-11 20:08:15 +08:00
Hardy Ferentschik cac6d00342 METAGEN-91 Making sure that field annotated with @EmbeddedId gets added as singular attribute
Updating tests
2013-11-11 20:08:15 +08:00
Gunnar Morling 44aaa41339 METAGEN-85 Merging members for embeddedables and mapped superclasses lazily in order to consider only members with correct access type 2013-11-11 20:08:15 +08:00