bc2aa159a1
HHH-13373 ensure testing code correctness by local testing
2020-01-23 11:06:34 +00:00
7beb96a2ab
HHH-13373 add a testing case annotated with '@FailureExpected' annotation
2020-01-23 11:06:34 +00:00
8fb35947ff
HHH-13373 fix the bug that 'different sequence names in differnt dbs' breaks SequenceInformationExtractorMariaDBDatabaseImpl
2020-01-23 11:06:34 +00:00
4318349b4d
Fix String format in log
...
Use %s in the log string format, to avoid java.util.UnknownFormatConversionException: Conversion = ']' when enabling debug logs.
2020-01-22 10:54:19 +00:00
a2f7f59de4
HHH-13752 - Workaround id class issues like suggested by @jwgmeligmeyling
2020-01-21 15:24:43 +00:00
8f563fbd31
HHH-13752 - Test and fix deletion of entities with many-to-many assocations using non-primary keys for join table
2020-01-21 15:24:43 +00:00
fa952863cf
HHH-13823 Make it possible to reuse MergeContext in Hibernate RX.
...
Exposes the operations used by DefaultMergeEventListener
2020-01-21 13:00:26 +00:00
e5f8341aa4
HHH-13823 Add setters for two of the properties of EntityIdentityInsertAction
...
This is needed by hibernate-rx.
2020-01-21 13:00:23 +00:00
a0f9b1df00
HHH-13823 Make three private methods of SessionImpl visible to subclasses
2020-01-21 13:00:20 +00:00
a2f21e12a4
HHH-13823 Expose members of some SQL construction classes to subclasses
...
Allows hibernate-rx to more easily customize bind variable syntax.
2020-01-21 13:00:17 +00:00
12a8508e66
HHH-13823 Introduce an indirection when instantiating Insert/Update/Delete
...
This allows hibernate-rx to intervene in the rendering of bind variables
and use $n instead of ?
2020-01-21 13:00:15 +00:00
96faae93b1
HHH-13823 Always generate lowercase column aliases
...
This change is needed by hibernate-rx as a workaround for behavior
of the Postgres client. But anyway I think it's cleaner.
2020-01-21 13:00:12 +00:00
f59f0ce406
HHH-13823 Changes for Hibernate RX
...
Mostly just expose some operations and constructors that were previously inaccessible.
2020-01-21 13:00:02 +00:00
bf473681e4
HHH-13780 Allow NamedQuery to set hint QueryHints.PASS_DISTINCT_THROUGH
2020-01-21 10:09:17 +00:00
63a96e335e
HHH-13814 : Add tests
2020-01-15 15:41:48 -08:00
19b7921d1d
HHH-13806 CoreMessageLogger#unableToLoadCommand is not printing the cause of the error
2020-01-10 09:44:20 +00:00
0b938bd16b
HHH-13800 fix typo in AbstractGraphNode's verifyMutability() method
2020-01-06 16:38:35 -05:00
207c0d68be
HHH-13800 add a new found typo in org.hibernate.graph package's package-info.java
2020-01-06 16:01:13 -05:00
674b1dfd27
HHH-13800 Fix typos in Javadoc
2020-01-06 16:00:03 -05:00
00e9db2b8b
HHH-11958 Make EntityManager.find() support QueryHints.HINT_READONLY
2020-01-06 08:59:35 -06:00
49fe4f6494
HHH-13726 Extract 'prepareEventListeners' method out of SessionFactoryImpl
2020-01-06 07:30:19 -06:00
2663f8718e
HHH-13802 revert back @todo
2020-01-06 07:09:05 -06:00
3df0fcefa4
HHH-13802 fix javadoc warnings
2020-01-06 07:09:05 -06:00
6cf7fdaa97
HHH-13759 Small refactoring for PersistentAttributeTransformer
...
This change makes it easier to identify where we behave differently
because we are dealing with a class annotated with @MappedSuperclasss.
2019-12-13 14:56:51 +00:00
57a45dab19
HHH-13579 Add comment to InlineDirtyChekingHandler
2019-12-13 14:56:51 +00:00
0251473c87
HHH-13759 Additional test cases
2019-12-13 14:56:51 +00:00
0dea8319d4
HHH-13759 - Support for private Embedded in MappedSuperclass
2019-12-13 14:56:51 +00:00
c4dc9b0d25
HHH-13704 Make javassist a compile time dependency again
...
This commit revert some of the changes so that we can release it in a micro
without breaking application using Javassist.
In the next minor it should be reverted.
2019-12-13 11:29:40 +00:00
b8ffe851a7
HHH-13704 Format imports in EnhancerFileNotFoundTest
2019-12-12 13:50:01 +00:00
c3ccc65275
HHH-13704 Test Javassist is not on the classpath
2019-12-12 13:50:01 +00:00
39071a4d39
HHH-13704 Move EnhancerFileNotFoundTest
...
Tests requiring Javassist are now in a dedicated folder.
2019-12-12 10:33:32 +00:00
2e5892236b
HHH-13704 Remove Javassist from ClassFileArchiveEntryHandler
...
Use Jandex instead.
2019-12-12 10:33:32 +00:00
bac88eda53
HHH-13704 Typo: tupizer -> tuplizer
2019-12-12 10:33:32 +00:00
3a69b74894
HHH-13456 refactor ForeignGenerator to allow for the possibility of StatelessSession
2019-12-11 17:37:31 -06:00
8ce1404754
HHH-13644 fix the NPE by override ProcedureCallImpl's 'getResultStream()' method.
2019-12-11 17:23:22 -06:00
a6b924ffe7
HHH-9301 Fix test under PostgreSQL
2019-12-05 14:00:01 +00:00
963a516ea8
Revert "HHH-13752 - Test and fix deletion of entities with many-to-many assocations using non-primary keys for join table"
...
This reverts commit 58dd469e4c
2019-12-05 12:34:27 +00:00
e924d55fdf
Revert "HHH-13752 - Deletion of entities with many-to-many assocations using non-primary keys for join table"
...
This reverts commit 11455f3467
2019-12-05 12:34:10 +00:00
99868fb5f9
HHH-13355 : StaleStateException for updates to optional secondary table using saveOrUpdate
2019-12-05 12:05:24 +00:00
69dad5fda5
HHH-13355 : test case
2019-12-05 12:05:24 +00:00
6ce7831f77
HHH-13365 : Entities in joined subclass table are not inserted with batch size > 0 using sequence-identity ID generator
2019-12-05 11:36:04 +00:00
7d11649d99
HHH-13365 : Added test case
2019-12-05 11:36:04 +00:00
11455f3467
HHH-13752 - Deletion of entities with many-to-many assocations using non-primary keys for join table
2019-12-05 10:18:23 +00:00
58dd469e4c
HHH-13752 - Test and fix deletion of entities with many-to-many assocations using non-primary keys for join table
2019-12-05 10:05:16 +00:00
a133aff97f
HHH-13608 Fix failing tests
2019-12-05 09:25:32 +00:00
7daf67172a
HHH-13758 - Limit Handler for SQL server doesn't work with CTE queries with strings literals
2019-12-04 19:38:56 +00:00
42752ec89d
HHH-8901 Missing data cleanup in the new test
2019-12-04 17:44:02 +00:00
386d77129e
HHH-13761 Debug logging of JPA compliance settings didn't log the value of the settings
2019-12-04 16:56:23 +00:00
b9b15245b7
HHH-8901 Some very minor string handling optimisations
2019-12-04 16:37:34 +00:00
ab9ae43185
HHH-8901 replace "in ()" SQL with "in (null)" in QueryParameterBindingsImpl
2019-12-04 16:05:10 +00:00
4e449dfafa
HHH-13764 Test behaviour doesn't change when @Embedded is on the getter
2019-12-03 20:40:53 +00:00
4fb813f39c
HHH-13764 Include getter annotations when required for the enhancements
2019-12-03 20:09:09 +00:00
f08abf3628
HHH-13608 Oracle8iDialect should use CASE_INSENSITIVE pattern matching when checking the statement type
2019-11-25 15:41:33 +00:00
21e79125e6
HHH-9301 - Support select variable refs in group by for DBMS dialects that support it
...
While not strictly compliant with the SQL specification, the MySQL, PostgreSQL and H2 support the use of select aliases in the GROUP BY clause. An obvious benefit is that produced SQL queries will be easier to read, because complex select expressions from aggregrate queries will have to be included in the group by clause as well. These can now simply reference the aliases of the respective columns for the tuple element. However, there is also a functional difference. For function invocations that have parameterized arguments, the query optimizer can't guarantee the that the function result between the selection projection and grouping process are equal. This results in an error because a value is projected which is not grouped by. An example where this for example becomes relevant, is when parameterizing TimeScaleDB's [`time_bucket_gapfill()`](https://docs.timescale.com/latest/api#time_bucket_gapfill-examples ) function.
For example, using `time_bucket_gapfill()` one might want to produce a criteria query that produces the following SQL:
```sql
SELECT
time_bucket_gapfill(?, time, ?, ?) AS ts,
avg(tg) as tg
FROM iaqmeasurement
GROUP BY ts
ORDER BY ts;
```
When the alias is not used as grouping value, the query will yield an error:
```sql
SELECT
time_bucket_gapfill(?, time, ?, ?) AS ts,
avg(tg) as tg
FROM iaqmeasurement
GROUP BY time_bucket_gapfill(?, time, ?, ?)
ORDER BY ts;
```
Of course the parameter values can just be stored in a CTE as well, but I think we should consider support for variable refs in group by for DBMS dialects that support it. This pull request implements the feature equivalently to how its currently done for order by clauses, and only enables the feature for known supported dialects (H2, PostgreSQL and MySQL - based on [https://stackoverflow.com/a/3841804/2104280 ](https://stackoverflow.com/a/3841804/2104280 )).
Jira: https://hibernate.atlassian.net/browse/HHH-9301
Co-authored-by: Sayra Ranjha <S.S.Ranjha@student.tudelft.nl>
2019-11-25 14:57:17 +00:00
bde7ca974b
HHH-12895 - Extra LEFT JOIN generated with @ManyToOne and @JoinTable when projecting
...
on main entity id
2019-11-25 14:27:57 +00:00
473566c50d
HHH-13742 - Added additional tests
2019-11-25 12:15:21 +00:00
325239353e
HHH-13742 - Preliminary fix for HHH-13742
2019-11-21 16:28:49 +01:00
8089d8c575
HHH-13742 - Missing from clause with joined inheritance property in association subquery
2019-11-21 15:30:41 +01:00
be23e167af
HHH-13722 Introducing a test case
2019-11-18 14:59:56 +00:00
7331a58d5e
HHH-13722 ArrayStoreException in Constraint.generateName
2019-11-18 14:55:37 +00:00
76308e8a3e
HHH-13737 : Correct log message and fix checkstyle failure
2019-11-14 18:22:01 -08:00
7d8549d8aa
HHH-13737 : Add debug logging
2019-11-14 18:22:01 -08:00
c02011ef40
HHH-13737 : Add test case for HHH-13433
2019-11-14 18:22:01 -08:00
841368175f
HHH-13614 Allow the IntegratorProvider to be supplied via its FQN in the JPA persistence.xml
2019-11-14 13:35:09 +00:00
52f9a36a6d
HHH-13614 Allow the IntegratorProvider to be supplied via its FQN in the JPA persistence.xml
2019-11-14 13:35:09 +00:00
f5fb84cfe2
HHH-13705 Enhancement as Proxy with inline dirty checking - flush of an @ManyToOne with an Embedded value having not null properties causes PropertyValueException
2019-11-14 11:31:11 +00:00
842a155615
HHH-13705 Add test for issue
...
HHH-13705 Add test for issue
2019-11-14 11:31:11 +00:00
47c8a89390
HHH-13712 - Test and fix for missing superclass table joins when joining superclass associations
2019-11-14 11:29:01 +00:00
9ddab37748
HHH-13727 H2 database with DATABASE_TO_UPPER=false throws org.h2.jdbc.JdbcSQLSyntaxErrorException: Table sequences not found
2019-11-13 13:57:48 +00:00
0c0248d448
Include the WITH clause AST in the FromElement so that column references can be analyzed
2019-11-12 17:47:48 +00:00
05e6a41e5f
HHH-13670 - Reproducer Missing from clause in query with joined inheritance, regression in 5.4.5
2019-11-12 17:47:48 +00:00
164e1fc7cc
HHH-13687 TenantSchemaResolver not called in integration test after upgrade from
2019-11-12 17:40:59 +00:00
66515a2e4e
HHH-13723 Hint sizing of ArrayList in ResultSetProcessingContextImpl
2019-11-11 10:59:14 +00:00
a682a7d19c
HHH-13433 EntityManager.find() should only check for roll-back-only condition if there is an active JTA transaction, otherwise ORM should throw throw convert( e, lockOptions )
2019-11-07 20:33:25 -08:00
0c1df5fc0d
HHH-13698 : Hibernate does not recognize MySQL 8 error code 3572 as PessimisticLockException
2019-11-01 10:58:46 -07:00
a7f017c3dc
HHH-13307 : On release of batch it still contained JDBC statements using JTA
2019-11-01 10:58:13 -07:00
1241d35a50
HHH-13307 : Added test
2019-11-01 10:58:13 -07:00
cec7329214
HHH-13700 Configuration property CONNECTION_PROVIDER_DISABLES_AUTOCOMMIT should not be passed to the JDBC connection properties
2019-10-31 23:43:38 +00:00
2bcb1b0a6d
HHH-13654 Reorganize fields and add some comments about this work
2019-10-30 12:27:59 +00:00
f89bf35106
HHH-13654 Make AbstractFlushingEventListener#entitiesByKey also lazily initialized
2019-10-30 12:27:59 +00:00
6034ece731
HHH-13654 Refactor references to StatefulPersistenceContext#batchFetchQueue
2019-10-30 12:27:55 +00:00
500819e169
HHH-13654 Defer initialization of StatefulPersistenceContext#entitySnapshotsByKey
2019-10-30 12:27:53 +00:00
f4bf11331b
HHH-13654 Defer initialization of StatefulPersistenceContext#collectionsByKey
2019-10-30 12:27:48 +00:00
1dd787eaa1
HHH-13446 - Validate mapped-by values got from annotations in bytecode enhancers
2019-10-26 17:53:56 +01:00
b4a8052a15
HHH-13695 DDL export forgets to close a Statement
2019-10-25 16:47:52 +01:00
e5539cc36c
HHH-13651 Adding a regression test for the issue
2019-10-24 11:25:17 +01:00
a5c8a812f5
HHH-13651 Applying hibernate codestyle to PersistentBag
2019-10-24 09:27:23 +01:00
2808a75d5c
HHH-13651 NPE on flushing when ElementCollection field contains null element
2019-10-24 09:26:51 +01:00
96e7abf80b
HHH-13672 The temporary PersistenceContext of a StatelessSession is not cleared after a refresh operation
2019-10-21 12:08:58 +01:00
43402ea51c
HHH-13672 Add test for issue
2019-10-21 12:08:58 +01:00
cacef1f466
HHH-13680 Upgrade to Byte-buddy 1.10.2
2019-10-21 12:59:29 +02:00
f39d96f9fa
HHH-13673 Cryptic error when providing import.sql file without a terminal char at the end of each line
2019-10-21 10:17:03 +01:00
8f68a3573e
HHH-13673 Add test for issue
2019-10-21 10:17:03 +01:00
3b1e7afb20
HHH-13675 : Optimize PersistentBag.groupByEqualityHash()
2019-10-18 13:28:00 +01:00
1c840f9dd1
HHH-12858 HHH-13432 fix Oracle failing tests
2019-10-18 13:15:48 +01:00
93a07453f0
HHH-13634 : Fix test case queries to order results
2019-10-17 12:04:19 -07:00
42de569a37
HHH-13634 : PersistenceContext can get cleared before load completes using StatelessSessionImpl
2019-10-17 09:46:58 -07:00
eccb786ba4
HHH-13634 : Test cases
2019-10-17 09:46:58 -07:00
6cdb0256d4
HHH-13666 Test custom BeforeTransactionCompletionProcess/AfterTransactionCompletionProcess
2019-10-17 15:54:16 +02:00
5c8169ba7c
HHH-13666 Re-use the wrapped exception's message upon beforeTransactionCompletion/afterTransactionCompletion failure
...
For convenience.
2019-10-17 15:54:16 +02:00
f9c149ab0d
HHH-13666 Throw a HibernateException with a more appropriate message upon beforeTransactionCompletion/afterTransactionCompletion failure
2019-10-17 15:54:16 +02:00
250f569339
HHH-13666 Clarify that existing BeforeCompletion/AfterCompletion tests are about JTA only
2019-10-17 15:54:16 +02:00
8655d683e6
HHH-13666 Remove some dead code in tests related to transactions
2019-10-17 15:54:16 +02:00
81d5f5eb21
HHH-13633 : Fix test case queries to order results
2019-10-16 13:53:53 -07:00
388b62f049
HHH-13633 : Bugs join-fetching a collection when scrolling with a stateless session using enhancement as proxy
...
Make corrections.
(cherry picked from commit 40a7cee13d
2019-10-16 11:27:35 -07:00
ce19b83e4e
HHH-13633 : Add tests including for no HibernateProxy factory
...
(cherry picked from commit 5aa421d697
2019-10-16 11:27:35 -07:00
20d6b53631
HHH-13633 : Bugs join-fetching a collection when scrolling with a stateless session using enhancement as proxy
...
Minor changes suggested by Andrea.
(cherry picked from commit cce634f03b
2019-10-16 11:27:35 -07:00
f1fa438bbe
HHH-13633 : Bugs join-fetching a collection when scrolling with a stateless session using enhancement as proxy
...
(cherry picked from commit b589251166
2019-10-16 11:27:35 -07:00
e2a403e19d
HHH-13633 : Added more tests based on renamed original (w/ and w/o bytecode enhancement)
...
(cherry picked from commit 9ad427a33e
2019-10-16 11:27:35 -07:00
38ff41c896
HHH-13633 : Add test for issue
...
(cherry picked from commit 1d8f93ca64
2019-10-16 11:27:35 -07:00
fb8d5b42c9
HHH-13640 : Correct DefaultLoadEventListener#proxyOrLoad to work properly enhancement but no HibernateProxy factory
2019-10-15 10:47:33 -07:00
66afff296a
HHH-13640 : Add test using custom EntityTuplizer with no HibernateProxy factory using Session
2019-10-15 10:47:33 -07:00
c392d03bf1
HHH-13665 selecting an Entity annotated with @Immutalbe but not with @Cachable causes a NPE when use_reference_entries is enabled
2019-10-15 11:02:04 +01:00
8d9eb04d16
HHH-13665 Add test for issue
2019-10-15 11:02:04 +01:00
e10e84159a
HHH-13640 : Remove SharedSessionContractImplementor#internalLoad(String, Serializable, boolean, boolean, Boolean unwrapProxy)
2019-10-14 11:40:00 -07:00
c21ecb511c
HHH-13640 : Added/modified tests
2019-10-14 11:39:59 -07:00
8f96d7e1e9
HHH-4235 MapBinder.createFormulatedValue() does not honor DB schema name when creating query
2019-10-14 10:29:58 +01:00
2985c1db98
HHH-4235 Add test for issue
2019-10-14 10:27:11 +01:00
14b6330a32
HHH-13663 Have the test actually use ThreadLocalSessionContext
2019-10-11 10:59:29 +01:00
1d64a386cd
HHH-13663 adjust formatting style
2019-10-11 10:44:39 +01:00
26edb2863f
HHH-13663 Method setHibernateFlushMode not callable without an active transaction on threadbound Sessions
2019-10-11 10:41:53 +01:00
9d6463eab6
HHH-13662 Avoid initializing XmlMappingBinderAccess when no XML mappings are defined
2019-10-10 10:27:52 +01:00
404bc196f7
HHH-13660 Removing dead parameter: forceFetchLazyAttributes
2019-10-09 11:57:56 +01:00
9dd6b8439b
HHH-13660 Reduce allocation costs of IdentityMaps used by ResultSetProcessingContextImpl
2019-10-09 11:57:53 +01:00
d6376834a7
HHH-13640 : Minor improvement
2019-10-07 12:22:51 +01:00
cec4228d70
HHH-13640 - Fix initialization of existing proxy association leaf subclass
2019-10-07 12:22:51 +01:00
c712b83955
HHH-13653 : More test cases
2019-10-07 07:58:45 +01:00
3c1f4356dd
HHH-13653 Uninitialized entity does not get initialized when a setter is called with enhancement-as-proxy enabled
2019-10-07 07:58:45 +01:00
ab508d2afa
HHH-12858 - integration overrides during JPA bootstrap ought to override all logically related settings
...
HHH-13432 - Have EntityManagerFactory expose persistence.xml `jta-data-source` element as a `javax.persistence.nonJtaDataSource` property
2019-10-05 23:03:09 -05:00
fd72e4f75f
HHH-12858 - integration overrides during JPA bootstrap ought to override all logically related settings
...
HHH-13432 - Have EntityManagerFactory expose persistence.xml `jta-data-source` element as a `javax.persistence.nonJtaDataSource` property
2019-10-05 22:45:29 -05:00
00f45951da
HHH-13653 : Test case
2019-10-03 23:54:23 -07:00
b350599442
HHH-12858 - integration overrides during JPA bootstrap ought to override all logically related settings
...
- e.g. a datasource passed in the integration overrides map ought to effectively override JDBC-connection settings in `persistence.xml` (and vice-versa)
HHH-13432 - Have EntityManagerFactory expose persistence.xml `jta-data-source` element as a `javax.persistence.nonJtaDataSource` property
2019-10-03 16:03:43 +01:00
2bc7fed96e
HHH-13640 - Add PrepareStatement executed check to LazyToOnesProxyWithoutSubclassesTest
2019-10-02 16:19:54 +01:00
616f549f8c
HHH-13640 : Added failing test where a proxy is found in PersistenceContext, but it does not have a subclass
2019-10-01 17:32:45 -07:00
ee304305e8
HHH-13640 - Uninitialized HibernateProxy mapped as NO_PROXY gets initialized when reloaded with enhancement-as-proxy enabled
2019-10-01 09:25:09 -05:00
d46d3d66a2
HHH-13432 - EntityManagerFactory no longer exposes "javax.persistence.nonJtaDataSource"
2019-10-01 09:25:09 -05:00
9a627c30fe
HHH-13493 - For a native query, the SessionImpl class does not call applyQuerySettingsAndHints
2019-09-30 11:02:22 +01:00
a92cd6c9b9
HHH-13645 Include a comment in the implementation about the design choice to not optimise for null values
2019-09-30 10:40:45 +01:00
00d25c1824
HHH-13645 : StatsNamedContainer#getOrCompute throws NullPointerException when computed value is null
2019-09-30 10:30:05 +01:00
3f7d03bfec
HHH-13645 : test cases
2019-09-30 10:30:05 +01:00
7355fc5131
Fix error in error message
2019-09-27 12:33:27 +01:00
e04348079f
HHH-13597 Building DatabaseInformation fails on H2 without DATABASE_TO_UPPER
2019-09-27 11:57:36 +01:00
0e9ef8c7c9
HHH-13597 Add test for issue
2019-09-27 11:57:36 +01:00
57fba402b4
HHH-12858 - Persistence.createEntityManagerFactory(Map) should allow overwriting jta-data-source of persistence.xml
2019-09-25 15:12:25 -05:00
283802c491
HHH-13640 : Test case (marked FailureExpected)
2019-09-24 15:03:29 -07:00
1bdbc0e764
HHH-13625 After upgrading to 5.4.5, it's no longer possible to bootstrap Hibernate if the org.hibernate.cfg LOG is set to DEBUG
2019-09-17 19:43:08 +01:00
f5877052ff
HHH-13621 Exception if spaces after value of javax.persistence.schema-generation.scripts.action in hibernate.properties
2019-09-16 10:12:13 +01:00
26c2e0bf2b
HHH-13621 Add test for issue
2019-09-16 10:12:13 +01:00
debc5d37f8
HHH-13581 Disable tests involving MariaDB ConnectorJ's buggy ResultSet#getTime(int, Calendar) method
2019-09-11 21:20:35 -05:00
74d35b2d59
HHH-13580 Ignore LocalTimeTest and OffsetTimeTest's 'nativeWriteThenRead' test for MySQL
...
The returned time is right (otherwise #writeThenRead would fail), it's
just that a different day is returned, but it won't affect the LocalTime
representation manipulated by the user.
2019-09-11 19:38:15 -05:00
Nathan Xu
Antoine Reilles
Christian Beikov
gavinking
marekchodak
Gail Badner
Sanne Grinovero
Davide D'Alto
Andrea Boriero
Jan-Willem Gmelig Meyling
Jason Jijón
Nathan Xu
Vlad Mihalcea
Andreas Knees
Scott Marlow
barreiro
Yosef Yona
Yoann Rodière
Christoph Dreis
Francisco A. Lozano
mimmoz81
Steve Ebersole
Kim Hansen
Vootele Rotov