4553 Commits

Author SHA1 Message Date
Gail Badner
a5fa213658 HHH-12875 : Remove "where" clause for Top used by MultiTableTest;
After HHH-12875 is fixed, the "where" clause causes
            MultiTableTest to fail due to HHH-12016
2018-08-13 21:49:45 -07:00
Gail Badner
a3cecf3411 HHH-12875 : Add comments to clarify how Collection#setWhere and #setManyToManyWhere are used 2018-08-13 17:42:54 -07:00
Gail Badner
27937e5627 HHH-12875 HHH-12882 : Class level where="..." clause hbm.xml mappings is not enforced on collections of that class; add parentheses when where clauses get combined in a conjunction (hbm and annotations)
HHH-12882 : correct assertions in ParentChildTest
2018-08-13 17:42:54 -07:00
Gail Badner
cdf5e45514 HHH-12875 HHH-12882 : test cases 2018-08-13 17:42:54 -07:00
Gail Badner
10826d8f3a HHH-12875 : Class level where="..." clause in hbm.xml mappings is not enforced on collections of that class 2018-08-13 17:42:54 -07:00
Gail Badner
eef8974877 HHH-12875 : test cases 2018-08-13 17:42:54 -07:00
Guillaume Smet
8e6fcce523 HHH-12905 Improve the error message and update the tests accordingly
Also fix a loose end in the MySQL test: at least with MariaDB, using
a bit(1) as datatype for boolean does not work: it always return true
even if you set it to 0. Using either boolean or tinyint(1) solves
the issue.

As I'm not sure older versions of MySQL supports a real boolean type I
used a tinyint(1).
2018-08-14 00:41:44 +02:00
Guillaume Smet
764b1826bb HHH-12905 Fix error message tested in MySQL and PostgreSQL tests 2018-08-13 18:43:25 +02:00
Roland Kurucz
cc1ffbaaa0 HHH-12905 - Bind value [null] was not of specified type in StoredProcedureQuery 2018-08-13 18:03:45 +02:00
Sanne Grinovero
4a4ecc434b HHH-12904 Removing some dead code in InFlightMetadataCollectorImpl and MetadataImpl 2018-08-13 16:47:11 +01:00
Guillaume Smet
34f58e91c6 HHH-12907 Avoid creating too many ByteBuddy objects
This commit should reduce the garbage collection pressure as reported at
https://github.com/raphw/byte-buddy/issues/515.
2018-08-13 14:37:00 +02:00
Guillaume Smet
a934a03a20 HHH-12906 Add tests 2018-08-13 11:49:04 +02:00
Florian Beaufumé
37d430df5e HHH-12906 Used the correct attribute in getAllCollectionRoles() 2018-08-13 11:49:04 +02:00
Fernando Guardiola
0ab6c1178b HHH-12770 - Document @NotFound(action = NotFoundAction.IGNORE) and FetchType.LAZY behavior 2018-08-13 08:36:51 +03:00
Guillaume Smet
20c6f15af2 HHH-10782 Add a comment about what clearing the query plan cache means 2018-08-09 15:53:06 +02:00
Guillaume Smet
ea859736c2 HHH-12896 Minor memory improvements in HQLQueryPlan 2018-08-08 22:24:48 +01:00
Sanne Grinovero
fa5f592fb9 HHH-12894 Simplify code of StandardSessionFactoryServiceInitiators 2018-08-08 10:59:42 +01:00
Vlad Mihalcea
870a033a52 HHH-12361 - In the User Guide, omit constructors and equals/hashCode for brevity 2018-08-08 10:20:07 +03:00
Chris Cranford
8bd79b29cf HHH-12871 - Fix test that uses dynamic-map entities which failed. 2018-08-07 10:52:24 -04:00
Chris Cranford
b9e0449602 HHH-12871 - Fix metamodel to properly exclude dynamic-map based types when using ignoreUnsupported. 2018-08-07 10:52:24 -04:00
Chris Cranford
6a594712db HHH-12871 - Added test cases. 2018-08-07 10:52:24 -04:00
Guillaume Smet
b66df9a352 HHH-12196 Implement a naive limit handler for Sybase
It doesn't manage all the corner cases but it should be safe enough as
only triggered in the simple cases.
2018-08-03 17:23:44 +02:00
Guillaume Smet
5d965f8e15 HHH-12883 Fix NaturalIdDereferenceTest with Sybase
With Sybase (and maybe others), the cross join operator is ", " so
only counting the " join " occurrences does not work.
2018-08-03 15:28:14 +02:00
Guillaume Smet
07e21cf66e HHH-12880 LockModeTest hangs indefinitely with Sybase due to HHH-12847 2018-08-02 14:32:19 +02:00
Sanne Grinovero
c108f48674 HHH-12879 Remove unnecessary constants in StandardDialectResolver 2018-08-02 10:56:45 +01:00
Guillaume Smet
719e5d0c12 HHH-12847 Consider LockOptions for getting the LockMode
Otherwise, it leads to null pointer exceptions.
2018-08-02 00:11:42 +02:00
Guillaume Smet
6a3ed33627 HHH-12857 Reuse the TypePool created in EnhancerImpl 2018-08-01 23:41:28 +02:00
Guillaume Smet
dff202ded9 HHH-12857 Rewrite getDeclaredMethod() calls in static initializers
We rewrite them to run them as privileged blocks.
2018-08-01 23:41:06 +02:00
Guillaume Smet
d95b36ffb6 HHH-12857 Avoid using a static ByteBuddy object
In the end, it does not change anything as the BytecodeProvider is still
static but it helps as a general cleanup for the following commits.
2018-08-01 18:01:20 +02:00
Guillaume Smet
349bd2649c HHH-12835 In the end, remove the assertion
It's not really compatible with batch loading, padding and a couple of
other corner cases.

And I don't think it has a lot of value by itself.
2018-08-01 16:07:49 +02:00
Andrea Boriero
725da274fd HHH-12849 - QuotedIdentifierTest fails with ORA-04043 on Oracle12c 2018-08-01 13:42:10 +02:00
Guillaume Smet
bee200a84c HHH-12835 Fix an incorrect assertion in BatchFetchQueueHelper 2018-08-01 11:44:19 +02:00
Guillaume Smet
d85831f543 HHH-12848 Restore the original Oracle LimitHandler
Oracle does not support using the SQL 2008 standard limit handler with
FOR UPDATE clauses. Thus we need to get back to the old limit handler.
2018-08-01 11:44:19 +02:00
Guillaume Smet
e84aae23f0 HHH-10603 Avoid doing distinct and comparisons on byte arrays
They are stored as blobs starting with Oracle12cDialect and distinct and
comparisons on blobs are not supported.

Some tests were adapted, some are now skipped with Oracle12cDialect.
2018-08-01 11:43:32 +02:00
Guillaume Smet
f43f668fb8 HHH-12730 Remove the deprecated methods previouly added
We don't need them as everything is now dealt with the transformer.
2018-08-01 11:32:02 +02:00
Guillaume Smet
0ada118635 HHH-12730 Add missing @Overrides 2018-08-01 11:32:02 +02:00
Guillaume Smet
6d7f7878e1 HHH-12730 Add deprecated constructors taking a SessionImplementor 2018-08-01 11:32:02 +02:00
Gail Badner
19388972dc HHH-12730 : User types built using 5.1 are not binary compatible with 5.3 2018-08-01 11:32:02 +02:00
Guillaume Smet
d30e461fa1 HHH-12868 Fix NPE when loading entity with CacheConcurrencyStrategy.NONE 2018-07-31 14:52:15 +02:00
Sanne Grinovero
d67278a6d2 HHH-12872 Reduce memory consumption of XSD schema validations 2018-07-31 12:48:10 +02:00
Andrea Boriero
7da105be0a HHH-12861 SchemaUpdate doesn't work with Sybase 2018-07-31 10:43:54 +01:00
Yoann Rodière
dc42deafcb HHH-12492 Qualify references to columns from the target table in subqueries in DELETE/UPDATE queries
Don't try to duplicate the logic from
org.hibernate.hql.internal.ast.tree.FromElementType#toColumns(java.lang.String, java.lang.String, boolean, boolean)
in other classes, it's complex enough and already seems to handle all
the cases we might encounter.

In this specific case, we want the table name to be used to qualify
column names, because the target table doesn't have any alias (it's not
supported by every version of every RDBMS), and not qualifying columns
at all may lead to a confusing statement, in particular if tables
referenced in the subquery contain columns with the same name.
Since we use aliases for every other table in the query, referencing the
table should not lead to any conflict.
2018-07-27 15:02:55 +02:00
Yoann Rodière
48f59e891f HHH-12492 Test HQL Delete query with a subquery referencing the parent query's aliases 2018-07-27 15:02:48 +02:00
Martin Simka
036ea775da HHH-12863 SchemaUpdateTest should be skipped with Sybase 2018-07-27 14:55:49 +02:00
Jan-Willem Gmelig Meyling
ea77c1fb4b HHH-12775 - Avoid join on natural id property access 2018-07-23 21:37:49 +02:00
Alvaro Esteban Pedraza
b94b126141 HHH-12763 - Log which JtaPlatform implementation is used at startup on info level 2018-07-23 18:13:28 +02:00
Sanne Grinovero
5164d8b5b3 HHH-12841 DriverManagerConnectionProviderImpl: implement lazy Thread starting and fix visibility guarantees 2018-07-23 18:11:38 +02:00
Martin Simka
8be7aaf1be HHH-12851 ConverterTest fails with SQL Server depending on collation 2018-07-23 18:08:24 +02:00
Chris Cranford
333c190c82 HHH-12846 - Merge cascade of collection fails when orphan removal enabled with flush mode commit. 2018-07-23 11:00:55 -04:00
Martin Simka
89844c50de HHH-12844 Fix HbmWithIdentityTest with Oracle 2018-07-20 14:03:05 +02:00