Commit Graph

19981 Commits

Author SHA1 Message Date
Gavin King a389f771bf avoid use of char(n) types on MySQL
MySQL strips trailing space characters from char(n) columns,
which is very bad, because we use char(1) for storing Java
char values.

We can sort-of compensate for this in CharacterJavaType,
but it's ugly and fragile to do it that way.

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-31 16:31:40 +01:00
Gavin King 3c793c7a30 inline a redundant variable
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-31 16:31:40 +01:00
Gavin King 08f25cf8d9 spotless changes
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-31 16:31:40 +01:00
Gavin King ddc2b36bbe disable a test on MySQL
MySQL cast() doesn't do truncation, this never worked properly

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-31 16:31:40 +01:00
Gavin King 920d4bce44 throw CoercionException when CharacterJavaType receives a string of wrong length
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-31 16:31:40 +01:00
Gavin King 7df56dadda more work on flow typing in the JavaTypes
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-31 16:31:40 +01:00
Gavin King 16a15ea6ac cleanups in descriptor.java package
- delete a duplicate class
- fix some incorrect usage of that class
- continue using more flow typing

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-31 16:31:40 +01:00
Gavin King 2924fe8875 treat an empty string as a null character in CharacterJavaType conversion
an empty string should not be converted to a space char

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-31 16:31:40 +01:00
Gavin King 26988dd536 start using flow typing in the JavaTypes
- but definitely not done with this

squash

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-31 16:31:40 +01:00
Gavin King 65bc730cc1 use switch expressions in isWider() impls
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-31 16:31:40 +01:00
Gavin King d6e85b0a44 move GenerationTarget to the SPI package, since it's exposed by the SPI
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-29 18:07:17 +01:00
Gavin King c037d74bbc move TableMigrator to the SPI package
I must have just made a mistake when I created this interface

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-29 18:07:17 +01:00
stringintech e676ebe62e HHH-18764 Fix incorrect type resolution in ManyToOneType dirty check 2024-10-29 11:43:12 +01:00
Karel Maesen b5fb125425
HHH-18760 - CockroachDB dialect remaps serialization error (#9152) 2024-10-29 10:40:02 +01:00
Marco Belladelli ac74e3b4e7 HHH-18777 EntityHolder map optimization to avoid double accesses 2024-10-28 17:16:49 +01:00
Christian Beikov 9622f1965b HHH-18689 Maintain proxy targets when converting cache entries 2024-10-28 13:12:49 +01:00
Konrad Kügler c7f8813b70 HHH-18689 Test FULL query cache sometimes incomplete 2024-10-28 13:12:49 +01:00
Christian Beikov e024bd0568 HHH-18773 Deduplicate result initializers to avoid double initialization issues 2024-10-28 13:09:10 +01:00
Yoann Rodière a63716dab7
Fix upload of Devbelocity build scans
Forgot this line.
2024-10-28 12:02:21 +01:00
Yoann Rodière 6551aa59c5 Fix upload of Develocity build scans
Don't tar them, as this was broken: we ended up uploading the
build-scan-data directory instead of the tar, while still expecting a
tar when dowloading, which made everything fail.

We don't need tars anyway, as workflow artifacts are already zipped.
2024-10-28 12:00:03 +01:00
Gavin King b44833b7c9 HHH-18772 introduce AuthException and simplify SQLStateConversionDelegate
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-26 16:08:59 +02:00
Gavin King 55255e9d4a finish big refactor of AbstractMultiIdEntityLoader and children
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-26 16:08:59 +02:00
Gavin King ae538102f9 minor cleanup in Dialect
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-26 16:08:59 +02:00
Gavin King 9828ad7b33 document performance implications of id batching i.e. BatchSize
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-26 16:08:59 +02:00
Gavin King 10c83d8370 further cleanups on multi id loaders
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-26 16:08:59 +02:00
Gavin King 6c5f577223 partial refactoring of AbstractMultiIdEntityLoader and children
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-26 16:08:59 +02:00
Gavin King be895c722b HHH-18767 make MultiIdEntityLoaderArrayParam respect explicit BatchSize
keep ignoring the *implicit* upper limit from the Dialect

refactor a very long method which was extremely hard to understand

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-26 16:08:59 +02:00
Gavin King 7f7c861f4b HHH-18767 add BatchSize for use with findMultiple()
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-26 16:08:59 +02:00
Jan Schatteman cb0d70309a HHH-17989 - Fix for StatisticsImplementor.closeStatement() never called
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2024-10-25 14:13:24 +02:00
Marco Belladelli ddf936286f HHH-18494 Always use standard table group in result builder entity
Also ignore placeholder aliases for to-one properties using join-tables, and use the target column name instead
2024-10-25 13:34:59 +02:00
Marco Belladelli 92103ff59c HHH-18494 Add test for issue 2024-10-25 13:34:59 +02:00
Yoann Rodière 013bb46470 Do not include the whole Gradle cache in GH Actions caches
We don't need the whole cache, since most (all?) of it is stored on
Develocity already.

Including ./gradle/caches/modules-2 is enough, because that's where
Maven dependencies are stored, and *those* are not stored on Develocity.
2024-10-25 12:29:15 +02:00
Yoann Rodière 62fe772cc0
Fix invalid arguments in GitHub Actions for download of build-scan-data artifacts 2024-10-25 12:07:21 +02:00
Yoann Rodière 5eaaff2e63 Improve build cache strategy
Ripped off from Quarkus.

Here's how it will work:

1. We create a cache entry on push only. Pull requests only restore it.
2. We create a new cache entry every day, prefixed with something like
   2024-10-25.
3. When restoring the cache, we try the entry for the day first
   (2024-10-25) and default to the one for the month (2024-10-*).
   Critically, this means we will build each day's cache based on the
   previous day's cache.
4. Atlas infra uses its own, separate cache entries.

Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com>
2024-10-25 12:02:27 +02:00
Yoann Rodière 4e8eb91562 Sanitize user home on GitHub Action job start on Atlas 2024-10-25 11:52:58 +02:00
Christian Beikov 543e095cf7 Don't use the build cache during releases
So that we're extra sure we're not relying on cache left by a previous
Gradle execution.
2024-10-25 11:52:58 +02:00
Christian Beikov df8b16369f Rework/simplify GH Actions jobs
* Use `pull_request` instead of `pull_request_target`
* Move Develocity build scan publishing for untrusted code to a separate workflow
* Merge Atlas workflow into the main CI workflow
* Split caches between trusted and untrusted code
* Update secrets to use "Develocity" name instead of "Gradle Enterprise"
* Update comments

Co-Authored-By: Yoann Rodière <yoann@hibernate.org>
2024-10-25 11:52:58 +02:00
Gavin King d25a86b12d minor fix to generated @see jdoc annotation in @Find method
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-25 01:34:41 +02:00
Gavin King 7bf6004ef8 fix broken code examples, and make 'em more readable
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-24 18:59:13 +02:00
Gavin King 7002ee8d0d shorter method name in doc example
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-24 14:07:22 +02:00
Gavin King 743691e3b2 HHH-18761 add test
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-24 14:07:22 +02:00
Gavin King fb7602a2e5 HHH-18761 fix generation of named query method in presence of Jakarta Data
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-24 14:07:22 +02:00
Čedomir Igaly bdc0070d97 HHH-18446 Added default SQL type code to LongVarbinaryJdbcType abd LongVarcharJdbcType 2024-10-24 08:57:11 +02:00
Čedomir Igaly b5b195740b HHH-18446 Test case 2024-10-24 08:57:11 +02:00
Gavin King 93c18dafae more doc updates for JPA 3.2
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-24 01:26:28 +02:00
Gavin King 1fa10e3b53 update prefaces
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-23 21:24:47 +02:00
Gavin King 6480154cd7 more updates for JPA 3.2
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-23 21:24:47 +02:00
Christian Beikov 82b20a0e90 HHH-18731 Add generate_series() set-returning function 2024-10-23 18:29:20 +02:00
Gavin King 5bd244dd20 whitespace fix
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-23 17:25:36 +02:00
Gavin King 7f3c73b438 update processor chapter for JPA 3.2
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-23 16:32:54 +02:00