Commit Graph

10028 Commits

Author SHA1 Message Date
Gavin 559c325759 add @DialectOverride.SQLSelect 2023-04-08 13:10:46 +02:00
Gavin adffa890b1 HHH-16163 replace @OrderBy and @Where by @SQLOrder and @SQLRestriction 2023-04-08 13:10:46 +02:00
Gavin 7b8cd14052 HHH-16163 update tests to use new annotations 2023-04-08 13:10:46 +02:00
Davide D'Alto e6c8fbc7af HHH-16443 Convert SqlStatementLogger into a Service
This way is possible to get the logger without having
to initialize the JdbcServices service.

Without this change, in Hibernate Reactive, we have a cyclic
dependency during the initialization of the services between
JdbcEnvironment and JdbcServices.
2023-04-08 10:48:18 +01:00
Gavin 07a9cee923 fix inconsistently-formatted log message 2023-04-08 03:09:50 +02:00
Gavin e5545492cc proper logging and documentation for semi-deprecation of 'hibernate.dialect'
and code cleanup
2023-04-08 00:14:08 +02:00
Gavin d8c300dcf1 add two missing keywords to the list of "soft" keywords 2023-04-07 13:13:34 +02:00
Andrea Boriero 5902d0b4db HHH-16429 WF SessionFactoryTestCase test fails 2023-04-07 10:53:58 +02:00
Gavin King 543226087f add a test for round-tripping Instant 2023-04-07 01:11:49 +02:00
Jan Schatteman 53f752d138 Remove some unnecessary code duplications in AbstractSelectionQuery and AbstractQuery
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-04-06 20:21:28 +02:00
Davide D'Alto 1de4a76008 HHH-16444 When logging the selected dialect, log the db version too
The db version used by the dialect makes a huge different on the
sql queries used.

The log before this commit:
```
INFO SQL dialect [vert.x-worker-thread-0] HHH000400: Using dialect: org.hibernate.dialect.MariaDBDialect
```

The log after this commit:
```
INFO SQL dialect [vert.x-worker-thread-0] HHH000400: Using dialect: org.hibernate.dialect.MariaDBDialect, version: 10.11
```

I've also updated the HANADialectTestCase because now the error message
contains the db version
2023-04-06 16:54:40 +01:00
Jan Schatteman 4eef64f81e HHH-16435 - Fix for issue (combine filterpredicates with potential already existing ones)
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-04-06 17:26:46 +02:00
Jan Schatteman 7f6b054a14 HHH-16435 - Added test for issue
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-04-06 17:26:46 +02:00
Gavin 1b2107e7b4 make a code comment even clearer b/c apparently some don't get it 2023-04-06 10:56:19 +02:00
Gavin 2927c006b2 allow @UuidGenerator to be applied to a non-@Id field 2023-04-06 10:11:24 +02:00
Christian Beikov 783da2a906 HHH-16389 Introduce checkerframework for nullness marking/checking and null check the JPA metamodel generator 2023-04-05 19:14:37 +02:00
Marco Belladelli 169757d5b1 HHH-16340 Avoid checking discriminator duplication when not insertable 2023-04-05 18:37:24 +02:00
Marco Belladelli 814cddfeb4 HHH-16340 Add test for issue 2023-04-05 18:37:24 +02:00
Jan Schatteman 7452319807 HHH-16418 - Improve error message
Co-authored-by: Christian Beikov <christian.beikov@gmail.com>
2023-04-05 15:57:12 +02:00
Jan Schatteman 76ea320cdb HHH-16418 - Added test and improvement for issue
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-04-05 15:57:12 +02:00
Yoann Rodière 9884afe78b HHH-16403 Avoid unnecessary wrapping for exceptions/errors thrown by getters/setters 2023-04-05 15:22:42 +02:00
Yoann Rodière 01b0ff7940 HHH-16403 Upgrade to assertj 3.22.0 2023-04-05 15:22:42 +02:00
Gavin 0bf50ae3f5 improve tests for truncate(datetime) function 2023-04-05 15:03:52 +02:00
Sanne Grinovero e38b85ea86 Retained memory analysis: ReflectHelper#JAVA_CONSTANT_PATTERN 2023-04-04 12:51:17 +02:00
Sanne Grinovero 2ab56b3ece Retained memory analysis: remove unused field JdbcTypeNameMapper#JDBC_TYPE_NAME_MAP 2023-04-04 12:51:17 +02:00
Sanne Grinovero a5315c7e50 HHH-16430 Small optimisation in Dialect initializations 2023-04-04 12:51:17 +02:00
Sanne Grinovero 845e9770d5 HHH-16430 Avoid AnsiSqlKeywords to retain all keywords as static constants 2023-04-04 12:51:17 +02:00
Sanne Grinovero ca3e69a4f6 HHH-16430 Strictly define ansiSQL2003 as lowercase 2023-04-04 12:51:17 +02:00
Sanne Grinovero 049a25aa66 HHH-16430 Simplify construction of set of ansiSQL2003 keywords 2023-04-04 12:51:17 +02:00
Steve Ebersole 8e1247c909 HHH-16012 - Develop an abstraction for domain model Class refs 2023-04-03 19:54:41 -05:00
Andreas Asplund f6e3a56b8e HHH-16413 Add test for issue 2023-04-03 15:18:38 +02:00
Marco Belladelli 288242a10f HHH-16414 Improve TableGroup resolution for get or create 2023-04-03 15:18:38 +02:00
Marco Belladelli bc31a9532a Fix failing tests on CockroachDB and Oracle 11 2023-04-03 15:14:20 +02:00
Jan Schatteman 9991b9d32c HHH-16406 - Fix error in PaginationTest for Sybase
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-03-31 17:32:20 +02:00
Steve Ebersole 7db9bc83c1 HHH-16407 - EntityPersister and CollectionPersister deprecations 2023-03-30 17:10:41 -05:00
Andrea Boriero 6b8efd01fa HHH-16368 UnsupportedOperationException: compare() not implemented for EntityType 2023-03-30 17:08:13 -05:00
Andrea Boriero fb174d19c7 HHH-16396 HQL with SubQuery having same alias of root Query generates wrong SQL 2023-03-30 17:01:18 -05:00
Jan Schatteman b26d8765c2 HHH-16384 - Fix NPE in AbstractSelectionQuery.setFirstResult
Included check for that in PaginationTest
Moved PaginationTest to Junit5

Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-03-30 20:36:35 +02:00
Andrea Boriero 40f22e482f HHH-16218 Natural id cache is extremely slow for entities with compound natural id 2023-03-30 18:14:20 +02:00
Sylvain Dusart c5897db954 HHH-16218 Natural id cache is extremely slow for entities with compound natural id 2023-03-30 18:14:20 +02:00
Marco Belladelli 201f10db02 HHH-16241 Add relational java type to SqmExpressible for function argument validation 2023-03-30 18:10:53 +02:00
Marco Belladelli bf9f3488f2 HHH-16241 Add test for issue 2023-03-30 18:10:53 +02:00
Christian Beikov b4a306e3e4 HHH-16372 Fix NPEs in some Bindable implementations that operate on values 2023-03-30 18:09:20 +02:00
Christian Beikov 51660d1784 HHH-16359 Make attributes non-optional which have only non-nullable columns 2023-03-30 18:09:20 +02:00
Christian Beikov 80065dabdf HHH-16358 Make OneToMany with abstract TABLE_PER_CLASS element work again 2023-03-30 18:09:20 +02:00
Christian Beikov a35234a149 HHH-16388 Treat wrapper arrays with @Lob like the legacy mapping would 2023-03-30 18:07:45 +02:00
Christian Beikov b5220ff929 HHH-16388 - Configuration setting for wrapper Byte[]/Character[] treatment 2023-03-30 18:07:45 +02:00
Steve Ebersole f209423797 HHH-16388 - Configuration setting for wrapper Byte[]/Character[] treatment 2023-03-30 18:07:45 +02:00
Yoann Rodière e54b4dee54 HHH-16400 Avoid reflection for calls to StackWalker 2023-03-30 17:39:37 +02:00
Christian Beikov 31f1a30c7d Fix issues with nightly tests 2023-03-30 15:43:51 +02:00
Marco Belladelli bddfa7c5c6 HHH-16350 Pass correct state to pre-load events 2023-03-30 15:15:06 +02:00
Marco Belladelli ab91f08ad8 HHH-16350 Add test for issue 2023-03-30 15:15:06 +02:00
Christian Beikov 9b7e4d7cfa HHH-16402 Fix default window frame mode to be RANGE instead of ROWS 2023-03-30 14:46:10 +02:00
Marco Belladelli dc87f4bf18 HHH-16378 Handle non-embeddable generic attribute paths 2023-03-30 14:01:05 +02:00
Yoann Rodière b703f23a92 HHH-16378 Add test for issue 2023-03-30 14:01:05 +02:00
Yoann Rodière 107b6e495b HHH-16255 Avoid confusing logs "Executing import script"
1. Only log this when we're actually executing the script, i.e. when
   the target is the database.
2. Log "Executing script" rather than "Executing import script" since
   sometimes we're executing a drop script
   ("jakarta.persistence.schema-generation.drop-script-source").
2023-03-30 14:00:21 +02:00
Yoann Rodière 943fd55ba2 HHH-16255 De-duplicate a few methods from SchemaCreatorImpl/SchemaDropperImpl/SchemaTruncatorImpl 2023-03-30 14:00:21 +02:00
Davide D'Alto d99889359d HHH-16399 Minor refactoring 2023-03-30 13:08:29 +02:00
Davide D'Alto 6cdef8beab HHH-16399 Recognize ConstraintViolationException form errorCode in MSSQL
This is for Hibernate Reactive.

Hibernate ORM recognizes the error because, when it comes from the JDBC driver,
 it's an instance of `java.sql.SQLIntegrityConstraintViolationException`.
2023-03-30 13:08:29 +02:00
Marco Belladelli 715a12ba7e HHH-16305 Skip checking JavaObjectType function arguments 2023-03-30 12:45:26 +02:00
Marco Belladelli 3942961eeb HHH-16305 Add test for issue 2023-03-30 12:45:26 +02:00
Andrea Boriero c9640c2ee3 HHH-16281 Inconsistent Behaivor of L2 cache between Hibernate 5 and 6 2023-03-30 09:40:57 +02:00
Steve Ebersole 52e95aec46 HHH-16391 - Incorrect mutability-plan resolution for converted collection-as-basic mappings 2023-03-29 15:34:25 -05:00
Andrea Boriero 53b3ea6b3b HHH-16272 Hibernate 6 fails to refresh when collections are accessed in entity setter method when access type is property 2023-03-29 17:25:56 +02:00
Andrea Boriero 8c9497b63a HHH-16272 Add test for issue 2023-03-29 17:25:56 +02:00
Marco Belladelli be10b32b94 HHH-16390 - Execution of non-batched statements do not force execution of current batch
HHH-16319 - test
2023-03-28 15:12:30 -05:00
Steve Ebersole a9f51a3eae oracle test fix up 2023-03-28 14:15:49 -05:00
Jan Schatteman 1b86b2228c HHH-16386 - Disable batching for dynamic-insert and dynamic-update
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-03-28 07:25:23 -05:00
Steve Ebersole 0455e2d676 HHH-16339 - Unify entity and any discriminator handling 2023-03-27 13:06:20 -05:00
Marco Belladelli 055aeba6b9 HHH-16380 Avoid metamodel access when instantiating entity instances 2023-03-27 18:17:14 +02:00
Jan Schatteman c2a3bd3b48 HHH-16249 - Add test for issue
Disable batching in a stateless session when no transaction is active

Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-03-27 16:47:31 +02:00
Marco Belladelli 943c2210dd HHH-16274 Fix sorting of DependantValue's properties 2023-03-24 19:06:31 +01:00
Marco Belladelli 0a8cf3f6bf HHH-16274 Add test for issue 2023-03-24 19:06:31 +01:00
Andrea Boriero a367da6d09 HHH-16334 Persist and load an entity with an all-delete-orphan collection null 2023-03-24 16:26:34 +01:00
Andrea Boriero 79c34b97d3 HHH-16334 Add test for issue 2023-03-24 16:26:34 +01:00
Andrea Boriero 973437ceca HHH-16281 Inconsistent Behaivor of L2 cache between Hibernate 5 and 6 2023-03-24 16:25:53 +01:00
Andrea Boriero 76de84e7c6 HHH-16281 Add test for issue 2023-03-24 16:25:53 +01:00
Andrea Boriero 6f3feca7f4 HHH-16337 Bytecode enhancement : ElementCollection is not deleted when replaced 2023-03-24 08:12:09 -05:00
Andrea Boriero 570ccae476 HHH-16097 Move all tests from documentation into hibernate-core 2023-03-24 07:43:13 -05:00
Davide D'Alto 07e0a7aaa4 HHH-16353 Convert comments to Javadoc for Hibernate Reactive
So they get moved with any refactoring
2023-03-24 11:29:13 +01:00
Davide D'Alto f28933a0cc HHH-16353 Make it possible for Hibernate Reactive to override the creation of AttributeMapping and Fetch strategies 2023-03-24 11:29:13 +01:00
Marco Belladelli 7028c614e0 HHH-16248 Check referenced model part declaring type when batch fetching associations 2023-03-24 10:44:30 +01:00
Marco Belladelli fdee401f09 HHH-16248 Add test for issue 2023-03-24 10:44:30 +01:00
Marco Belladelli bee9ea6ae0 HHH-16355 Fix check for binding inverse many to many foreign key 2023-03-23 12:04:40 +01:00
Marco Belladelli 01ce5c63f0 HHH-16355 Add test for issue 2023-03-23 12:04:40 +01:00
Christian Beikov eb9e16c83f HHH-16317 Don't use InstantAsTimestampWithTimeZoneJdbcType for PG-JDBC and MSSQL due to a bug 2023-03-23 11:59:53 +01:00
Christian Beikov 41bec6d5f9 HHH-16287 Consider hibernate.timezone.default_storage for OffsetTime typing and storage 2023-03-23 11:59:53 +01:00
Christian Beikov 30943e1214 HHH-16189 Skip test for H2 1.x due to a H2 issue 2023-03-23 11:59:53 +01:00
Christian Beikov a4bcc4240b HHH-16311 - Fix HANA test issues 2023-03-23 11:59:53 +01:00
Christian Beikov 64d139325a HHH-16333 Get rid of special Character[] and Byte[] handling 2023-03-23 11:59:53 +01:00
Davide D'Alto eeccc9c99d
HHH-16346 Relax scopes for TableBased*Handler
So that Hibernate Reactive can create a custom LocalTemporaryTableStrategy
2023-03-22 19:36:24 +01:00
Christian Beikov 3598ee25a9 HHH-16280 Fix Jackson XML mapper support for Oracle Array data types 2023-03-22 18:07:44 +01:00
Christian Beikov ef874b2268 HHH-16348 Re-add JdbcOperationQuery#getAppliedParameters for query extensions 2023-03-22 18:06:28 +01:00
Christian Beikov 195cbdb342 HHH-16348 Re-add JdbcOperationQuery#getAppliedParameters for query extensions 2023-03-22 17:32:20 +01:00
Christian Beikov e632981e4b HHH-16333 Get rid of special Character[] and Byte[] handling 2023-03-22 17:27:26 +01:00
Christian Beikov 0b68a36f8b HHH-16333 Handle converters properly in BasicPluralType 2023-03-22 17:27:26 +01:00
Christian Beikov 87e378a9a4 Respect precision for VM generated temporal values 2023-03-22 17:27:26 +01:00
Marco Belladelli 892976187b HHH-16336 Allow same table and subtypes in mappedBy check 2023-03-20 19:17:17 +01:00
Jan Schatteman 15873c17fb HHH-16295 - trivial correction in JdbcUpdateMutation
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-03-17 22:42:28 +01:00
Jan Schatteman 26a173ff8e HHH-15108 - tweak to not ignore exceptions in AggregateClassLoader.findClass()
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-03-17 14:23:08 -05:00
Marco Belladelli c6fa754f06 HHH-16280 Fix JacksonXmlFormatMapper handling of array data types 2023-03-17 14:16:27 -05:00
Steve Ebersole e675962779 HHH-16311 - Migrate away from UserType for enum handling 2023-03-17 13:13:24 -05:00
Andrea Boriero bcb50d1052 HHH-16322 Merge of entities having a collection with orphanRemoval true fails when bytecode enhancement is enabled 2023-03-17 12:22:09 -05:00
Marco Belladelli cdada7a916 HHH-16313 HHH-16313 Check mappedBy type when binding entity associations 2023-03-17 17:59:29 +01:00
Marco Belladelli 83894d39ab HHH-16313 Add test for issue 2023-03-17 17:59:29 +01:00
Andrea Boriero bc582290a0 HHH-16015 Merge operation throws a NPE: Cannot invoke org.hibernate.property.access.spi.Setter.set(Object, Object) when using CompositeUserType 2023-03-17 17:31:16 +01:00
Andrea Boriero 7aea8723f2 HHH-16015 Add test for issue 2023-03-17 17:31:16 +01:00
Andrea Boriero 664b10abc3 HHH-16189 Wrong order by and group by generated 2023-03-17 17:30:24 +01:00
Andrea Boriero 75d1f36ded HHH-16189 Add test for issue 2023-03-17 17:30:24 +01:00
Jan Schatteman 42f64f1c2e Merge org.hibernate.testing.orm.ExceptionHelper into org.hibernate.internal.util.ExceptionHelper
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-03-17 16:29:48 +01:00
Marco Belladelli 575847322d HHH-16248 Fix h2 json test 2023-03-17 16:02:07 +01:00
Christian Beikov 272df3ebe2 Remove SelfInterpretingSqmPath and remove some warnings 2023-03-17 15:26:37 +01:00
Marco Belladelli 46e3c54271 HHH-16166 Correct Plural and ToOne attribute mapping declaring types 2023-03-17 12:34:16 +01:00
Marco Belladelli d6b5357c7b HHH-16166 Change subtype property access and deprecate unused method in PersistentClass 2023-03-17 12:34:16 +01:00
Marco Belladelli 06490876d6 HHH-16166 Add test for issue 2023-03-17 12:34:16 +01:00
Marco Belladelli 3f029e1dde HHH-13627 Invalidate cache on update for CacheMode GET and IGNORE 2023-03-17 12:31:06 +01:00
Marco Belladelli af074e2b1d HHH-13627 Add test for issue 2023-03-17 12:31:06 +01:00
Marco Belladelli 22c3edc0dc HHH-16237 Restore version update group for subtype entities 2023-03-17 12:28:02 +01:00
Marco Belladelli b385ee578f HHH-16237 Add test for issue 2023-03-17 12:28:02 +01:00
Andrea Boriero 5aaf6f75c4 HHH-16247 Criteria Query with Object-Typed Embedded Parameter throws AssertionError 2023-03-17 12:25:35 +01:00
Andrea Boriero 91228ca72c HHH-16247 Add test for issue 2023-03-17 12:25:35 +01:00
Andrea Boriero e9ba27e88f HHH-16297 Removing an element from a collection of elements removes the whole collection 2023-03-17 12:16:00 +01:00
Davide D'Alto b56be6cdab HHH-16297 Add test for issue 2023-03-17 12:16:00 +01:00
Sanne Grinovero a9e1cbffc3 HHH-16326 Upgrade to JUnit 5.9.2 2023-03-17 11:12:13 +00:00
Marco Belladelli c3fa3ae777 HHH-16320 Handle json columns with native ddl type on H2 2023-03-17 10:21:41 +01:00
Christian Beikov 39f4fdda5e HHH-16316 Move version specific dialects of unsupported versions to hibernate-community-dialects 2023-03-17 10:12:34 +01:00
Sanne Grinovero faf98a14af HHH-16323 Ensure new service ParameterMarkerStrategy can be looked up efficiently 2023-03-16 12:34:28 -05:00
Steve Ebersole 56223d3ebc HHH-16257 - Add `@JavaServiceLoadable` to document Services or strategies that are loadable as Java services 2023-03-16 08:41:21 -05:00
Steve Ebersole e72d58161c HHH-16276 - More readable exception for non-compliant @OrderBy expressions 2023-03-16 00:38:26 -05:00
Steve Ebersole eaeb7f38ae HHH-16276 - More readable exception for non-compliant @OrderBy expressions 2023-03-15 19:16:17 -05:00
Réda Housni Alaoui 187bf4f5e7 HHH-15972 entitygraph load error when Inheritance JOINED is used in 6.1.6 2023-03-15 21:13:03 +01:00
Yoann Rodière d09640fe36 HHH-16302 Clarify that the JDBC timezone is supposed to match the database timezone
See https://hibernate.zulipchat.com/#narrow/stream/132094-hibernate-orm-dev/topic/hibernate.2Etimezone.2Edefault_storage/near/341706032
2023-03-15 15:36:47 +01:00
Yoann Rodière 4a8bb326de HHH-16302 Document that TimeZoneStorageType.NORMALIZE normalizes to the JVM timezone, not to hibernate.jdbc.time_zone, upon reading values 2023-03-15 15:36:47 +01:00
Marco Belladelli a358d1d2d0 HHH-16234 Log identity hash code instead to calling instance.toString()
when resolving entity instance
2023-03-15 15:12:24 +01:00
Marco Belladelli 343eda7b14 HHH-16234 Add test for issue 2023-03-15 15:12:24 +01:00
Yoann Rodière 9c1d455c8a HHH-16310 Centralize the detection of multitenancy 2023-03-15 12:05:51 +01:00
Yoann Rodière 5bff5a383c HHH-16310 Fix retrieval of JDBC metadata when MultiTenantConnectionProvider is set through the service registry builder
... as opposed to setting it through settings.
2023-03-15 12:05:51 +01:00
Marco Belladelli 615267f61d HHH-16210 Avoid join fetching multiple bag-type collections 2023-03-15 10:23:56 +01:00
Marco Belladelli 8700f6f93b HHH-16210 Add test for issue 2023-03-15 10:23:56 +01:00
Yoann Rodière f8494fa097 HHH-16279 Test extracting SQL from import.sql containing only comments 2023-03-14 17:00:04 +01:00
Yoann Rodière 0094616d2d HHH-16279 Allow scripts containing only comments in MultiLineSqlScriptExtractor 2023-03-14 17:00:04 +01:00
Steve Ebersole b276128f56 HHH-16284 - Rename JdbcParameterRender to ParameterMarkerStrategy 2023-03-13 15:35:38 -05:00
Steve Ebersole f45dcf4c2f HHH-16290 - Mark `o.h.persister.entity` and `o.h.persister.collection` as internal 2023-03-13 15:27:28 -05:00
Christian Beikov 0000347b03 Fix issues with too long table/column names for Oracle 11 2023-03-13 10:58:53 +01:00
Christian Beikov 51b6833876 HHH-15885 Fix wrong collection fetch element ordering 2023-03-13 10:56:31 +01:00
Jan Schatteman 44ad64b971 HHH-15885 Add test case for issue
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-03-13 10:56:31 +01:00
Davide D'Alto 06e24bd420 HHH-16282 Make it possible for Hibernate Reactive to plug in custom fetch initializers 2023-03-11 13:12:52 +00:00
Sanne Grinovero ff19a9124f HHH-16260 DialectDelegateWrapper needs to be updated to delegate the new Dialect#getNativeParameterRenderer method 2023-03-10 11:38:13 +00:00
Steve Ebersole 99f8b0fd3d HHH-16260 - JdbcParameterRenderer not called with dynamic filters
HHH-16256 - JdbcParameterRenderer to have an impact on write operations
HHH-16273 - Support for Dialect native JdbcParameterRenderer
2023-03-09 19:51:33 -06:00
Steve Ebersole a98ab519ba HHH-16260 - JdbcParameterRenderer not called with dynamic filters
HHH-16256 - JdbcParameterRenderer to have an impact on write operations
HHH-16273 - Support for Dialect native JdbcParameterRenderer

agroal tests :(
2023-03-09 19:51:33 -06:00