Commit Graph

12590 Commits

Author SHA1 Message Date
Marco Belladelli 726ae6a959 HHH-18178 Add test for issue 2024-09-13 12:37:25 +02:00
Marco Belladelli 67269a6137 HHH-18503 Register root table name usage for persisters with physical discriminators 2024-09-13 12:36:59 +02:00
marko-bekhta ecf4c29a60 HHH-18503 Add a test showing the issue 2024-09-13 12:36:59 +02:00
Yanming Zhou 464ad489d6 Mark field `INSTANCE` as private or deprecated for removal if method `instance()` present 2024-09-13 11:03:04 +02:00
Andrea Boriero c181e1913e Revert "HHH-18543 Skip GenericCompositeUserTypeTest for JVM OpenJ9"
This reverts commit 7e4df3f805.
2024-09-13 10:45:58 +02:00
Andrea Boriero d8ad674e7f HHH-18480 ClassCastException when updating a Blob with Oracle 2024-09-12 20:55:00 +02:00
Andrea Boriero 6cc292e9d3 HHH-18480 Add test for issue 2024-09-12 20:55:00 +02:00
Yoann Rodière 4b33d0d067 HHH-18602 Expose `determineDatabaseVersion` in `Dialect` 2024-09-12 12:48:38 -05:00
Andrea Boriero 4bd164222f HHH-18353 ArrayConstructorFunction comparing argument types by reference causes FunctionArgumentException 2024-09-12 15:43:15 +02:00
Andrea Boriero ab11020ed1 HHH-18353 Add test for issue 2024-09-12 15:43:15 +02:00
Andrea Boriero c1d9ac00bf HHH-18565 Mark bytecode enhanced lazy entities as RESOLVED 2024-09-12 14:01:49 +02:00
Andrea Boriero 1a03011d8e HHH-18565 Add test for issue 2024-09-12 14:01:49 +02:00
Matej Pucihar 4518f3daa0 HHH-18565 reproduce issue 2024-09-12 14:01:49 +02:00
Andrea Boriero 952cf531cf HHH-18556 Expressions.nullExpresion() in querydsl result in NPE in SqmExpressible 2024-09-12 13:18:26 +02:00
Andrea Boriero c56d413bf2 HHH-18556 Add test for issue 2024-09-12 13:18:26 +02:00
Gavin King f80ba1fe22 HHH-16880 nail a bit down the handling of converted types in TypecheckUtil 2024-09-11 22:43:06 +02:00
Gavin King 20cd322f37 extract a method in EnumJavaType 2024-09-11 22:43:06 +02:00
Gavin King c57a90e088 cleanup warnings in PersistenceContext
+ code cleanups in CacheEntityLoaderHelper
2024-09-11 08:36:44 +02:00
Gavin King 3a4da8dd85 HHH-18554 also deprecate CascadingActions.LOCK 2024-09-11 07:03:30 +02:00
Gavin King d82913d65f HHH-18544 multiload() and findAll() should return existing proxies 2024-09-11 07:03:30 +02:00
Gavin King 47270d4157 tidy up TypecheckUtil 2024-09-11 01:00:10 +02:00
Gavin King 58a6afe78d remove deprecated FunctionRenderingSupport 2024-09-11 01:00:10 +02:00
Gavin King f2f802645c cleanups related to function registry 2024-09-11 01:00:10 +02:00
Gavin King d269637f77 HHH-18554 deprecate @Cascade and CascadeType 2024-09-10 23:49:55 +02:00
Jan Schatteman 30f2a2045d HHH-18458 - Remove deprecated org.hibernate.EmptyInterceptor
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2024-09-10 21:41:50 +02:00
Gavin King 1f16a0698e fix more warnings 2024-09-10 17:25:21 +02:00
Gavin King 0c3b8fd819 unexpose the ServiceRegistry on SqmCreationContext + SqlAstCreationContext 2024-09-10 17:25:21 +02:00
Gavin King 25d0922ff9 fix up lots of warnings, esp. unused parameters 2024-09-10 17:25:21 +02:00
Gavin King b4e26b3e32 refactor a bit the BindingContext hierarchy 2024-09-10 17:25:21 +02:00
Gavin King 1abc64fc65 SqmCriteriaNodeBuilder doesn't need to be a SqmCreationContext 2024-09-10 17:25:21 +02:00
Gavin King 4a974fe976 fix up warnings in BasicDotIdentifierConsumer + genericize FullyQualifiedReflectivePathTerminal 2024-09-10 17:25:21 +02:00
Gavin King 0dedc62270 clean up JdbcXxxxJavaTypes 2024-09-10 17:25:21 +02:00
Gavin King 2e4c2ff565 clean up two more enums 2024-09-10 17:25:21 +02:00
Jan Schatteman d0d6f08243 Add cleanup method to test
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2024-09-10 16:58:46 +02:00
Jan Schatteman 8da3f3700f HHH-18592 - Remove deprecated @TestForIssue
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2024-09-10 14:09:20 +02:00
Gavin King 4a4c55f830 HHH-17576 fix tests to not demand that fractional seconds are stored for Times 2024-09-10 06:46:25 +02:00
Gavin King 6d64e854e2 HHH-17576 inappropriate use of getDefaultTimestampPrecision() as default precision
This default is only appropriate for timestamps (hence the name) and should not be
used for dates or plain times.
2024-09-10 06:46:25 +02:00
Gavin King 6d4002bd97 reset the ValueHandlingMode after pagination 2024-09-10 00:42:18 +02:00
Gavin King 9f91f2dbff major refactor to horrible instantiation of QueryEngine 2024-09-10 00:42:18 +02:00
Andrea Boriero 53f9321cc0 HHH-18520 Fix issue with dynamic model 2024-09-09 11:17:54 -05:00
Andrea Boriero 92c434dd9b HHH-18520 Upgrade to hibernate-models 0.9.0 2024-09-09 11:17:54 -05:00
Andrea Boriero 3c1b5c7a1d HHH-18520 Upgrade to hibernate-models 0.9.0 + HHH-18521 Leverage hibernate-models ModelsConfiguration 2024-09-09 11:17:54 -05:00
Gavin King 6e2ed7f1a0 HHH-17948 make findAll() accept FindOptions
and add missing options to MultiIdentifierLoadAccess
2024-09-09 17:24:10 +02:00
Gavin King 62e1b0470e HHH-17948 make getAll(), findAll() accept List instead of varargs 2024-09-09 17:24:10 +02:00
Gavin King 7e36768c65 fix warnings in StatelessSessionImpl 2024-09-09 17:24:10 +02:00
Gavin King 362da7ebf1 add javadoc cross links b/w byMultipleIds and findAll
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-09 17:24:10 +02:00
Gavin King 526e282c4c HHH-17948 add Session.findAll(), StatelessSession.getAll()
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-09 17:24:10 +02:00
Gavin King f25060eeac clean up obsolete code in MetadataBuildingProcess 2024-09-09 09:37:06 +02:00
Gavin King 22aba27cff use switch expressions in main enums 2024-09-09 09:00:10 +02:00
Gavin King eed7ec0837 fix a couple of warnings in Configuration 2024-09-09 09:00:10 +02:00
Gavin King 2a904a46b2 fix a minor typing issue in SessionFactoryImpl 2024-09-09 09:00:10 +02:00
Gavin King fc9229e9f4 warning cleanups in Dialects 2024-09-09 09:00:10 +02:00
Gavin King 47f9bcfb24 some code and warning cleanups in Hibernate class 2024-09-09 09:00:10 +02:00
Gavin King 6612868d29 some code and warning cleanups in org.hibernate.boot 2024-09-09 09:00:10 +02:00
Gavin King 04b8d80125
HHH-18492 add Hibernate.isEmpty() for pure convenience
HHH-18492 add Hibernate.isEmpty() for pure convenience

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-08 23:07:16 +02:00
Gavin King 349b209deb HHH-17739 add tests 2024-09-08 23:02:50 +02:00
Gavin King 6c6c92e88d HHH-17739 fix NPE for field with unsupported collection type
cleanups and warning fixes in TypeConfiguration and BasicValue
2024-09-08 23:02:50 +02:00
Paria f5e1d1cd73
HHH-18470: fix duplicate generated FK names for TABLE_PER_CLASS inheritance 2024-09-08 14:12:14 +02:00
Gavin King ee00217733 HHH-18586 report StaleObjectStateExceptions when batch update fails
and some minor cleanups to the Coordinators

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-08 14:02:48 +02:00
Gavin King e55c05f0b4 HHH-16954 introduce HibernateCriteriaBuilder.parameterList()
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-07 23:52:44 +02:00
Gavin King 0c1a1e9832 HHH-18584 fix logic for deciding if something is implicitly selectable
implicit joins should not be added to the select list!

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-07 13:49:27 +02:00
Gavin King 306991f8d9 HHH-18584 disallow "ambiguous" queries for the deprecated createQuery() method
and add support for using 'this' alias to infer the 'select' list (JPA 3.2)

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-07 13:49:27 +02:00
Gavin King 2630b33261 workaround for Maria reporting that "string" is a keyword
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-06 20:26:05 +02:00
Gavin King 57cfbb6161 simplify quoting algorithm in FilterHelper
and generally refactor logic

eliminate cast to FilterImpl

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-06 20:26:05 +02:00
Gavin King d1fdb24fb8 minor cleanups to InFlightMetadataCollectorImpl
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-06 20:26:05 +02:00
Gavin King a20fb5663d major rework of Template + battery of new tests
I discovered that the over-complex support for ANSI trim() was
completely broken, unsurprisingly, given the complexity of the
implementation, and the absence of tests.

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-06 20:26:05 +02:00
Gavin King 35f96d6e90 HHH-18570 reallow use of 'date' and 'time' as regular column names in parsed SQL
attempt to simplify the logic here

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-06 20:26:05 +02:00
Yanming Zhou cb0268a618 Remove redundant methods `isBatchLoadable()`
The method implementation is identical to default method
2024-09-06 16:28:26 +02:00
Noel Trout 8a88ad7f59 HHH-18571 Fix bug and correctly report effective batching 2024-09-05 14:53:02 +02:00
Noel Trout ff1d5fdb90 HHH-18571 Added test case demonstrating issue 2024-09-05 14:53:02 +02:00
Gavin King 52a9de7cac more @SuppressWarnings cleanups
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-05 10:46:52 +02:00
Gavin King 5748376edc improve an error message
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-05 10:46:52 +02:00
Gavin King 56e0893b3a some misc code cleanups
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-05 10:46:52 +02:00
Gavin King 0dd2defc89 @SuppressWarnings({"UnusedDeclaration"}) -> @SuppressWarnings("unused")
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-05 10:46:52 +02:00
Alex 9cf4bd8251 HHH-18560: added unittest 2024-09-05 10:36:36 +02:00
Alex 944ff41a65 HHH-18560: fix for invalid queries executed on DB2i AS/400 machine 2024-09-05 10:36:36 +02:00
Yanming Zhou b870214ce9 Polishing `EntityVersionMappingImpl`
1. remove unused field `BasicAttributeMapping attributeMapping`
2. remove unused constructor parameter `MappingModelCreationProcess creationProcess`
2024-09-05 09:58:41 +02:00
Gavin King 7c30bbed2b very minor code cleanups
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-04 22:22:58 +02:00
Gavin King eacbd78956 split out SessionFactorySettings and kill off MappingMetamodelImpl.close()
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-04 09:27:46 +02:00
Gavin King 4781c09d0d migrate toward the new PersistenceUnitTransactionType from JPA 3.2
clean up the test base classes etc.

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-04 09:27:46 +02:00
Gavin King 437b59a57d continue in attempt to clean up EMFBuilderImpl
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-03 19:05:12 +02:00
Gavin King 1f48e8c41d get rid of hangovers from HEM merge
make a rough start on cleaning up EntityManagerFactoryBuilderImpl

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-03 02:57:37 +02:00
Gavin King 049610b90d split out SessionFactoryRegistryMessageLogger
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 19:22:41 +02:00
Gavin King f6ff6fa0f7 code cleanup in Visitors
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King 763401a5c8 clean up the internal DefaultVisitor hierarchy
by removing two obsolete abstract superclasses

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King 9c75adcffc cleanups in event listeners
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King ec3be767e4 HHH-18553 handle case where managed entity was already removed
just short-circuit and abort the remove()

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King edf813083e HHH-18553 add a log message
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King 342afd28d4 improve/modernize some error messages
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King f7adc587b2 HHH-18553 add the test
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King 578023e538 HHH-18553 change thrown exception type
and cleanups in DefaultDeleteEventListener

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Andrea Boriero 7e4df3f805 HHH-18543 Skip GenericCompositeUserTypeTest for JVM OpenJ9 2024-09-02 10:00:18 +02:00
Gavin King 052eb0b78c cleanups to EventListenerGroup(Impl)
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 00:46:51 +02:00
Gavin King 48fc2ee66d cleanups to EntityEntryContext javadoc
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 00:46:51 +02:00
Gavin King 302dd29be1 move check for remove(detached) to SessionImpl for consistency/simplicity
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 00:46:51 +02:00
Gavin King f7db3f0005 misc cleanups
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 00:46:51 +02:00
Gavin King 09fa8ef76a HHH-18553 flush/evict when there is a managed instance while deleting the detached instance
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 00:46:51 +02:00
Gavin King 5c89079f2e consistently pass along session-level lock options
previously, these were respected by a random subset of session methods

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King 335f7bea9c avoid use of deprecated methods
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King f95182e736 more consistent error message between JPA and plain Hibernate
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00