Commit Graph

4659 Commits

Author SHA1 Message Date
Andrea Boriero e86a7a43d9 HHH-13107 - JtaWithStatementsBatchTest fails on Oracle
(cherry picked from commit 5515347ec3)
2019-02-24 15:44:42 -08:00
Guillaume Smet 72b9fb13ad HHH-13220 Only create the PersistentAttributeTransformer if the class is enhanced 2019-02-07 17:44:53 -08:00
Sanne Grinovero 747c784dc1 HHH-13100 Remove unused import 2019-02-07 17:44:53 -08:00
Guillaume Smet 7ecf22793f HHH-13100 Make a couple of equals()/hashCode() implementations lighter 2019-02-07 17:44:53 -08:00
Guillaume Smet f511e871fb HHH-13097 Don't throw an exception if there are two getter candidates 2019-02-07 17:44:53 -08:00
Guillaume Smet af519e3c12 HHH-13097 Cache a static ByteBuddy matcher 2019-02-07 17:44:53 -08:00
Guillaume Smet 38e48ef0bc HHH-13097 Cache the resolution of the getters 2019-02-07 17:44:53 -08:00
Guillaume Smet 43ee75b966 HHH-13097 Cache the annotations resolution 2019-02-07 17:44:53 -08:00
Guillaume Smet 3b0f092bce HHH-13097 Only rewrite class if enhanced in the ByteBuddy enhancer
This makes the behavior of the ByteBuddy enhancer consistent with the
behavior of the Javassist enhancer.

Currently, the Maven plugin rewrites every class provided.
2019-02-07 17:44:52 -08:00
Sanne Grinovero ddcb0bb0e6 HHH-13100 All custom implementation of Byte Buddy "Implementation" s should have a proper equals and hashcode 2019-02-07 17:44:52 -08:00
Sanne Grinovero 0c62351515 HHH-13057 Prevent Byte Buddy's Advice helper to reload to many resources from the ClassLoader 2019-02-07 17:44:52 -08:00
Guillaume Smet f388420eca HHH-13005 Upgrade to ByteBuddy 1.9.0 2019-02-07 17:44:52 -08:00
Sanne Grinovero bf1f56b6bb HHH-12919 Interning of strings for EntityReferenceAliases
(cherry picked from commit fb54090329)
2019-02-07 14:54:05 -08:00
Sanne Grinovero 5f7b41d54b HHH-12918 Interning of strings for Formula and Column exctraction templates
(cherry picked from commit 096b436f3d)
2019-02-07 14:54:04 -08:00
Sanne Grinovero e520fd9b99 HHH-12917 Interning of strings for Filter definitions
(cherry picked from commit 4fa0491341)
2019-02-07 14:54:04 -08:00
Gail Badner 8b4fd69dfa HHH-13194 : Some methods returning org.hibernate.query.Query are not defined for StatelessSession
HHH-13194 : Remove @Incubating from org.hibernate.query.Query
2019-02-07 14:54:04 -08:00
Gail Badner 98fb897712 HHH-13244 : add header to test; shorten table/column names to avoid oracle failure
(cherry picked from commit 0720b2b376)
2019-02-07 14:54:04 -08:00
Gail Badner 86879b3dd5 HHH-13244 : Fix EntityPrinter to log "<uninitialized>" for uninitalized proxies
(cherry picked from commit 36fc1ad35e)
2019-02-07 14:54:04 -08:00
Stoty 855dafc029 HHH-13244 - setting hibernate.jpa.compliance.proxy=true and
org.hibernate debug level to DEBUG breaks hibernate test case

simplify test case

(cherry picked from commit 80ff6b4fe6)
2019-02-07 14:54:04 -08:00
Chris Cranford 7ea75516b6 HHH-13164 - Revert changes made for HHH-11019. 2019-02-07 14:54:04 -08:00
Chris Cranford 6002a7bd7a HHH-13164 - Revert change made for HHH-12464.
(cherry picked from commit dc873c3d36)
2019-02-07 14:54:04 -08:00
Moritz Becker 516eac225e HHH-13169 - Use exact table name for multitable update queries instead of table alias
(cherry picked from commit 8f748db9b0)
2019-02-07 14:54:04 -08:00
Gail Badner d9e7428cbe HHH-13172 : Add @LogMessage(level = WARN) to CoreMessageLogger#unsupportedAttributeOverrideWithEntityInheritance (was lost due to bad conflict resolution) 2019-02-07 14:54:04 -08:00
Guillaume Smet b1ffde0e94 HHH-13172 Log a warning instead of throwing an exception when
@AttributeOverride is used in conjunction with entity inheritance

(cherry picked from commit 2dd008adb7)
2019-02-07 13:59:34 -08:00
Andrea Boriero 14f5473fef HHH-13076 - Hibernate 'Transaction already active' behaviour with JTA transaction manager
(cherry picked from commit a15dfe0e05)
2019-02-07 13:55:16 -08:00
Andrea Boriero e88e45cf38 HHH-13076 - Add test for issue
(cherry picked from commit 0fa4b50188)
2019-02-07 13:55:16 -08:00
Gail Badner 438733d32c HHH-13129 : Cascaded merge fails for detached bytecode-enhanced entity with uninitialized ToOne
(cherry picked from commit a66ca0463e)
2019-02-07 13:53:10 -08:00
Bolek Ziobrowski fb3b710d99 HHH-13129 - Add test
HHH-13129 : Move and reformat test

HHH-13129 : Add more tests
(cherry picked from commit c62f0a75cd)
2019-02-07 13:53:10 -08:00
Keshavan Santhanam 56f67fb0cd HHH-10891 Support @Any in @Embedded
(cherry picked from commit 64179673a3)
2019-02-07 13:50:38 -08:00
Guillaume Smet e20d66ad49 HHH-10891 Add a test case
(cherry picked from commit ac03494e70)
2019-02-07 13:50:38 -08:00
Andrea Boriero fdab459b82 HHH-13050 - On release of batch it still contained JDBC statements logged
(cherry picked from commit 11e71f6977)
2019-02-07 13:47:47 -08:00
Gail Badner 1642853c89 HHH-13050 : Add test with a batch that fails when addToBatch() is called
(cherry picked from commit a7fccaa377)
2019-02-07 13:47:47 -08:00
Andrea Boriero 6a91c6b0c5 HHH-13050 - Add test for issue
(cherry picked from commit be0ee006ab)
2019-02-07 13:47:47 -08:00
Gail Badner 36877bfd69 HHH-11209 : Log a DEBUG message if collection with queued operations is detached due to rollback; otherwise, log INFO message
(cherry picked from commit e12a688524)
2019-02-07 13:45:18 -08:00
Gail Badner 8c5b1b7740 HHH-11209 : Fix checkstyle error
(cherry picked from commit 741c84a10c)
2019-02-07 13:45:18 -08:00
Gail Badner cf18916444 HHH-11209 : Log a DEBUG message if collection with queued operations is detached due to rollback
(cherry picked from commit 7af7182cc1)
2019-02-07 13:45:18 -08:00
Gail Badner ed55fff92b HHH-11209 : Added test case for testing debug logging when collection is detached during rollback
(cherry picked from commit 22ad668b88)
2019-02-07 13:45:18 -08:00
Gail Badner aea7b31996 HHH-11209 : Test cases
HHH-11209 : NullPointerException in EntityType.replace() with a PersistentBag

HHH-11209 : Add test for merging a detached collection with queued operations

HHH-11209 : Throw UnsupportedOperationException if a detached collection with queued operations is merged

HHH-11209 : Ignore queued operations when merging a detached collection with queued operations; add warnings

HHH-11209 : Fix typo in comment
(cherry picked from commit 6f5b1e5543)
2019-02-07 13:45:18 -08:00
Guillaume Smet 4a564ab45a HHH-13059 Partially revert HHH-12594
The first commit was on the safe side, we decided to go the extra mile
and that was a mistake as we missed all the consequences.

The new issue is about having a shared ReaderCollector: we add the info
there for each batch which leads to collecting the elements several
times.

This reverts commit a19fc84320.

HHH-13059 : Correct Javadoc
(cherry picked from commit e6286e04f4)
2019-01-22 16:39:45 +01:00
Guillaume Smet 7047119061 HHH-13059 Add test
(cherry picked from commit 502fd78c45)
2019-01-22 16:38:48 +01:00
Gail Badner 4137181bb6 HHH-13084 HHH-13114 : Correct test case using reserved word
(cherry picked from commit fa5b632f4e)
2018-12-18 15:16:59 -08:00
Gail Badner b198a42db1 HHH-13084 HHH-13114 : Add test cases
HHH-13084 HHH-13114 : Refactor test cases

HHH-13084 HHH-13114 : Add test cases

HHH-13084 HHH-13114 : Refactor test cases

HHH-13084 HHH-13114 : Add failing test case

(cherry picked from commit 346b3c7f3e)

HHH-13084 HHH-13114 : Bugs querying entity with non-ID property named 'id'

HHH-13084 HHH-13114 : Query 'select count(h) from Human h' fails if a subclass has a non-Id property named 'id'

HHH-13084 HHH-13114 : Update hibernate-core/src/main/java/org/hibernate/hql/internal/ast/tree/FromElement.java

Co-Authored-By: dreab8 <dreborier@gmail.com>

HHH-13084 HHH-13114 - Fix FromElementType method name

HHH-13084 HHH-13114 : Correct generated column names

(cherry picked from commit 7316307d0e)
2018-12-18 09:23:06 -08:00
Guillaume Smet 91ede032c9 HHH-12555 Fix merging of lazy loaded blobs/clobs/nclobs
It's better to avoid pushing UNFETCHED_PROPERTY to the types as it
requires all the types to take it into account.

TypeHelper looks like the only sensible caller that needs change.

(cherry picked from commit 1af878166f)

HHH-12555 Add tests

(cherry picked from commit 4e05953240)

HHH-12555 : Update test to check results

(cherry picked from commit ca6dc226eb)

HHH-12555 : Remove code in LobMergeStrategy implementations that copied original Lob when target is null

(cherry picked from commit 4d0b5dc184)

HHH-12555 Add a DialectCheck for NClob support

(cherry picked from commit 855f34c771)

HHH-12555 Disable NClob test for dialects not supporting NClob

(cherry picked from commit 98249af058)
2018-12-18 09:20:27 -08:00
Andrea Boriero 6f636a8c0b Add 'Use {@link #getTransactionStartTimestamp()}' to SharedSessionContractImplementor#getTimestamp deprecated comment 2018-11-05 16:20:32 +00:00
Guillaume Smet 023db8de0e HHH-12935 Make ExportIdentifierTests extend BaseUnitTestCase 2018-10-16 23:58:10 +02:00
Gail Badner 6257846943 HHH-13011 Fix the tests: use int column in where clause 2018-10-16 23:58:10 +02:00
Guillaume Smet 8f13d226a4 HHH-12935 Require sequence support in ExportIdentifierTests 2018-10-16 23:58:10 +02:00
Guillaume Smet 91d94c7e69 HHH-13011 Fix the tests: use a boolean query 2018-10-16 23:58:10 +02:00
Guillaume Smet b964aae339 HHH-13011 Fix the tests: use a boolean query 2018-10-16 23:58:10 +02:00
Gail Badner 55e430dd43 HHH-13011 : test cases 2018-10-16 15:13:10 +02:00
Gail Badner b5d3826604 HHH-13011 : Add option enabling/disabling use of an entity's mapped where-clause when loading collections of that entity 2018-10-16 15:13:10 +02:00
Gail Badner 98ae615bbe HHH-12104 : Test cases using annotations and hbm.xml 2018-10-16 15:13:10 +02:00
Guillaume Smet d5d1f0781a HHH-12937 Only run the tests with H2Dialect 2018-10-16 14:23:17 +02:00
Gail Badner 5ba82d6691 HHH-12935 : Constraint and AuxiliaryDatabaseObject export identifiers are not qualified by schema or catalog
(cherry picked from commit ba80f0b3dc)
2018-10-16 04:01:30 -07:00
Gail Badner 320772e5ee HHH-12935 : test cases
(cherry picked from commit e3726bc4db)
2018-10-16 04:01:09 -07:00
Gail Badner 8da2daa4f1 HHH-12937 : Remove duplicated line
(cherry picked from commit ae2da95f55)
2018-10-15 23:36:58 -07:00
Gail Badner faabcafa81 HHH-12937 : Where clause for collections of basic, embeddable and "any" elements is ignored when mapped using hbm.xml
(cherry picked from commit eb14b8de6f)
2018-10-15 23:36:44 -07:00
Gail Badner 7c4d18404c HHH-12937 : test cases
(cherry picked from commit da50076afc)
2018-10-15 23:36:34 -07:00
Gail Badner 83a9adbdb8 HHH-13027 : org.hibernate.ejb.HibernatePersistence can no longer be used as a persistence provider name 2018-10-12 23:43:47 +01:00
Gail Badner 15924cb466 HHH-13027 : test case 2018-10-12 12:40:28 -07:00
Guillaume Smet 5f92f028c4 HHH-12784 Fix a regression in Javassist support 2018-09-13 11:21:14 +02:00
Jonathan Bregler 00ec2e4fde HHH-12961 Update HANA dialects Javadoc
- Fix the links
- Add some more information
2018-09-07 16:24:52 +02:00
Guillaume Smet e8fcbe29c3 HHH-12920 Fix a debug message causing an exception at debug level 2018-09-03 15:48:36 +02:00
Guillaume Smet b04de4c9f7 HHH-12932 Execute ByteBuddy code requiring privileges inside a privileged block 2018-08-28 00:43:46 +02:00
Guillaume Smet 56a29af496 HHH-12931 Revert "HHH-12542 - Add necessary privileged action blocks for SecurityManager used on WildFly."
This reverts commit d24685de67.
2018-08-27 17:38:07 +02:00
Dmitry Matveev b8b0fbc13c Fix a typo in a variable name 2018-08-15 18:32:50 +02:00
Guillaume Smet 5ed5656c29 Fix the previous commit to reference #getMaxResults() 2018-08-14 17:01:53 +02:00
Sande Gilda 70381b8c84 Fix Javadocs comments for Query.getHibernateMaxResults() method 2018-08-14 16:58:32 +02:00
Guillaume Smet 5b826c9062 HHH-12905 Improve the error message and update the tests accordingly
Also fix a loose end in the MySQL test: at least with MariaDB, using
a bit(1) as datatype for boolean does not work: it always return true
even if you set it to 0. Using either boolean or tinyint(1) solves
the issue.

As I'm not sure older versions of MySQL supports a real boolean type I
used a tinyint(1).
2018-08-14 13:17:24 +02:00
Guillaume Smet fdfef4f5ce HHH-12905 Fix error message tested in MySQL and PostgreSQL tests 2018-08-14 13:17:24 +02:00
Gail Badner 99b93ae949 HHH-12875 HHH-12882 : Drop tables in proper order in test setup methods
(cherry picked from commit 770ae50e8b)
2018-08-13 23:28:27 -07:00
Gail Badner 9c96641d00 HHH-12875 : Remove "where" clause for Top used by MultiTableTest;
After HHH-12875 is fixed, the "where" clause causes
            MultiTableTest to fail due to HHH-12016

(cherry picked from commit a5fa213658)
2018-08-13 22:00:21 -07:00
Gail Badner 69e7132e91 HHH-12875 : Add comments to clarify how Collection#setWhere and #setManyToManyWhere are used
(cherry picked from commit a3cecf3411)
2018-08-13 22:00:11 -07:00
Gail Badner f381490a49 HHH-12875 HHH-12882 : Class level where="..." clause hbm.xml mappings is not enforced on collections of that class; add parentheses when where clauses get combined in a conjunction (hbm and annotations)
HHH-12882 : correct assertions in ParentChildTest
(cherry picked from commit 27937e5627)
2018-08-13 21:59:59 -07:00
Gail Badner 70a39d91cb HHH-12875 HHH-12882 : test cases
(cherry picked from commit cdf5e45514)
2018-08-13 21:59:48 -07:00
Gail Badner 22c9b2ba0a HHH-12875 : Class level where="..." clause in hbm.xml mappings is not enforced on collections of that class
(cherry picked from commit 10826d8f3a)
2018-08-13 21:59:39 -07:00
Gail Badner 01243a9b0e HHH-12875 : test cases
(cherry picked from commit eef8974877)
2018-08-13 21:59:28 -07:00
Roland Kurucz f062abe72a HHH-12905 - Bind value [null] was not of specified type in StoredProcedureQuery 2018-08-13 18:04:58 +02:00
Guillaume Smet 7eb0cee178 HHH-12907 Avoid creating too many ByteBuddy objects
This commit should reduce the garbage collection pressure as reported at
https://github.com/raphw/byte-buddy/issues/515.
2018-08-13 16:27:02 +02:00
Vlad Mihalcea b65121c557 HHH-12361 - In the User Guide, omit constructors and equals/hashCode for brevity 2018-08-13 15:15:49 +02:00
Guillaume Smet 61bdbabf18 HHH-12906 Add tests 2018-08-13 12:05:10 +02:00
Florian Beaufumé cbd141996a HHH-12906 Used the correct attribute in getAllCollectionRoles() 2018-08-13 12:05:10 +02:00
Guillaume Smet ad4978c36a HHH-10782 Add a comment about what clearing the query plan cache means 2018-08-09 15:53:29 +02:00
Chris Cranford 0b17fc3225 HHH-12871 - Fix test that uses dynamic-map entities which failed.
(cherry picked from commit 8bd79b29cf)
2018-08-07 10:53:36 -04:00
Chris Cranford dc49ef6ef4 HHH-12871 - Fix metamodel to properly exclude dynamic-map based types when using ignoreUnsupported.
(cherry picked from commit b9e0449602)
2018-08-07 10:53:28 -04:00
Chris Cranford 9f3b1cfb5b HHH-12871 - Added test cases.
(cherry picked from commit 6a594712db)
2018-08-07 10:53:21 -04:00
Guillaume Smet a6c7733179 HHH-12196 Implement a naive limit handler for Sybase
It doesn't manage all the corner cases but it should be safe enough as
only triggered in the simple cases.
2018-08-03 17:24:04 +02:00
Guillaume Smet beb623093a HHH-12880 LockModeTest hangs indefinitely with Sybase due to HHH-12847 2018-08-02 14:32:46 +02:00
Guillaume Smet 236033bdaf HHH-12847 Consider LockOptions for getting the LockMode
Otherwise, it leads to null pointer exceptions.
2018-08-02 00:12:11 +02:00
Guillaume Smet 5150fd5d60 HHH-12857 Reuse the TypePool created in EnhancerImpl 2018-08-02 00:10:17 +02:00
Guillaume Smet fdf19f17b4 HHH-12857 Rewrite getDeclaredMethod() calls in static initializers
We rewrite them to run them as privileged blocks.
2018-08-02 00:10:17 +02:00
Guillaume Smet 129530e464 HHH-12857 Avoid using a static ByteBuddy object
In the end, it does not change anything as the BytecodeProvider is still
static but it helps as a general cleanup for the following commits.
2018-08-02 00:10:17 +02:00
Guillaume Smet c9de4b8ce7 HHH-12835 In the end, remove the assertion
It's not really compatible with batch loading, padding and a couple of
other corner cases.

And I don't think it has a lot of value by itself.
2018-08-01 16:16:19 +02:00
Andrea Boriero 7d9ebd262d HHH-12849 - QuotedIdentifierTest fails with ORA-04043 on Oracle12c 2018-08-01 13:42:25 +02:00
Guillaume Smet 0d224e45d6 HHH-12835 Fix an incorrect assertion in BatchFetchQueueHelper 2018-08-01 11:44:53 +02:00
Guillaume Smet 98f46d64e7 HHH-12848 Restore the original Oracle LimitHandler
Oracle does not support using the SQL 2008 standard limit handler with
FOR UPDATE clauses. Thus we need to get back to the old limit handler.
2018-08-01 11:44:53 +02:00
Guillaume Smet 92f194f291 HHH-10603 Avoid doing distinct and comparisons on byte arrays
They are stored as blobs starting with Oracle12cDialect and distinct and
comparisons on blobs are not supported.

Some tests were adapted, some are now skipped with Oracle12cDialect.
2018-08-01 11:44:49 +02:00
Guillaume Smet 6b679c8860 HHH-12730 Remove the deprecated methods previouly added
We don't need them as everything is now dealt with the transformer.
2018-08-01 11:15:39 +02:00
Guillaume Smet 338b97e7b5 HHH-12730 Add missing @Overrides 2018-08-01 11:15:39 +02:00
Guillaume Smet a4dd9a96d9 HHH-12730 Add deprecated constructors taking a SessionImplementor 2018-08-01 11:15:39 +02:00