Commit Graph

4878 Commits

Author SHA1 Message Date
Chris Cranford d6bc53235a HHH-12320 HHH-12975 - Make sure foreign key name/mode is set prior to building the constraint.
(cherry picked from commit 41e49725ae)
2021-07-15 15:26:08 -07:00
Chris Cranford 92f41e41f6 HHH-12320 HHH-12975 - Added test cases.
(cherry picked from commit 9022085f5c)
2021-07-15 15:26:08 -07:00
Ranabir Chakraborty 859ac47263 HHH-14697 TimePropertyTest fails on MySQL 8.0 with a ComparisonFailure 2021-07-09 10:15:17 -07:00
Andrea Boriero 2c7cbf04e0 HHH-14616 Change VERSION_COLUMN_ALIAS from v to version_
(cherry picked from commit dae2c73f83)
2021-06-04 11:17:02 -07:00
Gail Badner 3ce531f1d6 HHH-14616 : Add test case with default hibernate.globally_quoted_identifiers (=false) and version column quoted
(cherry picked from commit 23055fb6ce)
2021-06-04 11:17:02 -07:00
Andrea Boriero 2f0504853a HHH-14616 Oprimistic Lock throws org.hibernate.exception.SQLGrammarException: could not retrieve version
(cherry picked from commit 1b50cfaea1)
2021-06-04 11:17:02 -07:00
Andrea Boriero 755f4ef6b6 HHH-14616 Add test for issue
(cherry picked from commit 2a571aeb40)
2021-06-04 11:17:02 -07:00
Yoann Rodière 86d883e998 HHH-13682 Enable extended bytecode enhancement in NaturalIdInUninitializedAssociationTest
This test accesses a field of an entity directly and expects it to be
automatically initialized; this cannot work without extended bytecode
enhancement.

This used to work with Java 8 bytecode, but only by chance. It seems
that Java 8 bytecode relies on "synthetic", static access methods
inserted by the compiler to access the fields of entities in this test:
any access to the field is done through this access method instead of
through a direct field access. Since we apply bytecode enhancement to
all methods of entities, this means that access to fields triggers
initialization, without any bytecode enhancement in the caller class.

I believe this is specific to nested classes, but couldn't find a
source. For reference, the bytecode of access methods looks like this:

  static int access$002(org.hibernate.test.bytecode.enhancement.lazy.NaturalIdInUninitializedAssociationTest$AnEntity, int);
    Code:
       0: aload_0
       1: iload_1
       2: dup_x1
       3: putfield      #3                  // Field id:I
       6: ireturn

  static org.hibernate.test.bytecode.enhancement.lazy.NaturalIdInUninitializedAssociationTest$EntityImmutableNaturalId access$102(org.hibernate.test.bytecode.enhancement.lazy.NaturalIdInUninitializedAssociationTest$AnEntity, org.hibernate.test.bytecode.enhancement.lazy.NaturalIdInUninitializedAssociationTest$EntityImmutableNaturalId);
    Code:
       0: aload_0
       1: aload_1
       2: dup_x1
       3: putfield      #2                  // Field entityImmutableNaturalId:Lorg/hibernate/test/bytecode/enhancement/lazy/NaturalIdInUninitializedAssociationTest$EntityImmutableNaturalId;
       6: areturn

With Java 11, however, access to fields of entities is done directly,
even for nested classes. So the access methods no longer exist, and we
don't get automatic initialization upon field access. We need extended
bytecode enhancement, like we would in any other case of field access
(in particular accessing fields of non-nested classes).

(cherry picked from commit 1060baf74b)
2021-06-04 10:23:46 -07:00
Yoann Rodière b95f589e08 HHH-14640 Remove some JTA-related dependencies that weren't there in 5.3.20.Final 2021-06-03 16:10:37 -07:00
Andrea Boriero b3ae29406a HHH-14640 : Fix checkstyle errors 2021-06-03 16:10:37 -07:00
Andrea Boriero cc6fe84f30 HHH-14640 : Fix gradle errors 2021-06-03 16:10:37 -07:00
Andrea Boriero 40d82d6370 HHH-14640 : Fix issue with generated pom missing project description 2021-06-03 16:10:37 -07:00
Yoann Rodière f795213e5a HHH-13689 Replace uses of the deprecated osgi plugin with the biz.aQute.bnd plugin
https://docs.gradle.org/5.0-milestone-1/release-notes.html#deprecated-osgi-plugin
2021-06-03 16:10:37 -07:00
Yoann Rodière 861b3c00aa HHH-13685 Replace uses of deprecated classifier property in Jar tasks with archiveClassifier 2021-06-03 16:10:37 -07:00
Gail Badner d7b68ba8ce HHH-14537 : Updated test as requested; added tests that lazy associations with non-existing entity is unaffected.
(cherry picked from commit ad84aaf0bc)
2021-04-20 10:57:51 -07:00
Gail Badner c2bb67515f HHH-14537 EntityNotFoundException thrown when non-existing association with @NotFound(IGNORE) mapped has proxy in PersistenceContext
(cherry picked from commit 3c1e16e06c)
2021-04-20 10:57:51 -07:00
Gail Badner edcf4a6369 HHH-14537 : Added test for issue
(cherry picked from commit 9cb9137fb8)
2021-04-20 10:57:51 -07:00
Steve Ebersole bc8e38a9a8 HHH-14325 - Add Query hint for specifying "query spaces" for native queries
(cherry picked from commit be70d49df9)
2020-11-16 10:46:35 -06:00
Steve Ebersole d5067eccf3 HHH-14325 - Add Query hint for specifying "query spaces" for native queries 2020-11-16 10:46:20 -06:00
Andrea Boriero 2896372dd5 HHH-14257 Add test for issue 2020-11-16 09:39:00 +00:00
Andrea Boriero 00b3ccb8ec HHH-14257 An Entity A with a map collection having as index an Embeddable with a an association to the Entity A fails with a NPE 2020-11-16 09:38:56 +00:00
Andrea Boriero d22bbb5c33 HHH-14225 CVE-2020-25638 Potential for SQL injection on use_sql_comments logging enabled 2020-11-13 13:34:09 +00:00
Andrea Boriero 096916e6fa HHH-13310 getParameterValue() not working for collections 2020-11-10 18:53:09 +00:00
Andrea Boriero 36f9360a31 HHH-13310 Add test for issue 2020-11-10 18:52:59 +00:00
Scott Marlow 06fdd27b3d HHH-14196 Add parsing of persistence.xml/orm.xml documents in the EE 9 namespace
Signed-off-by: Scott Marlow <smarlow@redhat.com>
2020-11-10 13:23:57 +00:00
Steve Ebersole 204dc9f9db Fixed Javadoc for `BulkOperationCleanupAction.affectedEntity` 2020-11-10 11:35:03 +00:00
Andrea Boriero 1cdf75c212 HHH-14077 PostgreSQL, skip testLiteralProjectionAndGroupBy (PostgreSQL does not support literals in group by statement) 2020-08-04 14:58:21 -07:00
Gail Badner 646b383f95 HHH-14077 : CVE-2019-14900 SQL injection issue in Hibernate ORM 2020-08-04 14:58:21 -07:00
Gail Badner d7400b5a08 HHH-14103 : Add test cases showing that an entity's transient attribute can be overridden to be persistent in entity subclasses
(cherry picked from commit fb40f8edc0)
2020-08-04 14:47:41 -07:00
Vlad Mihalcea 7317331108 HHH-13110 - @PreUpdate method on a Embeddable null on the parent caused NullPointerException
(cherry picked from commit 3ff3615d00)
2020-08-03 15:15:36 -07:00
Gail Badner 23fae34ea9 Revert "HHH-14096 Remove unused import for deprecated type XmlDocument and dom4j"
Imports are required for 5.3 branch

This reverts commit 5ead0e4dd5.
2020-08-03 15:12:51 -07:00
Sanne Grinovero eeb8225b6f HHH-14096 Moving the XMLHelper from ORM core into testsuite helpers
(cherry picked from commit 115b5b9976)
2020-08-03 15:12:51 -07:00
Sanne Grinovero b13291591f HHH-14096 Remove unused import for deprecated type XmlDocument and dom4j
(cherry picked from commit 77ee4529a6)
2020-08-03 15:12:51 -07:00
Gail Badner bc0f109540 HHH-12268 : LazyInitializationException thrown from lazy collection when batch fetching enabled and owning entity refreshed with lock
HHH-12268 : Add imports back in because they are required for 5.3
2020-08-03 15:03:39 -07:00
Gail Badner d7af5ffbd6 HHH-12268 : Added test case 2020-08-03 15:03:39 -07:00
Andrea Boriero b425c6045f HHH-13936 Add additional test
(cherry picked from commit 0e1713a3a0)
2020-05-19 09:23:33 +01:00
michiel.hendriks 7b7ef154d1 HHH-13936 Call pulseTransactionCoordinator before checking for transaction in flush()
(cherry picked from commit 585ca8e2bf)
2020-05-19 09:23:33 +01:00
Sanne Grinovero f35229d19a HHH-13695 DDL export forgets to close a Statement
(cherry picked from commit b4a8052a15)
2020-04-29 16:39:11 -07:00
Panagiotis Sotiropoulos 78bcb66cd5 HHH-13960 Add SAXReader sec features to match the defaults 2020-04-21 10:50:46 +01:00
Gail Badner 2574016f44 HHH-13910 : MySQL57Dialect selected by automatic dialect resolution when using MySQL 8.0 database
(cherry picked from commit e1d2aecef7)
2020-03-26 21:26:41 -07:00
Gail Badner 5d51d48cea HHH-13910 : Added and corrected tests
(cherry picked from commit caded6cd40)
2020-03-26 21:26:41 -07:00
Yanming Zhou a7120626ab HHH-12977 - Update latest dialect for MySQL
(cherry picked from commit a9fd8efe33)
2020-03-26 21:26:41 -07:00
Gail Badner 3005b4bc60 HHH-13891 : ProxyFactory should not be built if any ID or property getter/setter methods are final
(cherry picked from commit a54d657d98)
2020-03-25 19:52:42 -07:00
Gail Badner c1f79fd304 HHH-13891 : Added test
(cherry picked from commit 3427bc8414)
2020-03-25 19:52:42 -07:00
Sanne Grinovero e0be465f2c HHH-13851 Remove a dead code field from PojoEntityTuplizer
(cherry picked from commit 8043e49384)
2020-03-25 19:52:42 -07:00
Sanne Grinovero 8d73884cbf HHH-13851 Rework initialization of ProxyFactoryFactory, allow some code reuse from SPI
(cherry picked from commit 0964b881f7)
2020-03-25 19:52:42 -07:00
Joël Arnold 9fc4f5b8e7 HHH-13184 - Oracle dialect detection does not return latest dialect in the default case 2020-03-25 19:47:53 -07:00
Andrea Boriero f0ffae0198 HHH-12858 HHH-13432 fix Oracle failing tests
(cherry picked from commit 1c840f9dd1)
2020-01-07 14:06:41 -08:00
Steve Ebersole 814a5ce6e2 HHH-12858 - integration overrides during JPA bootstrap ought to override all logically related settings
HHH-13432 - Have EntityManagerFactory expose persistence.xml `jta-data-source` element as a `javax.persistence.nonJtaDataSource` property

(cherry picked from commit ab508d2afa)
2020-01-07 14:06:41 -08:00
Steve Ebersole cec3107e13 HHH-12858 - integration overrides during JPA bootstrap ought to override all logically related settings
HHH-13432 - Have EntityManagerFactory expose persistence.xml `jta-data-source` element as a `javax.persistence.nonJtaDataSource` property

(cherry picked from commit fd72e4f75f)
2020-01-07 14:06:41 -08:00