Commit Graph

7327 Commits

Author SHA1 Message Date
Yoann Rodière 916bcbdef0 HHH-14659 Fix "join fetch" on mapped-by association being ignored when using bytecode enhancement 2021-06-09 17:02:39 +02:00
Yoann Rodière 50b8ad1f2b HHH-14659 Test query "join fetch" on lazy to-one associations with bytecode enhancement 2021-06-09 17:02:39 +02:00
Yoann Rodière 0eb187fae4 HHH-14659 Test join fetch correctly in HHH3949Test 2021-06-09 17:02:39 +02:00
Christian Beikov 5e0864729b Update H2 to 1.4.200. Replace LockMode in Fetch and DomainResult with the source alias to resolve lock mode during initializer creation. Introduce notion of aggregate function with an optional filter clause. Implement support for rendering locks into SQL. Move locking tests to orm package 2021-06-09 16:41:23 +02:00
Christian Beikov 66ae1c9557 HHH-14665 Fix schema generation test missing the default semi-colon in comments 2021-06-08 23:05:51 +02:00
Christian Beikov 10cba26bda HHH-14665 Use semi-colon as the default statement delimiter for scripts 2021-06-08 20:49:39 +02:00
Sanne Grinovero 40ed10e9fa HHH-14662 Remove unnecessary statuful lambda instances from StatisticsImpl 2021-06-08 15:55:09 +01:00
Christian Beikov 3443541f6c HHH-14655 Upper case the information schema sequence identifier again to fix issues with case sensitive databases 2021-06-07 16:39:36 +02:00
Andrea Boriero 6ced2f0aca Merge remote-tracking branch 'upstream/main' into wip/6.0 2021-06-07 12:47:53 +02:00
gavin 97869203ba rename things to 'Emulation' for consistency 2021-06-04 13:23:46 +02:00
nathan.xu f9534ead03 HHH-14642 finish ScrollableResultsImpl 2021-06-04 13:21:21 +02:00
Sanne Grinovero 5579a38d4d HHH-14650 AbstractRowReader: remove more redundant checks 2021-06-03 13:58:18 +01:00
Sanne Grinovero 84e7c5f63b HHH-14650 AbstractRowReader: remove unnecessary nullchecks 2021-06-03 13:58:15 +01:00
Sanne Grinovero fb69172a4b HHH-14650 AbstractRowReader: no need to pre-compute the entityInitializerByEntityReference cache in advance 2021-06-03 13:58:11 +01:00
Sanne Grinovero c22393d57b HHH-14650 Optimise AbstractRowReader for iterations on entity initializers 2021-06-03 13:58:05 +01:00
Sanne Grinovero df48d19bbc HHH-14647 Make ResourceRegistryStandardImpl#unassociatedResultSets lazily initialized 2021-06-03 10:07:45 +01:00
Jan Schatteman 2dc07c2ffe HHH-14503 - Migrate tests from jpa/test to orm/test/jpa
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2021-06-02 16:50:50 +02:00
Andrea Boriero 422b80b80d HHH-14624 Oracle from version 12 started supporting the syntax for pagination 2021-06-01 15:19:44 +01:00
Andrea Boriero 2952b60cc3 HHH-14624 add test 2021-06-01 15:19:44 +01:00
Gavin King fa261190ec HHH-14240 Stop generating fragments of uppercase SQL
Hibernate generates lowercase SQL.

(Note that I already fixed all this in H6, but not in H5.)
2021-06-01 15:16:10 +01:00
Andrea Boriero d413bdf2e9 Fix errors after merge with main 2021-05-31 16:21:31 +02:00
Andrea Boriero 451568f322 Merge remote-tracking branch 'upstream/main' into wip/6.0_merge_7 2021-05-31 14:55:18 +02:00
Andrea Boriero 2c6e000537 Merge branch 'wip/6.0_merge_6' into wip/6.0 2021-05-31 13:18:38 +02:00
Andrea Boriero 020319b4fb Re-enable additional tests 2021-05-27 12:02:08 +02:00
Andrea Boriero f47a44e1cf Fix eager batch collection not initialized 2021-05-27 09:31:43 +02:00
Andrea Boriero 21c607c929 Fix CollectionLoaderBatchKey parameters binding error 2021-05-27 09:31:43 +02:00
Andrea Boriero 629b318731 Fix SmqBagJoin, SqmSetJoin and SqmListJoin throwing NotYetImplementedFor6Exception 2021-05-27 09:31:43 +02:00
Yoann Rodière 07eca3883d HHH-14635 Upgrade to log4j 2 2021-05-26 09:05:56 +02:00
Christian Beikov 8c9330a8ff Fix jakarta tests 2021-05-25 18:11:29 +02:00
nathan.xu f90a5f930b HHH-14607 prefer FetchOptions over FetchStrategy 2021-05-25 07:29:52 -05:00
Vlad Mihalcea cea044ec69 HHH-14632 - Call statistics.queryPlanCacheHit and statistics.queryPlanCacheMiss for FilterQueryPlan and NativeSQLQueryPlan 2021-05-25 07:41:07 +02:00
Andrea Boriero ffae5474a6 Merge remote-tracking branch 'upstream/main' into wip/6.0_merge_6 2021-05-24 20:41:03 +02:00
Andrea Boriero 466c9b5f38 Merge branch 'main_2' into wip/6.0_merge_5 2021-05-24 16:00:11 +02:00
Christoph Dreis fc3accfbd1 HHH-14574 Avoid NPEs from LoadContexts.cleanup(ResultSet) 2021-05-24 12:08:05 +02:00
Andrea Boriero 26e858c78b HHH-14616 Change VERSION_COLUMN_ALIAS from v to version_ 2021-05-24 10:46:29 +01:00
Gail Badner 6bb1900495 HHH-14616 : Add test case with default hibernate.globally_quoted_identifiers (=false) and version column quoted 2021-05-24 10:46:29 +01:00
Andrea Boriero e76a60cbfc HHH-14616 Oprimistic Lock throws org.hibernate.exception.SQLGrammarException: could not retrieve version 2021-05-24 10:46:29 +01:00
Andrea Boriero 75bcb6bc0c HHH-14616 Add test for issue 2021-05-24 10:46:29 +01:00
Christian Beikov a57c0e34ff HHH-14618 Allow passing multiple script source files separated by comma 2021-05-24 11:42:36 +02:00
Christian Beikov bf19f98c2d HHH-14619 Test and fix ClassCastException because collection of uninitialized proxy is dirty checked 2021-05-21 09:15:36 +02:00
gavin 6dc3b4a726 make logFlushResults() protected for the benefit of HR 2021-05-20 15:07:34 +01:00
Sanne Grinovero e6688f8ebc HHH-14622 Improved iteration of PreLoadEventListener 2021-05-20 14:24:50 +01:00
Yoann Rodière ccc5eb1305 HHH-14620 Remove duplicate assertions in LazyCollectionLoadingTest 2021-05-20 11:53:57 +02:00
Yoann Rodière 12cb577f9f HHH-14620 Test incorrect initialization of a collection with extended bytecode enhancement 2021-05-20 11:53:57 +02:00
Yoann Rodière b9270e44b1 HHH-14620 Do not initialize collections just to take a snapshot of their size
As far as I can tell this is safe enough for dirty tracking:

* The collection tracker will return a size of -1 for that collection
* Which is exactly the behavior we currently get after
  $$_hibernane_clearDirtyCollectionNames is called if a collection has
  been "retrieved" (getter called) but was not initialized.
* This will mainly prevent some optimizations because we will no longer
  be able to tell whether a collection is "dirty" or not.

I think we should be able to restore those optimizations: for
PersistentCollection instances, we would store the "initial" size
inside the collection itself upon initialization,
and we would compare THAT size to the current size in implementations
of $$_hibernate_areCollectionFieldsDirty (see
org.hibernate.bytecode.enhance.internal.bytebuddy.CodeTemplates).

Alternatively we could store the CollectionTracker inside the
PersistentCollection so that the collection can update the tracker
upon initialization.

However, that's outside the scope of this bug, that would require
significant testing, and that may cause conflicts with ORM 6, so I won't
do it here.
2021-05-20 11:53:57 +02:00
nathan.xu 2e875f9b8a HHH-14617 remove QueryLiteralRendering and LiteralHandlingMode 2021-05-20 11:26:22 +02:00
Sanne Grinovero eb6c68cdc6 HHH-14621 Introduce new methods on EventListenerGroup which allow Hibernate Reactive to fire events more efficiently 2021-05-19 20:58:43 +01:00
Steve Ebersole db502bf1b0 prepare for 6.0.0.Alpha8 2021-05-18 12:37:36 -05:00
Andrea Boriero 531d0f923c Fix joined sublcass hql wrong join type for associations 2021-05-18 16:30:50 +02:00
Andrea Boriero b52dfbab7e Collection Intializer fix creation of persistence set instance for the wrong subclass 2021-05-18 16:30:50 +02:00
Andrea Boriero 9e343ac0d7 Re-enable additional tests and fix hql queries not detecting circularity 2021-05-18 16:30:50 +02:00
nathan.xu 92c70ecb08 HHH-14605 add BLOB, CLOB and NCLOB to JdbcTypeDescriptor's type category method 2021-05-18 12:51:59 +02:00
Steve Ebersole c7e37dc1d7 HHH-14513 : Move publishing release and snapshot artifacts to Sonatype OSSRH 2021-05-14 15:06:15 -05:00
nathan.xu d53216306f HHH-14600 verify UUID 2021-05-14 12:44:52 -05:00
Nathan Xu 0f683ff25d HHH-14601 fix the typo of `extracter` 2021-05-14 11:43:13 -05:00
Steve Ebersole c17396521c mariadb nationalization support 2021-05-13 12:43:59 -05:00
Steve Ebersole 71515af5cc HHH-14589 - Make sure documentation examples regarding basic-types work and update the section
- re-enable the basic-type tests in the `documentation` module
- fix basic-type resolution in various cases from tests in both `hibernate-core` and `documentation`
- updated the basic_types.adoc user-guide section + moved much of the "legacy" discussion to an appendix
- fixed missing impls of the optional contract `org.hibernate.type.AdjustableBasicType`
- improved handling of `NationalizationSupport` offered by a Dialect

NOTE :
- changes to `ColumnTransformerTest` are related to "composite basics" not being supported, not problems with `ColumnTransformer`.
- final failure in `org.hibernate.userguide.mapping.basic` is `SubselectTest#testRefreshLifecycle` which actually fails because refresh is not working properly
2021-05-13 09:58:20 -05:00
Andrea Boriero b30a68f5be HHH-14596 WhereAnnotatedOneToManySizeTest fails on HANA database 2021-05-13 09:49:14 +02:00
Jan Schatteman 987dbbba2f Fix in one of the PersistenceXmlParser.parse() methods used in tests
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2021-05-12 17:44:17 +02:00
Andrea Boriero f7ab5f315d HHH-14541 Only mark the session factory as closed *after* SessionFactoryObserver#sessionFactoryClosing was called 2021-05-12 17:27:14 +02:00
Yoann Rodière eb4e397a04 HHH-14541 Only mark the session factory as closed *after* SessionFactoryObserver#sessionFactoryClosing was called 2021-05-12 16:25:02 +02:00
Yoann Rodière 7f152c36f7 HHH-14541 Test that the session factory is still open in SessionFactoryObserver#sessionFactoryClosing 2021-05-12 16:25:02 +02:00
gavin e60e3736a7 cleaner approach to work around Oracle setNull(BOOLEAN) bug
- introduce doBindNull() in BasicBinder
- use WrapperOptions and FastSessionServices
- use getPreferredSqlTypeCodeForBoolean()
2021-05-12 14:56:51 +02:00
Fabio Massimo Ercoli d0febfd042 HHH-14585 Test more size() cases
In particular projections using a size function
2021-05-11 18:33:02 +02:00
Fabio Massimo Ercoli a106ce29dc HHH-14585 Handle filter fragment on CollectionSizeNode 2021-05-11 18:33:02 +02:00
Fabio Massimo Ercoli 15d9eb4112 HHH-14585 Skip test for some dialects 2021-05-11 18:33:02 +02:00
mrizzi 51529f5f20 HHH-14585 size() HQL function discards '@Where' clause 2021-05-11 18:33:02 +02:00
Andrea Boriero 0ecd66fd46 Fix use EmbeddedIdentifier instance as Entity 2021-05-10 18:12:06 +02:00
Christian Beikov 4e9b8c0c34 Introduce ForeignKeyDescriptor.Side wrapper around ModelPart of the FK sides to discriminate the role of the side better 2021-05-10 16:45:40 +02:00
Christian Beikov 3be99c1c73 Introduce enum for describing KEY and TARGET of FK and use/expose that to describe the FK direction of to-one associations 2021-05-10 14:33:28 +02:00
Christian Beikov a864e25339 Fix wrong key model of FK for inverse FK side 2021-05-07 12:47:47 +02:00
Andrea Boriero 867dd52ab3 Re-enabled OneToOneFormulaTest 2021-05-07 09:59:08 +02:00
Andrea Boriero 05ff370488 Re-enabled OneToOneFormulaTest 2021-05-07 09:57:56 +02:00
Christian Beikov e122ac33dc Fix foreign key direction issues 2021-05-06 16:54:47 +02:00
Andrea Boriero 0157af79f7 Fix OneToOneFormulaTest#testOneToOneFormula() 2021-05-06 12:33:41 +02:00
Andrea Boriero d6a6c29bd4 Re-enabled additional tests 2021-05-06 09:10:03 +02:00
Christian Beikov a7ed354af9 Cleanup the circular handling of fetch building of embeddable FKs. Use the target navigable path for target FK domain results 2021-05-06 08:50:07 +02:00
Christian Beikov 1a24c93155 Move tests from packages actionqueue, annotations, batch, boot, bytecode, id, resource, schemafilter, schematools, schemaupdate, schemavalidation, serialization, service, tool, unidir, util 2021-05-06 07:29:57 +02:00
Christian Beikov 71f666f0b6 Use Property#getPropertyAccessStrategy which internally delegates to BuiltInPropertyAccessStrategies to handle enhanced cases 2021-05-06 07:29:57 +02:00
Christian Beikov 8e26756cce Handle basic value type bindings before the copy identifier component second pass like in Hibernate 5 to avoid issues with missing types 2021-05-06 07:29:57 +02:00
Christian Beikov 9bba88b10e Fix NPE when fetch profile returns null for a fetch by role. Don't fetch discriminator in result set mapping if entity type has not subtypes 2021-05-06 07:29:57 +02:00
Christian Beikov c79e9effe9 Retain newlines between command parts in sql script parsing as spaces like in Hibernate 5. Also, improve the parsing efficiency by not defining rules and thus creating contexts for every token type 2021-05-06 07:29:57 +02:00
Christian Beikov 181ac6e0ff Move classloader, comments, connections, entityname, event, events, eviction, exception and fetch packages. Fix issues with key-many-to-one in collection key FK and implement cascade based fetching 2021-05-05 16:57:40 +02:00
Steve Ebersole c87a50ca0f Support for type coercion for values passed as ids and as query parameter bindings
- fixed compilation errors when using JDK 8
2021-05-04 09:15:19 -05:00
Steve Ebersole fa8571c706 Support for type coercion for values passed as ids and as query parameter bindings
- widening coercions
- valid (no over/under flow) narrowing coercions
- JpaCompliance setting
2021-05-04 07:42:06 -05:00
Steve Ebersole eb9bb2d82f Support for type coercion for values passed as ids and as query parameter bindings
- widening coercions
- valid (no over/under flow) narrowing coercions
- JpaCompliance setting
2021-05-04 07:21:11 -05:00
Steve Ebersole d95806b516 Support for type coercion for values passed as ids and as query parameter bindings
- widening coercions
- valid (no over/under flow) narrowing coercions
2021-05-04 07:21:11 -05:00
Christian Beikov 27662f91a9 Move most of the sql package to orm.test, remove unnecessary JdbcValuesMappingProducer implementations and make it clear that ResultSetMapping is required for native queries. Fix quoting and some hbm issues 2021-05-04 12:21:32 +02:00
Christian Beikov fef3e53132 Move where package to orm.test and further improve result set mapping support 2021-05-04 12:21:32 +02:00
Yoann Rodière 72f4a2f610 HHH-12445 Remove unused constants related to "null"/"not-null" discriminator values 2021-05-04 09:18:55 +02:00
Yoann Rodière 662f86abe1 HHH-12445 Test "null"/"not-null" discriminator values 2021-05-04 09:18:55 +02:00
Yoann Rodière 1a2510df16 HHH-12445 Fix ORM not detecting "null"/"not null" discriminator values correctly for joined inheritance 2021-05-04 09:18:55 +02:00
Yoann Rodière 7144af5990 HHH-12445 Auto-detect when discriminator columns are nullable 2021-05-04 09:18:55 +02:00
Andrea Boriero 8936034d29 HHH-14503 - Migration of tests from jpa/test to orm/test/jpa 2021-05-03 18:12:54 +02:00
Andrea Boriero 28d7f48019 HHH-14503 - Migration of tests from jpa/test to orm/test/jpa 2021-05-03 17:55:26 +02:00
Jan Schatteman 4a59e2d002 HHH-14503 - Migration of tests from jpa/test to orm/test/jpa
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2021-05-03 17:55:26 +02:00
Andrea Boriero 9bbad43e75 Fix PluraAttributeMapping wrong DelayedCollectionFetch creation 2021-05-03 17:25:18 +02:00
Emmanuel Duchastenier 41c71bfed7 HHH-13779 (5.4) - Foreign key schema migrator should be case-insensitive
This avoids re-creating existing foreign keys with a different name,
after migrating from Hibernate 4 to Hibernate 5 (as implicit naming
convention has changed).
Actually, some RDBMS allow it (PostgreSQL, MySQL, MS SQL Server, ...)
and duplicate the same key, whereas others (Oracle, ...) do not
allow it and Schema update fails.

This fix ignores the case of the table and column name when checking
if a equivalent Foreign Key already exists (whatever its name)

Closes https://hibernate.atlassian.net/browse/HHH-13779

(cherry picked from commit 0b819863f2)
2021-04-30 12:48:05 -05:00
Andrea Boriero 8dabefd111 HHH-14573 Remove useless call to EnhancementAsProxyLazinessInterceptor#isInitialized() 2021-04-30 13:11:01 +02:00
Christian Beikov ff9e9eebc9 HHH-13946 Create Jakarta artifacts for hibernate-core, hibernate-envers, hibernate-jpamodelgen and hibernate-testing 2021-04-30 11:41:05 +02:00
Christian Beikov eb8b8620d7 HHH-14274 Support for jakarta prefixed String properties for integrations 2021-04-30 11:41:05 +02:00
Christian Beikov 14b35bb3b6 HHH-14273 Support for jakarta.persistence prefixed String properties 2021-04-30 11:41:05 +02:00
Steve Ebersole 9348952507 support for selecting of joined plural attributes 2021-04-29 13:02:50 -05:00
Steve Ebersole 19fbf18908 minor renaming and `#toString` fixups 2021-04-29 13:02:50 -05:00
Christian Beikov c096b463ee Emulate null ordering for CockroachDB 2021-04-29 13:43:52 +02:00
Christian Beikov 33b0087f2a Emulate null ordering for CockroachDB 2021-04-29 12:16:05 +02:00
Sanne Grinovero 0a4cd8e800 HHH-14575 Adapt BasicProxyFactoryImpl to be more native-image friendly 2021-04-28 10:31:27 +01:00
Andrea Boriero 9872fd9f0f HHH-14503 - Migration of tests from jpa/test to orm/test/jpa 2021-04-27 15:52:05 +02:00
Jan Schatteman 4b184fa0f1 HHH-14503 - Migration of tests from jpa/test to orm/test/jpa
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2021-04-23 00:04:41 +02:00
Yoann Rodière 1023ee02b9 HHH-14571 Always report identifiers as initialized when using enhanced proxies 2021-04-22 17:25:18 +02:00
Yoann Rodière 6bc8421972 HHH-14571 Test that the identifier is always reported as initialized by Hibernate.isPropertyInitialized when using enhanced proxies 2021-04-22 17:25:18 +02:00
Andrea Boriero b27b414511 Fix EmbeddedForeignKeyDescriptor creation when o.h.mapping.Value has no columns, Re-enabled additional tests 2021-04-22 13:52:16 +02:00
Christian Beikov 12f1c7917e HHH-14475 Don't render subquery for collection functions 2021-04-22 12:19:45 +02:00
Burkhard Graves 96980606fd HHH-14475 - select indices from ternary relation is broken since 5.4.13 (at least in mariadb) 2021-04-22 12:19:45 +02:00
Gavin King 179327cd40 [HHH-14031] on H2 1.4.200 and above use localtime/localtimestamp
As suggested by @famod we need to use localtime instead
or current_time because of changes in H2.

In particular the JDBC driver now refuses to convert
TIME/TIMESTAMP WITH TIME ZONE to plain TIME/TIMESTAMP.
2021-04-22 12:18:36 +02:00
Andrea Boriero 15e49692e9 Fix wrong creation of new instances for non aggregated id with no IdClass 2021-04-22 10:32:03 +02:00
Christian Beikov 9080872946 Infer parameter bind type for null parameter values instead of using a default 2021-04-22 10:16:52 +02:00
Andrea Boriero c48606a5aa Merge remote-tracking branch 'upstream/main' into wip/6.0_merge_1 2021-04-20 09:45:47 +02:00
Steve Ebersole 607234e7bf re-enable tests
re-organize some tests
o.h.test.hql.ParameterTest -> LegacyParameterTests
bug with binding ordinal parameter lists
created "standard domain model" for Hibernate's legacy Animal model
2021-04-19 16:44:25 -05:00
Steve Ebersole cebb9d7649 re-enable tests
re-organize some tests
o.h.test.hql.EntityJoinTest
fixed RIGHT JOIN handling
2021-04-19 14:34:48 -05:00
Yoann Rodière 8389b1a7a2 HHH-14567 Do not reuse query plans after session filters changed 2021-04-19 17:58:57 +02:00
Yoann Rodière 3bac846de2 HHH-14567 Test enabling filters after query creation but before query execution 2021-04-19 17:58:57 +02:00
Yoann Rodière 4264bc55ac HHH-14563 Remove the DOM4J dependency from hibernate-core 2021-04-19 15:39:35 +02:00
Yoann Rodière 87a3e0a5d8 HHH-14563 Remove a few obsolete references to DOM4J entity-mode
This mode was removed literally a decade ago.
2021-04-19 15:39:35 +02:00
Yoann Rodière b076216e84 HHH-14563 Remove XmlMappingOptions
We don't need that anymore: XML mapping is either enabled or disabled,
there are no other options. So a boolean will do.
2021-04-19 15:39:35 +02:00
Yoann Rodière 6f5f6b32c3 HHH-14563 Remove DOM4J-based XML mapping
Use JAXB-based XML mapping everywhere.
2021-04-19 15:39:35 +02:00
Yoann Rodière 194e53a0fb HHH-14563 Remove legacy tests for DOM4J-based XML mapping 2021-04-19 15:39:35 +02:00
Yoann Rodière 4f7bb75ec7 HHH-14529 Fix access type being ignored when defined at the entity level in orm.xml
That's a bug I introduced when I migrated code from dom4j to jaxb.
2021-04-19 15:39:35 +02:00
Yoann Rodière 5b830f3f5e HHH-14529 Fix invalid order of elements in orm.xml files used for tests
Surprisingly, the XSD does mandate a specific order for some elements,
including "entity", "embeddable" and the children of "attributes".

It turns out we were allowing a wrong order with the dom4j
implementation, but we no longer do with the jaxb implementation.
2021-04-19 15:39:35 +02:00
Yoann Rodière 6723ed4626 HHH-14529 Fix incorrect attribute name for @NamedEntityGraph in JPAXMLOverriddenAnnotationReader 2021-04-19 15:39:35 +02:00
Andrea Boriero 6f75d96a99 HHH-14549 Collection with default field initializer will always be empty 2021-04-19 14:14:48 +02:00
Andrea Boriero 7620e0e395 HHH-14549 Add test for issue 2021-04-19 14:14:48 +02:00
Jan Schatteman 107aab03eb Added test for non-select criteria queries
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2021-04-16 12:14:45 -05:00
Christian Beikov 9cea757979 Move unionsubclass tests and implement better union subclass support 2021-04-16 18:50:31 +02:00
Jan Schatteman 9e66c77749 Correction to the QuerySqmImpl constructor used for criteria queries
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2021-04-16 10:34:11 -05:00
Christian Beikov 4f6019d524 Cleanup case when handling and implement parameter handling for case result arms 2021-04-16 07:27:19 -05:00
Andrea Boriero badc99705a Merge remote-tracking branch 'upstream/main' into wip/6.0_merge 2021-04-16 13:19:16 +02:00
Christian Beikov df9d285f2c Implement support for avoiding joins when accessing FK keys 2021-04-16 10:35:05 +02:00
Steve Ebersole c74e5ef595 re-enable tests
re-organize some tests
continuing with o.h.test.hql
improve cast-target handling
2021-04-15 12:51:02 -05:00
Steve Ebersole b31f2c02d7 re-enable tests
re-organize some tests
CastNullSelectExpressionTest (not-implemented-yet)
2021-04-15 11:42:07 -05:00
Steve Ebersole 4917d7c6bd re-enable tests
re-organize some tests
continuing with o.h.test.hql
improve cast-target handling

https://github.com/hibernate/hibernate-orm/discussions/3889
2021-04-15 11:41:43 -05:00
Steve Ebersole e0bbb02c99 re-enable tests
re-organize some tests
case expression and nested expression type inference
preliminary support for "type precedence"
2021-04-15 08:52:41 -05:00
Steve Ebersole c2f59beb64 re-enable tests
re-organize some tests
case expression and nested expression type inference
preliminary support for "type precedence"
2021-04-15 08:52:32 -05:00
Yoann Rodière ac4f4ff4ad HHH-14529 Implement the (opt-in) orm.xml handling using JAXB 2021-04-15 14:01:28 +02:00
Yoann Rodière 10aee2a9fa HHH-14529 Add a common interface for Jaxb representations of associations 2021-04-15 14:01:28 +02:00
Yoann Rodière 437af3b4da HHH-14529 Add a common interface for JaxbEntity, JaxbMappedSuperclass and JaxbEntityListener 2021-04-15 14:01:28 +02:00
Yoann Rodière b4dd2e272f HHH-14529 Add a few missing methods to the JAXB representation of ManagedType 2021-04-15 14:01:28 +02:00
Yoann Rodière efe5424d35 HHH-14529 Add a few missing enum mappings for orm.xml 2021-04-15 14:01:28 +02:00
Yoann Rodière bbc25cf28b HHH-14529 Add common interface for JaxbEntity and JaxbMappedSuperclass 2021-04-15 14:01:28 +02:00
Yoann Rodière 8ab3a2f7e9 HHH-14529 Configuration and wiring to prefer JAXB over DOM4J for orm.xml handling 2021-04-15 14:01:28 +02:00
Yoann Rodière e8cd9f8917 HHH-14529 Clean up constructors in JPAXMLOverriddenMetadataProvider and related 2021-04-15 14:01:28 +02:00
Yoann Rodière ef6bb2679b HHH-14529 Remove an unused orm.xml file from tests 2021-04-15 14:01:28 +02:00
Yoann Rodière 7291036680 HHH-14529 Copy orm.xml handling code to prepare for the new JAXB-based implementation
We will adapt the code in a later commit; I'm only doing the copy in
this commit in order to keep the review manageable.
2021-04-15 14:01:28 +02:00
Yoann Rodière 55ef4d47f2 HHH-14529 Remove commented-out code related to mapping parsing using dom4j 2021-04-15 14:01:28 +02:00
Yoann Rodière f92275f6c2 HHH-14529 Clarify that most fields are final in JPAOverriddenAnnotationReader 2021-04-15 14:01:28 +02:00
Yoann Rodière 2907c95cbd HHH-14529 Introduce JAXB bindings for JPA's orm.xml
Adapted from Steve's work on the unified JPA/ORM XML mapping. See:
4ff3795e60 (diff-b407928c3aa7ee1f231e0119ff70345caa5f6a83ed6348128c5159afbe3c6df2)
https://github.com/sebersole/hibernate-orm/compare/jandex-binding

Co-authored-by: Steve Ebersole <steve@hibernate.org>
2021-04-15 14:01:28 +02:00
Yoann Rodière 252fb65f95 HHH-14529 Remove an unused xjb file 2021-04-15 14:01:28 +02:00
Yoann Rodière 18f23ee701 HHH-14529 Fix invalid namespace URIs in MappingXsdSupport
Probably copy/pasted from ConfigXsdSupport, and we forgot to add the
"/orm" suffix.
2021-04-15 14:01:28 +02:00
Yoann Rodière fcc63d9ab0 HHH-14529 Stop using two separate BootstrapServiceRegistries for the same SessionFactory in BaseCoreFunctionalTestCase 2021-04-15 14:01:28 +02:00
Yoann Rodière ebb30aa178 HHH-14530 Allow adding pre-parsed XML mappings to MetadataSources
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-04-15 14:01:28 +02:00
Steve Ebersole 3958ee2360 re-enable tests
re-organize some tests
work on `org.hibernate.test.hql.size`
improved key/target handling for fk-descriptor
2021-04-14 16:06:15 -05:00
Yoann Rodière 571af7bc9e HHH-14557 Test JDBC resources are released on each rollback 2021-04-14 14:15:07 +02:00
Yoann Rodière e03beca97f HHH-14557 Test JDBC resources are released on each commit
Not just on session closing.
2021-04-14 14:15:07 +02:00
Yoann Rodière 3825a671a7 HHH-14557 Always release JDBC connection and resources on rollback 2021-04-14 14:15:07 +02:00
Christian Beikov c4445fbf5c Work on named-native query support 2021-04-13 10:32:55 +02:00
Andrea Boriero ae69a1aeb4 Fix MariaDB, DB2 and Derby column type for text type attributes 2021-04-10 12:34:58 +02:00
Andrea Boriero 6f42929b55 Move tests from org.hibernate.test.immutable to org.hibernate.orm.test.immutable 2021-04-10 12:34:58 +02:00
Andrea Boriero 951a7611b3 JPA Criteria do not load eagerly JOIN Fecth collections as Hibernate Criteria did 2021-04-10 12:34:57 +02:00
Andrea Boriero dc21d565d3 JPA Criteria do not load eagerly JOIN Fecth collections as Hibernate Criteria did 2021-04-10 12:34:57 +02:00
Andrea Boriero f6f1cb06d4 Fix issue with EmbeddableMappingType creation 2021-04-10 12:34:57 +02:00
Andrea Boriero 7fc2593515 AbstractImmediateCollectionInitializer fix NPE 2021-04-10 12:34:56 +02:00
Andrea Boriero 9c27e41184 Remove o.h.testing.junit5 package 2021-04-10 12:32:18 +02:00
Steve Ebersole 4f2b0778d3 re-enable tests
re-organize some tests
continuing with o.h.test.hql
improve parameter handling by tracking mapping-model types resolved for them in SQM->SQL translation
improve support for ANY mapping use in queries
improve support for comparisons involving SqlTuple
improve support for binding composite Query param values
improve support for plural-attribute refs in SQM
improve support for to-one attribute refs in SQM (including lazily generating the TableGroupJoin when used as selection)
2021-04-09 16:02:56 -05:00
Andrea Boriero 6bd7a4d972 HHH-14503 - Migration of tests from jpa/test to orm/test/jpa 2021-04-08 17:33:43 +02:00
Andrea Boriero a7f242af03 HHH-14503 - Migration of tests from jpa/test to orm/test/jpa 2021-04-08 17:33:43 +02:00
Jan Schatteman e2225d8814 HHH-14503 - Migration of tests from jpa/test to orm/test/jpa
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2021-04-08 17:33:43 +02:00
Steve Ebersole 3d90dbfbae re-enable tests
re-organize some tests
continuing with o.h.test.hql
improve parameter handling by tracking mapping-model types resolved for them in SQM->SQL translation
2021-04-08 08:08:54 -05:00
Christian Beikov 06b5eb43c6 HHH-11692 Introduce DISTINCT predicate in HQL and implement emulations 2021-04-07 18:28:38 +02:00
Andrea Boriero e67d10ee6c Merge remote-tracking branch 'upstream/main' into wip/6.0 2021-04-07 09:19:21 +02:00
Steve Ebersole c85ec5a7e4 re-enable tests
re-organize some tests
continuing with o.h.test.hql - order-by
2021-04-06 14:31:36 -05:00
Christian Beikov b166e684e1 Skip certain LockTests for Oracle on GH Actions which don't work there 2021-04-06 16:12:19 +02:00
Andrea Boriero e8a5506eb5 Merge remote-tracking branch 'upstream/main' into wip/6.0 2021-04-06 10:17:37 +02:00
Christian Beikov c285f604f3 Implement table group rendering for real table groups and get rid of canInnerJoin flags due to that 2021-04-06 09:08:18 +02:00
Steve Ebersole 159135ea89 re-enable tests
re-organize some tests
continuing with o.h.test.hql - order-by
add Expression#unwrap to help account for SqlSelectionExpression
2021-04-02 07:30:08 -05:00
Steve Ebersole 51074eb9a0 re-enable tests
re-organize some tests
continuing with o.h.test.hql
fixed bug in JPA model building with dynamic entities
added NavigablePath#getUnaliasedLocalName to aid in resolving ModelParts as part of SQM->SQL
2021-04-01 11:07:28 -05:00
Christian Beikov f1ede3df4f Fix type resolution issues and add missing JTDs. Fix SQL trim parsing and some newly added tests 2021-04-01 16:07:21 +02:00
Christian Beikov e22dc55adb Various fixes
* Resolve return type for SUM according to JPA spec
* Specify invariant return types for SQRT and MOD as required by the JPA spec
* Fix JPA tuple element access support
* Fix join management for JPA related methods
* Handle optional escape character for like predicate
* Implement type inference for result arms of case expressions
* Implement min/max element/index functions as sub-query
* Implement min/max function support
* Implement emptiness, exists and member of predicate for JPA Criteria
* Implement size function as sub-query
* Implement group by entity alias by using FK key
2021-04-01 16:07:21 +02:00
Christian Beikov 46a16c605a Add support for DML with versioned entities 2021-04-01 16:07:21 +02:00
Steve Ebersole af891c0997 re-enable tests
re-organize some tests
clean-up and tests related to fks
2021-04-01 06:54:57 -05:00
Steve Ebersole 1a9079006c Rename SelectionMapping(s) to SelectableMapping(s) and related changes 2021-03-31 11:21:51 -05:00
Steve Ebersole c7c963075b re-enable tests
re-organize some tests
support for `KEY(mapReference)` in SQM
2021-03-31 09:04:33 -05:00
Gail Badner ad84aaf0bc HHH-14537 : Updated test as requested; added tests that lazy associations with non-existing entity is unaffected. 2021-03-30 11:19:38 -07:00
Gail Badner 3c1e16e06c HHH-14537 EntityNotFoundException thrown when non-existing association with @NotFound(IGNORE) mapped has proxy in PersistenceContext 2021-03-30 11:19:38 -07:00
Gail Badner 9cb9137fb8 HHH-14537 : Added test for issue 2021-03-30 11:19:38 -07:00
Steve Ebersole a692061ae1 re-enable tests
re-organize some tests
fixed edge case for implicit basic type resolution
2021-03-30 08:47:16 -05:00
Steve Ebersole fcd7a6f356 re-enable tests
re-organize some tests
fixed bad merge
2021-03-29 12:23:37 -05:00
Steve Ebersole 7fcde66d61 HHH-14524 : Rename SqlType(X) as JdbcType(X) 2021-03-29 11:33:56 -05:00
Steve Ebersole a02835bdde re-enable tests
re-organize some tests
added `@LoggingInspections`
added `@MessageKeyWatcher`
account for various "odd" explicit Type mappings
fix column read/write transformations
2021-03-29 10:58:44 -05:00
Gavin King e4f1461e17 move the code for generating check constraints to Dialect 2021-03-26 21:27:46 +01:00
Steve Ebersole e4111a5453 re-enable tests
re-organize some tests
added `@LoggingInspections`
added `@MessageKeyWatcher`
2021-03-26 12:50:32 -05:00
Gavin King 3c72f6fe12 cleanup lots of warnings, especially generics-related 2021-03-26 18:45:18 +01:00
Gavin King d193a9409a simply remove @Tuplizer completely 2021-03-25 18:54:41 +01:00
Gavin King 20e855acf1 use wildcard instead of raw type in annotation members 2021-03-25 18:54:41 +01:00
Gavin King aeee127e59 deprecate @Tuplizer since EntityTuplizer is deprecated
and add a constraint to the class type
2021-03-25 18:54:41 +01:00
Gavin King 4e22929c3c remove deprecated FlushModeType
that was already removed from FlushMode
2021-03-25 18:54:41 +01:00
Gavin King bbf4619fcd remove deprecated Sort annotation 2021-03-25 18:54:41 +01:00
Gavin King d0afd6359e remove deprecated and unused members of QueryHints 2021-03-25 18:54:41 +01:00
Gavin King 9dcbe4c2d1 get rid of useless members of @Tuplizer annotation
Get rid of both the deprecated way and the unimplemented (!) way
of doing something that was never useful to begin with.
2021-03-25 18:54:41 +01:00
Gavin King 3b3487a74e remove deprecated @Entity annotation 2021-03-25 18:54:41 +01:00
Gavin King 50363dcc2c remove deprecated CascadeType.EVICT 2021-03-25 18:54:41 +01:00
Gavin King c89319f3e9 remove AccessType annotation 2021-03-25 18:54:41 +01:00
Gavin King 4b56842c7f make @AttributeAccessor annotation typesafe 2021-03-25 18:32:21 +01:00
Gavin King ef69465f48 move several new types out of the root package
The namespace org.hibernate is already much too cluttered and
we should try hard to not make it worse in H6.

Furthermore, some of these things look to be of more interest
to developers of Hibernate than to users.

Now, I'm not sure that org.hibernate.query is absolutely the
best place either, but it's at least better.
2021-03-25 17:33:54 +01:00
gavin af84daa416 remove some deprecated code
- OptimisticLockException
- MappingNotFoundException
- BasicQueryContract

these types were already deprecated in 5.
2021-03-25 17:30:24 +01:00
Andrea Boriero 9d6306cac2 re-enabled AggressiveReleaseTest tests 2021-03-25 17:09:54 +01:00
Christian Beikov cee56a5c42 Fix tests for PostgreSQL 2021-03-25 12:52:38 +01:00
Christian Beikov 9c175d0de2 Fix issues in PackagedEntityManagerTest 2021-03-25 11:57:29 +01:00
Christian Beikov 9612c838ed Fix test suite hanging for PostgreSQL and MariaDB 2021-03-25 09:22:59 +01:00
Christian Beikov 2b06123635 Try dropping local tables in same connection 2021-03-25 09:20:39 +01:00
Steve Ebersole fd470d1387 re-enable tests
re-organize some tests
2021-03-24 16:10:43 -05:00
Steve Ebersole 523113d2ca re-enable tests
re-organize some tests

fixed EnumType mapping from hbm.xml
various fixes in HQL, Criteria and parameter handling related to enum values
2021-03-24 15:34:14 -05:00
Andrea Boriero 1114da8b8f Merge remote-tracking branch 'upstream/main' into wip/6.0 2021-03-24 09:45:58 +01:00
Guillaume Smet 2c1aedd176 HHH-12867 Add test case 2021-03-24 09:40:11 +01:00
Steve Ebersole edcd7cfdc4 re-enable tests
re-organize some tests
fixed more missing `@Entity#name`
2021-03-23 14:53:34 -05:00
Steve Ebersole e04a9bff0d re-enable tests
re-organize some tests
2021-03-23 13:13:12 -05:00
Steve Ebersole 1caebf7cc6 re-enable tests
re-organize some tests
2021-03-22 17:28:28 -05:00
Steve Ebersole 1f028095cf re-enable tests
remove org.hibernate.type.descriptor.java.JavaTypeDescriptorRegistry
re-organize some tests
2021-03-22 15:40:25 -05:00
Mark Rotteveel e76da92b04 HHH-14484 Improve support for Firebird 4
Also includes:
- Some general Firebird improvements
- Tweak tests to run (or be skipped) against Firebird
- Fix to BooleanDecoder
- Add statistical/linear regression function definitions in CommonFunctionFactory
- Added the relevant functions to other dialects where I could verify they apply
- Fix for unions with parenthesized selects
- Add casts for parameters in functions
2021-03-22 19:08:05 +01:00
Andrea Boriero 0864c6e711 Fix test failures 2021-03-22 17:56:34 +01:00
Andrea Boriero 619a123c8d Fix DriverManagerRegistrationTest failure 2021-03-22 14:22:24 +01:00
Andrea Boriero c3df793dbe HHH-14509 : Git master -> main branch renaming 2021-03-22 12:38:00 +01:00
Andrea Boriero 96d103215c Merge remote-tracking branch 'upstream/main' into wip/6.0 2021-03-22 12:26:31 +01:00
Steve Ebersole 6d49d1c49f re-enable tests 2021-03-19 16:24:59 -05:00
Steve Ebersole cc105596b4 re-enable tests 2021-03-19 15:51:45 -05:00
Steve Ebersole 12fb58f6b9 re-enable tests 2021-03-19 15:25:08 -05:00
Steve Ebersole 2589671fa1 re-enable tests 2021-03-19 13:56:57 -05:00
Steve Ebersole 725faa258f HHH-14509 : Git master -> main branch renaming 2021-03-19 10:59:03 -05:00
Christian Beikov e29f616d77 Add Oracle specific SqlTypeDescriptor for Boolean that binds with type BIT for null boolean 2021-03-18 20:19:03 +01:00
Christian Beikov 5b0b822717 Move tests to orm/test and fix query cache stats, native query variable substitution and named query support as loader 2021-03-18 20:19:03 +01:00
Andrea Boriero 3e32e15c0a Avoid new join sqm path creation when it already exists 2021-03-18 13:18:28 -05:00
Andrea Boriero 4144c4af4c Fix Criteria NPE for named parameters when paramClass is a Collection 2021-03-18 15:06:55 +01:00
Gautham Kumar b4bf58188c HHH-14449 : ResultStream closing is not properly handled 2021-03-18 07:22:42 -05:00
Andrea Boriero 86c024a245 Fix Cannot resolve path with EmbeddedId hql queries not using aliases 2021-03-18 11:24:35 +01:00
Steve Ebersole 31b1627baa HHH-14506 - IdentifierGenerator changes
- HHH-14491 - Apply default allocation/increment size for @GeneratedValue(AUTO)
- HHH-14492 - Prefer sequence-per-entity (hierarchy) by default
- HHH-14497 - Drop `hibernate.id.new_generator_mappings` & `hibernate.model.generator_name_as_sequence_name`
- enabled existing tests and convert to JUnit5
2021-03-17 18:00:22 -05:00
Joseph B. Ottinger d963acf443 HHH-14508 : Fixing invalid conversion specifier 2021-03-17 15:06:06 -05:00
Jan Schatteman 7695f03bf9 HHH-14503 - Migration of tests from jpa/test to orm/test/jpa
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2021-03-16 17:58:45 +01:00
Christian Beikov 3f2afe6b40 Move tests from cfg, dialect, id/enhanced, jdbc to orm/test and fix SQL Server 2005 limit handler issue, as well as sqm function return type resolver issue 2021-03-16 17:58:34 +01:00
Andrea Boriero 222e3fb697 Fix wrong order in SQL TableGroupJoin rendering 2021-03-16 13:49:03 +01:00
Andrea Boriero 6c3d0d86dc Merge remote-tracking branch 'upstream/master' into wip/6.0 2021-03-16 10:43:42 +01:00
Sanne Grinovero 2c39bc0ac6 HHH-14502 Iterations and memory retention improvements for processing of PropertyContainer metadata 2021-03-15 17:13:27 +00:00
Andrea Boriero 9f22dafe17 HHH-14499 Explicitly listing mapped classes which are @MappedSuperClass might break narrowing down of generics 2021-03-15 16:44:21 +00:00
Andrea Boriero 394d6ab2d4 HHH-14499 Add test for issue 2021-03-15 16:44:21 +00:00
Andrea Boriero d28b719c2c Merge remote-tracking branch 'upstream/master' into wip/6.0 2021-03-15 10:46:40 +01:00
randymay 44d78d9b85 HHH-12076 Fix index out of bounds exception and allow table group joins for collection joins as well 2021-03-12 14:53:13 +01:00
Chris Cranford fd73a1af85 Use dialect default precision for additional types 2021-03-12 08:32:07 +01:00
Chris Cranford 79a0c325e9 Move null check into lambda for DelayedCollectionInitializer 2021-03-12 08:32:07 +01:00
Chris Cranford c2569bde4c Pass sorted collection comparator as ctor argument 2021-03-12 08:32:07 +01:00
Chris Cranford 5cf052775b Remove UnsupportedOperationException in ctor 2021-03-12 08:32:07 +01:00
Chris Cranford 44719e9bb2 Avoid NPE when resolving collection key for delayed collections 2021-03-12 08:32:07 +01:00
Chris Cranford 71f633a8f7 Set comparator on Persistent SortedSet and SortedMap collection instances 2021-03-12 08:32:07 +01:00
Chris Cranford 4292d118ad Enforce dialect's default timestamp precision 2021-03-12 08:32:07 +01:00
Chris Cranford 87a40f6c2f Set strategySelector before reflectionOptimizer is resolved 2021-03-12 08:32:07 +01:00
Christian Beikov 06d2a0c23e Use FK descriptor instead of target entity identifier 2021-03-12 08:06:48 +01:00
Christian Beikov 52684bba26 Fix concurrency issue in QueryCacheTest 2021-03-12 08:06:33 +01:00
Christian Beikov d1445efd82 HHH-9663 Implement support for orphan removal of assocations within embeddables 2021-03-12 08:06:33 +01:00
Jaanus Hansen 8101e3e47d HHH-9663 added failing test case for Embeddable orphanRemoval 2021-03-12 08:06:33 +01:00
Andrea Boriero c58227241f Merge remote-tracking branch 'upstream/master' into wip/6.0 2021-03-11 10:52:24 +01:00
Steve Ebersole 9952c09843 HHH-14491 - Apply default allocation/increment size for @GeneratedValue(AUTO)
HHH-14492 - Prefer sequence-per-entity (hierarchy) for @GeneratedValue(AUTO) by default

- added test as @FailureExpected to track this into 6.0
2021-03-10 16:23:42 -06:00
Christian Beikov 682678fbe5 Introduce FunctionExpression in SQL AST and remove shallowness handling in sqm to sql converter 2021-03-10 18:39:17 +01:00
Andrea Boriero 7934625688 Fix derby test failure 2021-03-10 18:37:22 +01:00
Andrea Boriero 60c4fbe099 SemanticQueryBuilder#visitPathExpression() cannot cast DomainPathPart to SqmExpression 2021-03-10 18:37:22 +01:00
Andrea Boriero 15b52460f3 BaseSqmToSqlAstConverter#consumeEntityJoin() postpone tableGroupJoin.applyPredicate after consuming implicit joins 2021-03-10 18:37:22 +01:00
Andrea Boriero 1905e8bba3 HHH-14482 Do not discard prior implicit join by key 2021-03-10 14:54:34 +01:00
Chris Cranford a022127428 HHH-14482 Do not discard prior implicit join by key 2021-03-10 11:00:56 +01:00
Andrea Boriero f2b79eef67 Fix issue with Column#getSqlType() for Columns which Type is an EntityType not referring to a PK 2021-03-10 10:54:38 +01:00
Jan Schatteman 2fb1cdcae1 Migrate more tests from jpa/test to orm/test/jpa
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2021-03-09 15:43:49 +01:00
Christian Beikov 56d90a0aa9 Implement non-select native query support and fix parameter binding ordering issues for select native queries 2021-03-09 09:40:55 +01:00
Christian Beikov ce41447875 Migrate java type descriptor tests and fix JdbcTimestampTypeDescriptor 2021-03-09 09:09:49 +01:00
Christian Beikov a3d2f1937e Implement support for delayed collections with FKs based on non-primary keys 2021-03-09 09:09:07 +01:00
Christian Beikov 350fd81cf5 Switch from java.lang.Class to java.lang.reflect.Type in the metamodel to support parameterized types 2021-03-09 09:01:46 +01:00
Christian Beikov 4a1a084def Fix StaticMetadataTest 2021-03-08 15:20:24 +01:00
Steve Ebersole 69564cd7c8 HHH-14478 : Allow DialectResolvers to be discovered by ServiceLoader 2021-03-08 08:14:05 -06:00
Andrea Boriero 47f7ca7ff5 Clean up BasicValue 2021-03-08 11:58:31 +01:00
Christian Beikov b225beb3cc Fix processing state issues with insert-select statements 2021-03-08 11:43:40 +01:00
Christian Beikov ee52989647 Don't build session factory and entity manager eagerly and stop enforcing id class implements Serializable 2021-03-08 11:43:39 +01:00
Andrea Boriero f7d421b6ff Fix NPE with DelayedCollectionInitializer 2021-03-08 09:28:53 +01:00
Chris Cranford 711fb53505 Resolve JavaTypeDescriptor, if not explicitly specified, for StandardRowReader 2021-03-08 09:21:45 +01:00
Chris Cranford 9591bbb185 Fix NPE with DelayedCollectionInitializer
Since the collectionInstance has not been resolved when asked to resolve the
collection key, provided an overridden method to not register the resolution
listener to avoid the NPE.
2021-03-08 09:19:48 +01:00
Chris Cranford 79d2569618 Don't add superfluous "and" when there is no discriminator filter 2021-03-08 09:09:41 +01:00
Christian Beikov a514460bb9 HHH-9182 Cleanup grammar ambiguity issues 2021-03-05 15:20:03 +01:00
Steve Ebersole 2ee5ed0e52 hibernate-testing cleanup 2021-03-05 07:28:41 -06:00
Andrea Boriero 6250942e7f Merge remote-tracking branch 'upstream/master' into wip/6.0 2021-03-05 11:18:14 +01:00
Andrea Boriero cb603a337b Removed use of EntityPersister#getEntityTuplizer() 2021-03-04 17:29:26 +01:00
Steve Ebersole ddf434df7e HHH-14469 - Support schema-tooling on sub-sets of the relational model known to Hibernate
- @BootstrapServiceRegistry
- Support for filtering at schema-tooling level
2021-03-04 09:42:45 -06:00
Gavin King 7b7597f40e modernize Interceptor + Lifecycle interfaces 2021-03-04 15:24:02 +01:00
Gavin King b3aa7d0794 remove Serializable id from the Tuplizer stuff 2021-03-04 15:24:02 +01:00
Gavin King d4aa643630 type ids as Object instead of Serializable 2021-03-04 15:24:02 +01:00
Christian Beikov abfa2de1d4 Try cast instead of inlining 2021-03-04 12:57:31 +01:00
Christian Beikov abbbd2d3fb Merge AbstractSqlAstWalker into AbstractSqlAstTranslator 2021-03-04 12:57:31 +01:00
Christian Beikov 1ea675d58d Apply requested changes 2021-03-04 12:57:31 +01:00
Christian Beikov 003fddccb5 Implement support for special parameter rendering through functions to support using certain Derby functions with parameters 2021-03-04 12:57:31 +01:00
Yoann Rodière fb079d077c HHH-14439 Test executing the same query with subselects a second time with different list parameters
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-03-04 08:35:23 +01:00
Yoann Rodière 81071a4594 HHH-14439 Clean up expanded list parameters before re-executing a query
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-03-04 08:35:23 +01:00
Vlad Mihalcea ed3bbf15e4 HHH-13077 - Optimize query plan call count 2021-03-03 08:07:53 -06:00
johnniang 2d5d6061c5 HHH-14473 add test case 2021-03-03 11:06:13 +00:00
johnniang f03dd44107 HHH-14473 Resolve managed class name with class loader as well 2021-03-03 11:06:13 +00:00
Sanne Grinovero f7c85fad4a HHH-14477 Log warnings about the use of Javassist as BytecodeProvider being deprecated 2021-03-03 10:57:35 +00:00
Gavin King b6dc77280f remove two unnecessary calls to deprecated getEntityTuplizer() 2021-03-03 08:58:28 +01:00
Christian Beikov 44f4f93a29 HHH-9182 Test and fix HQL rules to allow more expression types in aggregate functions 2021-03-03 08:34:12 +01:00
Gail Badner 34a361058d HHH-14390 HHH-14466 : StackOverflowError loading inverse side of associations owned by associated entity ID
Improved code comments as recommended by Steve Ebersole.
2021-03-02 14:13:48 -08:00
Gail Badner cb18fdb4f7 HHH-14390 : StackOverflowError with @Fetch(FetchMode.SELECT) mapped for entity with an ID that is a bidirectional one-to-one eager association
Move fix into FetchStyleLoadPlanBuildingAssociationVisitationStrategy
2021-03-02 14:13:47 -08:00
Gail Badner 2bacaabc37 HHH-14466 : StackOverflowError loading an entity with eager one-to-many if bidirectional and many-to-one side is the ID 2021-03-02 14:13:47 -08:00
Andrea Boriero bd84bb69bd Fix MetadataTest failures, the behaviour introduced by HHH-4702 has been reverted, SingularAttribute#getBindableJavaType() and SingularAttribute#getType().getJavaType() return Integer.class also for int attributes 2021-03-02 18:39:03 +01:00
Christian Beikov 59735d2329 HHH-14471 Fix concurrency issue due to builder sharing in DynamicBatchingEntityLoader 2021-03-02 18:11:47 +01:00
Christian Beikov 1714c022e2 HHH-11076 Log a warning if uninitialized collection unsets session when filters are enabled 2021-03-02 17:28:13 +01:00
Sanne Grinovero eb639a2d95 HHH-14474 Method AbstractEntityPersister#getAppropriateUniqueKeyLoader also need to change in protected 2021-03-02 13:25:59 +00:00
Sanne Grinovero 17bffb08a5 HHH-14474 Style and formatting improvements 2021-03-02 10:26:58 +00:00
Gavin King 4fad616d4b HHH-14474 Refactor internal visibility to allow Hibernate Reactive to implement non-primary key associations
see https://github.com/hibernate/hibernate-reactive/issues/565
2021-03-02 10:26:47 +00:00
Sanne Grinovero 6868c68278 HHH-14443 Formatting and style fixes 2021-03-01 16:13:02 +00:00
Francois van Delft de3f3c1d74 HHH-14443 Add hashcode to ObjectTypeCacheEntry, so query cache can do a successfull lookup for queryies with AnyTypes 2021-03-01 16:05:38 +00:00
Andrea Boriero 70f8498fd6 Merge remote-tracking branch 'upstream/master' into wip/6.0 2021-03-01 12:02:58 +01:00
gbadner a90aaa48b4 HHH-14467 Avoid false positives when detecting *ToOne associations that are part of the identifier
Co-authored-by: Yoann Rodière <yoann@hibernate.org>
2021-03-01 08:37:14 +01:00
Gail Badner 021b2741ab HHH-14467 Simplify detection of *ToOne associations that are part of the entity identifier 2021-03-01 08:37:14 +01:00
Yoann Rodière b6b83536e6 HHH-14467 Test referencing an entity whose ID is derived
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-03-01 08:37:14 +01:00
Yoann Rodière 9b991310b5 HHH-14467 Fix relative ordering of second pass for associations and derived IDs
Always execute second pass for associations referencing an entity with
derived ID after the second pass for that entity's derived ID.

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-03-01 08:37:14 +01:00
Christian Beikov 682cbc7d87 Simplify type resolving and ignore a test for Oracle 2021-02-25 16:24:10 +01:00
Christian Beikov d4ffbea54f Introduce callback in dialect to resolve the SqlTypeDescriptor from the Jdbc type code, precision and scale 2021-02-25 16:24:10 +01:00
Steve Ebersole e5c239c7c8 natural-id caching
- on top of Christian's PR #3735 which fixes a problem with pulling entity snapshots from the database which effects natural-id handling and caused test failures here (b4 #3735)
2021-02-25 09:08:59 -06:00
Christian Beikov 37b03ecc05 Properly handle parameters and null literals as plain select items 2021-02-25 12:08:49 +01:00
Christian Beikov 5b5254fbd6 Fix issues with inverse FK creation and related natural id issues 2021-02-25 12:08:49 +01:00
Andrea Boriero 0fafae4624 Merge remote-tracking branch 'upstream/master' into wip/6.0 2021-02-25 10:15:33 +01:00
Christian Beikov 0f92f53884 Remove BIT column type registrations from dialects 2021-02-24 15:27:30 +01:00
Christian Beikov 9ce2fa9cb4 Fix check constraint generation 2021-02-24 15:27:30 +01:00
Christian Beikov 0fd5fe7d5e Treat PREFERRED_BOOLEAN_JDBC_TYPE_CODE value BIT like BOOLEAN and only consider the value in CastFunction 2021-02-24 15:27:30 +01:00
Gavin King fc3c20f669 remove BitTypeDescriptor 2021-02-24 15:27:30 +01:00
Andrea Boriero 005c4cea63 Merge remote-tracking branch 'upstream/master' into wip/6.0 2021-02-24 15:02:45 +01:00
Gavin King 496e5995b2 deprecate old code for fetching id by natural id 2021-02-24 07:59:57 -06:00
Gavin King 3a24c700fc cache the @NaturalId loaders
and clean up some of the other loader caching code
2021-02-24 07:59:57 -06:00
Gavin King e0ee9f5b0a make it easy for Hibernate Reactive to reuse the @NaturalId stuff 2021-02-24 07:59:57 -06:00
Gavin King e368ac5bab more efficient loading by multiple @NaturalIds 2021-02-24 07:59:57 -06:00
Gavin King 725083b767 more efficient loading by @NaturalId
For entities with a single @NaturalId property only.
Uses a unique key EntityLoader instead of two selects.
2021-02-24 07:59:57 -06:00
Christian Beikov 7bf5117a02 Work on column alias resolving 2021-02-23 19:29:52 +01:00
Gavin King e38df7ed59 HHH-14464 Expose useful things to enable cleanup of HR code
- expose useful static-y methods in AbstractEntityPersister
- add methods to OptimisticLockStyle to reduce verbosity
- add a useful method to ValueGeneration
2021-02-23 13:36:42 +00:00
Gavin King 578edbfd9f HHH-14464 Make two methods of AbstractEntityPersister protected
for the benefit of Hibernate Reeactive
2021-02-23 13:36:32 +00:00
Christian Beikov 6643e9f4bc Use java.lang.reflect.Type instead of java.lang.Class for JavaTypeDescriptor#getJavaType to support parameterized types 2021-02-23 12:22:54 +01:00
Christian Beikov 6b66feb0ac HHH-14452 Support set operations in JPA Criteria API 2021-02-23 10:38:43 +01:00
Gavin King 222837df95 properly genericize CollectionSemantics hierarchy 2021-02-23 10:33:58 +01:00
Jan Schatteman c44570757d Migrated more tests from jpa/tests to orm/test/jpa
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2021-02-22 21:45:38 +01:00
Steve Ebersole db54fe44db HHH-13658 : Make LazyToOne optional
HHH-13134 : JOIN FETCH does not work properly with enhanced entities
2021-02-22 12:50:44 -06:00
Gavin King e631574922 genericize PersistentCollection hierarchy 2021-02-22 12:39:07 +01:00
Andrea Boriero 40947297e4 Merge remote-tracking branch 'upstream/master' into wip/6.0 2021-02-18 08:29:28 +01:00
Christian Beikov 91a68c6746 HHH-14460 Validate setter exists for persistent property also with mixed access strategy 2021-02-17 14:06:13 +01:00
Christian Beikov dc884e077b HHH-14456 Add DialectResolutionInfo#unwrap to be able to detect Cockroach in dialect resultion. Cleanup dialect resolution code. 2021-02-12 18:07:20 +01:00
Gavin King 130733af17 Maria supports 'alter table if exists ...' 2021-02-12 16:30:02 +01:00
Christian Beikov 35643c468a Merge remote-tracking branch 'upstream/master' into wip/6.0 2021-02-12 15:49:53 +01:00
Christian Beikov 9f096e89ec Repurpose DefaultSizeStrategy to SizeStrategy for resolving final size. Fix boolean encoding/decoding issues. Remove duplicate order bys. Fix set operation nesting. Fix lots of tests for SQLServer, MariaDB, Derby and Oracle 2021-02-12 13:43:42 +01:00
Gail Badner 7e2747516a HHH-14389 : Add test case that throw IllegalArgumentException using EntityManager#find by ID when ID is a one-to-one association 2021-02-11 16:04:41 -08:00
Gail Badner 8a01b4dab4 HHH-14390 : StackOverflowError with @Fetch(FetchMode.SELECT) mapped for entity with an ID that is a bidirectional one-to-one eager association 2021-02-11 10:04:54 -08:00
Steve Ebersole 611796c0fc HHH-14450 - Drop ability to disable "enhanced proxies" 2021-02-10 13:11:35 -06:00
Jan Schatteman 019f934344 Migrating tests from jpa/tests/emops to orm/test/jpa/emops
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2021-02-10 17:50:55 +01:00
Christian Beikov 4931c7e69f Merge remote-tracking branch 'upstream/master' into wip/6.0 2021-02-10 12:00:37 +01:00
Christian Beikov 3eee006002 Merge remote-tracking branch 'upstream/wip/6.0' into wip/6.0 2021-02-10 11:38:39 +01:00
Christian Beikov de1524df68 Merge remote-tracking branch 'upstream/master' into wip/6.0 2021-02-10 11:28:58 +01:00
Christian Beikov 15caff9cbc Fix PostgreSQL cleanup wrt extensions, fix Oracle cleanup wrt sys objects, always drop id tables in tests, fix global temp table tests, add on commit delete rows for hana dialects 2021-02-10 09:30:48 +01:00
Sanne Grinovero 2eaa0f8c67 HHH-14447 Remove unneccessary type check 2021-02-09 13:35:44 +01:00
Sanne Grinovero 81a9b87ec1 HHH-14447 Add missing EventGroupListeners into FastSessionService and take advantage of them 2021-02-09 13:00:45 +01:00
Yoann Rodière 14e181806f HHH-14444 Encapsulate ID generation in GenerationState for PooledLoThreadLocalOptimizer
This is just a cosmetic change, it doesn't change the behavior at all.

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-02-09 09:17:44 +00:00
Yoann Rodière 511dda7dee HHH-14444 Avoid synchronization for multi-tenant generation in PooledLoThreadLocalOptimizer
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-02-09 09:17:44 +00:00
Yoann Rodière 5c155f3f8d HHH-14444 Avoid synchronization for single-tenant generation in PooledLoThreadLocalOptimizer
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-02-09 09:17:44 +00:00
Yoann Rodière 04a40f8397 HHH-14444 Test concurrent usage of ID generator optimizers
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-02-09 09:17:44 +00:00
Andrea Boriero a094e17d2a HHH-14445 Javassist skip EntityWithMutableAttributesTest, LoadAndUpdateEntitiesWithCollectionsTest, SimpleDynamicUpdateTest, SimpleDynamicUpdateTest 2021-02-08 16:26:09 +01:00
Andrea Boriero b1951f5c26 Migrate tests from org.hibernate.jpa.test to org.hibernate.orm.test.jpa (#5) 2021-02-05 01:17:29 +01:00
Jan Schatteman 470af28795 Migrate tests from org.hibernate.jpa.test to org.hibernate.orm.test.jpa (2)
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2021-02-05 01:17:29 +01:00
Andrea Boriero cfc7b97250 HHH-14424 When enhanced as a proxy is enabled with dirty checking, on flush uninitialized entities containing collections are updated and all the fields are set to null 2021-02-04 14:09:25 +01:00
Andrea Boriero 26a46b2010 HHH-14424 Add test for issue 2021-02-04 14:09:25 +01:00
Gavin King 0ecb05614f use localtime/localtimestamp on HSQL and Postgres
Since we don't need the TIME ZONE for our current_time
and current_timestamp functions, these are cleaner
mappings to SQL for these functions.
2021-02-04 12:02:20 +01:00
Gavin King fbba9ed4a8 Javadoc for the current date/time/timestamp functions
Explain the difference between these various functions, and
how to correctly map them to SQL.
2021-02-04 12:02:20 +01:00
Gavin King 9d33bc39fb prefer localtime, localtimestamp on H2 1.4.200
As suggested by @famod we need to use localtime instead
or current_time because of changes in H2.

See https://github.com/hibernate/hibernate-orm/pull/3412
2021-02-04 12:02:20 +01:00
Nathan Xu 2cf9ec856c HHH-14384 Fix QueryProducer.createNativeQuery documentation 2021-02-04 11:16:26 +01:00
Gavin King ab5d350805 generate sensibly-lengthed columns for UUIDs
Previously, Hibernate generated column definitions of
type 255 for BINARY/CHAR columns that will have UUIDs
stored in them. It should be:

- length 16 for BINARY
- length 36 for CHAR
2021-02-04 10:59:30 +01:00
Gavin King 377ca5c073 use proper bullet list in Dialect javadoc
This is Javadoc, not a comment, so I should have
formatted it properly when I originally wrote this.
2021-02-04 10:45:34 +01:00
Gavin King d5b0c167c8 on H2 after 2.0 don't need column type workaround
Apparently H2 correctly reports column types via JDBC metadata
since 2.0, so this workaround is unnecessary.

Also add a default mapping for DECIMAL in superclass, just for
completeness.

cc @famod
2021-02-04 10:34:18 +01:00
Gavin King 34cb6d50d9 on H2 prior to 2.0 map NUMERIC to DECIMAL
This is helpful the schema update tool.

This workaround was lost during my work on Dialects.
2021-02-04 10:30:04 +01:00
Christian Beikov b3ab4c2299 Fix newly added tests for derby 2021-02-03 17:03:47 +01:00
Christian Beikov 1983123d72 Use a shared connection provider for most tests to reduce test time significantly 2021-02-03 17:03:47 +01:00
Christian Beikov 709ac039d1 Drop TypeConfigurationRegistry which was leaking session factories that had a bootstrap error
As far as I can tell, the purpose of TypeConfigurationRegistry was only for serialization, but since the TypeConfiguration UUID is always random, this won't work anyway.
2021-02-03 17:03:47 +01:00
Christian Beikov ffe45ccdd6 Register transaction coordinator as observer when session is waiting for auto close but coordinator is not shared 2021-02-03 17:03:47 +01:00
Christian Beikov 9f460e1c30 HHH-14432 Implement cleanup for EntityManagerFactoryBuilderImpl to close connections on bootstrap errors 2021-02-03 17:03:47 +01:00
Christian Beikov 21c89240d0 HHH-14435 Improve table information extraction (especially for Oracle with enableSynonyms)
Previously Oracle with enableSynonyms ran into a timeout on CI because the JDBC driver issues a rather expensive query. The new implementation issues a dummy query and uses the result set metadata as suggested in various online articles about schema introspection
2021-02-03 17:03:47 +01:00
Christian Beikov a8cddb93e8 HHH-14434 Fix autocommit reset for connection used in DdlTransactionIsolatorNonJtaImpl 2021-02-03 17:03:47 +01:00
Christian Beikov 9135f69c91 HHH-14433 Add possibility to drop local temporary tables to enable connection pooling in tests 2021-02-03 17:03:47 +01:00
Christian Beikov d767d46d05 Fix most tests to work on all DBs and fix a bunch of connection leaks 2021-02-03 17:03:47 +01:00
Christian Beikov 5d9f6936ff HHH-14351 Fix order by type discriminator rendering issue 2021-02-03 17:02:59 +01:00
Christian Beikov d2036cb11a HHH-14351 Test showing that order by type discriminator desc fails 2021-02-03 17:02:59 +01:00
Christian Beikov 52785ce0ed HHH-14408 Defer property type access until integrators ran 2021-02-03 15:18:50 +01:00
Christian Beikov 6fcb83c90d HHH-14408 Test that user type provided by integrator is properly registered 2021-02-03 15:18:50 +01:00
Andrea Boriero d213d675ce HHH-13658 fix failing test on Oracle 2021-02-03 10:11:53 +01:00
Andrea Boriero f48dd846f8 fix checkstyle erroe 2021-02-02 12:00:15 +01:00
Andrea Boriero e861604805 Merge remote-tracking branch 'upstream/master' into wip/6.0 2021-02-02 11:34:47 +01:00
Sanne Grinovero 22f858c68b HHH-14428 Could avoid allocating an org.hibernate.internal.SessionFactoryImpl when no options are set 2021-02-01 22:26:38 +00:00
Sanne Grinovero 15d418c332 HHH-14386 Fails to boot if provided CurrentTenantIdentifierResolver is unable to operate during bootstrap 2021-02-01 22:26:38 +00:00
Gail Badner 0e75b4f3b5 HHH-13944 : Added "join fetch" and one-to-many test cases 2021-02-01 14:05:10 -08:00
Andrea Boriero 20008b19bc HHH-13944 HQL/JPQL size() does not work (anymore) with nested expression 2021-02-01 14:05:10 -08:00
Andrea Boriero c99904a606 HHH-13944 Add test for issue 2021-02-01 14:05:10 -08:00
Alexander Iskuskov 19d46d2fed HHH-14421 Fix javadoc for Query.stream() method 2021-02-01 21:43:40 +00:00
Steve Ebersole 6371835dce More natural-id work
- preliminary work for natural-id caching support
- re-worked the previous NaturalIdHelper, NaturalIdXRefDelegate, etc
- minor fixes/improvements to previous commit
2021-02-01 08:38:20 -06:00
Sanne Grinovero 5881b88173 HHH-14418 Revert to previous semantics: EventListenerGroup#clear() to also get rid of the default DuplicationStrategy 2021-01-28 22:20:33 +00:00
Steve Ebersole 70baa0b659 More natural-id work
- preliminary work for natural-id caching support
- re-worked the previous NaturalIdHelper, NaturalIdXRefDelegate, etc
- minor fixes/improvements to previous commit
2021-01-28 11:53:30 -06:00
Andrea Boriero 270fba830a Fix checkstyle errors 2021-01-27 18:40:13 +01:00
Andrea Boriero 0659c9f4ce HHH-14409 : Fix issue with Proxies 2021-01-27 18:24:43 +01:00
Steve Ebersole 9849ea5a1f - HHH-14409 : Internal format of natural-id values
- org.hibernate.loader.access
- `ModelPart.breakDownJdbcValues`
- build/keep natural-id loaders per entity (inheritance)
- changes to NotImplementedYetExtension
- tests
2021-01-27 10:38:20 -06:00
Andrea Boriero 7e34535cfe Fix initializer post load call timing 2021-01-27 15:20:19 +01:00
Andrea Boriero e9e81eeda3 Applied changes based on review suggestions 2021-01-26 17:24:31 +01:00
Andrea Boriero 84523cd0d9 fix issue with EmbeddableFKDescriptor 2021-01-26 15:26:41 +01:00
Andrea Boriero e97aa81916 Fix EntitiyInitialization returning a Proxy, NPE for InferredBasicValueResolution, Fix issue issue with loading by Unique key, Fix FkDescriptor for Embeddable 2021-01-26 15:25:58 +01:00
Christian Beikov e1aa2d941f Allow implicit casting of types if implied and actual type are both numeric and change floor/ceil to return argument type 2021-01-26 14:55:40 +01:00
Sanne Grinovero 6fa09dd4db HHH-14418 Reduce memory retention of each EventListenerGroup 2021-01-26 10:02:27 +00:00
Jan Schatteman 5d768af983 Some more adjustments for commit f9937f6
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2021-01-25 23:38:02 +01:00
Andrea Boriero 24b79133f2 Created a ClassLoadingIsolaterExtension to remove the need of @Rule in tests using ClassLoadingIsolater 2021-01-25 22:38:53 +01:00
Andrea Boriero e0e44433a9 Fix some issues with tests migration 2021-01-25 18:40:59 +01:00
Andrea Boriero 491cbabc6c Added Junit5 extention to use LoggerInspection without @Rule annotation 2021-01-25 18:40:59 +01:00
Jan Schatteman d714fd047a Switch tests over to @Jpa from @DomainModel where possible and some other minor changes
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2021-01-25 16:20:45 +01:00
Andrea Boriero a5d60b3b7e Add @BaseUnitTest annotation and minor changes 2021-01-25 16:20:45 +01:00
Jan Schatteman f9937f66be Migrate tests from org.hibernate.jpa.test to org.hibernate.orm.test.jpa
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2021-01-25 16:20:45 +01:00
Andrea Boriero b761cfddd3 Merge remote-tracking branch 'upstream/master' into wip/6.0 2021-01-20 17:48:43 +01:00
Yoann Rodière 4c9c2a809a HHH-14404 Remove check for concurrent execution of LogicalConnectionManagedImpl#releaseConnection
It's unlikely to ever happen, and even if it happened, the resulting
exception would probably be rather clear about the fact that the problem
is related to concurrent execution (ConcurrentModificationException
thrown by a Map of resources, for example).

See
https://github.com/hibernate/hibernate-orm/pull/3693#discussion_r560393293

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-01-20 09:26:51 +00:00
Yoann Rodière 8210bc220b HHH-14404 Test setting the connection handling mode through SessionBuilder
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-01-20 09:26:51 +00:00
Yoann Rodière d0b44c48ef HHH-14404 Take into account the connectionHandlingMode passed through SessionBuilder
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-01-20 09:26:51 +00:00
Yoann Rodière d726dcb394 HHH-14326 Test JDBC resources are released before closing the connection
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-01-20 09:26:51 +00:00
Yoann Rodière e5c830da19 HHH-14326 Always close the connection even if releasing JDBC resources fails
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-01-20 09:26:51 +00:00
Yoann Rodière 74433cdec3 HHH-14326 Release JDBC resources before closing the connection
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-01-20 09:26:51 +00:00
Nathan Xu 1e5d64cf79 HHH-14407 NPE in Column.getSqlTypeCode(Mapping mapping) for column 'hib_sess_id' when using PersistentTableBulkIdStrategy 2021-01-15 08:08:14 +01:00
Andrea Boriero 90f18b3137 Merge branch master into wip/6.0 2021-01-14 17:39:16 +01:00
Andrea Boriero ef36b4faa2 Move new InstrumentedProxyLazyToOneTest and InstrumentedLazyToOneTest to org.hibernate.test package, bytecode not yet working properly 2021-01-14 17:36:49 +01:00
Andrea Boriero 3e6e5a4e8f Added FailureExpected to InstrumentedProxyLazyToOneTest 2021-01-14 16:11:01 +01:00
Steve Ebersole 3ecc2550df HHH-14409 : Internal format of natural-id values
At the moment, internally the value of a natural-id is always kept as an array.  For simple natural-ids that means creating an unnecessary array to wrap the simple value.  Change this to allow Object to allow for these simple values
2021-01-14 08:52:15 -06:00
Andrea Boriero 6d124a7c6d Merge remote-tracking branch 'upstream/master' into wip/6.0 2021-01-14 11:34:06 +01:00
Christian Beikov 0196911c8d Throw ParsingException on tokenization or parsing error for HQL instead of just logging to console and fix test issues 2021-01-14 08:00:17 +01:00
Gail Badner 602926bf9b HHH-13658 : Remove @LazyToOne(NO_PROXY) from classes used with bytecode-proxies enabled. FetchGraphTest#testRandomAccess failed so it was marked @FailureExpected. 2021-01-13 16:13:54 -08:00
Steve Ebersole 0c974991f7 HHH-13658 : make NO_PROXY unnecessary
- Better handle `FetchModeType#LAZY` for to-one associations based on whether bytecode-enhancement-as-proxy is enabled.  Minimize the cases a user is likely to need to use `@LazyToOne`
- See also EAP7-1402
2021-01-13 12:03:44 -06:00
Steve Ebersole e5c40e3af7 more changes for id type as Object instead of Serializable 2021-01-13 11:38:42 -06:00
Christian Beikov 4efffca23b Add support for FETCH clause, CTEs and set operations 2021-01-13 17:24:45 +01:00
Steve Ebersole f54072df4e HHH-14398 : AttributeMapping order
- Also, marked 3 `org.hibernate.orm.test.sql.exec.onetoone.bidirectional.EntityWithBidirectionalOneToOneTest` tests as expected failures due to https://hibernate.atlassian.net/browse/HHH-14403
2021-01-13 10:07:22 -06:00
Nathan Xu d5a6774cd2 reuse ArrayHelper's empty array constant to avoid object creation 2021-01-13 14:35:08 +01:00
Yanming Zhou 633d0f08d6 HHH-14229 Fix unexpected foreign key creation
before this commit, foreign key is created even ConstraintMode.NO_CONSTRAINT present on the @ManyToOne side
2021-01-11 14:23:35 -08:00
Gail Badner b40d1251e3 HHH-14390 : Added test cases 2021-01-05 19:47:14 -08:00
Gail Badner 30fcb05795 HHH-14389 : Added test case. OneToOneWithDerivedIdentityTest#testFindById reproduces the bug and is annotated with @FailureExpected 2021-01-05 12:32:29 -08:00
Sanne Grinovero 016625eb5d HHH-14385 Allow specifying a target JVM version for compatibility of generated proxies via ByteBuddy 2020-12-22 18:01:27 +00:00
Jan Schatteman 2e835c47cd New Test annotation @NotImplementedYet
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2020-12-21 19:45:20 +01:00
Christian Beikov 9c69ddc8f1 HHH-14380 - Only reorder destination from elements from the same from clause 2020-12-20 10:52:20 +01:00
Jan-Willem Gmelig Meyling 34bacba59e HHH-14380 Test case from https://github.com/Blazebit/blaze-persistence/pull/1237 for subquery in on-clause 2020-12-20 10:52:20 +01:00
Christian Beikov 4de1870785 HHH-14318 Introduce column mapping abstract to support formulas easily 2020-12-17 17:44:25 +01:00
Christian Beikov cb7c65e49d Use new parent PostgreSQLDialect for @RequiresDialect rather than subclass 2020-12-17 17:44:25 +01:00
jiangHZ cc14c785b9 HHH-13913 An SQL Dialect for PostgreSQL 10 and later. Adds support for Partition table. 2020-12-16 14:39:17 +01:00
Yanming Zhou c9ade2affe HHH-14356 Avoid NPE when booting with xml_mapping_enabled=false
Introduced by HHH-14334
when use Envers with hibernate.xml_mapping_enabled=false
see 34151a9660 (r44735539)
2020-12-14 16:26:12 +00:00
Yoann Rodière 6396cd17a2 HHH-14371 Open java.base/java.lang to the unnamed module in javassist tests
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2020-12-14 14:02:18 +00:00
Yoann Rodière 7f518cddb3 HHH-14371 Move tests specific to Javassist to the appropriate source set
Otherwise they won't be executed with the appropriate JVM args.

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2020-12-14 14:02:18 +00:00
Yoann Rodière 8e3bf43a18 HHH-14371 Open java.base/java.security and java/base/java.lang to the unnamed module in tests
Weld needs this, in CDI tests.

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2020-12-14 14:02:18 +00:00
Yoann Rodière 27c5980a20 HHH-14371 Open java.base/java.nio.charset to the unnamed module in tests
NamingHelper test needs access to Charset.defaultCharset.

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2020-12-14 14:02:18 +00:00
Yoann Rodière f6a9338f97 HHH-14371 Correctly set JVM args in the JVM running tests
Turns out getJvmArgs() returns a copy, so modifying that copy won't
change the JVM args.

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2020-12-14 14:02:18 +00:00
Andrea Boriero f468666b6d HHH-14360 Fix failure on Oracle db 2020-12-11 17:16:29 +01:00
Andrea Boriero 9770b49c4b Fix compilation errors 2020-12-11 10:30:18 +01:00
Steve Ebersole 33358df72b New testing `@Jpa` annotation 2020-12-11 10:24:29 +01:00
Andrea Boriero d810970489 Remove duplicated code from ConcreteSqmSelectQueryPlan 2020-12-11 09:56:16 +01:00
Andrea Boriero 820b815b35 BaseSqmToSqlAstConverter#consumeAttributeJoin() code clean up 2020-12-10 17:02:49 +01:00
Andrea Boriero 6d2e80d43a Fix EmbeddedId lazy collection initializer 2020-12-10 17:02:49 +01:00
Andrea Boriero c10b4e0f2f Fix issue with fetch deep and hql join fetch recognition 2020-12-10 17:02:49 +01:00
Andrea Boriero 7d74f1c727 Fix issue with emneddable id initialization 2020-12-10 17:02:49 +01:00
Christian Beikov c915168cf1 HHH-14360 Test a fix for NPE due to non-existing previous state in bytecode enhanced dirty attribute resolving 2020-12-09 11:46:43 +01:00
Andrea Boriero d32fb746d6 Fix SqlAstTranslator affected tablenames includes synch tables 2020-12-08 17:01:27 +01:00
Andrea Boriero 9a6465a72f Check if auto flush is required for hql queries 2020-12-08 17:01:27 +01:00
Andrea Boriero dbec10aff1 HHH-14364 UpdateDetachedTest#testUpdateDetachedWithAttachedPersistentSet failing when run on OracleDB 2020-12-08 16:04:07 +01:00
Andrea Boriero bdc3a5cdc7 HHH-14363 MutableTypeEnhancementTestCase failing when run on Oracle DB 2020-12-08 15:45:37 +01:00
Andrea Boriero f54105cc51 Fix issue with fetch for hql query 2020-12-08 11:36:04 +01:00
Christian Beikov c4673e5a5c Fix a few more test issues and handle group by summarization rendering strategies as well as group by literal rendering strategies 2020-12-08 11:27:27 +01:00
Christian Beikov a57f93b14a Use processing stack during parsing to access query spec, fix lots of db2 issues 2020-12-08 11:27:27 +01:00
Christian Beikov 604cef2cb6 Move persistence context access in EntitySelectFetchInitializer to fix PostgreSQL issues 2020-12-08 11:27:27 +01:00
Christian Beikov 7f1a60c4c6 Fix some more tests and fix auto flushing for select queries 2020-12-08 11:27:27 +01:00
Christian Beikov 650342c093 Move out the temporary session cleanup into a dedicated method called after translation 2020-12-08 11:27:27 +01:00
Christian Beikov fa5d2d9e08 Use WrapperOptions for JdbcLiteralFormatter instead of SessionImplementor 2020-12-08 11:27:27 +01:00
Christian Beikov 817bf95a9a Fixes according to review comments 2020-12-08 11:27:27 +01:00
Christian Beikov 3b730ac376 Fix a few more tests, simplify collation handling, HQL parsing support for tuples, revert wrong dialect changes, alias support for group by and order by, implement index optimized tuple comparison emulation 2020-12-08 11:27:27 +01:00
Christian Beikov d9446e7c77 Fix a few test issues, implement tuple emulation, group by support and support configuring criteria value handling mode 2020-12-08 11:27:27 +01:00
Andrea Boriero b9e7cc3c93 Merge remote-tracking branch 'upstream/master' into wip/6.0 2020-12-01 13:20:14 +01:00
Andrea Boriero cf9d4ec3b3 HHH-14242 Fix issue for Dialects supporting row value constructor Syntax but not in the SET clause 2020-11-30 20:59:01 +00:00
Andrea Boriero e7bcc03ede HHH-14251 Fix issue for Dialects not supporting row value constructor Syntax 2020-11-30 20:58:50 +00:00
Andrea Boriero 9376650097 HHH-14251 Invalid SQL for @Embedded UPDATE 2020-11-30 20:58:44 +00:00
Andrea Boriero 900da12419 HHH-14251 Add test for issue 2020-11-30 20:58:37 +00:00
nicklas.wallgren 53a5c7fa97 HHH-14350 MariaDB103Dialect requires the lock wait timeout to be expressed in seconds 2020-11-30 20:38:39 +00:00
Michael Edgar 3de7fb653e HHH-14346 Check declaredPluralAttributes for null before access 2020-11-30 18:49:55 +00:00
Christian Beikov 8ded205b5f HHH-14343 Fix quoting of column names when globally quoted identifiers is active 2020-11-30 17:35:41 +00:00
info@kawoolutions.com 3434293a7e Test case for HHH-14343 2020-11-30 17:35:41 +00:00
Christian Beikov e2dbf52abe Restore collectionsInDefaultFetchGroupEnabled usage in LazyAttributesMetadata 2020-11-30 17:17:58 +00:00
Christian Beikov b08fbdaa6e HHH-14348 Special handling in bytecode enhancement for lazy PersistentCollection fields 2020-11-30 17:17:58 +00:00
Andrea Boriero 1a9bd7d4b3 Re-enabled additional test and fix issue with native queries not flushing session 2020-11-25 18:18:15 +01:00
Andrea Boriero e3947b3b1c Re-enabled additional tests and fix issues with IdClass 2020-11-25 15:15:34 +01:00
Andrea Boriero 52ba3d9c5a Fix issue with StandardPojoEntityRepresentationStrategy 2020-11-24 16:12:43 +01:00
Andrea Boriero a3f946ad6e Re-enabled additional tests 2020-11-24 15:04:46 +01:00
Andrea Boriero bb4c4d0767 Merge remote-tracking branch 'upstream/master' into wip/6.0 2020-11-24 12:33:51 +01:00
Andrea Boriero ddb0be61d5 Re-enabled more tests and fix issues with in predicate, sqmMultiTableMutationStrategy creation and other minor issues 2020-11-24 12:24:59 +01:00