Commit Graph

653 Commits

Author SHA1 Message Date
The Geeky Asian e808041477 HHH-13856 - Long-awaited TODOs done as an improvement
1. TODO: Remove duplicate method from ConstraintConstaint.java currently has two duplicate methods. 1. getColumnIterator()2. columnIterator()

Both the methods return the same value i.e. column.iterator().

One of them needs to be removed in order to reduce and clean the duplication. 

2. TODO: Change method name for getXmlFiles in BaseCoreFunctionalTestCaseCurrently, in BaseCoreFunctionalTestCase a method named getXmlFiles()has a TODO placed that suggests the method name to be changed to getOrmXmlFiles().

Since the method has a protected scope, there is a possibility it is being used by other clients. Hence, changing the method name in minor versions might break the code for clients.
2020-02-20 10:54:50 -06:00
Andrea Boriero eb43734658 Fix compilation errors after merge 2020-02-05 12:16:41 +00:00
Andrea Boriero f77fb75639 Merge remote-tracking branch 'upstream/master' into wip/6.0_merge_23 2020-02-05 11:37:36 +00:00
gavinking 4f5b37c9c4 Use SequenceSupport everywhere instead of deprecated methods of Dialect 2020-01-30 14:01:34 -06:00
gavinking 992b390fce Get type-specific column length/precision/scale defaulting working again
And fix resulting breakage to envers
2020-01-30 14:01:34 -06:00
Chris Cranford 38f0131160 HHH-10844 Resolve columnDefinition to appropriate sql-type for audit mappings 2020-01-27 13:18:16 +00:00
Chris Cranford c02a703b17 HHH-6615 Minor format changes 2020-01-27 12:53:27 +00:00
Chris Cranford f4abc09854 HHH-6615 Throw AuditException when generated revision number is negative. 2020-01-27 12:53:27 +00:00
Chris Cranford 8c52eb2eae HHH-13770 Fix modified columns being populated with null values 2020-01-27 12:33:59 +00:00
Chris Cranford b3ea1d67c4 HHH-13760 Code formatting changes & suggested logic simplification 2020-01-27 12:12:23 +00:00
Chris Cranford d1b32d2b65 HHH-13760 Code formatting changes & suggested logic simplification 2020-01-27 12:12:23 +00:00
Chris Cranford 92bd6f89dd HHH-13760 Fix ClassCastException when Envers inserts audit rows that use lazy many-to-one mappings 2020-01-27 12:12:23 +00:00
Andrea Boriero 4b0da2444b Merge remote-tracking branch 'upstream5/master' into wip/6.0_merged_11 2019-11-08 14:24:48 +00:00
Steve Ebersole 92391ec3e6 change expected type of entity identifier values from Serializable to Object - fixed all related compile problems in all modules 2019-11-07 13:42:57 -06:00
Steve Ebersole 5b3c6c4884 continued work on replacing LoadPlan with SQL AST approach - cleanup;
change expected type of entity identifier values from Serializable to Object
2019-11-07 13:42:57 -06:00
Chris Cranford 72b81eebfe HHH-12965 Avoid creating foreign keys between audit and main tables
* Added test case
2019-10-28 14:21:56 +00:00
Chris Cranford b28c7b0761 HHH-12965 Avoid creating foreign keys between audit and main tables
* Fixes a corner case not addressed by HHH-10667
* Avoids creating foreign-key constraints for any many-to-one
2019-10-28 14:21:56 +00:00
Andrea Boriero 8b500acc1d Merge remote-tracking branch 'upstream5/master' into wip/6.0_merged_9 2019-10-17 16:02:43 +01:00
Yoann Rodière 250f569339 HHH-13666 Clarify that existing BeforeCompletion/AfterCompletion tests are about JTA only 2019-10-17 15:54:16 +02:00
Andrea Boriero 567eb38069 Merge remote-tracking branch 'upstream5/master' into wip/6.0_merged_6 2019-10-09 18:00:48 +01:00
Chris Cranford d95c16e9ab HHH-13655 Fix NullPointerException for audited MapKeyEnumerated collections with basic value types 2019-10-04 19:28:20 -04:00
Andrea Boriero 4b6777cde2 Merge remote-tracking branch 'upstream5/master' into wip/6.0_merged_4 2019-10-02 10:24:59 +01:00
Chris Cranford b606759e61 HHH-10398 Allow MOD column naming to be driven by a strategy
* Fixed javadoc comments
* Various code suggested code changes from review
2019-10-01 10:38:57 -04:00
Chris Cranford f78877a607 HHH-10398 Allow MOD column naming to be driven by a strategy
* Fixes OSGI integration with missing service lookup registration
2019-10-01 10:38:57 -04:00
Chris Cranford 3ecdd860a3 HHH-10398 Allow MOD column naming to be driven by a strategy
In the past the MOD columns were constructed based on the property name,
therefore if users specified a @Column/@JoinColumn like annotation and
changed the underlying schema column, the MOD column would continue to
be derived based on the property name.

This enhancement introduces a new ModifiedColumnNamingStrategy SPI that
comes with two implementations, a default/legacy mode that maintains
the prior naming model and an improved mode that will derive the MOD
name based on the naming strategy ORM used to derive the column name.
2019-10-01 10:38:57 -04:00
Andrea Boriero 726dbeef34 Merge remote-tracking branch 'upstream5/master' into wip/6.0_merged_4 2019-09-30 16:45:27 +01:00
Chris Cranford 4b8c81908c HHH-11797 Add support for @MapKeyEnumerated mappings 2019-09-30 09:25:17 +01:00
Andrea Boriero 20f2002269 6 - fix compilation errors in envers and osgi projects 2019-09-12 10:42:33 +01:00
Steve Ebersole 0acd11fae3 6 - SQM based on JPA type system
Completed rebase on master (from the point just after HHH-11147 work) - fixed compilation failures
2019-09-12 10:42:33 +01:00
Andrea Boriero c45108a2b6 6 - SQM based on JPA type system 2019-09-12 10:42:32 +01:00
Andrea Boriero b196374da9 6 - SQM based on JPA type system 2019-09-12 10:42:32 +01:00
Andrea Boriero 44e01cdf7e 6 - SQM based on JPA type system 2019-09-12 10:42:31 +01:00
Steve Ebersole f8a75994e1 6 - SQM based on JPA type system
- work on `org.hibernate.query` (especially `NamedQueryRepository` and friends)
- work on `org.hibernate.sql.exec`
- work on `org.hibernate.sql.results`
- work on `org.hibernate.sql.exec`
- work on `org.hibernate.sql.results`
- work related to `org.hibernate.metamodel.model.mapping.spi.ValueMapping` - including "sketching in" the hooks with `org.hibernate.persister.walking`
2019-09-12 10:42:29 +01:00
Steve Ebersole 8d0ff71dfc 6 - SQM based on JPA type system
- further work on `org.hibernate.query` (especially `NamedQueryRepository` and friends)
- initial work on `org.hibernate.sql.exec`
- initial work on `org.hibernate.sql.results`
- SemanticPathPart handling
- NamedQueryMemento
- work on ProcedureCall
- continued work on `org.hibernate.sql.exec`
- continued work on `org.hibernate.sql.results`
- ported `hibernate-testing` JUnit 5 support
2019-09-12 10:42:29 +01:00
Andrea Boriero ea301a7084 HHH-13564 - Fix EmbeddedIdGenericsTest failures on Oracle and MariaDB 2019-09-02 14:02:47 +01:00
Chris Cranford 5c95096e7c HHH-13564 - Fix NullPointerException for audited entity with embedded-id
in mapping superclass that makes use of generics.
2019-08-23 15:04:52 -04:00
Chris Cranford 14f7b49b79 HHH-13500 Fix audit strategy sub-query return incorrect results
In order to maintain backward compatibility with long-standing behavior,
this introduces a new configuration option which can be toggled to have
AuditReader#find implementations adhere to returning an exact match on
revision-number rather than one which is less-than or equal-to the
provided argument.

So a new configuration option org.hibernate.envers.find_by_revision_exact_match
provides users with the ability to be able to force this new behavior
while allowing legacy behavior to remain the default.
2019-07-22 16:34:19 -04:00
Sanne Grinovero 2e81c32265 HHH-13465 Allow inlined access to the PersistenceContext for internal methods 2019-06-28 12:00:39 +01:00
Gail Badner 6fba4c1035 HHH-13285 : ClassCastException: org.dom4j.DocumentFactory cannot be cast to org.dom4j.DocumentFactory after dom4j update 2019-02-25 12:20:36 -08:00
wonwoo 69af6caa95 HHH-13265 - Remove double semicolon 2019-02-14 09:00:08 +02:00
Chris Cranford 67ec2d07cc HHH-13080 - EntityExistException when audited collection updated with detached entities. 2019-01-16 09:27:35 -05:00
Chris Cranford fc8f6871fd HHH-13080 - Added test case. 2019-01-16 09:27:35 -05:00
Chris Cranford aa288ba345 HHH-13104 - Skip these tests when no-column-support enabled. 2019-01-15 18:18:20 -05:00
Chris Cranford b66f548b5f HHH-13191 - Fix test using a table-name that wasn't compliant across dialects. 2019-01-10 10:52:27 -05:00
Chris Cranford 3cf2b50911 HHH-13191 - Added test case. 2019-01-08 08:54:29 -05:00
Chris Cranford c8166b3f5d HHH-13051 - Refactored strategy solution. 2018-11-13 19:20:45 +01:00
Rokko11 68df2792c6 HHH-13051 Make audit tables structure more extensible 2018-11-13 19:20:45 +01:00
Chris Cranford 69bde03c24 HHH-12913 - Fix test on oracle database. 2018-11-13 08:36:44 -05:00
Chris Cranford c17e4832a9 HHH-12913 - Fix test failure on Oracle db. 2018-11-08 08:35:50 -05:00
Chris Cranford b00f580d8d HHH-12913 - Fix AuditJoinTable to work when specified in an AuditOverride. 2018-11-07 15:31:47 -05:00