Commit Graph

9434 Commits

Author SHA1 Message Date
Guillaume Smet fdf19f17b4 HHH-12857 Rewrite getDeclaredMethod() calls in static initializers
We rewrite them to run them as privileged blocks.
2018-08-02 00:10:17 +02:00
Guillaume Smet 129530e464 HHH-12857 Avoid using a static ByteBuddy object
In the end, it does not change anything as the BytecodeProvider is still
static but it helps as a general cleanup for the following commits.
2018-08-02 00:10:17 +02:00
Guillaume Smet c9de4b8ce7 HHH-12835 In the end, remove the assertion
It's not really compatible with batch loading, padding and a couple of
other corner cases.

And I don't think it has a lot of value by itself.
2018-08-01 16:16:19 +02:00
Andrea Boriero 7d9ebd262d HHH-12849 - QuotedIdentifierTest fails with ORA-04043 on Oracle12c 2018-08-01 13:42:25 +02:00
Guillaume Smet 5d5cfe82ef HHH-12869 Do not check the cacheManager is not null when creating it 2018-08-01 11:44:53 +02:00
Guillaume Smet 0d224e45d6 HHH-12835 Fix an incorrect assertion in BatchFetchQueueHelper 2018-08-01 11:44:53 +02:00
Guillaume Smet 98f46d64e7 HHH-12848 Restore the original Oracle LimitHandler
Oracle does not support using the SQL 2008 standard limit handler with
FOR UPDATE clauses. Thus we need to get back to the old limit handler.
2018-08-01 11:44:53 +02:00
Guillaume Smet 92f194f291 HHH-10603 Avoid doing distinct and comparisons on byte arrays
They are stored as blobs starting with Oracle12cDialect and distinct and
comparisons on blobs are not supported.

Some tests were adapted, some are now skipped with Oracle12cDialect.
2018-08-01 11:44:49 +02:00
Guillaume Smet 6b679c8860 HHH-12730 Remove the deprecated methods previouly added
We don't need them as everything is now dealt with the transformer.
2018-08-01 11:15:39 +02:00
Guillaume Smet 338b97e7b5 HHH-12730 Add missing @Overrides 2018-08-01 11:15:39 +02:00
Guillaume Smet a4dd9a96d9 HHH-12730 Add deprecated constructors taking a SessionImplementor 2018-08-01 11:15:39 +02:00
Gail Badner dfa2bc0685 HHH-12730 : User types built using 5.1 are not binary compatible with 5.3 2018-08-01 11:15:39 +02:00
Guillaume Smet e43c374f30 HHH-12868 Fix NPE when loading entity with CacheConcurrencyStrategy.NONE 2018-07-31 14:53:01 +02:00
Andrea Boriero 9ab285eb58 HHH-12861 SchemaUpdate doesn't work with Sybase 2018-07-31 10:45:48 +01:00
Yoann Rodière b8b7a0f19b HHH-12492 Qualify references to columns from the target table in subqueries in DELETE/UPDATE queries
Don't try to duplicate the logic from
org.hibernate.hql.internal.ast.tree.FromElementType#toColumns(java.lang.String, java.lang.String, boolean, boolean)
in other classes, it's complex enough and already seems to handle all
the cases we might encounter.

In this specific case, we want the table name to be used to qualify
column names, because the target table doesn't have any alias (it's not
supported by every version of every RDBMS), and not qualifying columns
at all may lead to a confusing statement, in particular if tables
referenced in the subquery contain columns with the same name.
Since we use aliases for every other table in the query, referencing the
table should not lead to any conflict.
2018-07-27 15:03:13 +02:00
Yoann Rodière 6cf91c832c HHH-12492 Test HQL Delete query with a subquery referencing the parent query's aliases 2018-07-27 15:03:07 +02:00
Martin Simka 77661b2275 HHH-12863 SchemaUpdateTest should be skipped with Sybase 2018-07-27 14:56:35 +02:00
Gail Badner a0ca735ae3 HHH-12792 : Document binary incompatibility of persisters 2018-07-24 09:36:53 +02:00
Martin Simka 3e8b35a370 HHH-12851 ConverterTest fails with SQL Server depending on collation 2018-07-23 18:09:54 +02:00
Chris Cranford 27449d2dc2 HHH-12846 - Merge cascade of collection fails when orphan removal enabled with flush mode commit.
(cherry picked from commit 333c190c82)
2018-07-23 11:08:43 -04:00
Guillaume Smet 03a209c8ec Prepare for next development iteration 2018-07-20 16:18:35 +02:00
Guillaume Smet 3c81ade198 5.3.3.Final 2018-07-20 15:45:36 +02:00
Martin Simka 95c11255f8 HHH-12844 Fix HbmWithIdentityTest with Oracle 2018-07-20 14:47:43 +02:00
Martin Simka 88a015368b HHH-12843 Fix CreateDeleteTest and FlushIdGenTest with Oracle 2018-07-20 13:22:56 +02:00
Martin Simka 0caee98355 HHH-12839 Fix EntityProxySerializationTest with Oracle 2018-07-20 11:30:11 +02:00
Guillaume Smet d02ad78eb7 HHH-7404 HHH-6776 Add tests to prevent regressions
The issues have apparently already been fixed but let's add the tests
present in the issue to prevent regressions.
2018-07-20 11:30:11 +02:00
Guillaume Smet 0091169f9d HHH-12666 Only run the tests with H2
We don't need to run them with all our dialects: we just need to check
the mechanism works correctly.

At least TransactionExceptionHandlingTest fails with MariaDB so better
be safe.
2018-07-20 11:30:11 +02:00
Guillaume Smet 0075225ab7 HHH-12832 Make SchemaUpdateHaltOnErrorTest use the CustomRunner
Otherwise @SkipForDialect doesn't work.
2018-07-20 10:38:19 +02:00
Martin Simka ad08bdf513 HHH-12838 Fix AndNationalizedTests with DB2
This is consecutive to the changes made in HHH-12753.
2018-07-20 10:27:51 +02:00
Gail Badner 1b445a7e02 HHH-12666 : Document hibernate.native_exception_handling_51_compliance in migration guide 2018-07-20 10:27:38 +02:00
Gail Badner 5fd8b36e34 HHH-12666 : Add test 2018-07-20 10:27:05 +02:00
Gail Badner 0bbacccf8d HHH-12666 : Add documentation 2018-07-20 10:27:05 +02:00
Gail Badner a76dde0ec6 HHH-12666 : Added more tests 2018-07-20 10:27:05 +02:00
Yoann Rodière 566a93d6c7 HHH-12666 Test the current behavior of exception conversion on persist/save/merge/flush/etc.
Original tests by Gail Badner:
09aa6fbce2
2018-07-20 10:27:05 +02:00
Gail Badner e5da120f13 HHH-12666 : Add an option for restoring 5.1 native exception handling 2018-07-20 10:27:05 +02:00
Martin Simka ed03dfb958 HHH-12833 Fix UniqueConstraintDropTest with DB2 2018-07-19 16:06:15 +02:00
Chris Cranford 9ca732cf29 HHH-12753 - Remove an override that was not relevant to this jira.
(cherry picked from commit ad5f96c613)
2018-07-19 10:01:52 -04:00
Chris Cranford 86abe7fd4f HHH-12753 - Fix Nationalized CLOB test failures on DB2.
Force column read/write to use non-nationalized driver methods since the driver does
not implement the nationalized equivalents.

(cherry picked from commit 005d5b7c74)
2018-07-19 09:54:46 -04:00
nikowitt 722ba32f9f HHH-12830 Improve error message when a method is called in a non active
transaction
2018-07-19 15:36:59 +02:00
Guillaume Smet 255a096ee8 HHH-12832 Skip SchemaUpdateHaltOnErrorTest and al. with DB2
DB2 has no issue with reserved keywords in the CREATE TABLE clause so
let's skip these tests.

There is very little value to test them for every dialect anyway.
2018-07-19 15:18:42 +02:00
Guillaume Smet d6f8d2e7a0 HHH-12822 Skip "case when" tests requiring casts for DB2 2018-07-19 15:18:42 +02:00
Guillaume Smet 3747352ec5 HHH-12827 Define a numeric type as decimal for DB2
DB2 converts the numeric type to decimal and returns Types.DECIMAL for a
numeric. We change the type name used so that we have a match when
comparing the type names as last resort.
2018-07-19 15:18:42 +02:00
Guillaume Smet 7174b03a25 HHH-12815 Remove the zeroDateTimeBehavior option
It's useless for this test and it causes compatibility issues.
2018-07-19 15:18:42 +02:00
Guillaume Smet b84d364cd2 HHH-12829 Update the Ehcache documentation to use the new short names 2018-07-19 10:23:22 +02:00
Guillaume Smet 1945180569 HHH-12791 Cache the Component type to avoid generating one proxy per call
While Javassist only generates one proxy as the name is stable,
ByteBuddy uses random names and thus generates a new proxy for every
call, leading to the generation of 18 different proxies for the other
test of the test class.

We can't do better than using a volatile/synchronized pattern as the
Component is not fully initialized in the constructor.

Maybe we could take the risk of admitting that the getType() method is
called at least once before we pass the element to a multi-threaded
environment but that's a bet I don't want to take alone.
2018-07-19 10:02:03 +02:00
Guillaume Smet f6e8dc9845 HHH-12828 Make ScannerTests more stable
In a shared containerized environment like Travis, it's not obvious that
the second read will be faster than the first one.

And indeed, the test often fails.

There's no real value in testing that, we are just testing I/O, and the OS
cache.
2018-07-19 10:00:17 +02:00
Chris Cranford 4fc2ce7ab7 HHH-12826 - Persist cascade of collection fails when orphan removal enabled with flush mode commit.
(cherry picked from commit 3fe7d6e13e)
2018-07-18 18:10:58 -04:00
Chris Cranford 310ae3ea0d HHH-12826 - Added test case.
(cherry picked from commit 3d93073b83)
2018-07-18 18:10:51 -04:00
Chris Cranford d24685de67 HHH-12542 - Add necessary privileged action blocks for SecurityManager used on WildFly. 2018-07-18 17:50:27 +02:00
Martin Simka d23fc129cc HHH-12825 CriteriaHQLAlignmentTest.testCountReturnValues fails on databases that don't support tuple distinct counts because it expects wrong exception 2018-07-18 16:03:24 +02:00