Commit Graph

4897 Commits

Author SHA1 Message Date
Sanne Grinovero e82861bfb1 HHH-14787 Upgrade to Javassist 3.27.0-GA 2021-08-20 14:06:55 +01:00
Yoann Rodière 3addca2498 HHH-14371 Open java.base/java.lang to the unnamed module in javassist tests
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-08-20 14:06:55 +01:00
Yoann Rodière da0d8415e6 HHH-14371 Move tests specific to Javassist to the appropriate source set
Otherwise they won't be executed with the appropriate JVM args.

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-08-20 14:06:55 +01:00
Yoann Rodière 66ecd0cc67 HHH-14371 Open java.base/java.security and java/base/java.lang to the unnamed module in tests
Weld needs this, in CDI tests.

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-08-20 14:06:55 +01:00
Yoann Rodière 5b23a51dac HHH-14371 Open java.base/java.nio.charset to the unnamed module in tests
NamingHelper test needs access to Charset.defaultCharset.

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-08-20 14:06:55 +01:00
Yoann Rodière 7d82649ed4 HHH-14371 Correctly set JVM args in the JVM running tests
Turns out getJvmArgs() returns a copy, so modifying that copy won't
change the JVM args.

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-08-20 14:06:55 +01:00
Yoann Rodière f2e6289717 HHH-14315 Force JVM options when using toolchains
Apparently Gradle won't just use the same options as in its own JVM.

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-08-20 14:06:55 +01:00
Yoann Rodière 75ba67b6b2 HHH-14315 Add optional support for toolchains to the Gradle build
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-08-20 14:06:55 +01:00
Sanne Grinovero 2da1b79856 HHH-13821 Update to Byte Buddy 1.10.7 2021-08-20 14:06:55 +01:00
Andrea Boriero 8c66c83ef0 HHH-14608 Merge causes StackOverflow when JPA proxy compliance is enabled
(cherry picked from commit 8b02aaf5a8)
2021-07-15 23:03:35 -07:00
Andrea Boriero 4783ef11f0 HHH-14608 Add test for issue
(cherry picked from commit 8dcf6f983b)
2021-07-15 23:03:35 -07:00
Gail Badner b6ccfa531b HHH-13875 : Optional one-to-one does not always join the associated entity table when querying
(cherry picked from commit a7261ad053)
2021-07-15 15:26:08 -07:00
Gail Badner 8b21120e95 HHH-13875 : Added test cases
(cherry picked from commit b060b21851)
2021-07-15 15:26:08 -07:00
Gail Badner 5a4a796c57 HHH-12436 : Shorten entity names to fix test failures on Oracle
(cherry picked from commit 563758669a)
2021-07-15 15:26:08 -07:00
Gail Badner b419a0031b HHH-12436 - Attempted to assign id from null one-to-one property
(cherry picked from commit 3218f6cc7d)
2021-07-15 15:26:08 -07:00
Gail Badner f0117e8874 HHH-12436 : Added test cases
(cherry picked from commit 925c737096)
2021-07-15 15:26:08 -07:00
Jan-Willem Gmelig Meyling 7e73de1cc9 HHH-12842 : Remove invalid workaround from ea77c1f for isNullable regression from 2bfe300
(cherry picked from commit 8535adc057)
2021-07-15 15:26:08 -07:00
Jan-Willem Gmelig Meyling b53ce90255 HHH-12842 - Test that shows @OneToOne will be lazily loaded again
(cherry picked from commit bf6f105c41)
2021-07-15 15:26:08 -07:00
Jan-Willem Gmelig Meyling f21e8c64c3 HHH-12842 - Pass OneToOne constrained to determine nullability of type
(cherry picked from commit 662f6b2b53)
2021-07-15 15:26:08 -07:00
Chris Cranford d6bc53235a HHH-12320 HHH-12975 - Make sure foreign key name/mode is set prior to building the constraint.
(cherry picked from commit 41e49725ae)
2021-07-15 15:26:08 -07:00
Chris Cranford 92f41e41f6 HHH-12320 HHH-12975 - Added test cases.
(cherry picked from commit 9022085f5c)
2021-07-15 15:26:08 -07:00
Ranabir Chakraborty 859ac47263 HHH-14697 TimePropertyTest fails on MySQL 8.0 with a ComparisonFailure 2021-07-09 10:15:17 -07:00
Andrea Boriero 2c7cbf04e0 HHH-14616 Change VERSION_COLUMN_ALIAS from v to version_
(cherry picked from commit dae2c73f83)
2021-06-04 11:17:02 -07:00
Gail Badner 3ce531f1d6 HHH-14616 : Add test case with default hibernate.globally_quoted_identifiers (=false) and version column quoted
(cherry picked from commit 23055fb6ce)
2021-06-04 11:17:02 -07:00
Andrea Boriero 2f0504853a HHH-14616 Oprimistic Lock throws org.hibernate.exception.SQLGrammarException: could not retrieve version
(cherry picked from commit 1b50cfaea1)
2021-06-04 11:17:02 -07:00
Andrea Boriero 755f4ef6b6 HHH-14616 Add test for issue
(cherry picked from commit 2a571aeb40)
2021-06-04 11:17:02 -07:00
Yoann Rodière 86d883e998 HHH-13682 Enable extended bytecode enhancement in NaturalIdInUninitializedAssociationTest
This test accesses a field of an entity directly and expects it to be
automatically initialized; this cannot work without extended bytecode
enhancement.

This used to work with Java 8 bytecode, but only by chance. It seems
that Java 8 bytecode relies on "synthetic", static access methods
inserted by the compiler to access the fields of entities in this test:
any access to the field is done through this access method instead of
through a direct field access. Since we apply bytecode enhancement to
all methods of entities, this means that access to fields triggers
initialization, without any bytecode enhancement in the caller class.

I believe this is specific to nested classes, but couldn't find a
source. For reference, the bytecode of access methods looks like this:

  static int access$002(org.hibernate.test.bytecode.enhancement.lazy.NaturalIdInUninitializedAssociationTest$AnEntity, int);
    Code:
       0: aload_0
       1: iload_1
       2: dup_x1
       3: putfield      #3                  // Field id:I
       6: ireturn

  static org.hibernate.test.bytecode.enhancement.lazy.NaturalIdInUninitializedAssociationTest$EntityImmutableNaturalId access$102(org.hibernate.test.bytecode.enhancement.lazy.NaturalIdInUninitializedAssociationTest$AnEntity, org.hibernate.test.bytecode.enhancement.lazy.NaturalIdInUninitializedAssociationTest$EntityImmutableNaturalId);
    Code:
       0: aload_0
       1: aload_1
       2: dup_x1
       3: putfield      #2                  // Field entityImmutableNaturalId:Lorg/hibernate/test/bytecode/enhancement/lazy/NaturalIdInUninitializedAssociationTest$EntityImmutableNaturalId;
       6: areturn

With Java 11, however, access to fields of entities is done directly,
even for nested classes. So the access methods no longer exist, and we
don't get automatic initialization upon field access. We need extended
bytecode enhancement, like we would in any other case of field access
(in particular accessing fields of non-nested classes).

(cherry picked from commit 1060baf74b)
2021-06-04 10:23:46 -07:00
Yoann Rodière b95f589e08 HHH-14640 Remove some JTA-related dependencies that weren't there in 5.3.20.Final 2021-06-03 16:10:37 -07:00
Andrea Boriero b3ae29406a HHH-14640 : Fix checkstyle errors 2021-06-03 16:10:37 -07:00
Andrea Boriero cc6fe84f30 HHH-14640 : Fix gradle errors 2021-06-03 16:10:37 -07:00
Andrea Boriero 40d82d6370 HHH-14640 : Fix issue with generated pom missing project description 2021-06-03 16:10:37 -07:00
Yoann Rodière f795213e5a HHH-13689 Replace uses of the deprecated osgi plugin with the biz.aQute.bnd plugin
https://docs.gradle.org/5.0-milestone-1/release-notes.html#deprecated-osgi-plugin
2021-06-03 16:10:37 -07:00
Yoann Rodière 861b3c00aa HHH-13685 Replace uses of deprecated classifier property in Jar tasks with archiveClassifier 2021-06-03 16:10:37 -07:00
Gail Badner d7b68ba8ce HHH-14537 : Updated test as requested; added tests that lazy associations with non-existing entity is unaffected.
(cherry picked from commit ad84aaf0bc)
2021-04-20 10:57:51 -07:00
Gail Badner c2bb67515f HHH-14537 EntityNotFoundException thrown when non-existing association with @NotFound(IGNORE) mapped has proxy in PersistenceContext
(cherry picked from commit 3c1e16e06c)
2021-04-20 10:57:51 -07:00
Gail Badner edcf4a6369 HHH-14537 : Added test for issue
(cherry picked from commit 9cb9137fb8)
2021-04-20 10:57:51 -07:00
Steve Ebersole bc8e38a9a8 HHH-14325 - Add Query hint for specifying "query spaces" for native queries
(cherry picked from commit be70d49df9)
2020-11-16 10:46:35 -06:00
Steve Ebersole d5067eccf3 HHH-14325 - Add Query hint for specifying "query spaces" for native queries 2020-11-16 10:46:20 -06:00
Andrea Boriero 2896372dd5 HHH-14257 Add test for issue 2020-11-16 09:39:00 +00:00
Andrea Boriero 00b3ccb8ec HHH-14257 An Entity A with a map collection having as index an Embeddable with a an association to the Entity A fails with a NPE 2020-11-16 09:38:56 +00:00
Andrea Boriero d22bbb5c33 HHH-14225 CVE-2020-25638 Potential for SQL injection on use_sql_comments logging enabled 2020-11-13 13:34:09 +00:00
Andrea Boriero 096916e6fa HHH-13310 getParameterValue() not working for collections 2020-11-10 18:53:09 +00:00
Andrea Boriero 36f9360a31 HHH-13310 Add test for issue 2020-11-10 18:52:59 +00:00
Scott Marlow 06fdd27b3d HHH-14196 Add parsing of persistence.xml/orm.xml documents in the EE 9 namespace
Signed-off-by: Scott Marlow <smarlow@redhat.com>
2020-11-10 13:23:57 +00:00
Steve Ebersole 204dc9f9db Fixed Javadoc for `BulkOperationCleanupAction.affectedEntity` 2020-11-10 11:35:03 +00:00
Andrea Boriero 1cdf75c212 HHH-14077 PostgreSQL, skip testLiteralProjectionAndGroupBy (PostgreSQL does not support literals in group by statement) 2020-08-04 14:58:21 -07:00
Gail Badner 646b383f95 HHH-14077 : CVE-2019-14900 SQL injection issue in Hibernate ORM 2020-08-04 14:58:21 -07:00
Gail Badner d7400b5a08 HHH-14103 : Add test cases showing that an entity's transient attribute can be overridden to be persistent in entity subclasses
(cherry picked from commit fb40f8edc0)
2020-08-04 14:47:41 -07:00
Vlad Mihalcea 7317331108 HHH-13110 - @PreUpdate method on a Embeddable null on the parent caused NullPointerException
(cherry picked from commit 3ff3615d00)
2020-08-03 15:15:36 -07:00
Gail Badner 23fae34ea9 Revert "HHH-14096 Remove unused import for deprecated type XmlDocument and dom4j"
Imports are required for 5.3 branch

This reverts commit 5ead0e4dd5.
2020-08-03 15:12:51 -07:00