2016-08-25 13:37:30 -04:00
|
|
|
<?php
|
|
|
|
/**
|
|
|
|
* Diff API: WP_Text_Diff_Renderer_Table class
|
|
|
|
*
|
|
|
|
* @package WordPress
|
|
|
|
* @subpackage Diff
|
|
|
|
* @since 4.7.0
|
|
|
|
*/
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Table renderer to display the diff lines.
|
|
|
|
*
|
|
|
|
* @since 2.6.0
|
|
|
|
* @uses Text_Diff_Renderer Extends
|
|
|
|
*/
|
Code Modernization: Add `AllowDynamicProperties` attribute to all (parent) classes.
Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.
There are a number of ways to mitigate this:
* If it is an accidental typo for a declared property: fix the typo.
* For known properties: declare them on the class.
* For unknown properties: add the magic `__get()`, `__set()`, et al. methods to the class or let the class extend `stdClass` which has highly optimized versions of these magic methods built in.
* For unknown ''use'' of dynamic properties, the `#[AllowDynamicProperties]` attribute can be added to the class. The attribute will automatically be inherited by child classes.
Trac ticket #56034 is open to investigate and handle the third and fourth type of situations, however it has become clear this will need more time and will not be ready in time for WP 6.1.
To reduce “noise” in the meantime, both in the error logs of WP users moving onto PHP 8.2, in the test run logs of WP itself, in test runs of plugins and themes, as well as to prevent duplicate tickets from being opened for the same issue, this commit adds the `#[AllowDynamicProperties]` attribute to all “parent” classes in WP.
The logic used for this commit is as follows:
* If a class already has the attribute: no action needed.
* If a class does not `extend`: add the attribute.
* If a class does `extend`:
- If it extends `stdClass`: no action needed (as `stdClass` supports dynamic properties).
- If it extends a PHP native class: add the attribute.
- If it extends a class from one of WP's external dependencies: add the attribute.
* In all other cases: no action — the attribute should not be needed as child classes inherit from the parent.
Whether or not a class contains magic methods has not been taken into account, as a review of the currently existing magic methods has shown that those are generally not sturdy enough and often even set dynamic properties (which they should not). See the [https://www.youtube.com/watch?v=vDZWepDQQVE live stream from August 16, 2022] for more details.
This commit only affects classes in the `src` directory of WordPress core.
* Tests should not get this attribute, but should be fixed to not use dynamic properties instead. Patches for this are already being committed under ticket #56033.
* While a number bundled themes (2014, 2019, 2020, 2021) contain classes, they are not a part of this commit and may be updated separately.
Reference: [https://wiki.php.net/rfc/deprecate_dynamic_properties PHP RFC: Deprecate dynamic properties].
Follow-up to [53922].
Props jrf, hellofromTonya, markjaquith, peterwilsoncc, costdev, knutsp, aristath.
See #56513, #56034.
Built from https://develop.svn.wordpress.org/trunk@54133
git-svn-id: http://core.svn.wordpress.org/trunk@53692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-09-12 11:47:14 -04:00
|
|
|
#[AllowDynamicProperties]
|
2016-08-25 13:37:30 -04:00
|
|
|
class WP_Text_Diff_Renderer_Table extends Text_Diff_Renderer {
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @see Text_Diff_Renderer::_leading_context_lines
|
|
|
|
* @var int
|
|
|
|
* @since 2.6.0
|
|
|
|
*/
|
2017-11-30 18:11:00 -05:00
|
|
|
public $_leading_context_lines = 10000;
|
2016-08-25 13:37:30 -04:00
|
|
|
|
|
|
|
/**
|
|
|
|
* @see Text_Diff_Renderer::_trailing_context_lines
|
|
|
|
* @var int
|
|
|
|
* @since 2.6.0
|
|
|
|
*/
|
|
|
|
public $_trailing_context_lines = 10000;
|
|
|
|
|
Code Modernization: Declare dynamic properties on WP_Text_Diff_Renderer_Table.
Core uses 3 known, named, dynamic properties on the `WP_Text_Diff_Renderer_Table` class:
* `_title`
* `_title_left`
* `_title_right`
When reviewing revisions (within the admin UI), `wp_text_diff()` passes the arguments (without the leading `_`) to a new instance, which raised deprecation notices (see [56354]).
Note: the parent class adds the leading `_` to each of these properties (see [7747]).
The deprecation notices are resolved by declaring each of these known, named, dynamic properties on the class, per the #56034 mitigation strategy. These new properties are not initialized to retain their previous `null` behavior.
Follow-up to [56354], [23506], [7747].
Props wildworks, antonvlasenko, hellofromTonya, ironprogrammer, kafleg, mukesh27, nicolefurlan, presskopp, sabernhardt.
Fixes #59431.
See #58898, #56034.
Built from https://develop.svn.wordpress.org/trunk@56938
git-svn-id: http://core.svn.wordpress.org/trunk@56449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-10-15 10:55:23 -04:00
|
|
|
/**
|
|
|
|
* Title of the item being compared.
|
|
|
|
*
|
|
|
|
* @since 6.4.0 Declared a previously dynamic property.
|
|
|
|
* @var string|null
|
|
|
|
*/
|
|
|
|
public $_title;
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Title for the left column.
|
|
|
|
*
|
|
|
|
* @since 6.4.0 Declared a previously dynamic property.
|
|
|
|
* @var string|null
|
|
|
|
*/
|
|
|
|
public $_title_left;
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Title for the right column.
|
|
|
|
*
|
|
|
|
* @since 6.4.0 Declared a previously dynamic property.
|
|
|
|
* @var string|null
|
|
|
|
*/
|
|
|
|
public $_title_right;
|
|
|
|
|
2016-08-25 13:37:30 -04:00
|
|
|
/**
|
|
|
|
* Threshold for when a diff should be saved or omitted.
|
|
|
|
*
|
|
|
|
* @var float
|
|
|
|
* @since 2.6.0
|
|
|
|
*/
|
|
|
|
protected $_diff_threshold = 0.6;
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Inline display helper object name.
|
|
|
|
*
|
|
|
|
* @var string
|
|
|
|
* @since 2.6.0
|
|
|
|
*/
|
|
|
|
protected $inline_diff_renderer = 'WP_Text_Diff_Renderer_inline';
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Should we show the split view or not
|
|
|
|
*
|
|
|
|
* @var string
|
|
|
|
* @since 3.6.0
|
|
|
|
*/
|
|
|
|
protected $_show_split_view = true;
|
|
|
|
|
|
|
|
protected $compat_fields = array( '_show_split_view', 'inline_diff_renderer', '_diff_threshold' );
|
|
|
|
|
2018-12-13 20:04:36 -05:00
|
|
|
/**
|
|
|
|
* Caches the output of count_chars() in compute_string_distance()
|
|
|
|
*
|
|
|
|
* @var array
|
|
|
|
* @since 5.0.0
|
|
|
|
*/
|
|
|
|
protected $count_cache = array();
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Caches the difference calculation in compute_string_distance()
|
|
|
|
*
|
|
|
|
* @var array
|
|
|
|
* @since 5.0.0
|
|
|
|
*/
|
|
|
|
protected $difference_cache = array();
|
|
|
|
|
2016-08-25 13:37:30 -04:00
|
|
|
/**
|
|
|
|
* Constructor - Call parent constructor with params array.
|
|
|
|
*
|
|
|
|
* This will set class properties based on the key value pairs in the array.
|
|
|
|
*
|
|
|
|
* @since 2.6.0
|
|
|
|
*
|
|
|
|
* @param array $params
|
|
|
|
*/
|
|
|
|
public function __construct( $params = array() ) {
|
|
|
|
parent::__construct( $params );
|
2017-11-30 18:11:00 -05:00
|
|
|
if ( isset( $params['show_split_view'] ) ) {
|
|
|
|
$this->_show_split_view = $params['show_split_view'];
|
|
|
|
}
|
2016-08-25 13:37:30 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @ignore
|
|
|
|
*
|
|
|
|
* @param string $header
|
|
|
|
* @return string
|
|
|
|
*/
|
|
|
|
public function _startBlock( $header ) {
|
|
|
|
return '';
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @ignore
|
|
|
|
*
|
2020-07-23 16:01:04 -04:00
|
|
|
* @param array $lines
|
2016-08-25 13:37:30 -04:00
|
|
|
* @param string $prefix
|
|
|
|
*/
|
2017-11-30 18:11:00 -05:00
|
|
|
public function _lines( $lines, $prefix = ' ' ) {
|
2016-08-25 13:37:30 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @ignore
|
|
|
|
*
|
|
|
|
* @param string $line HTML-escape the value.
|
|
|
|
* @return string
|
|
|
|
*/
|
|
|
|
public function addedLine( $line ) {
|
I18N: Mark screen reader strings as such with translator comments.
This aims to provide better context for translators and make it easier to determine that some strings contain hidden accessibility text and are not displayed in the UI.
Props kebbet, mercime, pavelevap, ocean90, swissspidy, Chouby, jipmoors, afercia, desrosj, costdev, audrasjb, SergeyBiryukov.
Fixes #29748.
Built from https://develop.svn.wordpress.org/trunk@55276
git-svn-id: http://core.svn.wordpress.org/trunk@54809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-02-07 12:10:21 -05:00
|
|
|
return "<td class='diff-addedline'><span aria-hidden='true' class='dashicons dashicons-plus'></span><span class='screen-reader-text'>" .
|
|
|
|
/* translators: Hidden accessibility text. */
|
|
|
|
__( 'Added:' ) .
|
|
|
|
" </span>{$line}</td>";
|
2016-08-25 13:37:30 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @ignore
|
|
|
|
*
|
|
|
|
* @param string $line HTML-escape the value.
|
|
|
|
* @return string
|
|
|
|
*/
|
|
|
|
public function deletedLine( $line ) {
|
I18N: Mark screen reader strings as such with translator comments.
This aims to provide better context for translators and make it easier to determine that some strings contain hidden accessibility text and are not displayed in the UI.
Props kebbet, mercime, pavelevap, ocean90, swissspidy, Chouby, jipmoors, afercia, desrosj, costdev, audrasjb, SergeyBiryukov.
Fixes #29748.
Built from https://develop.svn.wordpress.org/trunk@55276
git-svn-id: http://core.svn.wordpress.org/trunk@54809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-02-07 12:10:21 -05:00
|
|
|
return "<td class='diff-deletedline'><span aria-hidden='true' class='dashicons dashicons-minus'></span><span class='screen-reader-text'>" .
|
|
|
|
/* translators: Hidden accessibility text. */
|
|
|
|
__( 'Deleted:' ) .
|
|
|
|
" </span>{$line}</td>";
|
2016-08-25 13:37:30 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @ignore
|
|
|
|
*
|
|
|
|
* @param string $line HTML-escape the value.
|
|
|
|
* @return string
|
|
|
|
*/
|
|
|
|
public function contextLine( $line ) {
|
I18N: Mark screen reader strings as such with translator comments.
This aims to provide better context for translators and make it easier to determine that some strings contain hidden accessibility text and are not displayed in the UI.
Props kebbet, mercime, pavelevap, ocean90, swissspidy, Chouby, jipmoors, afercia, desrosj, costdev, audrasjb, SergeyBiryukov.
Fixes #29748.
Built from https://develop.svn.wordpress.org/trunk@55276
git-svn-id: http://core.svn.wordpress.org/trunk@54809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-02-07 12:10:21 -05:00
|
|
|
return "<td class='diff-context'><span class='screen-reader-text'>" .
|
|
|
|
/* translators: Hidden accessibility text. */
|
|
|
|
__( 'Unchanged:' ) .
|
|
|
|
" </span>{$line}</td>";
|
2016-08-25 13:37:30 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @ignore
|
|
|
|
*
|
|
|
|
* @return string
|
|
|
|
*/
|
|
|
|
public function emptyLine() {
|
|
|
|
return '<td> </td>';
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @ignore
|
|
|
|
*
|
|
|
|
* @param array $lines
|
2020-07-23 16:01:04 -04:00
|
|
|
* @param bool $encode
|
2016-08-25 13:37:30 -04:00
|
|
|
* @return string
|
|
|
|
*/
|
|
|
|
public function _added( $lines, $encode = true ) {
|
|
|
|
$r = '';
|
2017-11-30 18:11:00 -05:00
|
|
|
foreach ( $lines as $line ) {
|
2016-08-25 13:37:30 -04:00
|
|
|
if ( $encode ) {
|
|
|
|
$processed_line = htmlspecialchars( $line );
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Contextually filters a diffed line.
|
|
|
|
*
|
|
|
|
* Filters TextDiff processing of diffed line. By default, diffs are processed with
|
|
|
|
* htmlspecialchars. Use this filter to remove or change the processing. Passes a context
|
|
|
|
* indicating if the line is added, deleted or unchanged.
|
|
|
|
*
|
|
|
|
* @since 4.1.0
|
|
|
|
*
|
2019-11-12 17:42:02 -05:00
|
|
|
* @param string $processed_line The processed diffed line.
|
|
|
|
* @param string $line The unprocessed diffed line.
|
|
|
|
* @param string $context The line context. Values are 'added', 'deleted' or 'unchanged'.
|
2016-08-25 13:37:30 -04:00
|
|
|
*/
|
|
|
|
$line = apply_filters( 'process_text_diff_html', $processed_line, $line, 'added' );
|
|
|
|
}
|
|
|
|
|
|
|
|
if ( $this->_show_split_view ) {
|
2021-01-27 16:53:58 -05:00
|
|
|
$r .= '<tr>' . $this->emptyLine() . $this->addedLine( $line ) . "</tr>\n";
|
2016-08-25 13:37:30 -04:00
|
|
|
} else {
|
|
|
|
$r .= '<tr>' . $this->addedLine( $line ) . "</tr>\n";
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return $r;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @ignore
|
|
|
|
*
|
|
|
|
* @param array $lines
|
2020-07-23 16:01:04 -04:00
|
|
|
* @param bool $encode
|
2016-08-25 13:37:30 -04:00
|
|
|
* @return string
|
|
|
|
*/
|
|
|
|
public function _deleted( $lines, $encode = true ) {
|
|
|
|
$r = '';
|
2017-11-30 18:11:00 -05:00
|
|
|
foreach ( $lines as $line ) {
|
2016-08-25 13:37:30 -04:00
|
|
|
if ( $encode ) {
|
|
|
|
$processed_line = htmlspecialchars( $line );
|
|
|
|
|
|
|
|
/** This filter is documented in wp-includes/wp-diff.php */
|
|
|
|
$line = apply_filters( 'process_text_diff_html', $processed_line, $line, 'deleted' );
|
|
|
|
}
|
|
|
|
if ( $this->_show_split_view ) {
|
2021-01-27 16:53:58 -05:00
|
|
|
$r .= '<tr>' . $this->deletedLine( $line ) . $this->emptyLine() . "</tr>\n";
|
2016-08-25 13:37:30 -04:00
|
|
|
} else {
|
|
|
|
$r .= '<tr>' . $this->deletedLine( $line ) . "</tr>\n";
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return $r;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @ignore
|
|
|
|
*
|
|
|
|
* @param array $lines
|
2020-07-23 16:01:04 -04:00
|
|
|
* @param bool $encode
|
2016-08-25 13:37:30 -04:00
|
|
|
* @return string
|
|
|
|
*/
|
|
|
|
public function _context( $lines, $encode = true ) {
|
|
|
|
$r = '';
|
2017-11-30 18:11:00 -05:00
|
|
|
foreach ( $lines as $line ) {
|
2016-08-25 13:37:30 -04:00
|
|
|
if ( $encode ) {
|
|
|
|
$processed_line = htmlspecialchars( $line );
|
|
|
|
|
|
|
|
/** This filter is documented in wp-includes/wp-diff.php */
|
|
|
|
$line = apply_filters( 'process_text_diff_html', $processed_line, $line, 'unchanged' );
|
|
|
|
}
|
2017-11-30 18:11:00 -05:00
|
|
|
if ( $this->_show_split_view ) {
|
2021-01-27 16:53:58 -05:00
|
|
|
$r .= '<tr>' . $this->contextLine( $line ) . $this->contextLine( $line ) . "</tr>\n";
|
2016-08-25 13:37:30 -04:00
|
|
|
} else {
|
|
|
|
$r .= '<tr>' . $this->contextLine( $line ) . "</tr>\n";
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return $r;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Process changed lines to do word-by-word diffs for extra highlighting.
|
|
|
|
*
|
|
|
|
* (TRAC style) sometimes these lines can actually be deleted or added rows.
|
|
|
|
* We do additional processing to figure that out
|
|
|
|
*
|
|
|
|
* @since 2.6.0
|
|
|
|
*
|
|
|
|
* @param array $orig
|
|
|
|
* @param array $final
|
|
|
|
* @return string
|
|
|
|
*/
|
2023-01-30 10:24:13 -05:00
|
|
|
public function _changed( $orig, $final ) { // phpcs:ignore Universal.NamingConventions.NoReservedKeywordParameterNames.finalFound
|
2016-08-25 13:37:30 -04:00
|
|
|
$r = '';
|
|
|
|
|
2020-01-28 19:45:18 -05:00
|
|
|
/*
|
|
|
|
* Does the aforementioned additional processing:
|
|
|
|
* *_matches tell what rows are "the same" in orig and final. Those pairs will be diffed to get word changes.
|
|
|
|
* - match is numeric: an index in other column.
|
|
|
|
* - match is 'X': no match. It is a new row.
|
|
|
|
* *_rows are column vectors for the orig column and the final column.
|
2022-02-04 11:28:00 -05:00
|
|
|
* - row >= 0: an index of the $orig or $final array.
|
2020-01-28 19:45:18 -05:00
|
|
|
* - row < 0: a blank row for that column.
|
|
|
|
*/
|
2016-08-25 13:37:30 -04:00
|
|
|
list($orig_matches, $final_matches, $orig_rows, $final_rows) = $this->interleave_changed_lines( $orig, $final );
|
|
|
|
|
2020-01-28 19:45:18 -05:00
|
|
|
// These will hold the word changes as determined by an inline diff.
|
2016-08-25 13:37:30 -04:00
|
|
|
$orig_diffs = array();
|
|
|
|
$final_diffs = array();
|
|
|
|
|
2020-01-28 19:45:18 -05:00
|
|
|
// Compute word diffs for each matched pair using the inline diff.
|
2016-08-25 13:37:30 -04:00
|
|
|
foreach ( $orig_matches as $o => $f ) {
|
2017-11-30 18:11:00 -05:00
|
|
|
if ( is_numeric( $o ) && is_numeric( $f ) ) {
|
|
|
|
$text_diff = new Text_Diff( 'auto', array( array( $orig[ $o ] ), array( $final[ $f ] ) ) );
|
2022-11-29 10:51:14 -05:00
|
|
|
$renderer = new $this->inline_diff_renderer();
|
2017-11-30 18:11:00 -05:00
|
|
|
$diff = $renderer->render( $text_diff );
|
2016-08-25 13:37:30 -04:00
|
|
|
|
2020-01-28 19:45:18 -05:00
|
|
|
// If they're too different, don't include any <ins> or <del>'s.
|
2016-08-25 13:37:30 -04:00
|
|
|
if ( preg_match_all( '!(<ins>.*?</ins>|<del>.*?</del>)!', $diff, $diff_matches ) ) {
|
2020-01-28 19:45:18 -05:00
|
|
|
// Length of all text between <ins> or <del>.
|
2020-10-18 13:27:06 -04:00
|
|
|
$stripped_matches = strlen( strip_tags( implode( ' ', $diff_matches[0] ) ) );
|
2023-07-09 17:25:23 -04:00
|
|
|
/*
|
|
|
|
* Since we count length of text between <ins> or <del> (instead of picking just one),
|
|
|
|
* we double the length of chars not in those tags.
|
|
|
|
*/
|
2017-11-30 18:11:00 -05:00
|
|
|
$stripped_diff = strlen( strip_tags( $diff ) ) * 2 - $stripped_matches;
|
|
|
|
$diff_ratio = $stripped_matches / $stripped_diff;
|
|
|
|
if ( $diff_ratio > $this->_diff_threshold ) {
|
2016-08-25 13:37:30 -04:00
|
|
|
continue; // Too different. Don't save diffs.
|
2017-11-30 18:11:00 -05:00
|
|
|
}
|
2016-08-25 13:37:30 -04:00
|
|
|
}
|
|
|
|
|
2020-01-28 19:45:18 -05:00
|
|
|
// Un-inline the diffs by removing <del> or <ins>.
|
2017-11-30 18:11:00 -05:00
|
|
|
$orig_diffs[ $o ] = preg_replace( '|<ins>.*?</ins>|', '', $diff );
|
|
|
|
$final_diffs[ $f ] = preg_replace( '|<del>.*?</del>|', '', $diff );
|
2016-08-25 13:37:30 -04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-11-30 18:11:00 -05:00
|
|
|
foreach ( array_keys( $orig_rows ) as $row ) {
|
2016-08-25 13:37:30 -04:00
|
|
|
// Both columns have blanks. Ignore them.
|
2017-11-30 18:11:00 -05:00
|
|
|
if ( $orig_rows[ $row ] < 0 && $final_rows[ $row ] < 0 ) {
|
2016-08-25 13:37:30 -04:00
|
|
|
continue;
|
2017-11-30 18:11:00 -05:00
|
|
|
}
|
2016-08-25 13:37:30 -04:00
|
|
|
|
|
|
|
// If we have a word based diff, use it. Otherwise, use the normal line.
|
2017-11-30 18:11:00 -05:00
|
|
|
if ( isset( $orig_diffs[ $orig_rows[ $row ] ] ) ) {
|
|
|
|
$orig_line = $orig_diffs[ $orig_rows[ $row ] ];
|
|
|
|
} elseif ( isset( $orig[ $orig_rows[ $row ] ] ) ) {
|
|
|
|
$orig_line = htmlspecialchars( $orig[ $orig_rows[ $row ] ] );
|
|
|
|
} else {
|
2016-08-25 13:37:30 -04:00
|
|
|
$orig_line = '';
|
2017-11-30 18:11:00 -05:00
|
|
|
}
|
2016-08-25 13:37:30 -04:00
|
|
|
|
2017-11-30 18:11:00 -05:00
|
|
|
if ( isset( $final_diffs[ $final_rows[ $row ] ] ) ) {
|
|
|
|
$final_line = $final_diffs[ $final_rows[ $row ] ];
|
|
|
|
} elseif ( isset( $final[ $final_rows[ $row ] ] ) ) {
|
|
|
|
$final_line = htmlspecialchars( $final[ $final_rows[ $row ] ] );
|
|
|
|
} else {
|
2016-08-25 13:37:30 -04:00
|
|
|
$final_line = '';
|
2017-11-30 18:11:00 -05:00
|
|
|
}
|
2016-08-25 13:37:30 -04:00
|
|
|
|
2017-11-30 18:11:00 -05:00
|
|
|
if ( $orig_rows[ $row ] < 0 ) { // Orig is blank. This is really an added row.
|
|
|
|
$r .= $this->_added( array( $final_line ), false );
|
|
|
|
} elseif ( $final_rows[ $row ] < 0 ) { // Final is blank. This is really a deleted row.
|
|
|
|
$r .= $this->_deleted( array( $orig_line ), false );
|
2016-08-25 13:37:30 -04:00
|
|
|
} else { // A true changed row.
|
|
|
|
if ( $this->_show_split_view ) {
|
2021-01-27 16:53:58 -05:00
|
|
|
$r .= '<tr>' . $this->deletedLine( $orig_line ) . $this->addedLine( $final_line ) . "</tr>\n";
|
2016-08-25 13:37:30 -04:00
|
|
|
} else {
|
2017-11-30 18:11:00 -05:00
|
|
|
$r .= '<tr>' . $this->deletedLine( $orig_line ) . '</tr><tr>' . $this->addedLine( $final_line ) . "</tr>\n";
|
2016-08-25 13:37:30 -04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return $r;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Takes changed blocks and matches which rows in orig turned into which rows in final.
|
|
|
|
*
|
|
|
|
* @since 2.6.0
|
|
|
|
*
|
2017-06-30 01:29:41 -04:00
|
|
|
* @param array $orig Lines of the original version of the text.
|
|
|
|
* @param array $final Lines of the final version of the text.
|
|
|
|
* @return array {
|
2020-07-23 03:39:02 -04:00
|
|
|
* Array containing results of comparing the original text to the final text.
|
2017-06-30 01:29:41 -04:00
|
|
|
*
|
2020-07-23 03:39:02 -04:00
|
|
|
* @type array $orig_matches Associative array of original matches. Index == row
|
|
|
|
* number of `$orig`, value == corresponding row number
|
|
|
|
* of that same line in `$final` or 'x' if there is no
|
|
|
|
* corresponding row (indicating it is a deleted line).
|
|
|
|
* @type array $final_matches Associative array of final matches. Index == row
|
|
|
|
* number of `$final`, value == corresponding row number
|
|
|
|
* of that same line in `$orig` or 'x' if there is no
|
|
|
|
* corresponding row (indicating it is a new line).
|
|
|
|
* @type array $orig_rows Associative array of interleaved rows of `$orig` with
|
|
|
|
* blanks to keep matches aligned with side-by-side diff
|
|
|
|
* of `$final`. A value >= 0 corresponds to index of `$orig`.
|
|
|
|
* Value < 0 indicates a blank row.
|
|
|
|
* @type array $final_rows Associative array of interleaved rows of `$final` with
|
|
|
|
* blanks to keep matches aligned with side-by-side diff
|
|
|
|
* of `$orig`. A value >= 0 corresponds to index of `$final`.
|
|
|
|
* Value < 0 indicates a blank row.
|
2017-06-30 01:29:41 -04:00
|
|
|
* }
|
2016-08-25 13:37:30 -04:00
|
|
|
*/
|
2023-01-30 10:24:13 -05:00
|
|
|
public function interleave_changed_lines( $orig, $final ) { // phpcs:ignore Universal.NamingConventions.NoReservedKeywordParameterNames.finalFound
|
2016-08-25 13:37:30 -04:00
|
|
|
|
|
|
|
// Contains all pairwise string comparisons. Keys are such that this need only be a one dimensional array.
|
|
|
|
$matches = array();
|
2017-11-30 18:11:00 -05:00
|
|
|
foreach ( array_keys( $orig ) as $o ) {
|
|
|
|
foreach ( array_keys( $final ) as $f ) {
|
|
|
|
$matches[ "$o,$f" ] = $this->compute_string_distance( $orig[ $o ], $final[ $f ] );
|
2016-08-25 13:37:30 -04:00
|
|
|
}
|
|
|
|
}
|
2017-11-30 18:11:00 -05:00
|
|
|
asort( $matches ); // Order by string distance.
|
2016-08-25 13:37:30 -04:00
|
|
|
|
|
|
|
$orig_matches = array();
|
|
|
|
$final_matches = array();
|
|
|
|
|
|
|
|
foreach ( $matches as $keys => $difference ) {
|
2017-11-30 18:11:00 -05:00
|
|
|
list($o, $f) = explode( ',', $keys );
|
|
|
|
$o = (int) $o;
|
|
|
|
$f = (int) $f;
|
2016-08-25 13:37:30 -04:00
|
|
|
|
2020-01-28 19:45:18 -05:00
|
|
|
// Already have better matches for these guys.
|
2017-11-30 18:11:00 -05:00
|
|
|
if ( isset( $orig_matches[ $o ] ) && isset( $final_matches[ $f ] ) ) {
|
2016-08-25 13:37:30 -04:00
|
|
|
continue;
|
2017-11-30 18:11:00 -05:00
|
|
|
}
|
2016-08-25 13:37:30 -04:00
|
|
|
|
2020-01-28 19:45:18 -05:00
|
|
|
// First match for these guys. Must be best match.
|
2017-11-30 18:11:00 -05:00
|
|
|
if ( ! isset( $orig_matches[ $o ] ) && ! isset( $final_matches[ $f ] ) ) {
|
|
|
|
$orig_matches[ $o ] = $f;
|
|
|
|
$final_matches[ $f ] = $o;
|
2016-08-25 13:37:30 -04:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2020-01-28 19:45:18 -05:00
|
|
|
// Best match of this final is already taken? Must mean this final is a new row.
|
2017-11-30 18:11:00 -05:00
|
|
|
if ( isset( $orig_matches[ $o ] ) ) {
|
|
|
|
$final_matches[ $f ] = 'x';
|
2019-01-11 01:40:50 -05:00
|
|
|
} elseif ( isset( $final_matches[ $f ] ) ) {
|
2020-01-28 19:45:18 -05:00
|
|
|
// Best match of this orig is already taken? Must mean this orig is a deleted row.
|
2017-11-30 18:11:00 -05:00
|
|
|
$orig_matches[ $o ] = 'x';
|
|
|
|
}
|
2016-08-25 13:37:30 -04:00
|
|
|
}
|
|
|
|
|
2020-01-28 19:45:18 -05:00
|
|
|
// We read the text in this order.
|
2017-11-30 18:11:00 -05:00
|
|
|
ksort( $orig_matches );
|
|
|
|
ksort( $final_matches );
|
2016-08-25 13:37:30 -04:00
|
|
|
|
|
|
|
// Stores rows and blanks for each column.
|
2019-07-02 19:42:58 -04:00
|
|
|
$orig_rows = array_keys( $orig_matches );
|
|
|
|
$orig_rows_copy = $orig_rows;
|
|
|
|
$final_rows = array_keys( $final_matches );
|
2016-08-25 13:37:30 -04:00
|
|
|
|
2023-07-09 17:25:23 -04:00
|
|
|
/*
|
|
|
|
* Interleaves rows with blanks to keep matches aligned.
|
|
|
|
* We may end up with some extraneous blank rows, but we'll just ignore them later.
|
|
|
|
*/
|
2016-08-25 13:37:30 -04:00
|
|
|
foreach ( $orig_rows_copy as $orig_row ) {
|
2017-11-30 18:11:00 -05:00
|
|
|
$final_pos = array_search( $orig_matches[ $orig_row ], $final_rows, true );
|
|
|
|
$orig_pos = (int) array_search( $orig_row, $orig_rows, true );
|
2016-08-25 13:37:30 -04:00
|
|
|
|
|
|
|
if ( false === $final_pos ) { // This orig is paired with a blank final.
|
|
|
|
array_splice( $final_rows, $orig_pos, 0, -1 );
|
|
|
|
} elseif ( $final_pos < $orig_pos ) { // This orig's match is up a ways. Pad final with blank rows.
|
2018-12-13 20:04:36 -05:00
|
|
|
$diff_array = range( -1, $final_pos - $orig_pos );
|
|
|
|
array_splice( $final_rows, $orig_pos, 0, $diff_array );
|
2016-08-25 13:37:30 -04:00
|
|
|
} elseif ( $final_pos > $orig_pos ) { // This orig's match is down a ways. Pad orig with blank rows.
|
2018-12-13 20:04:36 -05:00
|
|
|
$diff_array = range( -1, $orig_pos - $final_pos );
|
|
|
|
array_splice( $orig_rows, $orig_pos, 0, $diff_array );
|
2016-08-25 13:37:30 -04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-01-28 19:45:18 -05:00
|
|
|
// Pad the ends with blank rows if the columns aren't the same length.
|
2017-11-30 18:11:00 -05:00
|
|
|
$diff_count = count( $orig_rows ) - count( $final_rows );
|
2016-08-25 13:37:30 -04:00
|
|
|
if ( $diff_count < 0 ) {
|
2017-11-30 18:11:00 -05:00
|
|
|
while ( $diff_count < 0 ) {
|
|
|
|
array_push( $orig_rows, $diff_count++ );
|
|
|
|
}
|
2016-08-25 13:37:30 -04:00
|
|
|
} elseif ( $diff_count > 0 ) {
|
|
|
|
$diff_count = -1 * $diff_count;
|
2017-11-30 18:11:00 -05:00
|
|
|
while ( $diff_count < 0 ) {
|
|
|
|
array_push( $final_rows, $diff_count++ );
|
|
|
|
}
|
2016-08-25 13:37:30 -04:00
|
|
|
}
|
|
|
|
|
2017-11-30 18:11:00 -05:00
|
|
|
return array( $orig_matches, $final_matches, $orig_rows, $final_rows );
|
2016-08-25 13:37:30 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Computes a number that is intended to reflect the "distance" between two strings.
|
|
|
|
*
|
|
|
|
* @since 2.6.0
|
|
|
|
*
|
|
|
|
* @param string $string1
|
|
|
|
* @param string $string2
|
|
|
|
* @return int
|
|
|
|
*/
|
|
|
|
public function compute_string_distance( $string1, $string2 ) {
|
2018-12-13 20:04:36 -05:00
|
|
|
// Use an md5 hash of the strings for a count cache, as it's fast to generate, and collisions aren't a concern.
|
|
|
|
$count_key1 = md5( $string1 );
|
|
|
|
$count_key2 = md5( $string2 );
|
|
|
|
|
|
|
|
// Cache vectors containing character frequency for all chars in each string.
|
|
|
|
if ( ! isset( $this->count_cache[ $count_key1 ] ) ) {
|
|
|
|
$this->count_cache[ $count_key1 ] = count_chars( $string1 );
|
|
|
|
}
|
|
|
|
if ( ! isset( $this->count_cache[ $count_key2 ] ) ) {
|
|
|
|
$this->count_cache[ $count_key2 ] = count_chars( $string2 );
|
|
|
|
}
|
|
|
|
|
|
|
|
$chars1 = $this->count_cache[ $count_key1 ];
|
|
|
|
$chars2 = $this->count_cache[ $count_key2 ];
|
|
|
|
|
|
|
|
$difference_key = md5( implode( ',', $chars1 ) . ':' . implode( ',', $chars2 ) );
|
|
|
|
if ( ! isset( $this->difference_cache[ $difference_key ] ) ) {
|
|
|
|
// L1-norm of difference vector.
|
|
|
|
$this->difference_cache[ $difference_key ] = array_sum( array_map( array( $this, 'difference' ), $chars1, $chars2 ) );
|
|
|
|
}
|
2016-08-25 13:37:30 -04:00
|
|
|
|
2018-12-13 20:04:36 -05:00
|
|
|
$difference = $this->difference_cache[ $difference_key ];
|
2016-08-25 13:37:30 -04:00
|
|
|
|
|
|
|
// $string1 has zero length? Odd. Give huge penalty by not dividing.
|
2017-11-30 18:11:00 -05:00
|
|
|
if ( ! $string1 ) {
|
2016-08-25 13:37:30 -04:00
|
|
|
return $difference;
|
2017-11-30 18:11:00 -05:00
|
|
|
}
|
2016-08-25 13:37:30 -04:00
|
|
|
|
|
|
|
// Return distance per character (of string1).
|
2017-11-30 18:11:00 -05:00
|
|
|
return $difference / strlen( $string1 );
|
2016-08-25 13:37:30 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @ignore
|
|
|
|
* @since 2.6.0
|
|
|
|
*
|
|
|
|
* @param int $a
|
|
|
|
* @param int $b
|
|
|
|
* @return int
|
|
|
|
*/
|
|
|
|
public function difference( $a, $b ) {
|
|
|
|
return abs( $a - $b );
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Make private properties readable for backward compatibility.
|
|
|
|
*
|
|
|
|
* @since 4.0.0
|
Code Modernization: Deprecate dynamic properties in WP_Text_Diff_Renderer_Table magic methods.
The unknown use of unknown dynamic property within the `WP_Text_Diff_Renderer_Table` property magic methods is now deprecated. A descriptive deprecation notice is provided to alert developers to declare the property on the child class extending `WP_Text_Diff_Renderer_Table`.
Changes in this commit:
* Adds a deprecation notice to the `__get()`, `__set()`, `__isset()`, `__unset()` magic methods, i.e. to alert and inform developers when attempting to get/set/isset/unset a dynamic property.
* Fixes `__get()` to explicitly returns `null` when attempting to get a dynamic property.
* Fixes `__set()` by removing the value return after setting a declared property, as (a) unnecessary and (b) `__set()` should return `void` [https://www.php.net/manual/en/language.oop5.overloading.php#object.set per the PHP handbook].
* Fixes `__isset()` to return `false` if not in the `$compat_fields`, as `isset()` and `__isset()` should always return `bool`:
* [https://www.php.net/manual/en/language.oop5.overloading.php#object.isset `__isset()` in the PHP manual]
* [https://www.php.net/manual/en/function.isset.php `isset()` in the PHP manual]
* Adds a test class with happy and unhappy paths for these changes.
For backward compatibility, no changes are made to the internal declared properties listed in `$compat_fields` and accessed through the magic methods.
For example:
A child class uses a property named `$data` that is not declared as a property on the child class. When getting its value, e.g. `$user_query->data`, the `WP_Text_Diff_Renderer_Table::__get()` magic method is invoked, the following deprecation notice thrown, and `null` returned:
>The property `data` is not declared. Setting a dynamic property is deprecated since version 6.4.0! Instead, declare the property on the class.
=== Why not remove the magic methods, remove the `$compat_fields` property, and restore the properties `public`?
tl;dr Backward compatibility.
If a plugin adds a property to `$compat_fields` array, then sites using that plugin would experience (a) an `Undefined property` `Warning` (PHP 8) | `Notice` (PHP 7) and (b) a possible change in behavior.
=== Why not limit the deprecation for PHP versions >= 8.2?
tl;dr original design intent and inform
The magic methods and `$compat_fields` property were added for one purpose: to continue providing external access to internal properties declared on `WP_Text_Diff_Renderer_Table`. They were not intended to be used for dynamic properties.
Deprecating that unintended usage both alerts developers a change is needed in their child class and informs them what to change.
References:
* Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.
* A [https://www.youtube.com/live/vDZWepDQQVE?feature=share&t=10097 live open public working session] where these changes were discussed and agreed to.
* [https://wiki.php.net/rfc/deprecate_dynamic_properties PHP RFC: Deprecate dynamic properties.]
Follow-up to [28525], [31135].
Props antonvlasenko, rajinsharwar, jrf, markjaquith, hellofromTonya, SergeyBiryukov, desrosj, peterwilsoncc, audrasjb, costdev, oglekler, jeffpaul.
Fixes #58898.
See #56034.
Built from https://develop.svn.wordpress.org/trunk@56354
git-svn-id: http://core.svn.wordpress.org/trunk@55866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-08-03 14:13:24 -04:00
|
|
|
* @since 6.4.0 Getting a dynamic property is deprecated.
|
2016-08-25 13:37:30 -04:00
|
|
|
*
|
|
|
|
* @param string $name Property to get.
|
Code Modernization: Deprecate dynamic properties in WP_Text_Diff_Renderer_Table magic methods.
The unknown use of unknown dynamic property within the `WP_Text_Diff_Renderer_Table` property magic methods is now deprecated. A descriptive deprecation notice is provided to alert developers to declare the property on the child class extending `WP_Text_Diff_Renderer_Table`.
Changes in this commit:
* Adds a deprecation notice to the `__get()`, `__set()`, `__isset()`, `__unset()` magic methods, i.e. to alert and inform developers when attempting to get/set/isset/unset a dynamic property.
* Fixes `__get()` to explicitly returns `null` when attempting to get a dynamic property.
* Fixes `__set()` by removing the value return after setting a declared property, as (a) unnecessary and (b) `__set()` should return `void` [https://www.php.net/manual/en/language.oop5.overloading.php#object.set per the PHP handbook].
* Fixes `__isset()` to return `false` if not in the `$compat_fields`, as `isset()` and `__isset()` should always return `bool`:
* [https://www.php.net/manual/en/language.oop5.overloading.php#object.isset `__isset()` in the PHP manual]
* [https://www.php.net/manual/en/function.isset.php `isset()` in the PHP manual]
* Adds a test class with happy and unhappy paths for these changes.
For backward compatibility, no changes are made to the internal declared properties listed in `$compat_fields` and accessed through the magic methods.
For example:
A child class uses a property named `$data` that is not declared as a property on the child class. When getting its value, e.g. `$user_query->data`, the `WP_Text_Diff_Renderer_Table::__get()` magic method is invoked, the following deprecation notice thrown, and `null` returned:
>The property `data` is not declared. Setting a dynamic property is deprecated since version 6.4.0! Instead, declare the property on the class.
=== Why not remove the magic methods, remove the `$compat_fields` property, and restore the properties `public`?
tl;dr Backward compatibility.
If a plugin adds a property to `$compat_fields` array, then sites using that plugin would experience (a) an `Undefined property` `Warning` (PHP 8) | `Notice` (PHP 7) and (b) a possible change in behavior.
=== Why not limit the deprecation for PHP versions >= 8.2?
tl;dr original design intent and inform
The magic methods and `$compat_fields` property were added for one purpose: to continue providing external access to internal properties declared on `WP_Text_Diff_Renderer_Table`. They were not intended to be used for dynamic properties.
Deprecating that unintended usage both alerts developers a change is needed in their child class and informs them what to change.
References:
* Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.
* A [https://www.youtube.com/live/vDZWepDQQVE?feature=share&t=10097 live open public working session] where these changes were discussed and agreed to.
* [https://wiki.php.net/rfc/deprecate_dynamic_properties PHP RFC: Deprecate dynamic properties.]
Follow-up to [28525], [31135].
Props antonvlasenko, rajinsharwar, jrf, markjaquith, hellofromTonya, SergeyBiryukov, desrosj, peterwilsoncc, audrasjb, costdev, oglekler, jeffpaul.
Fixes #58898.
See #56034.
Built from https://develop.svn.wordpress.org/trunk@56354
git-svn-id: http://core.svn.wordpress.org/trunk@55866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-08-03 14:13:24 -04:00
|
|
|
* @return mixed A declared property's value, else null.
|
2016-08-25 13:37:30 -04:00
|
|
|
*/
|
|
|
|
public function __get( $name ) {
|
2020-04-04 23:02:11 -04:00
|
|
|
if ( in_array( $name, $this->compat_fields, true ) ) {
|
2016-08-25 13:37:30 -04:00
|
|
|
return $this->$name;
|
|
|
|
}
|
Code Modernization: Deprecate dynamic properties in WP_Text_Diff_Renderer_Table magic methods.
The unknown use of unknown dynamic property within the `WP_Text_Diff_Renderer_Table` property magic methods is now deprecated. A descriptive deprecation notice is provided to alert developers to declare the property on the child class extending `WP_Text_Diff_Renderer_Table`.
Changes in this commit:
* Adds a deprecation notice to the `__get()`, `__set()`, `__isset()`, `__unset()` magic methods, i.e. to alert and inform developers when attempting to get/set/isset/unset a dynamic property.
* Fixes `__get()` to explicitly returns `null` when attempting to get a dynamic property.
* Fixes `__set()` by removing the value return after setting a declared property, as (a) unnecessary and (b) `__set()` should return `void` [https://www.php.net/manual/en/language.oop5.overloading.php#object.set per the PHP handbook].
* Fixes `__isset()` to return `false` if not in the `$compat_fields`, as `isset()` and `__isset()` should always return `bool`:
* [https://www.php.net/manual/en/language.oop5.overloading.php#object.isset `__isset()` in the PHP manual]
* [https://www.php.net/manual/en/function.isset.php `isset()` in the PHP manual]
* Adds a test class with happy and unhappy paths for these changes.
For backward compatibility, no changes are made to the internal declared properties listed in `$compat_fields` and accessed through the magic methods.
For example:
A child class uses a property named `$data` that is not declared as a property on the child class. When getting its value, e.g. `$user_query->data`, the `WP_Text_Diff_Renderer_Table::__get()` magic method is invoked, the following deprecation notice thrown, and `null` returned:
>The property `data` is not declared. Setting a dynamic property is deprecated since version 6.4.0! Instead, declare the property on the class.
=== Why not remove the magic methods, remove the `$compat_fields` property, and restore the properties `public`?
tl;dr Backward compatibility.
If a plugin adds a property to `$compat_fields` array, then sites using that plugin would experience (a) an `Undefined property` `Warning` (PHP 8) | `Notice` (PHP 7) and (b) a possible change in behavior.
=== Why not limit the deprecation for PHP versions >= 8.2?
tl;dr original design intent and inform
The magic methods and `$compat_fields` property were added for one purpose: to continue providing external access to internal properties declared on `WP_Text_Diff_Renderer_Table`. They were not intended to be used for dynamic properties.
Deprecating that unintended usage both alerts developers a change is needed in their child class and informs them what to change.
References:
* Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.
* A [https://www.youtube.com/live/vDZWepDQQVE?feature=share&t=10097 live open public working session] where these changes were discussed and agreed to.
* [https://wiki.php.net/rfc/deprecate_dynamic_properties PHP RFC: Deprecate dynamic properties.]
Follow-up to [28525], [31135].
Props antonvlasenko, rajinsharwar, jrf, markjaquith, hellofromTonya, SergeyBiryukov, desrosj, peterwilsoncc, audrasjb, costdev, oglekler, jeffpaul.
Fixes #58898.
See #56034.
Built from https://develop.svn.wordpress.org/trunk@56354
git-svn-id: http://core.svn.wordpress.org/trunk@55866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-08-03 14:13:24 -04:00
|
|
|
|
2023-09-07 16:48:12 -04:00
|
|
|
wp_trigger_error(
|
|
|
|
__METHOD__,
|
Code Modernization: Deprecate dynamic properties in WP_Text_Diff_Renderer_Table magic methods.
The unknown use of unknown dynamic property within the `WP_Text_Diff_Renderer_Table` property magic methods is now deprecated. A descriptive deprecation notice is provided to alert developers to declare the property on the child class extending `WP_Text_Diff_Renderer_Table`.
Changes in this commit:
* Adds a deprecation notice to the `__get()`, `__set()`, `__isset()`, `__unset()` magic methods, i.e. to alert and inform developers when attempting to get/set/isset/unset a dynamic property.
* Fixes `__get()` to explicitly returns `null` when attempting to get a dynamic property.
* Fixes `__set()` by removing the value return after setting a declared property, as (a) unnecessary and (b) `__set()` should return `void` [https://www.php.net/manual/en/language.oop5.overloading.php#object.set per the PHP handbook].
* Fixes `__isset()` to return `false` if not in the `$compat_fields`, as `isset()` and `__isset()` should always return `bool`:
* [https://www.php.net/manual/en/language.oop5.overloading.php#object.isset `__isset()` in the PHP manual]
* [https://www.php.net/manual/en/function.isset.php `isset()` in the PHP manual]
* Adds a test class with happy and unhappy paths for these changes.
For backward compatibility, no changes are made to the internal declared properties listed in `$compat_fields` and accessed through the magic methods.
For example:
A child class uses a property named `$data` that is not declared as a property on the child class. When getting its value, e.g. `$user_query->data`, the `WP_Text_Diff_Renderer_Table::__get()` magic method is invoked, the following deprecation notice thrown, and `null` returned:
>The property `data` is not declared. Setting a dynamic property is deprecated since version 6.4.0! Instead, declare the property on the class.
=== Why not remove the magic methods, remove the `$compat_fields` property, and restore the properties `public`?
tl;dr Backward compatibility.
If a plugin adds a property to `$compat_fields` array, then sites using that plugin would experience (a) an `Undefined property` `Warning` (PHP 8) | `Notice` (PHP 7) and (b) a possible change in behavior.
=== Why not limit the deprecation for PHP versions >= 8.2?
tl;dr original design intent and inform
The magic methods and `$compat_fields` property were added for one purpose: to continue providing external access to internal properties declared on `WP_Text_Diff_Renderer_Table`. They were not intended to be used for dynamic properties.
Deprecating that unintended usage both alerts developers a change is needed in their child class and informs them what to change.
References:
* Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.
* A [https://www.youtube.com/live/vDZWepDQQVE?feature=share&t=10097 live open public working session] where these changes were discussed and agreed to.
* [https://wiki.php.net/rfc/deprecate_dynamic_properties PHP RFC: Deprecate dynamic properties.]
Follow-up to [28525], [31135].
Props antonvlasenko, rajinsharwar, jrf, markjaquith, hellofromTonya, SergeyBiryukov, desrosj, peterwilsoncc, audrasjb, costdev, oglekler, jeffpaul.
Fixes #58898.
See #56034.
Built from https://develop.svn.wordpress.org/trunk@56354
git-svn-id: http://core.svn.wordpress.org/trunk@55866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-08-03 14:13:24 -04:00
|
|
|
"The property `{$name}` is not declared. Getting a dynamic property is " .
|
|
|
|
'deprecated since version 6.4.0! Instead, declare the property on the class.',
|
|
|
|
E_USER_DEPRECATED
|
|
|
|
);
|
|
|
|
return null;
|
2016-08-25 13:37:30 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Make private properties settable for backward compatibility.
|
|
|
|
*
|
|
|
|
* @since 4.0.0
|
Code Modernization: Deprecate dynamic properties in WP_Text_Diff_Renderer_Table magic methods.
The unknown use of unknown dynamic property within the `WP_Text_Diff_Renderer_Table` property magic methods is now deprecated. A descriptive deprecation notice is provided to alert developers to declare the property on the child class extending `WP_Text_Diff_Renderer_Table`.
Changes in this commit:
* Adds a deprecation notice to the `__get()`, `__set()`, `__isset()`, `__unset()` magic methods, i.e. to alert and inform developers when attempting to get/set/isset/unset a dynamic property.
* Fixes `__get()` to explicitly returns `null` when attempting to get a dynamic property.
* Fixes `__set()` by removing the value return after setting a declared property, as (a) unnecessary and (b) `__set()` should return `void` [https://www.php.net/manual/en/language.oop5.overloading.php#object.set per the PHP handbook].
* Fixes `__isset()` to return `false` if not in the `$compat_fields`, as `isset()` and `__isset()` should always return `bool`:
* [https://www.php.net/manual/en/language.oop5.overloading.php#object.isset `__isset()` in the PHP manual]
* [https://www.php.net/manual/en/function.isset.php `isset()` in the PHP manual]
* Adds a test class with happy and unhappy paths for these changes.
For backward compatibility, no changes are made to the internal declared properties listed in `$compat_fields` and accessed through the magic methods.
For example:
A child class uses a property named `$data` that is not declared as a property on the child class. When getting its value, e.g. `$user_query->data`, the `WP_Text_Diff_Renderer_Table::__get()` magic method is invoked, the following deprecation notice thrown, and `null` returned:
>The property `data` is not declared. Setting a dynamic property is deprecated since version 6.4.0! Instead, declare the property on the class.
=== Why not remove the magic methods, remove the `$compat_fields` property, and restore the properties `public`?
tl;dr Backward compatibility.
If a plugin adds a property to `$compat_fields` array, then sites using that plugin would experience (a) an `Undefined property` `Warning` (PHP 8) | `Notice` (PHP 7) and (b) a possible change in behavior.
=== Why not limit the deprecation for PHP versions >= 8.2?
tl;dr original design intent and inform
The magic methods and `$compat_fields` property were added for one purpose: to continue providing external access to internal properties declared on `WP_Text_Diff_Renderer_Table`. They were not intended to be used for dynamic properties.
Deprecating that unintended usage both alerts developers a change is needed in their child class and informs them what to change.
References:
* Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.
* A [https://www.youtube.com/live/vDZWepDQQVE?feature=share&t=10097 live open public working session] where these changes were discussed and agreed to.
* [https://wiki.php.net/rfc/deprecate_dynamic_properties PHP RFC: Deprecate dynamic properties.]
Follow-up to [28525], [31135].
Props antonvlasenko, rajinsharwar, jrf, markjaquith, hellofromTonya, SergeyBiryukov, desrosj, peterwilsoncc, audrasjb, costdev, oglekler, jeffpaul.
Fixes #58898.
See #56034.
Built from https://develop.svn.wordpress.org/trunk@56354
git-svn-id: http://core.svn.wordpress.org/trunk@55866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-08-03 14:13:24 -04:00
|
|
|
* @since 6.4.0 Setting a dynamic property is deprecated.
|
2016-08-25 13:37:30 -04:00
|
|
|
*
|
|
|
|
* @param string $name Property to check if set.
|
|
|
|
* @param mixed $value Property value.
|
|
|
|
*/
|
|
|
|
public function __set( $name, $value ) {
|
2020-04-04 23:02:11 -04:00
|
|
|
if ( in_array( $name, $this->compat_fields, true ) ) {
|
Code Modernization: Deprecate dynamic properties in WP_Text_Diff_Renderer_Table magic methods.
The unknown use of unknown dynamic property within the `WP_Text_Diff_Renderer_Table` property magic methods is now deprecated. A descriptive deprecation notice is provided to alert developers to declare the property on the child class extending `WP_Text_Diff_Renderer_Table`.
Changes in this commit:
* Adds a deprecation notice to the `__get()`, `__set()`, `__isset()`, `__unset()` magic methods, i.e. to alert and inform developers when attempting to get/set/isset/unset a dynamic property.
* Fixes `__get()` to explicitly returns `null` when attempting to get a dynamic property.
* Fixes `__set()` by removing the value return after setting a declared property, as (a) unnecessary and (b) `__set()` should return `void` [https://www.php.net/manual/en/language.oop5.overloading.php#object.set per the PHP handbook].
* Fixes `__isset()` to return `false` if not in the `$compat_fields`, as `isset()` and `__isset()` should always return `bool`:
* [https://www.php.net/manual/en/language.oop5.overloading.php#object.isset `__isset()` in the PHP manual]
* [https://www.php.net/manual/en/function.isset.php `isset()` in the PHP manual]
* Adds a test class with happy and unhappy paths for these changes.
For backward compatibility, no changes are made to the internal declared properties listed in `$compat_fields` and accessed through the magic methods.
For example:
A child class uses a property named `$data` that is not declared as a property on the child class. When getting its value, e.g. `$user_query->data`, the `WP_Text_Diff_Renderer_Table::__get()` magic method is invoked, the following deprecation notice thrown, and `null` returned:
>The property `data` is not declared. Setting a dynamic property is deprecated since version 6.4.0! Instead, declare the property on the class.
=== Why not remove the magic methods, remove the `$compat_fields` property, and restore the properties `public`?
tl;dr Backward compatibility.
If a plugin adds a property to `$compat_fields` array, then sites using that plugin would experience (a) an `Undefined property` `Warning` (PHP 8) | `Notice` (PHP 7) and (b) a possible change in behavior.
=== Why not limit the deprecation for PHP versions >= 8.2?
tl;dr original design intent and inform
The magic methods and `$compat_fields` property were added for one purpose: to continue providing external access to internal properties declared on `WP_Text_Diff_Renderer_Table`. They were not intended to be used for dynamic properties.
Deprecating that unintended usage both alerts developers a change is needed in their child class and informs them what to change.
References:
* Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.
* A [https://www.youtube.com/live/vDZWepDQQVE?feature=share&t=10097 live open public working session] where these changes were discussed and agreed to.
* [https://wiki.php.net/rfc/deprecate_dynamic_properties PHP RFC: Deprecate dynamic properties.]
Follow-up to [28525], [31135].
Props antonvlasenko, rajinsharwar, jrf, markjaquith, hellofromTonya, SergeyBiryukov, desrosj, peterwilsoncc, audrasjb, costdev, oglekler, jeffpaul.
Fixes #58898.
See #56034.
Built from https://develop.svn.wordpress.org/trunk@56354
git-svn-id: http://core.svn.wordpress.org/trunk@55866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-08-03 14:13:24 -04:00
|
|
|
$this->$name = $value;
|
|
|
|
return;
|
2016-08-25 13:37:30 -04:00
|
|
|
}
|
Code Modernization: Deprecate dynamic properties in WP_Text_Diff_Renderer_Table magic methods.
The unknown use of unknown dynamic property within the `WP_Text_Diff_Renderer_Table` property magic methods is now deprecated. A descriptive deprecation notice is provided to alert developers to declare the property on the child class extending `WP_Text_Diff_Renderer_Table`.
Changes in this commit:
* Adds a deprecation notice to the `__get()`, `__set()`, `__isset()`, `__unset()` magic methods, i.e. to alert and inform developers when attempting to get/set/isset/unset a dynamic property.
* Fixes `__get()` to explicitly returns `null` when attempting to get a dynamic property.
* Fixes `__set()` by removing the value return after setting a declared property, as (a) unnecessary and (b) `__set()` should return `void` [https://www.php.net/manual/en/language.oop5.overloading.php#object.set per the PHP handbook].
* Fixes `__isset()` to return `false` if not in the `$compat_fields`, as `isset()` and `__isset()` should always return `bool`:
* [https://www.php.net/manual/en/language.oop5.overloading.php#object.isset `__isset()` in the PHP manual]
* [https://www.php.net/manual/en/function.isset.php `isset()` in the PHP manual]
* Adds a test class with happy and unhappy paths for these changes.
For backward compatibility, no changes are made to the internal declared properties listed in `$compat_fields` and accessed through the magic methods.
For example:
A child class uses a property named `$data` that is not declared as a property on the child class. When getting its value, e.g. `$user_query->data`, the `WP_Text_Diff_Renderer_Table::__get()` magic method is invoked, the following deprecation notice thrown, and `null` returned:
>The property `data` is not declared. Setting a dynamic property is deprecated since version 6.4.0! Instead, declare the property on the class.
=== Why not remove the magic methods, remove the `$compat_fields` property, and restore the properties `public`?
tl;dr Backward compatibility.
If a plugin adds a property to `$compat_fields` array, then sites using that plugin would experience (a) an `Undefined property` `Warning` (PHP 8) | `Notice` (PHP 7) and (b) a possible change in behavior.
=== Why not limit the deprecation for PHP versions >= 8.2?
tl;dr original design intent and inform
The magic methods and `$compat_fields` property were added for one purpose: to continue providing external access to internal properties declared on `WP_Text_Diff_Renderer_Table`. They were not intended to be used for dynamic properties.
Deprecating that unintended usage both alerts developers a change is needed in their child class and informs them what to change.
References:
* Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.
* A [https://www.youtube.com/live/vDZWepDQQVE?feature=share&t=10097 live open public working session] where these changes were discussed and agreed to.
* [https://wiki.php.net/rfc/deprecate_dynamic_properties PHP RFC: Deprecate dynamic properties.]
Follow-up to [28525], [31135].
Props antonvlasenko, rajinsharwar, jrf, markjaquith, hellofromTonya, SergeyBiryukov, desrosj, peterwilsoncc, audrasjb, costdev, oglekler, jeffpaul.
Fixes #58898.
See #56034.
Built from https://develop.svn.wordpress.org/trunk@56354
git-svn-id: http://core.svn.wordpress.org/trunk@55866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-08-03 14:13:24 -04:00
|
|
|
|
2023-09-07 16:48:12 -04:00
|
|
|
wp_trigger_error(
|
|
|
|
__METHOD__,
|
Code Modernization: Deprecate dynamic properties in WP_Text_Diff_Renderer_Table magic methods.
The unknown use of unknown dynamic property within the `WP_Text_Diff_Renderer_Table` property magic methods is now deprecated. A descriptive deprecation notice is provided to alert developers to declare the property on the child class extending `WP_Text_Diff_Renderer_Table`.
Changes in this commit:
* Adds a deprecation notice to the `__get()`, `__set()`, `__isset()`, `__unset()` magic methods, i.e. to alert and inform developers when attempting to get/set/isset/unset a dynamic property.
* Fixes `__get()` to explicitly returns `null` when attempting to get a dynamic property.
* Fixes `__set()` by removing the value return after setting a declared property, as (a) unnecessary and (b) `__set()` should return `void` [https://www.php.net/manual/en/language.oop5.overloading.php#object.set per the PHP handbook].
* Fixes `__isset()` to return `false` if not in the `$compat_fields`, as `isset()` and `__isset()` should always return `bool`:
* [https://www.php.net/manual/en/language.oop5.overloading.php#object.isset `__isset()` in the PHP manual]
* [https://www.php.net/manual/en/function.isset.php `isset()` in the PHP manual]
* Adds a test class with happy and unhappy paths for these changes.
For backward compatibility, no changes are made to the internal declared properties listed in `$compat_fields` and accessed through the magic methods.
For example:
A child class uses a property named `$data` that is not declared as a property on the child class. When getting its value, e.g. `$user_query->data`, the `WP_Text_Diff_Renderer_Table::__get()` magic method is invoked, the following deprecation notice thrown, and `null` returned:
>The property `data` is not declared. Setting a dynamic property is deprecated since version 6.4.0! Instead, declare the property on the class.
=== Why not remove the magic methods, remove the `$compat_fields` property, and restore the properties `public`?
tl;dr Backward compatibility.
If a plugin adds a property to `$compat_fields` array, then sites using that plugin would experience (a) an `Undefined property` `Warning` (PHP 8) | `Notice` (PHP 7) and (b) a possible change in behavior.
=== Why not limit the deprecation for PHP versions >= 8.2?
tl;dr original design intent and inform
The magic methods and `$compat_fields` property were added for one purpose: to continue providing external access to internal properties declared on `WP_Text_Diff_Renderer_Table`. They were not intended to be used for dynamic properties.
Deprecating that unintended usage both alerts developers a change is needed in their child class and informs them what to change.
References:
* Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.
* A [https://www.youtube.com/live/vDZWepDQQVE?feature=share&t=10097 live open public working session] where these changes were discussed and agreed to.
* [https://wiki.php.net/rfc/deprecate_dynamic_properties PHP RFC: Deprecate dynamic properties.]
Follow-up to [28525], [31135].
Props antonvlasenko, rajinsharwar, jrf, markjaquith, hellofromTonya, SergeyBiryukov, desrosj, peterwilsoncc, audrasjb, costdev, oglekler, jeffpaul.
Fixes #58898.
See #56034.
Built from https://develop.svn.wordpress.org/trunk@56354
git-svn-id: http://core.svn.wordpress.org/trunk@55866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-08-03 14:13:24 -04:00
|
|
|
"The property `{$name}` is not declared. Setting a dynamic property is " .
|
|
|
|
'deprecated since version 6.4.0! Instead, declare the property on the class.',
|
|
|
|
E_USER_DEPRECATED
|
|
|
|
);
|
2016-08-25 13:37:30 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Make private properties checkable for backward compatibility.
|
|
|
|
*
|
|
|
|
* @since 4.0.0
|
Code Modernization: Deprecate dynamic properties in WP_Text_Diff_Renderer_Table magic methods.
The unknown use of unknown dynamic property within the `WP_Text_Diff_Renderer_Table` property magic methods is now deprecated. A descriptive deprecation notice is provided to alert developers to declare the property on the child class extending `WP_Text_Diff_Renderer_Table`.
Changes in this commit:
* Adds a deprecation notice to the `__get()`, `__set()`, `__isset()`, `__unset()` magic methods, i.e. to alert and inform developers when attempting to get/set/isset/unset a dynamic property.
* Fixes `__get()` to explicitly returns `null` when attempting to get a dynamic property.
* Fixes `__set()` by removing the value return after setting a declared property, as (a) unnecessary and (b) `__set()` should return `void` [https://www.php.net/manual/en/language.oop5.overloading.php#object.set per the PHP handbook].
* Fixes `__isset()` to return `false` if not in the `$compat_fields`, as `isset()` and `__isset()` should always return `bool`:
* [https://www.php.net/manual/en/language.oop5.overloading.php#object.isset `__isset()` in the PHP manual]
* [https://www.php.net/manual/en/function.isset.php `isset()` in the PHP manual]
* Adds a test class with happy and unhappy paths for these changes.
For backward compatibility, no changes are made to the internal declared properties listed in `$compat_fields` and accessed through the magic methods.
For example:
A child class uses a property named `$data` that is not declared as a property on the child class. When getting its value, e.g. `$user_query->data`, the `WP_Text_Diff_Renderer_Table::__get()` magic method is invoked, the following deprecation notice thrown, and `null` returned:
>The property `data` is not declared. Setting a dynamic property is deprecated since version 6.4.0! Instead, declare the property on the class.
=== Why not remove the magic methods, remove the `$compat_fields` property, and restore the properties `public`?
tl;dr Backward compatibility.
If a plugin adds a property to `$compat_fields` array, then sites using that plugin would experience (a) an `Undefined property` `Warning` (PHP 8) | `Notice` (PHP 7) and (b) a possible change in behavior.
=== Why not limit the deprecation for PHP versions >= 8.2?
tl;dr original design intent and inform
The magic methods and `$compat_fields` property were added for one purpose: to continue providing external access to internal properties declared on `WP_Text_Diff_Renderer_Table`. They were not intended to be used for dynamic properties.
Deprecating that unintended usage both alerts developers a change is needed in their child class and informs them what to change.
References:
* Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.
* A [https://www.youtube.com/live/vDZWepDQQVE?feature=share&t=10097 live open public working session] where these changes were discussed and agreed to.
* [https://wiki.php.net/rfc/deprecate_dynamic_properties PHP RFC: Deprecate dynamic properties.]
Follow-up to [28525], [31135].
Props antonvlasenko, rajinsharwar, jrf, markjaquith, hellofromTonya, SergeyBiryukov, desrosj, peterwilsoncc, audrasjb, costdev, oglekler, jeffpaul.
Fixes #58898.
See #56034.
Built from https://develop.svn.wordpress.org/trunk@56354
git-svn-id: http://core.svn.wordpress.org/trunk@55866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-08-03 14:13:24 -04:00
|
|
|
* @since 6.4.0 Checking a dynamic property is deprecated.
|
2016-08-25 13:37:30 -04:00
|
|
|
*
|
|
|
|
* @param string $name Property to check if set.
|
|
|
|
* @return bool Whether the property is set.
|
|
|
|
*/
|
|
|
|
public function __isset( $name ) {
|
2020-04-04 23:02:11 -04:00
|
|
|
if ( in_array( $name, $this->compat_fields, true ) ) {
|
2016-08-25 13:37:30 -04:00
|
|
|
return isset( $this->$name );
|
|
|
|
}
|
Code Modernization: Deprecate dynamic properties in WP_Text_Diff_Renderer_Table magic methods.
The unknown use of unknown dynamic property within the `WP_Text_Diff_Renderer_Table` property magic methods is now deprecated. A descriptive deprecation notice is provided to alert developers to declare the property on the child class extending `WP_Text_Diff_Renderer_Table`.
Changes in this commit:
* Adds a deprecation notice to the `__get()`, `__set()`, `__isset()`, `__unset()` magic methods, i.e. to alert and inform developers when attempting to get/set/isset/unset a dynamic property.
* Fixes `__get()` to explicitly returns `null` when attempting to get a dynamic property.
* Fixes `__set()` by removing the value return after setting a declared property, as (a) unnecessary and (b) `__set()` should return `void` [https://www.php.net/manual/en/language.oop5.overloading.php#object.set per the PHP handbook].
* Fixes `__isset()` to return `false` if not in the `$compat_fields`, as `isset()` and `__isset()` should always return `bool`:
* [https://www.php.net/manual/en/language.oop5.overloading.php#object.isset `__isset()` in the PHP manual]
* [https://www.php.net/manual/en/function.isset.php `isset()` in the PHP manual]
* Adds a test class with happy and unhappy paths for these changes.
For backward compatibility, no changes are made to the internal declared properties listed in `$compat_fields` and accessed through the magic methods.
For example:
A child class uses a property named `$data` that is not declared as a property on the child class. When getting its value, e.g. `$user_query->data`, the `WP_Text_Diff_Renderer_Table::__get()` magic method is invoked, the following deprecation notice thrown, and `null` returned:
>The property `data` is not declared. Setting a dynamic property is deprecated since version 6.4.0! Instead, declare the property on the class.
=== Why not remove the magic methods, remove the `$compat_fields` property, and restore the properties `public`?
tl;dr Backward compatibility.
If a plugin adds a property to `$compat_fields` array, then sites using that plugin would experience (a) an `Undefined property` `Warning` (PHP 8) | `Notice` (PHP 7) and (b) a possible change in behavior.
=== Why not limit the deprecation for PHP versions >= 8.2?
tl;dr original design intent and inform
The magic methods and `$compat_fields` property were added for one purpose: to continue providing external access to internal properties declared on `WP_Text_Diff_Renderer_Table`. They were not intended to be used for dynamic properties.
Deprecating that unintended usage both alerts developers a change is needed in their child class and informs them what to change.
References:
* Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.
* A [https://www.youtube.com/live/vDZWepDQQVE?feature=share&t=10097 live open public working session] where these changes were discussed and agreed to.
* [https://wiki.php.net/rfc/deprecate_dynamic_properties PHP RFC: Deprecate dynamic properties.]
Follow-up to [28525], [31135].
Props antonvlasenko, rajinsharwar, jrf, markjaquith, hellofromTonya, SergeyBiryukov, desrosj, peterwilsoncc, audrasjb, costdev, oglekler, jeffpaul.
Fixes #58898.
See #56034.
Built from https://develop.svn.wordpress.org/trunk@56354
git-svn-id: http://core.svn.wordpress.org/trunk@55866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-08-03 14:13:24 -04:00
|
|
|
|
2023-09-07 16:48:12 -04:00
|
|
|
wp_trigger_error(
|
|
|
|
__METHOD__,
|
Code Modernization: Deprecate dynamic properties in WP_Text_Diff_Renderer_Table magic methods.
The unknown use of unknown dynamic property within the `WP_Text_Diff_Renderer_Table` property magic methods is now deprecated. A descriptive deprecation notice is provided to alert developers to declare the property on the child class extending `WP_Text_Diff_Renderer_Table`.
Changes in this commit:
* Adds a deprecation notice to the `__get()`, `__set()`, `__isset()`, `__unset()` magic methods, i.e. to alert and inform developers when attempting to get/set/isset/unset a dynamic property.
* Fixes `__get()` to explicitly returns `null` when attempting to get a dynamic property.
* Fixes `__set()` by removing the value return after setting a declared property, as (a) unnecessary and (b) `__set()` should return `void` [https://www.php.net/manual/en/language.oop5.overloading.php#object.set per the PHP handbook].
* Fixes `__isset()` to return `false` if not in the `$compat_fields`, as `isset()` and `__isset()` should always return `bool`:
* [https://www.php.net/manual/en/language.oop5.overloading.php#object.isset `__isset()` in the PHP manual]
* [https://www.php.net/manual/en/function.isset.php `isset()` in the PHP manual]
* Adds a test class with happy and unhappy paths for these changes.
For backward compatibility, no changes are made to the internal declared properties listed in `$compat_fields` and accessed through the magic methods.
For example:
A child class uses a property named `$data` that is not declared as a property on the child class. When getting its value, e.g. `$user_query->data`, the `WP_Text_Diff_Renderer_Table::__get()` magic method is invoked, the following deprecation notice thrown, and `null` returned:
>The property `data` is not declared. Setting a dynamic property is deprecated since version 6.4.0! Instead, declare the property on the class.
=== Why not remove the magic methods, remove the `$compat_fields` property, and restore the properties `public`?
tl;dr Backward compatibility.
If a plugin adds a property to `$compat_fields` array, then sites using that plugin would experience (a) an `Undefined property` `Warning` (PHP 8) | `Notice` (PHP 7) and (b) a possible change in behavior.
=== Why not limit the deprecation for PHP versions >= 8.2?
tl;dr original design intent and inform
The magic methods and `$compat_fields` property were added for one purpose: to continue providing external access to internal properties declared on `WP_Text_Diff_Renderer_Table`. They were not intended to be used for dynamic properties.
Deprecating that unintended usage both alerts developers a change is needed in their child class and informs them what to change.
References:
* Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.
* A [https://www.youtube.com/live/vDZWepDQQVE?feature=share&t=10097 live open public working session] where these changes were discussed and agreed to.
* [https://wiki.php.net/rfc/deprecate_dynamic_properties PHP RFC: Deprecate dynamic properties.]
Follow-up to [28525], [31135].
Props antonvlasenko, rajinsharwar, jrf, markjaquith, hellofromTonya, SergeyBiryukov, desrosj, peterwilsoncc, audrasjb, costdev, oglekler, jeffpaul.
Fixes #58898.
See #56034.
Built from https://develop.svn.wordpress.org/trunk@56354
git-svn-id: http://core.svn.wordpress.org/trunk@55866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-08-03 14:13:24 -04:00
|
|
|
"The property `{$name}` is not declared. Checking `isset()` on a dynamic property " .
|
|
|
|
'is deprecated since version 6.4.0! Instead, declare the property on the class.',
|
|
|
|
E_USER_DEPRECATED
|
|
|
|
);
|
|
|
|
return false;
|
2016-08-25 13:37:30 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Make private properties un-settable for backward compatibility.
|
|
|
|
*
|
|
|
|
* @since 4.0.0
|
Code Modernization: Deprecate dynamic properties in WP_Text_Diff_Renderer_Table magic methods.
The unknown use of unknown dynamic property within the `WP_Text_Diff_Renderer_Table` property magic methods is now deprecated. A descriptive deprecation notice is provided to alert developers to declare the property on the child class extending `WP_Text_Diff_Renderer_Table`.
Changes in this commit:
* Adds a deprecation notice to the `__get()`, `__set()`, `__isset()`, `__unset()` magic methods, i.e. to alert and inform developers when attempting to get/set/isset/unset a dynamic property.
* Fixes `__get()` to explicitly returns `null` when attempting to get a dynamic property.
* Fixes `__set()` by removing the value return after setting a declared property, as (a) unnecessary and (b) `__set()` should return `void` [https://www.php.net/manual/en/language.oop5.overloading.php#object.set per the PHP handbook].
* Fixes `__isset()` to return `false` if not in the `$compat_fields`, as `isset()` and `__isset()` should always return `bool`:
* [https://www.php.net/manual/en/language.oop5.overloading.php#object.isset `__isset()` in the PHP manual]
* [https://www.php.net/manual/en/function.isset.php `isset()` in the PHP manual]
* Adds a test class with happy and unhappy paths for these changes.
For backward compatibility, no changes are made to the internal declared properties listed in `$compat_fields` and accessed through the magic methods.
For example:
A child class uses a property named `$data` that is not declared as a property on the child class. When getting its value, e.g. `$user_query->data`, the `WP_Text_Diff_Renderer_Table::__get()` magic method is invoked, the following deprecation notice thrown, and `null` returned:
>The property `data` is not declared. Setting a dynamic property is deprecated since version 6.4.0! Instead, declare the property on the class.
=== Why not remove the magic methods, remove the `$compat_fields` property, and restore the properties `public`?
tl;dr Backward compatibility.
If a plugin adds a property to `$compat_fields` array, then sites using that plugin would experience (a) an `Undefined property` `Warning` (PHP 8) | `Notice` (PHP 7) and (b) a possible change in behavior.
=== Why not limit the deprecation for PHP versions >= 8.2?
tl;dr original design intent and inform
The magic methods and `$compat_fields` property were added for one purpose: to continue providing external access to internal properties declared on `WP_Text_Diff_Renderer_Table`. They were not intended to be used for dynamic properties.
Deprecating that unintended usage both alerts developers a change is needed in their child class and informs them what to change.
References:
* Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.
* A [https://www.youtube.com/live/vDZWepDQQVE?feature=share&t=10097 live open public working session] where these changes were discussed and agreed to.
* [https://wiki.php.net/rfc/deprecate_dynamic_properties PHP RFC: Deprecate dynamic properties.]
Follow-up to [28525], [31135].
Props antonvlasenko, rajinsharwar, jrf, markjaquith, hellofromTonya, SergeyBiryukov, desrosj, peterwilsoncc, audrasjb, costdev, oglekler, jeffpaul.
Fixes #58898.
See #56034.
Built from https://develop.svn.wordpress.org/trunk@56354
git-svn-id: http://core.svn.wordpress.org/trunk@55866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-08-03 14:13:24 -04:00
|
|
|
* @since 6.4.0 Unsetting a dynamic property is deprecated.
|
2016-08-25 13:37:30 -04:00
|
|
|
*
|
|
|
|
* @param string $name Property to unset.
|
|
|
|
*/
|
|
|
|
public function __unset( $name ) {
|
2020-04-04 23:02:11 -04:00
|
|
|
if ( in_array( $name, $this->compat_fields, true ) ) {
|
2016-08-25 13:37:30 -04:00
|
|
|
unset( $this->$name );
|
Code Modernization: Deprecate dynamic properties in WP_Text_Diff_Renderer_Table magic methods.
The unknown use of unknown dynamic property within the `WP_Text_Diff_Renderer_Table` property magic methods is now deprecated. A descriptive deprecation notice is provided to alert developers to declare the property on the child class extending `WP_Text_Diff_Renderer_Table`.
Changes in this commit:
* Adds a deprecation notice to the `__get()`, `__set()`, `__isset()`, `__unset()` magic methods, i.e. to alert and inform developers when attempting to get/set/isset/unset a dynamic property.
* Fixes `__get()` to explicitly returns `null` when attempting to get a dynamic property.
* Fixes `__set()` by removing the value return after setting a declared property, as (a) unnecessary and (b) `__set()` should return `void` [https://www.php.net/manual/en/language.oop5.overloading.php#object.set per the PHP handbook].
* Fixes `__isset()` to return `false` if not in the `$compat_fields`, as `isset()` and `__isset()` should always return `bool`:
* [https://www.php.net/manual/en/language.oop5.overloading.php#object.isset `__isset()` in the PHP manual]
* [https://www.php.net/manual/en/function.isset.php `isset()` in the PHP manual]
* Adds a test class with happy and unhappy paths for these changes.
For backward compatibility, no changes are made to the internal declared properties listed in `$compat_fields` and accessed through the magic methods.
For example:
A child class uses a property named `$data` that is not declared as a property on the child class. When getting its value, e.g. `$user_query->data`, the `WP_Text_Diff_Renderer_Table::__get()` magic method is invoked, the following deprecation notice thrown, and `null` returned:
>The property `data` is not declared. Setting a dynamic property is deprecated since version 6.4.0! Instead, declare the property on the class.
=== Why not remove the magic methods, remove the `$compat_fields` property, and restore the properties `public`?
tl;dr Backward compatibility.
If a plugin adds a property to `$compat_fields` array, then sites using that plugin would experience (a) an `Undefined property` `Warning` (PHP 8) | `Notice` (PHP 7) and (b) a possible change in behavior.
=== Why not limit the deprecation for PHP versions >= 8.2?
tl;dr original design intent and inform
The magic methods and `$compat_fields` property were added for one purpose: to continue providing external access to internal properties declared on `WP_Text_Diff_Renderer_Table`. They were not intended to be used for dynamic properties.
Deprecating that unintended usage both alerts developers a change is needed in their child class and informs them what to change.
References:
* Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.
* A [https://www.youtube.com/live/vDZWepDQQVE?feature=share&t=10097 live open public working session] where these changes were discussed and agreed to.
* [https://wiki.php.net/rfc/deprecate_dynamic_properties PHP RFC: Deprecate dynamic properties.]
Follow-up to [28525], [31135].
Props antonvlasenko, rajinsharwar, jrf, markjaquith, hellofromTonya, SergeyBiryukov, desrosj, peterwilsoncc, audrasjb, costdev, oglekler, jeffpaul.
Fixes #58898.
See #56034.
Built from https://develop.svn.wordpress.org/trunk@56354
git-svn-id: http://core.svn.wordpress.org/trunk@55866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-08-03 14:13:24 -04:00
|
|
|
return;
|
2016-08-25 13:37:30 -04:00
|
|
|
}
|
Code Modernization: Deprecate dynamic properties in WP_Text_Diff_Renderer_Table magic methods.
The unknown use of unknown dynamic property within the `WP_Text_Diff_Renderer_Table` property magic methods is now deprecated. A descriptive deprecation notice is provided to alert developers to declare the property on the child class extending `WP_Text_Diff_Renderer_Table`.
Changes in this commit:
* Adds a deprecation notice to the `__get()`, `__set()`, `__isset()`, `__unset()` magic methods, i.e. to alert and inform developers when attempting to get/set/isset/unset a dynamic property.
* Fixes `__get()` to explicitly returns `null` when attempting to get a dynamic property.
* Fixes `__set()` by removing the value return after setting a declared property, as (a) unnecessary and (b) `__set()` should return `void` [https://www.php.net/manual/en/language.oop5.overloading.php#object.set per the PHP handbook].
* Fixes `__isset()` to return `false` if not in the `$compat_fields`, as `isset()` and `__isset()` should always return `bool`:
* [https://www.php.net/manual/en/language.oop5.overloading.php#object.isset `__isset()` in the PHP manual]
* [https://www.php.net/manual/en/function.isset.php `isset()` in the PHP manual]
* Adds a test class with happy and unhappy paths for these changes.
For backward compatibility, no changes are made to the internal declared properties listed in `$compat_fields` and accessed through the magic methods.
For example:
A child class uses a property named `$data` that is not declared as a property on the child class. When getting its value, e.g. `$user_query->data`, the `WP_Text_Diff_Renderer_Table::__get()` magic method is invoked, the following deprecation notice thrown, and `null` returned:
>The property `data` is not declared. Setting a dynamic property is deprecated since version 6.4.0! Instead, declare the property on the class.
=== Why not remove the magic methods, remove the `$compat_fields` property, and restore the properties `public`?
tl;dr Backward compatibility.
If a plugin adds a property to `$compat_fields` array, then sites using that plugin would experience (a) an `Undefined property` `Warning` (PHP 8) | `Notice` (PHP 7) and (b) a possible change in behavior.
=== Why not limit the deprecation for PHP versions >= 8.2?
tl;dr original design intent and inform
The magic methods and `$compat_fields` property were added for one purpose: to continue providing external access to internal properties declared on `WP_Text_Diff_Renderer_Table`. They were not intended to be used for dynamic properties.
Deprecating that unintended usage both alerts developers a change is needed in their child class and informs them what to change.
References:
* Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.
* A [https://www.youtube.com/live/vDZWepDQQVE?feature=share&t=10097 live open public working session] where these changes were discussed and agreed to.
* [https://wiki.php.net/rfc/deprecate_dynamic_properties PHP RFC: Deprecate dynamic properties.]
Follow-up to [28525], [31135].
Props antonvlasenko, rajinsharwar, jrf, markjaquith, hellofromTonya, SergeyBiryukov, desrosj, peterwilsoncc, audrasjb, costdev, oglekler, jeffpaul.
Fixes #58898.
See #56034.
Built from https://develop.svn.wordpress.org/trunk@56354
git-svn-id: http://core.svn.wordpress.org/trunk@55866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-08-03 14:13:24 -04:00
|
|
|
|
2023-09-07 16:48:12 -04:00
|
|
|
wp_trigger_error(
|
|
|
|
__METHOD__,
|
Code Modernization: Deprecate dynamic properties in WP_Text_Diff_Renderer_Table magic methods.
The unknown use of unknown dynamic property within the `WP_Text_Diff_Renderer_Table` property magic methods is now deprecated. A descriptive deprecation notice is provided to alert developers to declare the property on the child class extending `WP_Text_Diff_Renderer_Table`.
Changes in this commit:
* Adds a deprecation notice to the `__get()`, `__set()`, `__isset()`, `__unset()` magic methods, i.e. to alert and inform developers when attempting to get/set/isset/unset a dynamic property.
* Fixes `__get()` to explicitly returns `null` when attempting to get a dynamic property.
* Fixes `__set()` by removing the value return after setting a declared property, as (a) unnecessary and (b) `__set()` should return `void` [https://www.php.net/manual/en/language.oop5.overloading.php#object.set per the PHP handbook].
* Fixes `__isset()` to return `false` if not in the `$compat_fields`, as `isset()` and `__isset()` should always return `bool`:
* [https://www.php.net/manual/en/language.oop5.overloading.php#object.isset `__isset()` in the PHP manual]
* [https://www.php.net/manual/en/function.isset.php `isset()` in the PHP manual]
* Adds a test class with happy and unhappy paths for these changes.
For backward compatibility, no changes are made to the internal declared properties listed in `$compat_fields` and accessed through the magic methods.
For example:
A child class uses a property named `$data` that is not declared as a property on the child class. When getting its value, e.g. `$user_query->data`, the `WP_Text_Diff_Renderer_Table::__get()` magic method is invoked, the following deprecation notice thrown, and `null` returned:
>The property `data` is not declared. Setting a dynamic property is deprecated since version 6.4.0! Instead, declare the property on the class.
=== Why not remove the magic methods, remove the `$compat_fields` property, and restore the properties `public`?
tl;dr Backward compatibility.
If a plugin adds a property to `$compat_fields` array, then sites using that plugin would experience (a) an `Undefined property` `Warning` (PHP 8) | `Notice` (PHP 7) and (b) a possible change in behavior.
=== Why not limit the deprecation for PHP versions >= 8.2?
tl;dr original design intent and inform
The magic methods and `$compat_fields` property were added for one purpose: to continue providing external access to internal properties declared on `WP_Text_Diff_Renderer_Table`. They were not intended to be used for dynamic properties.
Deprecating that unintended usage both alerts developers a change is needed in their child class and informs them what to change.
References:
* Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.
* A [https://www.youtube.com/live/vDZWepDQQVE?feature=share&t=10097 live open public working session] where these changes were discussed and agreed to.
* [https://wiki.php.net/rfc/deprecate_dynamic_properties PHP RFC: Deprecate dynamic properties.]
Follow-up to [28525], [31135].
Props antonvlasenko, rajinsharwar, jrf, markjaquith, hellofromTonya, SergeyBiryukov, desrosj, peterwilsoncc, audrasjb, costdev, oglekler, jeffpaul.
Fixes #58898.
See #56034.
Built from https://develop.svn.wordpress.org/trunk@56354
git-svn-id: http://core.svn.wordpress.org/trunk@55866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-08-03 14:13:24 -04:00
|
|
|
"A property `{$name}` is not declared. Unsetting a dynamic property is " .
|
|
|
|
'deprecated since version 6.4.0! Instead, declare the property on the class.',
|
|
|
|
E_USER_DEPRECATED
|
|
|
|
);
|
2016-08-25 13:37:30 -04:00
|
|
|
}
|
|
|
|
}
|