From 05486cce3da71fd09f9b356728a67c0fca06aeb3 Mon Sep 17 00:00:00 2001 From: markjaquith Date: Sat, 10 Mar 2007 06:18:43 +0000 Subject: [PATCH] user_trailingslashit filter for users who sometimes want trailing slashes only on certain URL types. fixes #3899 git-svn-id: http://svn.automattic.com/wordpress/trunk@5019 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-includes/category-template.php | 2 +- wp-includes/comment-template.php | 2 +- wp-includes/feed.php | 4 ++-- wp-includes/link-template.php | 31 +++++++++++++++++++------------ wp-includes/post-template.php | 6 +++--- 5 files changed, 26 insertions(+), 19 deletions(-) diff --git a/wp-includes/category-template.php b/wp-includes/category-template.php index a65dae3033..2e61e3e392 100644 --- a/wp-includes/category-template.php +++ b/wp-includes/category-template.php @@ -35,7 +35,7 @@ function get_category_link($category_id) { $category_nicename = get_category_parents($parent, false, '/', true) . $category_nicename; $catlink = str_replace('%category%', $category_nicename, $catlink); - $catlink = get_option('home') . user_trailingslashit($catlink); + $catlink = get_option('home') . user_trailingslashit($catlink, 'category'); } return apply_filters('category_link', $catlink, $category_id); } diff --git a/wp-includes/comment-template.php b/wp-includes/comment-template.php index ea3ce15893..ba7c0cbebf 100644 --- a/wp-includes/comment-template.php +++ b/wp-includes/comment-template.php @@ -226,7 +226,7 @@ function get_trackback_url() { $tb_url = get_option('siteurl') . '/wp-trackback.php?p=' . $id; if ( '' != get_option('permalink_structure') ) - $tb_url = trailingslashit(get_permalink()) . user_trailingslashit('trackback'); + $tb_url = trailingslashit(get_permalink()) . user_trailingslashit('trackback', 'single_trackback'); return $tb_url; } diff --git a/wp-includes/feed.php b/wp-includes/feed.php index 2259498d23..da4e8fb759 100644 --- a/wp-includes/feed.php +++ b/wp-includes/feed.php @@ -113,7 +113,7 @@ function get_author_rss_link($echo = false, $author_id, $author_nicename) { $link = get_option('home') . '?feed=rss2&author=' . $author_id; } else { $link = get_author_posts_url($author_id, $author_nicename); - $link = $link . user_trailingslashit('feed'); + $link = $link . user_trailingslashit('feed', 'feed'); } $link = apply_filters('author_feed_link', $link); @@ -131,7 +131,7 @@ function get_category_rss_link($echo = false, $cat_ID, $category_nicename) { $link = get_option('home') . '?feed=rss2&cat=' . $cat_ID; } else { $link = get_category_link($cat_ID); - $link = $link . user_trailingslashit('feed/'); + $link = $link . user_trailingslashit('feed', 'feed'); } $link = apply_filters('category_feed_link', $link); diff --git a/wp-includes/link-template.php b/wp-includes/link-template.php index 65a502a9dc..1d15e0dd50 100644 --- a/wp-includes/link-template.php +++ b/wp-includes/link-template.php @@ -16,14 +16,19 @@ function permalink_link() { // For backwards compatibility * has a trailing slash, strips the trailing slash if not * @global object Uses $wp_rewrite * @param $string string a URL with or without a trailing slash + * @param $type_of_url string the type of URL being considered (e.g. single, category, etc) for use in the filter * @return string */ -function user_trailingslashit($string) { +function user_trailingslashit($string, $type_of_url = '') { global $wp_rewrite; if ( $wp_rewrite->use_trailing_slashes ) $string = trailingslashit($string); else - $string = preg_replace('|/$|', '', $string); // untrailing slash + $string = preg_replace('|/+$|', '', $string); // untrailing slash + + // Note that $type_of_url can be one of following: + // single, single_trackback, single_feed, single_paged, feed, category, page, year, month, day, paged + $string = apply_filters('user_trailingslashit', $string, $type_of_url); return $string; } @@ -94,7 +99,9 @@ function get_permalink($id = 0) { $author, $post->post_name, ); - return apply_filters('post_link', get_option('home') . str_replace($rewritecode, $rewritereplace, $permalink), $post); + $permalink = get_option('home') . str_replace($rewritecode, $rewritereplace, $permalink); + $permalink = user_trailingslashit($permalink, 'single'); + return apply_filters('post_link', $permalink, $post); } else { // if they're not using the fancy permalink option $permalink = get_option('home') . '/?p=' . $post->ID; return apply_filters('post_link', $permalink, $post); @@ -134,7 +141,7 @@ function _get_page_link( $id = false ) { $link = get_page_uri($id); $link = str_replace('%pagename%', $link, $pagestruct); $link = get_option('home') . "/$link"; - $link = user_trailingslashit($link); + $link = user_trailingslashit($link, 'page'); } else { $link = get_option('home') . "/?page_id=$id"; } @@ -176,7 +183,7 @@ function get_year_link($year) { $yearlink = $wp_rewrite->get_year_permastruct(); if ( !empty($yearlink) ) { $yearlink = str_replace('%year%', $year, $yearlink); - return apply_filters('year_link', get_option('home') . user_trailingslashit($yearlink), $year); + return apply_filters('year_link', get_option('home') . user_trailingslashit($yearlink, 'year'), $year); } else { return apply_filters('year_link', get_option('home') . '/?m=' . $year, $year); } @@ -192,7 +199,7 @@ function get_month_link($year, $month) { if ( !empty($monthlink) ) { $monthlink = str_replace('%year%', $year, $monthlink); $monthlink = str_replace('%monthnum%', zeroise(intval($month), 2), $monthlink); - return apply_filters('month_link', get_option('home') . user_trailingslashit($monthlink), $year, $month); + return apply_filters('month_link', get_option('home') . user_trailingslashit($monthlink, 'month'), $year, $month); } else { return apply_filters('month_link', get_option('home') . '/?m=' . $year . zeroise($month, 2), $year, $month); } @@ -212,7 +219,7 @@ function get_day_link($year, $month, $day) { $daylink = str_replace('%year%', $year, $daylink); $daylink = str_replace('%monthnum%', zeroise(intval($month), 2), $daylink); $daylink = str_replace('%day%', zeroise(intval($day), 2), $daylink); - return apply_filters('day_link', get_option('home') . user_trailingslashit($daylink), $year, $month, $day); + return apply_filters('day_link', get_option('home') . user_trailingslashit($daylink, 'day'), $year, $month, $day); } else { return apply_filters('day_link', get_option('home') . '/?m=' . $year . zeroise($month, 2) . zeroise($day, 2), $year, $month, $day); } @@ -236,7 +243,7 @@ function get_feed_link($feed='rss2') { $permalink = str_replace('%feed%', $feed, $permalink); $permalink = preg_replace('#/+#', '/', "/$permalink"); - $output = get_option('home') . user_trailingslashit($permalink); + $output = get_option('home') . user_trailingslashit($permalink, 'feed'); } else { if ( false !== strpos($feed, 'comments_') ) $feed = str_replace('comments_', 'comments-', $feed); @@ -257,7 +264,7 @@ function get_post_comments_feed_link($post_id = '', $feed = 'rss2') { $url = trailingslashit( get_permalink() ) . 'feed'; if ( 'rss2' != $feed ) $url .= "/$feed"; - $url = user_trailingslashit($url); + $url = user_trailingslashit($url, 'single_feed'); } else { $url = get_option('home') . "/?feed=$feed&p=$id"; } @@ -471,13 +478,13 @@ function get_pagenum_link($pagenum = 1) { $qstr = preg_replace('|^/+|', '', $qstr); if ( $permalink ) - $qstr = user_trailingslashit($qstr); + $qstr = user_trailingslashit($qstr, 'paged'); $qstr = preg_replace('/&([^#])(?![a-z]{1,8};)/', '&$1', trailingslashit( get_option('home') ) . $qstr ); // showing /page/1/ or ?paged=1 is redundant if ( 1 === $pagenum ) { - $qstr = str_replace(user_trailingslashit('index.php/page/1'), '', $qstr); // for PATHINFO style - $qstr = str_replace(user_trailingslashit('page/1'), '', $qstr); // for mod_rewrite style + $qstr = str_replace(user_trailingslashit('index.php/page/1', 'paged'), '', $qstr); // for PATHINFO style + $qstr = str_replace(user_trailingslashit('page/1', 'paged'), '', $qstr); // for mod_rewrite style $qstr = remove_query_arg('paged', $qstr); // for query style } return $qstr; diff --git a/wp-includes/post-template.php b/wp-includes/post-template.php index f1d468bacd..3b1ca3550d 100644 --- a/wp-includes/post-template.php +++ b/wp-includes/post-template.php @@ -161,7 +161,7 @@ function wp_link_pages($args = '') { if ( '' == get_option('permalink_structure') ) $output .= ''; else - $output .= ''; + $output .= ''; } } $output .= $j; @@ -180,7 +180,7 @@ function wp_link_pages($args = '') { if ( '' == get_option('permalink_structure') ) $output .= '' . $previouspagelink . ''; else - $output .= '' . $previouspagelink . ''; + $output .= '' . $previouspagelink . ''; } } $i = $page + 1; @@ -191,7 +191,7 @@ function wp_link_pages($args = '') { if ( '' == get_option('permalink_structure') ) $output .= '' . $nextpagelink . ''; else - $output .= '' . $nextpagelink . ''; + $output .= '' . $nextpagelink . ''; } } $output .= $after;