Menus: Revert unintentional changes in [56449].

Accidentally committed two simultaneous patches; reverting unintended list table changes.

Unprops joedolson.
See #56594.
Built from https://develop.svn.wordpress.org/trunk@56450


git-svn-id: http://core.svn.wordpress.org/trunk@55962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
joedolson 2023-08-24 16:14:18 +00:00
parent ad66de2933
commit 0bce794a37
18 changed files with 37 additions and 37 deletions

View File

@ -571,7 +571,7 @@ th.sorted.desc:hover .sorting-indicator.asc:before {
position: relative; position: relative;
} }
.check-column label { .check-column .label-covers-full-cell {
width: 100%; width: 100%;
height: 100%; height: 100%;
display: block; display: block;
@ -580,12 +580,12 @@ th.sorted.desc:hover .sorting-indicator.asc:before {
right: 0; right: 0;
} }
.check-column input { .check-column .label-covers-full-cell + input {
position: relative; position: relative;
z-index: 1; z-index: 1;
} }
.check-column:hover input { .check-column .label-covers-full-cell:hover + input {
box-shadow: 0 0 0 1px #2271b1; box-shadow: 0 0 0 1px #2271b1;
} }

File diff suppressed because one or more lines are too long

View File

@ -570,7 +570,7 @@ th.sorted.desc:hover .sorting-indicator.asc:before {
position: relative; position: relative;
} }
.check-column label { .check-column .label-covers-full-cell {
width: 100%; width: 100%;
height: 100%; height: 100%;
display: block; display: block;
@ -579,12 +579,12 @@ th.sorted.desc:hover .sorting-indicator.asc:before {
left: 0; left: 0;
} }
.check-column input { .check-column .label-covers-full-cell + input {
position: relative; position: relative;
z-index: 1; z-index: 1;
} }
.check-column:hover input { .check-column .label-covers-full-cell:hover + input {
box-shadow: 0 0 0 1px #2271b1; box-shadow: 0 0 0 1px #2271b1;
} }

File diff suppressed because one or more lines are too long

View File

@ -895,8 +895,7 @@ class WP_Comments_List_Table extends WP_List_Table {
if ( $this->user_can ) { if ( $this->user_can ) {
?> ?>
<input id="cb-select-<?php echo $comment->comment_ID; ?>" type="checkbox" name="delete_comments[]" value="<?php echo $comment->comment_ID; ?>" /> <label class="label-covers-full-cell" for="cb-select-<?php echo $comment->comment_ID; ?>">
<label for="cb-select-<?php echo $comment->comment_ID; ?>">
<span class="screen-reader-text"> <span class="screen-reader-text">
<?php <?php
/* translators: Hidden accessibility text. */ /* translators: Hidden accessibility text. */
@ -904,6 +903,7 @@ class WP_Comments_List_Table extends WP_List_Table {
?> ?>
</span> </span>
</label> </label>
<input id="cb-select-<?php echo $comment->comment_ID; ?>" type="checkbox" name="delete_comments[]" value="<?php echo $comment->comment_ID; ?>" />
<?php <?php
} }
} }

View File

@ -174,8 +174,7 @@ class WP_Links_List_Table extends WP_List_Table {
$link = $item; $link = $item;
?> ?>
<input type="checkbox" name="linkcheck[]" id="cb-select-<?php echo $link->link_id; ?>" value="<?php echo esc_attr( $link->link_id ); ?>" /> <label class="label-covers-full-cell" for="cb-select-<?php echo $link->link_id; ?>">
<label for="cb-select-<?php echo $link->link_id; ?>">
<span class="screen-reader-text"> <span class="screen-reader-text">
<?php <?php
/* translators: Hidden accessibility text. %s: Link name. */ /* translators: Hidden accessibility text. %s: Link name. */
@ -183,6 +182,7 @@ class WP_Links_List_Table extends WP_List_Table {
?> ?>
</span> </span>
</label> </label>
<input type="checkbox" name="linkcheck[]" id="cb-select-<?php echo $link->link_id; ?>" value="<?php echo esc_attr( $link->link_id ); ?>" />
<?php <?php
} }

View File

@ -1399,13 +1399,13 @@ class WP_List_Table {
if ( ! empty( $columns['cb'] ) ) { if ( ! empty( $columns['cb'] ) ) {
static $cb_counter = 1; static $cb_counter = 1;
$columns['cb'] = '<input id="cb-select-all-' . $cb_counter . '" type="checkbox" /> $columns['cb'] = '<label class="label-covers-full-cell" for="cb-select-all-' . $cb_counter . '">' .
<label for="cb-select-all-' . $cb_counter . '">' .
'<span class="screen-reader-text">' . '<span class="screen-reader-text">' .
/* translators: Hidden accessibility text. */ /* translators: Hidden accessibility text. */
__( 'Select All' ) . __( 'Select All' ) .
'</span>' . '</span>' .
'</label>'; '</label>' .
'<input id="cb-select-all-' . $cb_counter . '" type="checkbox" />';
$cb_counter++; $cb_counter++;
} }

View File

@ -419,8 +419,7 @@ class WP_Media_List_Table extends WP_List_Table {
if ( current_user_can( 'edit_post', $post->ID ) ) { if ( current_user_can( 'edit_post', $post->ID ) ) {
?> ?>
<input type="checkbox" name="media[]" id="cb-select-<?php echo $post->ID; ?>" value="<?php echo $post->ID; ?>" /> <label class="label-covers-full-cell" for="cb-select-<?php echo $post->ID; ?>">
<label for="cb-select-<?php echo $post->ID; ?>">
<span class="screen-reader-text"> <span class="screen-reader-text">
<?php <?php
/* translators: Hidden accessibility text. %s: Attachment title. */ /* translators: Hidden accessibility text. %s: Attachment title. */
@ -428,6 +427,7 @@ class WP_Media_List_Table extends WP_List_Table {
?> ?>
</span> </span>
</label> </label>
<input type="checkbox" name="media[]" id="cb-select-<?php echo $post->ID; ?>" value="<?php echo $post->ID; ?>" />
<?php <?php
} }
} }

View File

@ -420,9 +420,7 @@ class WP_MS_Sites_List_Table extends WP_List_Table {
if ( ! is_main_site( $blog['blog_id'] ) ) : if ( ! is_main_site( $blog['blog_id'] ) ) :
$blogname = untrailingslashit( $blog['domain'] . $blog['path'] ); $blogname = untrailingslashit( $blog['domain'] . $blog['path'] );
?> ?>
<input type="checkbox" id="blog_<?php echo $blog['blog_id']; ?>" name="allblogs[]" <label class="label-covers-full-cell" for="blog_<?php echo $blog['blog_id']; ?>">
value="<?php echo esc_attr( $blog['blog_id'] ); ?>" />
<label for="blog_<?php echo $blog['blog_id']; ?>">
<span class="screen-reader-text"> <span class="screen-reader-text">
<?php <?php
/* translators: %s: Site URL. */ /* translators: %s: Site URL. */
@ -430,6 +428,8 @@ class WP_MS_Sites_List_Table extends WP_List_Table {
?> ?>
</span> </span>
</label> </label>
<input type="checkbox" id="blog_<?php echo $blog['blog_id']; ?>" name="allblogs[]"
value="<?php echo esc_attr( $blog['blog_id'] ); ?>" />
<?php <?php
endif; endif;
} }

View File

@ -512,8 +512,7 @@ class WP_MS_Themes_List_Table extends WP_List_Table {
$theme = $item; $theme = $item;
$checkbox_id = 'checkbox_' . md5( $theme->get( 'Name' ) ); $checkbox_id = 'checkbox_' . md5( $theme->get( 'Name' ) );
?> ?>
<input type="checkbox" name="checked[]" value="<?php echo esc_attr( $theme->get_stylesheet() ); ?>" id="<?php echo $checkbox_id; ?>" /> <label class="label-covers-full-cell" for="<?php echo $checkbox_id; ?>" >
<label for="<?php echo $checkbox_id; ?>" >
<span class="screen-reader-text"> <span class="screen-reader-text">
<?php <?php
printf( printf(
@ -524,6 +523,7 @@ class WP_MS_Themes_List_Table extends WP_List_Table {
?> ?>
</span> </span>
</label> </label>
<input type="checkbox" name="checked[]" value="<?php echo esc_attr( $theme->get_stylesheet() ); ?>" id="<?php echo $checkbox_id; ?>" />
<?php <?php
} }

View File

@ -235,8 +235,7 @@ class WP_MS_Users_List_Table extends WP_List_Table {
return; return;
} }
?> ?>
<input type="checkbox" id="blog_<?php echo $user->ID; ?>" name="allusers[]" value="<?php echo esc_attr( $user->ID ); ?>" /> <label class="label-covers-full-cell" for="blog_<?php echo $user->ID; ?>">
<label for="blog_<?php echo $user->ID; ?>">
<span class="screen-reader-text"> <span class="screen-reader-text">
<?php <?php
/* translators: Hidden accessibility text. %s: User login. */ /* translators: Hidden accessibility text. %s: User login. */
@ -244,6 +243,7 @@ class WP_MS_Users_List_Table extends WP_List_Table {
?> ?>
</span> </span>
</label> </label>
<input type="checkbox" id="blog_<?php echo $user->ID; ?>" name="allusers[]" value="<?php echo esc_attr( $user->ID ); ?>" />
<?php <?php
} }

View File

@ -993,8 +993,8 @@ class WP_Plugins_List_Table extends WP_List_Table {
$checkbox = ''; $checkbox = '';
} else { } else {
$checkbox = sprintf( $checkbox = sprintf(
'<input type="checkbox" name="checked[]" value="%3$s" id="%1$s" />' . '<label class="label-covers-full-cell" for="%1$s"><span class="screen-reader-text">%2$s</span></label>' .
'<label for="%1$s"><span class="screen-reader-text">%2$s</span></label>', '<input type="checkbox" name="checked[]" value="%3$s" id="%1$s" />',
$checkbox_id, $checkbox_id,
/* translators: Hidden accessibility text. %s: Plugin name. */ /* translators: Hidden accessibility text. %s: Plugin name. */
sprintf( __( 'Select %s' ), $plugin_data['Name'] ), sprintf( __( 'Select %s' ), $plugin_data['Name'] ),

View File

@ -1033,8 +1033,7 @@ class WP_Posts_List_Table extends WP_List_Table {
*/ */
if ( apply_filters( 'wp_list_table_show_post_checkbox', $show, $post ) ) : if ( apply_filters( 'wp_list_table_show_post_checkbox', $show, $post ) ) :
?> ?>
<input id="cb-select-<?php the_ID(); ?>" type="checkbox" name="post[]" value="<?php the_ID(); ?>" /> <label class="label-covers-full-cell" for="cb-select-<?php the_ID(); ?>">
<label for="cb-select-<?php the_ID(); ?>">
<span class="screen-reader-text"> <span class="screen-reader-text">
<?php <?php
/* translators: %s: Post title. */ /* translators: %s: Post title. */
@ -1042,6 +1041,7 @@ class WP_Posts_List_Table extends WP_List_Table {
?> ?>
</span> </span>
</label> </label>
<input id="cb-select-<?php the_ID(); ?>" type="checkbox" name="post[]" value="<?php the_ID(); ?>" />
<div class="locked-indicator"> <div class="locked-indicator">
<span class="locked-indicator-icon" aria-hidden="true"></span> <span class="locked-indicator-icon" aria-hidden="true"></span>
<span class="screen-reader-text"> <span class="screen-reader-text">

View File

@ -416,8 +416,8 @@ abstract class WP_Privacy_Requests_Table extends WP_List_Table {
*/ */
public function column_cb( $item ) { public function column_cb( $item ) {
return sprintf( return sprintf(
'<input type="checkbox" name="request_id[]" id="requester_%1$s" value="%1$s" /><span class="spinner"></span>' . '<label class="label-covers-full-cell" for="requester_%1$s"><span class="screen-reader-text">%2$s</span></label>' .
'<label for="requester_%1$s"><span class="screen-reader-text">%2$s</span></label>', '<input type="checkbox" name="request_id[]" id="requester_%1$s" value="%1$s" /><span class="spinner"></span>',
esc_attr( $item->ID ), esc_attr( $item->ID ),
/* translators: Hidden accessibility text. %s: Email address. */ /* translators: Hidden accessibility text. %s: Email address. */
sprintf( __( 'Select %s' ), $item->email ) sprintf( __( 'Select %s' ), $item->email )

View File

@ -365,8 +365,8 @@ class WP_Terms_List_Table extends WP_List_Table {
if ( current_user_can( 'delete_term', $tag->term_id ) ) { if ( current_user_can( 'delete_term', $tag->term_id ) ) {
return sprintf( return sprintf(
'<input type="checkbox" name="delete_tags[]" value="%1$s" id="cb-select-%1$s" />' . '<label class="label-covers-full-cell" for="cb-select-%1$s"><span class="screen-reader-text">%2$s</span></label>' .
'<label for="cb-select-%1$s"><span class="screen-reader-text">%2$s</span></label>', '<input type="checkbox" name="delete_tags[]" value="%1$s" id="cb-select-%1$s" />',
$tag->term_id, $tag->term_id,
/* translators: Hidden accessibility text. %s: Taxonomy term name. */ /* translators: Hidden accessibility text. %s: Taxonomy term name. */
sprintf( __( 'Select %s' ), $tag->name ) sprintf( __( 'Select %s' ), $tag->name )

View File

@ -524,8 +524,8 @@ class WP_Users_List_Table extends WP_List_Table {
// Set up the checkbox (because the user is editable, otherwise it's empty). // Set up the checkbox (because the user is editable, otherwise it's empty).
$checkbox = sprintf( $checkbox = sprintf(
'<input type="checkbox" name="users[]" id="user_%1$s" class="%3$s" value="%1$s" />' . '<label class="label-covers-full-cell" for="user_%1$s"><span class="screen-reader-text">%2$s</span></label>' .
'<label for="user_%1$s"><span class="screen-reader-text">%2$s</span></label>', '<input type="checkbox" name="users[]" id="user_%1$s" class="%3$s" value="%1$s" />',
$user_object->ID, $user_object->ID,
/* translators: Hidden accessibility text. %s: User login. */ /* translators: Hidden accessibility text. %s: User login. */
sprintf( __( 'Select %s' ), $user_object->user_login ), sprintf( __( 'Select %s' ), $user_object->user_login ),

View File

@ -571,7 +571,7 @@ function list_plugin_updates() {
<tr> <tr>
<td class="check-column"> <td class="check-column">
<?php if ( $compatible_php ) : ?> <?php if ( $compatible_php ) : ?>
<label for="<?php echo $checkbox_id; ?>"> <label for="<?php echo $checkbox_id; ?>" class="label-covers-full-cell">
<span class="screen-reader-text"> <span class="screen-reader-text">
<?php <?php
/* translators: Hidden accessibility text. %s: Plugin name. */ /* translators: Hidden accessibility text. %s: Plugin name. */
@ -749,7 +749,7 @@ function list_theme_updates() {
<tr> <tr>
<td class="check-column"> <td class="check-column">
<?php if ( $compatible_wp && $compatible_php ) : ?> <?php if ( $compatible_wp && $compatible_php ) : ?>
<label for="<?php echo $checkbox_id; ?>"> <label for="<?php echo $checkbox_id; ?>" class="label-covers-full-cell">
<span class="screen-reader-text"> <span class="screen-reader-text">
<?php <?php
/* translators: Hidden accessibility text. %s: Theme name. */ /* translators: Hidden accessibility text. %s: Theme name. */

View File

@ -16,7 +16,7 @@
* *
* @global string $wp_version * @global string $wp_version
*/ */
$wp_version = '6.4-alpha-56449'; $wp_version = '6.4-alpha-56450';
/** /**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema. * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.