From 1a20e9cc6ae3ed36b98d36b70ea38a85cd8c0eb5 Mon Sep 17 00:00:00 2001
From: Sergey Biryukov <sergeybiryukov.ru@gmail.com>
Date: Thu, 9 May 2024 15:16:14 +0000
Subject: [PATCH] Coding Standards: Use strict comparison in
 `wp-includes/nav-menu-template.php`.

Includes correcting a conditional in `_wp_menu_item_classes_by_context()` where `$parent_item->object`, which contains a string like `page`, was erroneously compared to the queried object's ID. The correct property to compare is `$parent_item->object_id`.

Follow-up to [14876], [14923], [14942], [15302], [16731], [16742], [22302], [47550], [47557], [47808].

Props aristath, poena, afercia, SergeyBiryukov.
See #60700.
Built from https://develop.svn.wordpress.org/trunk@58124


git-svn-id: http://core.svn.wordpress.org/trunk@57589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
---
 wp-includes/nav-menu-template.php | 16 ++++++++--------
 wp-includes/version.php           |  2 +-
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/wp-includes/nav-menu-template.php b/wp-includes/nav-menu-template.php
index 19eb75a97b..860efa92d3 100644
--- a/wp-includes/nav-menu-template.php
+++ b/wp-includes/nav-menu-template.php
@@ -418,14 +418,14 @@ function _wp_menu_item_classes_by_context( &$menu_items ) {
 
 			// If the menu item corresponds to the currently queried post or taxonomy object.
 		} elseif (
-			$menu_item->object_id == $queried_object_id
+			(int) $menu_item->object_id === $queried_object_id
 			&& (
 				( ! empty( $home_page_id ) && 'post_type' === $menu_item->type
-					&& $wp_query->is_home && $home_page_id == $menu_item->object_id )
+					&& $wp_query->is_home && $home_page_id === (int) $menu_item->object_id )
 				|| ( 'post_type' === $menu_item->type && $wp_query->is_singular )
 				|| ( 'taxonomy' === $menu_item->type
 					&& ( $wp_query->is_category || $wp_query->is_tag || $wp_query->is_tax )
-					&& $queried_object->taxonomy == $menu_item->object )
+					&& $queried_object->taxonomy === $menu_item->object )
 			)
 		) {
 			$classes[]                   = 'current-menu-item';
@@ -512,18 +512,18 @@ function _wp_menu_item_classes_by_context( &$menu_items ) {
 				$active_object              = $menu_item->object;
 
 				// Give front page item the 'current-menu-item' class when extra query arguments are involved.
-			} elseif ( $item_url == $front_page_url && is_front_page() ) {
+			} elseif ( $item_url === $front_page_url && is_front_page() ) {
 				$classes[] = 'current-menu-item';
 			}
 
-			if ( untrailingslashit( $item_url ) == home_url() ) {
+			if ( untrailingslashit( $item_url ) === home_url() ) {
 				$classes[] = 'menu-item-home';
 			}
 		}
 
 		// Back-compat with wp_page_menu(): add "current_page_parent" to static home page link for any non-page query.
 		if ( ! empty( $home_page_id ) && 'post_type' === $menu_item->type
-			&& empty( $wp_query->is_page ) && $home_page_id == $menu_item->object_id
+			&& empty( $wp_query->is_page ) && $home_page_id === (int) $menu_item->object_id
 		) {
 			$classes[] = 'current_page_parent';
 		}
@@ -549,7 +549,7 @@ function _wp_menu_item_classes_by_context( &$menu_items ) {
 					&& ! empty( $queried_object->post_type )
 					&& is_post_type_hierarchical( $queried_object->post_type )
 					&& in_array( (int) $parent_item->object_id, $queried_object->ancestors, true )
-					&& $parent_item->object != $queried_object->ID
+					&& (int) $parent_item->object_id !== $queried_object->ID
 				) ||
 
 				// Ancestral term.
@@ -559,7 +559,7 @@ function _wp_menu_item_classes_by_context( &$menu_items ) {
 					&& in_array( (int) $parent_item->object_id, $possible_taxonomy_ancestors[ $parent_item->object ], true )
 					&& (
 						! isset( $queried_object->term_id ) ||
-						$parent_item->object_id != $queried_object->term_id
+						(int) $parent_item->object_id !== $queried_object->term_id
 					)
 				)
 			)
diff --git a/wp-includes/version.php b/wp-includes/version.php
index 638c33e2f2..31e6a28e7d 100644
--- a/wp-includes/version.php
+++ b/wp-includes/version.php
@@ -16,7 +16,7 @@
  *
  * @global string $wp_version
  */
-$wp_version = '6.6-alpha-58123';
+$wp_version = '6.6-alpha-58124';
 
 /**
  * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.