From 1c73f953c3e977ac6907070dc08553150364ba25 Mon Sep 17 00:00:00 2001 From: hellofromTonya Date: Mon, 1 Nov 2021 22:24:00 +0000 Subject: [PATCH] Build/Test Tools: Ignore "null to nullable" deprecations for select tests. Adds an expectation for PHP 8.1 "passing null to non-nullable" deprecation notice to select tests where the deprecation is generated by one of the functions in the `wp-includes/formatting.php` file, either via a filter hook callback or by a direct call. Instead of haphazardly fixing these issues exposed by the tests, a more structural and all-encompassing solution for input validation should be architected and implemented as otherwise, we'll keep running into similar issues time and again with each new PHP version. To discourage people from "fixing" these issues now anyway, this commit "hides" nearly all of these issues from the test runs. Once a more structural solution is designed, these tests and the underlying functions causing the deprecation notices should be revisited and the structural solution put in place. Includes a few minor other tweaks to select tests: * Removing a stray `return` (twice) from assertion statements. * Removing calls to `ob_*()` functions in favour of letting PHPUnit manage the output catching. This prevents warnings along the lines of `Test code or tested code did not (only) close its own output buffers`. Props jrf, hellofromTonya. See #53635. Built from https://develop.svn.wordpress.org/trunk@51968 git-svn-id: http://core.svn.wordpress.org/trunk@51557 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-includes/version.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wp-includes/version.php b/wp-includes/version.php index 48b763e5ae..ec9a63a412 100644 --- a/wp-includes/version.php +++ b/wp-includes/version.php @@ -16,7 +16,7 @@ * * @global string $wp_version */ -$wp_version = '5.9-alpha-51967'; +$wp_version = '5.9-alpha-51968'; /** * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.