From 2542aabe507b42b486e4a00d9190f9d6d8cfca44 Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Mon, 27 Nov 2023 09:17:21 +0000 Subject: [PATCH] Coding Standards: Reorder conditionals in `is_random_header_image()`. This aims to slightly improve performance by checking the faster `empty()` language construct first and potentially avoiding an unnecessary function call. Additionally, this better matches a similar conditional a few lines below. Follow-up to [17757], [17770]. Props Cybr. See #59650. Built from https://develop.svn.wordpress.org/trunk@57139 git-svn-id: http://core.svn.wordpress.org/trunk@56650 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-includes/theme.php | 6 ++++-- wp-includes/version.php | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/wp-includes/theme.php b/wp-includes/theme.php index 89fccddd37..f063bc97a0 100644 --- a/wp-includes/theme.php +++ b/wp-includes/theme.php @@ -1437,14 +1437,16 @@ function is_random_header_image( $type = 'any' ) { if ( 'any' === $type ) { if ( 'random-default-image' === $header_image_mod || 'random-uploaded-image' === $header_image_mod - || ( '' !== get_random_header_image() && empty( $header_image_mod ) ) + || ( empty( $header_image_mod ) && '' !== get_random_header_image() ) ) { return true; } } else { if ( "random-$type-image" === $header_image_mod ) { return true; - } elseif ( 'default' === $type && empty( $header_image_mod ) && '' !== get_random_header_image() ) { + } elseif ( 'default' === $type + && empty( $header_image_mod ) && '' !== get_random_header_image() + ) { return true; } } diff --git a/wp-includes/version.php b/wp-includes/version.php index c82620f436..6c9840fc71 100644 --- a/wp-includes/version.php +++ b/wp-includes/version.php @@ -16,7 +16,7 @@ * * @global string $wp_version */ -$wp_version = '6.5-alpha-57138'; +$wp_version = '6.5-alpha-57139'; /** * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.