From 2940a03ae5b622db5fda6c1e4349acee8a7ea633 Mon Sep 17 00:00:00 2001 From: Mark Jaquith Date: Thu, 11 Jul 2013 18:43:12 +0000 Subject: [PATCH] Revisions: Use jQuery animation. The CSS3 animations caused issues because the element was still there, and there is no standard way to know when a CSS3 animation is done. See #24425. git-svn-id: http://core.svn.wordpress.org/trunk@24660 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-admin/css/wp-admin.css | 8 -------- wp-admin/js/revisions.js | 8 +++----- 2 files changed, 3 insertions(+), 13 deletions(-) diff --git a/wp-admin/css/wp-admin.css b/wp-admin/css/wp-admin.css index 074b1ce087..d9aa74f2cb 100644 --- a/wp-admin/css/wp-admin.css +++ b/wp-admin/css/wp-admin.css @@ -3666,14 +3666,6 @@ table.diff .diff-addedline ins { padding: 4px; } -.revisions-tooltip.fade { - -webkit-transition: opacity 200ms; - -ms-transition: opacity 200ms; - -moz-transition: opacity 200ms; - -o-transition: opacity 200ms; - transition: opacity 200ms; -} - .comparing-two-revisions .revisions-tooltip { bottom: 145px; } diff --git a/wp-admin/js/revisions.js b/wp-admin/js/revisions.js index 512553ec62..e4f4535455 100644 --- a/wp-admin/js/revisions.js +++ b/wp-admin/js/revisions.js @@ -619,13 +619,11 @@ window.wp = window.wp || {}; toggleVisibility: function( options ) { options = options || {}; - var visible = this.visible() + var visible = this.visible(); if ( visible ) { // Immediate show - // this.$el.removeClass('fade'); - this.$el.css( 'opacity', 1 ); + this.$el.fadeIn( 200 ); } else if ( options.immediate ) { // Immediate fade out - this.$el.addClass('fade'); - this.$el.css( 'opacity', 0 ); + this.$el.fadeOut( 200 ); } else { // Wait a bit, make sure we're really done, then fade it out _.delay( function( view ) { if ( ! view.visible() )