RTL: Fix modal alignments.

* Prevent horizontal scrollbars in Chrome.
* URL fields should be always LTR.
* Force the plugin details to be LTR for all screens, see #19778.

fixes #29352.
Built from https://develop.svn.wordpress.org/trunk@29623


git-svn-id: http://core.svn.wordpress.org/trunk@29397 1a063a9b-81f0-0310-95a4-ce76da25c4cd

wp-admin/css/common-rtl.css

@@ -2137,6 +2137,7 @@ div.action-links {
 	font-size: 22px;
 	font-weight: 600;
 	line-height: 56px;
+	position: relative;
 	top: 0;
 	left: 0;
 	right: 0;
@@ -2377,10 +2378,16 @@ div.action-links {
 	background: #f3f3f3;
 }
 
+/* @noflip */
+#plugin-information .section {
+	direction: ltr;
+}
+
+/* @noflip */
 #plugin-information .section ul,
 #plugin-information .section ol {
 	list-style-type: disc;
-	margin-right: 24px;
+	margin-left: 24px;
 }
 
 #plugin-information .section,
@@ -2404,9 +2411,10 @@ div.action-links {
 	box-shadow: 0 1px 2px rgba( 0, 0, 0, 0.3 );
 }
 
+/* @noflip */
 #plugin-information #section-screenshots li p {
 	font-style: italic;
-	padding-right: 20px;
+	padding-left: 20px;
 }
 
 #plugin-information pre {
@@ -2415,9 +2423,10 @@ div.action-links {
 	border: 1px solid #ccc;
 }
 
+/* @noflip */
 #plugin-information .review {
 	width: 100%;
-	float: right;
+	float: left;
 	margin-bottom: 20px;
 	border-bottom: 1px solid #e6e6e6;
 }
@@ -2427,11 +2436,11 @@ div.action-links {
 	width: 100%;
 	clear: both;
 }
-
+/* @noflip */
 #plugin-information .review-title-section h4 {
 	display: inline-block;
-	float: right;
-	margin: 0 0 0 6px;
+	float: left;
+	margin: 0 6px 0 0;
 }
 
 #plugin-information .reviewer-info p {
@@ -2442,22 +2451,26 @@ div.action-links {
 	padding-top: 2px;
 }
 
+/* @noflip */
 #plugin-information .reviewer-info .avatar {
-	float: right;
-	margin: 4px 0 0 6px;
+	float: left;
+	margin: 4px 6px 0 0;
 }
 
-#plugin-information .star-rating {
-	float: right;
+/* @noflip */
+#plugin-information .reviewer-info .star-rating {
+	float: left;
 }
 
+/* @noflip */
 #plugin-information .review-meta {
-	float: right;
-	margin-right: 0.75em;
+	float: left;
+	margin-left: 0.75em;
 }
 
+/* @noflip */
 #plugin-information .review-body {
-	float: right;
+	float: left;
 	width: 100%;
 }
 
@@ -2568,6 +2581,7 @@ body.import-php .tb-close-icon,
 body.plugins-php .tb-close-icon,
 body.update-core-php .tb-close-icon,
 body.index-php .tb-close-icon {
+	right: auto;
 	left: -30px;
 	color: #eee;
 	-webkit-transition: color .1s ease-in-out, background .1s ease-in-out;

wp-admin/css/common.css

@@ -2137,6 +2137,7 @@ div.action-links {
 	font-size: 22px;
 	font-weight: 600;
 	line-height: 56px;
+	position: relative;
 	top: 0;
 	right: 0;
 	left: 0;
@@ -2377,6 +2378,12 @@ div.action-links {
 	background: #f3f3f3;
 }
 
+/* @noflip */
+#plugin-information .section {
+	direction: ltr;
+}
+
+/* @noflip */
 #plugin-information .section ul,
 #plugin-information .section ol {
 	list-style-type: disc;
@@ -2404,6 +2411,7 @@ div.action-links {
 	box-shadow: 0 1px 2px rgba( 0, 0, 0, 0.3 );
 }
 
+/* @noflip */
 #plugin-information #section-screenshots li p {
 	font-style: italic;
 	padding-left: 20px;
@@ -2415,6 +2423,7 @@ div.action-links {
 	border: 1px solid #ccc;
 }
 
+/* @noflip */
 #plugin-information .review {
 	width: 100%;
 	float: left;
@@ -2427,7 +2436,7 @@ div.action-links {
 	width: 100%;
 	clear: both;
 }
-
+/* @noflip */
 #plugin-information .review-title-section h4 {
 	display: inline-block;
 	float: left;
@@ -2442,20 +2451,24 @@ div.action-links {
 	padding-top: 2px;
 }
 
+/* @noflip */
 #plugin-information .reviewer-info .avatar {
 	float: left;
 	margin: 4px 6px 0 0;
 }
 
-#plugin-information .star-rating {
+/* @noflip */
+#plugin-information .reviewer-info .star-rating {
 	float: left;
 }
 
+/* @noflip */
 #plugin-information .review-meta {
 	float: left;
 	margin-left: 0.75em;
 }
 
+/* @noflip */
 #plugin-information .review-body {
 	float: left;
 	width: 100%;
@@ -2568,6 +2581,7 @@ body.import-php .tb-close-icon,
 body.plugins-php .tb-close-icon,
 body.update-core-php .tb-close-icon,
 body.index-php .tb-close-icon {
+	left: auto;
 	right: -30px;
 	color: #eee;
 	-webkit-transition: color .1s ease-in-out, background .1s ease-in-out;

wp-admin/css/media-rtl.css

@@ -823,6 +823,7 @@ border color while dragging a file over the uploader drop area */
 
 .edit-attachment-frame .attachment-info .details,
 .edit-attachment-frame .attachment-info .settings {
+	position: relative; /* RTL fix, #WP29352 */
 	overflow: hidden;
 	float: none;
 	margin-bottom: 15px;

wp-admin/css/media.css

@@ -823,6 +823,7 @@ border color while dragging a file over the uploader drop area */
 
 .edit-attachment-frame .attachment-info .details,
 .edit-attachment-frame .attachment-info .settings {
+	position: relative; /* RTL fix, #WP29352 */
 	overflow: hidden;
 	float: none;
 	margin-bottom: 15px;

wp-admin/includes/template.php

@@ -452,7 +452,7 @@ function wp_comment_reply($position = '1', $checkbox = false, $mode = 'single',
 
 		<div class="inside">
 		<label for="author-url"><?php _e('URL') ?></label>
-		<input type="text" id="author-url" name="newcomment_author_url" size="103" value="" />
+		<input type="text" id="author-url" name="newcomment_author_url" class="code" size="103" value="" />
 		</div>
 		<div style="clear:both;"></div>
 	</div>

wp-includes/css/media-views-rtl.css

@@ -1682,6 +1682,7 @@
 	margin-bottom: 16px;
 	padding: 0;
 	padding-bottom: 16px;
+	position: relative; /* RTL fix, #WP29352 */
 }
 
 .media-modal .imgedit-group:last-of-type {

wp-includes/css/media-views.css

@@ -1682,6 +1682,7 @@
 	margin-bottom: 16px;
 	padding: 0;
 	padding-bottom: 16px;
+	position: relative; /* RTL fix, #WP29352 */
 }
 
 .media-modal .imgedit-group:last-of-type {

wp-includes/js/media-views.js

@@ -6757,7 +6757,7 @@
 		initialize: function() {
 			var self = this;
 
-			this.$input = $('<input id="embed-url-field" type="text" />').val( this.model.get('url') );
+			this.$input = $('<input id="embed-url-field" type="url" />').val( this.model.get('url') );
 			this.input = this.$input[0];
 
 			this.spinner = $('<span class="spinner" />')[0];