Plugins: Prevent `ajaxComplete` listener from observing all events.
Add a conditional to prevent the `prefers-reduced-motion` `ajaxComplete` listener from observing events not occurring in the plugin installation screen. Improve handling of settings data test. The listener observing `ajaxComplete` in [56541] was intercepting all `ajaxComplete` events, creating potential for unexpected errors in unrelated functions. Props bplv, afercia, rudlinkon, hellofromTonya, huzaifaalmesbah, joedolson, jorbin. Fixes #59689. Built from https://develop.svn.wordpress.org/trunk@57022 git-svn-id: http://core.svn.wordpress.org/trunk@56533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
parent
b4a6b21986
commit
32bf11b728
|
@ -2219,9 +2219,12 @@ $( function( $ ) {
|
||||||
|
|
||||||
// Listen for jQuery AJAX events.
|
// Listen for jQuery AJAX events.
|
||||||
( function( $ ) {
|
( function( $ ) {
|
||||||
|
if ( window.pagenow === 'plugin-install' ) {
|
||||||
|
// Only listen for ajaxComplete if this is the plugin-install.php page.
|
||||||
$( document ).ajaxComplete( function( event, xhr, settings ) {
|
$( document ).ajaxComplete( function( event, xhr, settings ) {
|
||||||
|
|
||||||
// Check if this is the 'search-install-plugins' request.
|
// Check if this is the 'search-install-plugins' request.
|
||||||
if ( settings.data && settings.data.includes( 'action=search-install-plugins' ) ) {
|
if ( settings.data && typeof settings.data === 'string' && settings.data.includes( 'action=search-install-plugins' ) ) {
|
||||||
// Recheck if the user prefers reduced motion.
|
// Recheck if the user prefers reduced motion.
|
||||||
if ( window.matchMedia ) {
|
if ( window.matchMedia ) {
|
||||||
var mediaQuery = window.matchMedia( '(prefers-reduced-motion: reduce)' );
|
var mediaQuery = window.matchMedia( '(prefers-reduced-motion: reduce)' );
|
||||||
|
@ -2236,6 +2239,7 @@ $( function( $ ) {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
} );
|
} );
|
||||||
|
}
|
||||||
} )( jQuery );
|
} )( jQuery );
|
||||||
|
|
||||||
// Expose public methods.
|
// Expose public methods.
|
||||||
|
|
File diff suppressed because one or more lines are too long
|
@ -16,7 +16,7 @@
|
||||||
*
|
*
|
||||||
* @global string $wp_version
|
* @global string $wp_version
|
||||||
*/
|
*/
|
||||||
$wp_version = '6.5-alpha-57021';
|
$wp_version = '6.5-alpha-57022';
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.
|
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.
|
||||||
|
|
Loading…
Reference in New Issue