From 41ea1f106de2693565ee352199f3a5a286591c0e Mon Sep 17 00:00:00 2001 From: Gary Pendergast Date: Thu, 11 Jul 2019 23:51:56 +0000 Subject: [PATCH] Code Modernisation: Introduce the spread operator in `Walker`. Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable. Props jrf. See #47678. Built from https://develop.svn.wordpress.org/trunk@45624 git-svn-id: http://core.svn.wordpress.org/trunk@45435 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-includes/class-wp-walker.php | 10 +++++----- wp-includes/version.php | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/wp-includes/class-wp-walker.php b/wp-includes/class-wp-walker.php index 6799d42f28..4d35b093f5 100644 --- a/wp-includes/class-wp-walker.php +++ b/wp-includes/class-wp-walker.php @@ -184,10 +184,10 @@ class Walker { * * @param array $elements An array of elements. * @param int $max_depth The maximum hierarchical depth. + * @param mixed ...$args Optional additional arguments. * @return string The hierarchical item output. */ - public function walk( $elements, $max_depth ) { - $args = array_slice( func_get_args(), 2 ); + public function walk( $elements, $max_depth, ...$args ) { $output = ''; //invalid parameter or nothing to walk @@ -276,16 +276,16 @@ class Walker { * * @param array $elements * @param int $max_depth The maximum hierarchical depth. - * @param int $page_num The specific page number, beginning with 1. + * @param int $page_num The specific page number, beginning with 1. * @param int $per_page + * @param mixed ...$args Optional additional arguments. * @return string XHTML of the specified page of elements */ - public function paged_walk( $elements, $max_depth, $page_num, $per_page ) { + public function paged_walk( $elements, $max_depth, $page_num, $per_page, ...$args ) { if ( empty( $elements ) || $max_depth < -1 ) { return ''; } - $args = array_slice( func_get_args(), 4 ); $output = ''; $parent_field = $this->db_fields['parent']; diff --git a/wp-includes/version.php b/wp-includes/version.php index 01562a51f1..e38ff952ad 100644 --- a/wp-includes/version.php +++ b/wp-includes/version.php @@ -13,7 +13,7 @@ * * @global string $wp_version */ -$wp_version = '5.3-alpha-45623'; +$wp_version = '5.3-alpha-45624'; /** * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.