WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

XMLRPC: Fix bug where draft posts couldn’t be published in the future, and would publish immediately. 

Resolves bug introduced in [r34572], in which editing a Post via the XMLRPC API with a draft post_status, where the post_status changes from draft->publish with a future post_date set for the publish action, will have the future post_date disregarded and the Post will be published immediately. The expected behavior is that the post_date is used to schedule the Post to be published in the future.

Fixes #35874.

Props redsweater, rachelbaker, DrewAPicture
Built from https://develop.svn.wordpress.org/trunk@37043


git-svn-id: http://core.svn.wordpress.org/trunk@37010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
Rachel Baker 2016-03-22 15:10:28 +00:00
parent d1ae0642cf
commit 470110ec3d
2 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
wp-includes/class-wp-xmlrpc-server.php
View File

@ -1364,9 +1364,15 @@ class wp_xmlrpc_server extends IXR_Server {
$dateCreated = $post_data['post_date']->getIso(); $dateCreated = $post_data['post_date']->getIso();
} }
// Default to not flagging the post date to be edited unless it's intentional.
$post_data['edit_date'] = false;
if ( ! empty( $dateCreated ) ) { if ( ! empty( $dateCreated ) ) {
$post_data['post_date'] = get_date_from_gmt( iso8601_to_datetime( $dateCreated ) ); $post_data['post_date'] = get_date_from_gmt( iso8601_to_datetime( $dateCreated ) );
$post_data['post_date_gmt'] = iso8601_to_datetime( $dateCreated, 'GMT' ); $post_data['post_date_gmt'] = iso8601_to_datetime( $dateCreated, 'GMT' );
// Flag the post date to be edited.
$post_data['edit_date'] = true;
} }
if ( ! isset( $post_data['ID'] ) ) if ( ! isset( $post_data['ID'] ) )
@ -5375,16 +5381,22 @@ class wp_xmlrpc_server extends IXR_Server {
elseif ( !empty( $content_struct['dateCreated']) ) elseif ( !empty( $content_struct['dateCreated']) )
$dateCreated = $content_struct['dateCreated']->getIso(); $dateCreated = $content_struct['dateCreated']->getIso();
// Default to not flagging the post date to be edited unless it's intentional.
$edit_date = false;
if ( !empty( $dateCreated ) ) { if ( !empty( $dateCreated ) ) {
$post_date = get_date_from_gmt(iso8601_to_datetime($dateCreated)); $post_date = get_date_from_gmt(iso8601_to_datetime($dateCreated));
$post_date_gmt = iso8601_to_datetime($dateCreated, 'GMT'); $post_date_gmt = iso8601_to_datetime($dateCreated, 'GMT');
// Flag the post date to be edited.
$edit_date = true;
} else { } else {
$post_date = $postdata['post_date']; $post_date = $postdata['post_date'];
$post_date_gmt = $postdata['post_date_gmt']; $post_date_gmt = $postdata['post_date_gmt'];
} }
// We've got all the data -- post it. // We've got all the data -- post it.
$newpost = compact('ID', 'post_content', 'post_title', 'post_category', 'post_status', 'post_excerpt', 'comment_status', 'ping_status', 'post_date', 'post_date_gmt', 'to_ping', 'post_name', 'post_password', 'post_parent', 'menu_order', 'post_author', 'tags_input', 'page_template'); $newpost = compact('ID', 'post_content', 'post_title', 'post_category', 'post_status', 'post_excerpt', 'comment_status', 'ping_status', 'edit_date', 'post_date', 'post_date_gmt', 'to_ping', 'post_name', 'post_password', 'post_parent', 'menu_order', 'post_author', 'tags_input', 'page_template');
$result = wp_update_post($newpost, true); $result = wp_update_post($newpost, true);
if ( is_wp_error( $result ) ) if ( is_wp_error( $result ) )

2
wp-includes/version.php
View File

@ -4,7 +4,7 @@
* *
* @global string $wp_version * @global string $wp_version
*/ */
$wp_version = '4.5-beta4-37042'; $wp_version = '4.5-beta4-37043';
/** /**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema. * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.