From 4932c3653362f1988298db576a415aa0ee3c0cc8 Mon Sep 17 00:00:00 2001 From: Andrew Nacin Date: Tue, 8 Apr 2014 18:08:10 +0000 Subject: [PATCH] Harden HMAC verification. props duck_. [28053] for 3.7. Built from https://develop.svn.wordpress.org/branches/3.7@28055 git-svn-id: http://core.svn.wordpress.org/branches/3.7@27885 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-includes/pluggable.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wp-includes/pluggable.php b/wp-includes/pluggable.php index 6839b015ac..e340fc725c 100644 --- a/wp-includes/pluggable.php +++ b/wp-includes/pluggable.php @@ -546,7 +546,7 @@ function wp_validate_auth_cookie($cookie = '', $scheme = '') { $key = wp_hash($username . $pass_frag . '|' . $expiration, $scheme); $hash = hash_hmac('md5', $username . '|' . $expiration, $key); - if ( $hmac != $hash ) { + if ( hash_hmac( 'md5', $hmac, $key ) !== hash_hmac( 'md5', $hash, $key ) ) { do_action('auth_cookie_bad_hash', $cookie_elements); return false; }