Respect all post-related filters in `WP_Comment_Query`.
The refactor of `WP_Comment_Query`'s SQL generation in [34542] introduced a bug that caused only the last post-related filter to be respected in comment queries. In other words, if querying for comments using params `post_status=draft&post_author=3`, only the last-processed of these params would be respected. The current changeset fixes the logic so that these clauses don't overwrite each other. Props chriscct7. Fixes #35478. Built from https://develop.svn.wordpress.org/trunk@36326 git-svn-id: http://core.svn.wordpress.org/trunk@36293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
parent
f407e3a473
commit
4c91776f3b
|
@ -765,7 +765,7 @@ class WP_Comment_Query {
|
|||
foreach ( $post_fields as $field_name => $field_value ) {
|
||||
// $field_value may be an array.
|
||||
$esses = array_fill( 0, count( (array) $field_value ), '%s' );
|
||||
$this->sql_clauses['where']['post_fields'] = $wpdb->prepare( " {$wpdb->posts}.{$field_name} IN (" . implode( ',', $esses ) . ')', $field_value );
|
||||
$this->sql_clauses['where'][ $field_name ] = $wpdb->prepare( " {$wpdb->posts}.{$field_name} IN (" . implode( ',', $esses ) . ')', $field_value );
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
@ -4,7 +4,7 @@
|
|||
*
|
||||
* @global string $wp_version
|
||||
*/
|
||||
$wp_version = '4.5-alpha-1452888612815';
|
||||
$wp_version = '4.5-alpha-1452888638140';
|
||||
|
||||
/**
|
||||
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.
|
||||
|
|
Loading…
Reference in New Issue