Add sanity checks in `map_meta_cap()`, return `'do_not_allow'` when posts don't exist.
Adds unit test. Props ocean90, nerrad, filosofo. Fixes #23162. Built from https://develop.svn.wordpress.org/trunk@34113 git-svn-id: http://core.svn.wordpress.org/trunk@34081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
parent
49803a45f3
commit
5020135a10
|
@ -47,9 +47,17 @@ function map_meta_cap( $cap, $user_id ) {
|
||||||
case 'delete_post':
|
case 'delete_post':
|
||||||
case 'delete_page':
|
case 'delete_page':
|
||||||
$post = get_post( $args[0] );
|
$post = get_post( $args[0] );
|
||||||
|
if ( ! $post ) {
|
||||||
|
$caps[] = 'do_not_allow';
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
|
||||||
if ( 'revision' == $post->post_type ) {
|
if ( 'revision' == $post->post_type ) {
|
||||||
$post = get_post( $post->post_parent );
|
$post = get_post( $post->post_parent );
|
||||||
|
if ( ! $post ) {
|
||||||
|
$caps[] = 'do_not_allow';
|
||||||
|
break;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
$post_type = get_post_type_object( $post->post_type );
|
$post_type = get_post_type_object( $post->post_type );
|
||||||
|
@ -97,13 +105,17 @@ function map_meta_cap( $cap, $user_id ) {
|
||||||
case 'edit_post':
|
case 'edit_post':
|
||||||
case 'edit_page':
|
case 'edit_page':
|
||||||
$post = get_post( $args[0] );
|
$post = get_post( $args[0] );
|
||||||
if ( empty( $post ) ) {
|
if ( ! $post ) {
|
||||||
$caps[] = 'do_not_allow';
|
$caps[] = 'do_not_allow';
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
|
|
||||||
if ( 'revision' == $post->post_type ) {
|
if ( 'revision' == $post->post_type ) {
|
||||||
$post = get_post( $post->post_parent );
|
$post = get_post( $post->post_parent );
|
||||||
|
if ( ! $post ) {
|
||||||
|
$caps[] = 'do_not_allow';
|
||||||
|
break;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
$post_type = get_post_type_object( $post->post_type );
|
$post_type = get_post_type_object( $post->post_type );
|
||||||
|
@ -149,9 +161,17 @@ function map_meta_cap( $cap, $user_id ) {
|
||||||
case 'read_post':
|
case 'read_post':
|
||||||
case 'read_page':
|
case 'read_page':
|
||||||
$post = get_post( $args[0] );
|
$post = get_post( $args[0] );
|
||||||
|
if ( ! $post ) {
|
||||||
|
$caps[] = 'do_not_allow';
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
|
||||||
if ( 'revision' == $post->post_type ) {
|
if ( 'revision' == $post->post_type ) {
|
||||||
$post = get_post( $post->post_parent );
|
$post = get_post( $post->post_parent );
|
||||||
|
if ( ! $post ) {
|
||||||
|
$caps[] = 'do_not_allow';
|
||||||
|
break;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
$post_type = get_post_type_object( $post->post_type );
|
$post_type = get_post_type_object( $post->post_type );
|
||||||
|
@ -186,6 +206,11 @@ function map_meta_cap( $cap, $user_id ) {
|
||||||
break;
|
break;
|
||||||
case 'publish_post':
|
case 'publish_post':
|
||||||
$post = get_post( $args[0] );
|
$post = get_post( $args[0] );
|
||||||
|
if ( ! $post ) {
|
||||||
|
$caps[] = 'do_not_allow';
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
|
||||||
$post_type = get_post_type_object( $post->post_type );
|
$post_type = get_post_type_object( $post->post_type );
|
||||||
if ( ! $post_type ) {
|
if ( ! $post_type ) {
|
||||||
/* translators: 1: post type, 2: capability name */
|
/* translators: 1: post type, 2: capability name */
|
||||||
|
@ -200,6 +225,11 @@ function map_meta_cap( $cap, $user_id ) {
|
||||||
case 'delete_post_meta':
|
case 'delete_post_meta':
|
||||||
case 'add_post_meta':
|
case 'add_post_meta':
|
||||||
$post = get_post( $args[0] );
|
$post = get_post( $args[0] );
|
||||||
|
if ( ! $post ) {
|
||||||
|
$caps[] = 'do_not_allow';
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
|
||||||
$caps = map_meta_cap( 'edit_post', $user_id, $post->ID );
|
$caps = map_meta_cap( 'edit_post', $user_id, $post->ID );
|
||||||
|
|
||||||
$meta_key = isset( $args[ 1 ] ) ? $args[ 1 ] : false;
|
$meta_key = isset( $args[ 1 ] ) ? $args[ 1 ] : false;
|
||||||
|
@ -229,8 +259,11 @@ function map_meta_cap( $cap, $user_id ) {
|
||||||
break;
|
break;
|
||||||
case 'edit_comment':
|
case 'edit_comment':
|
||||||
$comment = get_comment( $args[0] );
|
$comment = get_comment( $args[0] );
|
||||||
if ( empty( $comment ) )
|
if ( ! $comment ) {
|
||||||
|
$caps[] = 'do_not_allow';
|
||||||
break;
|
break;
|
||||||
|
}
|
||||||
|
|
||||||
$post = get_post( $comment->comment_post_ID );
|
$post = get_post( $comment->comment_post_ID );
|
||||||
|
|
||||||
/*
|
/*
|
||||||
|
|
|
@ -4,7 +4,7 @@
|
||||||
*
|
*
|
||||||
* @global string $wp_version
|
* @global string $wp_version
|
||||||
*/
|
*/
|
||||||
$wp_version = '4.4-alpha-34112';
|
$wp_version = '4.4-alpha-34113';
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.
|
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.
|
||||||
|
|
Loading…
Reference in New Issue